ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D24803
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
==
ioeric updated this revision to Diff 72145.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressing review comments: added a test case for out-of-line static method
and fixed a bug.
https://reviews.llvm.org/D24803
Files:
change-namespace/ChangeNamespace.cpp
unittests/
Author: ioeric
Date: Thu Sep 22 06:54:00 2016
New Revision: 282146
URL: http://llvm.org/viewvc/llvm-project?rev=282146&view=rev
Log:
[change-namespace] fix qualifier of function references.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D24803
Modifi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282146: [change-namespace] fix qualifier of function
references. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24803?vs=72145&id=72152#toc
Repository:
rL LLVM
https://revi
ioeric added a comment.
Could you elaborate on what this CL does in the description?
https://reviews.llvm.org/D24828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with nits.
Comment at: clang-move/ClangMove.cpp:290
@@ -294,1 +289,3 @@
llvm::StringRef FileName) {
+ // Don't add the old_header.h to the
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added subscribers: klimek, cfe-commits.
- If a replacement has offset UINT_MAX, length 0, and a replacement text
that is an #include directive, this will insert the #include into the
correct block in the \p Code.
- If a rep
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
- UsingDecl matcher crashed when `UsingShadowDecl` has no parent map.
Workaround by moving parent check into `UsingDecl`.
- FunctionDecl matcher crashed when there is a lambda defined in paramet
ioeric updated this revision to Diff 72269.
ioeric added a comment.
- Update comments
https://reviews.llvm.org/D24862
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/tool/ClangChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-nam
ioeric added a comment.
In https://reviews.llvm.org/D24862#550615, @aaron.ballman wrote:
> Should this perhaps be fixed in the AST matchers rather than in the check
> itself?
I'll file bugs for the crashes, but the fix in this patch is not that "dirty" -
it simply changes the order of matcher
ioeric added a comment.
In https://reviews.llvm.org/D24862#550637, @aaron.ballman wrote:
> In https://reviews.llvm.org/D24862#550628, @ioeric wrote:
>
> > In https://reviews.llvm.org/D24862#550615, @aaron.ballman wrote:
> >
> > > Should this perhaps be fixed in the AST matchers rather than in the
ioeric updated this revision to Diff 72273.
ioeric added a comment.
- Update comments.
https://reviews.llvm.org/D24862
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/tool/ClangChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-na
ioeric updated this revision to Diff 72275.
ioeric added a comment.
- Update comment.
https://reviews.llvm.org/D24862
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/tool/ClangChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-nam
ioeric added a comment.
In https://reviews.llvm.org/D24862#550654, @aaron.ballman wrote:
> In https://reviews.llvm.org/D24862#550646, @ioeric wrote:
>
> > Acked, and I totally agree with you :) It's just that the change in this
> > patch would still be valid after the underlying bugs are fixed,
ioeric added a comment.
Thanks for the comments!
Comment at: change-namespace/ChangeNamespace.cpp:279
@@ -276,2 +278,3 @@
Finder->addMatcher(
- usingDecl(hasAnyUsingShadowDecl(IsInMovedNs)).bind("using_decl"), this);
+ usingDecl(IsInMovedNs, hasAnyUsingShadowDecl(de
ioeric updated this revision to Diff 72285.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D24829
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282253: [clang-format] support header deletion in
cleanupAroundReplacemnts. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24829?vs=72285&id=72286#toc
Repository:
rL LLVM
h
ioeric updated this revision to Diff 72284.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24862
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-
Author: ioeric
Date: Fri Sep 23 10:10:56 2016
New Revision: 282253
URL: http://llvm.org/viewvc/llvm-project?rev=282253&view=rev
Log:
[clang-format] support header deletion in cleanupAroundReplacemnts.
Summary:
- If a replacement has offset UINT_MAX, length 0, and a replacement text
that is an #
ioeric added a comment.
Friendly ping :)
https://reviews.llvm.org/D24800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:33
@@ +32,3 @@
+ auto EC = llvm::sys::fs::make_absolute(InitialDirectory, AbsolutePath);
+ assert(!EC);
+ (void)EC;
This doesn't seems to be good error handling... maybe also print an error
mes
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:177-178
@@ +176,4 @@
+ /// - are insertions at the same offset and applying them in either order
+ /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the
+ /// other
ioeric updated this revision to Diff 72635.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Replace dummy binary with unit test with dummy environemnt + fake codebase.
https://reviews.llvm.org/D24380
Files:
CMakeLists.txt
migrate-tool/AffectedFilesFinder.h
migrate-tool/
Author: ioeric
Date: Tue Sep 27 07:54:48 2016
New Revision: 282486
URL: http://llvm.org/viewvc/llvm-project?rev=282486&view=rev
Log:
Workaround ASTMatcher crashes. Added some more test cases.
Summary:
- UsingDecl matcher crashed when `UsingShadowDecl` has no parent map.
Workaround by moving pare
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282486: Workaround ASTMatcher crashes. Added some more test
cases. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24862?vs=72284&id=72640#toc
Repository:
rL LLVM
https://re
ioeric added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+ Replacements Rs(R);
+ Replacements ShiftedRs(getReplacementInChangedCode(R));
+ Replacements ShiftedReplaces;
+
ioeric updated this revision to Diff 72642.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24800
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D24963
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
==
ioeric abandoned this revision.
ioeric added a comment.
Abandon in favor of https://reviews.llvm.org/D24800
https://reviews.llvm.org/D24717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ioeric added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+llvm::Expected
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+ Replacements Rs(R);
+ Replacements RsShiftedByReplaces(getReplacementInChangedCode(R));
+ Repla
ioeric updated this revision to Diff 72666.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24800
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Author: ioeric
Date: Wed Sep 28 06:02:16 2016
New Revision: 282577
URL: http://llvm.org/viewvc/llvm-project?rev=282577&view=rev
Log:
Merge conflicting replacements when they are order-independent.
Summary:
Now two replacements are considered order-independent if applying them in
either order prod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282577: Merge conflicting replacements when they are
order-independent. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24800?vs=72666&id=72799#toc
Repository:
rL LLVM
https
This is causing buildbot failure. I am working on a fix.
On Wed, Sep 28, 2016 at 1:11 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Wed Sep 28 06:02:16 2016
> New Revision: 282577
>
> URL: http://llvm.org/viewvc/llvm-project?rev=
Author: ioeric
Date: Wed Sep 28 07:49:14 2016
New Revision: 282583
URL: http://llvm.org/viewvc/llvm-project?rev=282583&view=rev
Log:
Trying to buildbot failures caused by r282577.
Modified:
cfe/trunk/lib/Tooling/Core/Replacement.cpp
Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp
URL:
r282583 should fix this.
On Wed, Sep 28, 2016 at 2:14 PM Eric Liu wrote:
> This is causing buildbot failure. I am working on a fix.
>
> On Wed, Sep 28, 2016 at 1:11 PM Eric Liu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: ioeric
> Date: Wed
Decrementing "begin()" makes sanitizer sad. This fix makes sure "I" is
never decremented when it is the "begin".
On Wed, Sep 28, 2016 at 3:10 PM Manuel Klimek wrote:
> On Wed, Sep 28, 2016 at 2:58 PM Eric Liu via cfe-commits <
> cfe-commits@lists.llvm.org
ioeric added a comment.
Ping
https://reviews.llvm.org/D24380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
View RevisionPhab test.https://reviews.llvm.org/D24963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric created this revision.ioeric added a reviewer: hokein.ioeric added a subscriber: cfe-commits.
View RevisionAlso test phabricator.https://reviews.llvm.org/D25065Files:change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cppunittests/change-namespace/ChangeNames
Hi all,
Phabricator is (finally) back online! Let me know if you have any feedback
or problem :)
Thanks,
Eric
On Thu, Sep 29, 2016 at 10:23 PM Eric Liu wrote:
> According to top and iotop, mysqld is still working, and the progress bar
> did move by a little bit, so I think it's just really slo
Author: ioeric
Date: Thu Sep 29 23:32:39 2016
New Revision: 282837
URL: http://llvm.org/viewvc/llvm-project?rev=282837&view=rev
Log:
[change-namespace] fix namespace specifier of global variables.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D24963
This revision was automatically updated to reflect the committed changes.Closed by commit rL282837: [change-namespace] fix namespace specifier of global variables. (authored by ioeric).
View RevisionChanged prior to commit:https://reviews.llvm.org/D24963?vs=72648&id=72976#tocRepository:rL LLVMhttps
I've switched the default email format to be plain text only now. This
option should be per-user configurable, but somehow it is not shown in the
"Settings"; I'll try if I can make the option personalized.
Regarding new features and bug fixes in this upgrade, I don't really have a
list since the P
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with nits.
> ClangMove.cpp:36
> + llvm::sys::fs::make_absolute(InitialDirectory, AbsolutePath))
> +llvm::errs() << "warning: could not make absolute file: '" <<
> EC.message
ioeric added inline comments.
> klimek wrote in MigrateTool.cpp:52
> I'm wondering whether we really want to evolve this to a callback / executor
> based design. That is, have AffectedFilesFinder give an interface like
> RunOnAffectedFiles(...)
That sounds like a good design, but I'm not sure
ioeric added inline comments.
> klimek wrote in MigrateTool.cpp:52
> Well, my main concern is how we hook this up to full codebase wide analyses.
> Currently, we basically hard-code the execution strategy, right?
I see. That makes sense then. Thanks!
https://reviews.llvm.org/D24380
ioeric added a comment.
The code looks about right, but I am not the right person to decide whether
checks go into clang-tidy.
https://reviews.llvm.org/D25024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Eric
On Fri, Sep 30, 2016 at 3:05 PM Aaron Ballman
wrote:
> On Fri, Sep 30, 2016 at 2:04 AM, Eric Liu via cfe-commits
> wrote:
> > I've switched the default email format to be plain text only now. This
> > option should be per-user configurable, but somehow it is not shown
@Alex I tried glancing through emails in llvm-commits, and I found
"[PATCH]" makes it easier to tell revisions from patches, and I guess
people are also used to "[PATCH]" after all these years :)
@Zachary Yes! This option can be configured in "Email Preferences" in your
personal setting, but I'm n
ioeric updated this revision to Diff 73116.
ioeric added a comment.
- Remove redundant variable.
https://reviews.llvm.org/D25065
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
=
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D25162
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
ioeric created this revision.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Also test phabricator commit processing.
https://reviews.llvm.org/D25207
Files:
include/clang/Tooling/Core/Replacement.h
Index: include/clang/Tooling/Core/Replacement.h
=
ioeric accepted this revision.
ioeric added a reviewer: ioeric.
ioeric added a comment.
This revision is now accepted and ready to land.
Since this patch only introduces new comments, I'll commit it for now to also
test phabricator's commit processing.
https://reviews.llvm.org/D25207
___
Author: ioeric
Date: Mon Oct 3 14:14:30 2016
New Revision: 283135
URL: http://llvm.org/viewvc/llvm-project?rev=283135&view=rev
Log:
Added more comments to tooling::Replacements.
Summary: Also test phabricator commit processing.
Subscribers: klimek, cfe-commits
Differential Revision: https://re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283135: Added more comments to tooling::Replacements.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25207?vs=73322&id=73414#toc
Repository:
rL LLVM
https://reviews.llvm.or
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Thanks for the fix! :)
> ChangeNamespace.cpp:110-112
> + if (SM.getLocForEndOfFile(LocInfo.first) == End)
> +return End;
> + return End.getLocWithOffset(1);
return (SM.getLocForEndOfFi
ioeric added a comment.
Ping
https://reviews.llvm.org/D25065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This is not due to the upgrade. There was long delay before Phabricator
receives a commit, but the delay seems to be gone now. Let me know if you
are still experiencing the delay.
- Eric
On Mon, Oct 3, 2016 at 4:25 PM Michał Górny wrote:
> On Mon, 3 Oct 2016 13:47:08 +
> Sjoerd Meijer via c
ioeric updated this revision to Diff 73446.
ioeric added a comment.
Herald added a subscriber: modocache.
- Add SymbolRenameSpec; replace addIncludesToFiles and renameSymbolsInFiles
with renameSymbolsInAffectedFiles.
https://reviews.llvm.org/D24380
Files:
CMakeLists.txt
migrate-tool/Affect
ioeric added a comment.
This is great!
> ClangMove.cpp:70-74
> + if (SM->getLocForEndOfFile(LocInfo.first)
> + == EndLoc)
> +return EndLoc;
> + // Include the trailing newline character "\n".
> + return EndLoc.getLocWithOffset(1);
Maybe:
return (SM->getLocForEndOfFile(LocInfo.fi
ioeric updated this revision to Diff 73459.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Address review comments.
https://reviews.llvm.org/D25065
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-n
ioeric added inline comments.
> hokein wrote in ChangeNamespace.cpp:187
> I think the statement doesn't compile here, since `consume_front` return a
> `bool`. It should be `if (DeclName.consume_front((NsName + "::")))`?
>
> Looks like we can also put this judge into the above `while` statement?
ioeric updated this revision to Diff 73641.
ioeric added a comment.
- Added a test case.
https://reviews.llvm.org/D25162
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
==
ioeric added a comment.
Sorry for the delay
I've updated the patch to work with the new tooling::Replacements.
https://reviews.llvm.org/D21026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
ioeric updated this revision to Diff 73648.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Merged with origin/master.
- Update newline insertion according to the new Replacements implementation.
https://reviews.llvm.org/D21026
Files:
lib/Format/Format.cpp
unittests/Forma
Author: ioeric
Date: Wed Oct 5 10:42:19 2016
New Revision: 283330
URL: http://llvm.org/viewvc/llvm-project?rev=283330&view=rev
Log:
[clang-format] append newline after code when inserting new headers at the end
of the code which does not end with newline.
Summary:
append newline after code when
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283330: [clang-format] append newline after code when
inserting new headers at the end… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D21026?vs=73648&id=73651#toc
Repository:
Author: ioeric
Date: Wed Oct 5 10:49:01 2016
New Revision: 283332
URL: http://llvm.org/viewvc/llvm-project?rev=283332&view=rev
Log:
Make DeletedLines local variables in checkEmptyNamespace.
Summary: Patch by Sam McCall!
Reviewers: djasper
Subscribers: klimek, cfe-commits
Differential Revision
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283332: Make DeletedLines local variables in
checkEmptyNamespace. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25162?vs=73641&id=73652#toc
Repository:
rL LLVM
https://rev
Author: ioeric
Date: Wed Oct 5 10:52:39 2016
New Revision: 28
URL: http://llvm.org/viewvc/llvm-project?rev=28&view=rev
Log:
[change-namespace] Fixed a bug in getShortestQualifiedNameInNamespace.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL28: [change-namespace] Fixed a bug in
getShortestQualifiedNameInNamespace. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25065?vs=73459&id=73653#toc
Repository:
rL LLVM
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
https://reviews.llvm.org/D25282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ioeric added a comment.
Test phab...sorry spamming...
https://reviews.llvm.org/D24380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
> ClangMove.cpp:295
> void ClangMoveTool::registerMatchers(ast_matchers::MatchFinder *Finder) {
> - std::string FullyQualifiedName = "::" + Spec.Name;
> + auto ParseNames = [](llvm::StringRef Names) {
> +SmallVector ClassNames;
Why create this lambda if it's
ioeric added inline comments.
> hokein wrote in ClangMove.cpp:316
> "InMovedClassNames" should not be false in the matcher. Added an assert.
I think you should instead exit early if `ClassNames.empty()` or assert not
empty.
> ClangMove.cpp:299
> + for (StringRef ClassName : ClassNames) {
> +
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg. Thanks!
https://reviews.llvm.org/D25309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:316
auto InMovedClass =
- hasDeclContext(cxxRecordDecl(hasName(FullyQualifiedName)));
+ hasDeclContext(cxxRecordDecl(*InMovedClassNames));
ioeric wrote:
> hokein wrote:
> > ioeric w
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:27
+AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass,
+ ast_matchers::internal::Matcher, InnerMatcher) {
I'm not sure if we really need to limit this to the `outer-most` class
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D25397
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
==
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D24572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:387
+ Token Tok;
+ while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) {
+ }
hokein wrote:
> Maybe we can use `findLocationAfterToken` here?
This doesn't seem
Author: ioeric
Date: Wed Oct 12 07:34:18 2016
New Revision: 284011
URL: http://llvm.org/viewvc/llvm-project?rev=284011&view=rev
Log:
[change-namespace] don't miss comments in the beginning of a namespace block.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284011: [change-namespace] don't miss comments in the
beginning of a namespace block. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25397?vs=74038&id=74368#toc
Repository:
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with one nit.
Comment at: clang-move/ClangMove.cpp:410
std::string AbsolutePath = MakeAbsolutePath(SM, FileName);
if (MakeAbsolutePath(OriginalRunningDirectory, Spec
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added subscribers: cfe-commits, bkramer, hokein.
Herald added a subscriber: klimek.
If there are multiple pairs with the same file
path after removing dots, we only keep one pair (with path after dots being
removed) and discar
ioeric updated this revision to Diff 74531.
ioeric added a comment.
- Updated comments for RefactoringTool.
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:233
- Replacements mergeReplacements(const ReplacementsImpl &Second) const;
-
This is dead code.
https://reviews.llvm.org/D25565
___
Author: ioeric
Date: Thu Oct 13 13:56:14 2016
New Revision: 284147
URL: http://llvm.org/viewvc/llvm-project?rev=284147&view=rev
Log:
Print stack trace for clang-change-namespace tool.
Modified:
clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp
Modified: clang-tools-extra
Author: ioeric
Date: Thu Oct 13 14:04:19 2016
New Revision: 284148
URL: http://llvm.org/viewvc/llvm-project?rev=284148&view=rev
Log:
Print stack trace for clang-move tool.
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modified: clang-tools-extra/trunk/clang-move/tool/Cl
Author: ioeric
Date: Thu Oct 13 14:49:19 2016
New Revision: 284155
URL: http://llvm.org/viewvc/llvm-project?rev=284155&view=rev
Log:
[clang-move] error out when fail to create new files.
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modified: clang-tools-extra/trunk/cla
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
Since `remove_dots` does not delete leading "../" anymore, assertion test need
to be updated.
https://reviews.llvm.org/D25597
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/Virtu
ioeric updated this revision to Diff 74631.
ioeric added a comment.
- Separate assertions to get more information.
https://reviews.llvm.org/D25597
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/VirtualFileSystem.cpp
==
ioeric updated this revision to Diff 74632.
ioeric added a comment.
- Change name to groupReplacementsByFile
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
ioeric updated this revision to Diff 74634.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into arcpatch-D25565
- Forgot to update names in tests...
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactorin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284219: Deduplicate sets of replacements by file names.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25565?vs=74634&id=74636#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: ioeric
Date: Fri Oct 14 04:32:06 2016
New Revision: 284219
URL: http://llvm.org/viewvc/llvm-project?rev=284219&view=rev
Log:
Deduplicate sets of replacements by file names.
Summary:
If there are multiple pairs with the same file
path after removing dots, we only keep one pair (with path
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
301 - 400 of 970 matches
Mail list logo
