[PATCH] D53922: [clangd] fix non linux build

2018-10-31 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: kadircet, sammccall. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, krytarowski. There is no SCHED_IDLE semantic equivalent in BSD sy

[PATCH] D53922: [clangd] fix non linux build

2018-10-31 Thread David CARLIER via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345700: [clangd] fix non linux build (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53922?vs=171870&id=171873#toc Rep

[PATCH] D53922: [clangd] fix non linux build

2018-10-31 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. I thought applying this sort of change for BSD but SCHED_IDLE is a GNU extension and does not have equivalence per see. Repository: rL LLVM https://reviews.llvm.org/D53922 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added a reviewer: steveire. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Seems the previous statement does not hold up anymore. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57102 Fil

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In D57102#1368309 , @steveire wrote: > Is this covered by CI? The tests pass. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 _

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In D57102#1368373 , @steveire wrote: > The question was whether there is a build-bot for FreeBSD (if there is, then > it is covered by CI). > > Doesn't matter though. If no such bot exists, this isn't the commit to > enforce req

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Seems I can t commit myself to the svn repo ... had moved to git ? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 ___ cfe-commits mail

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. I did filled the form already ... do not know if it needs days to take effects ... Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 ___

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352031: [extra] unit tests enable crash-recovery cases on FreeBSD (authored by devnexen, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-11-15 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: george.karpenkov, dergachev.a. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - explicit_bzero has limited scope/usage only for security/crypto purposes but is non-optimisable version of m

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-11-27 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-12-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping @MaskRay my only hope seemingly :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-12-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 176722. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.c Index: test/Analysis/string.c

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

2018-12-05 Thread David CARLIER via Phabricator via cfe-commits
devnexen marked an inline comment as done. devnexen added inline comments. Comment at: test/Analysis/string.c:1399 + bzero(str, 2); + clang_analyzer_eval(strlen(str) == 0); // expected-warning{{UNKNOWN}} +} NoQ wrote: > I suspect that the reason why this didn't

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

2018-12-05 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 176780. devnexen added a comment. - Using same type for zero as memset. - Updating slighty the unit tests with ptr/dynamic array for bzero. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files: lib/Stati

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

2018-12-05 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In D54592#1319421 , @Szelethus wrote: > I hope you don't mind me changing the revision title -- many of us are > automatically subscribed to revisions with `analyzer` in the title, that also > helps with getting feedback sooner

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

2018-12-07 Thread David CARLIER via Phabricator via cfe-commits
devnexen marked an inline comment as done. devnexen added inline comments. Comment at: test/Analysis/string.c:1405-1406 + clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}} + bzero(str + 2, 2); + clang_analyzer_eval(strlen(str) == 0); // expected-warning{{FALSE

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

2018-12-07 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 177171. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.c Index: test/Analysis/string.c

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

2018-12-11 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping just want to put it behind :-) thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

2018-12-11 Thread David CARLIER via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348884: [analyzer][CStringChecker] evaluate explicit_bzero (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54592?vs=177

[PATCH] D58324: Enable esan for the cache frag support

2019-03-12 Thread David CARLIER via Phabricator via cfe-commits
devnexen abandoned this revision. devnexen added a comment. Esan removed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58324/new/ https://reviews.llvm.org/D58324 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

2018-09-22 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

2018-09-22 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:275 +os << "sizeof(" << DstName << ")"; + else +os << "sizeof()"; MaskRay wrote: > Why can't this `else if` case be folded into the `strlcpy` cas

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

2018-09-22 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 166626. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

2018-09-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:275 +os << "sizeof(" << DstName << ")"; + else +os << "sizeof()"; MaskRay wrote: > devnexen wrote: > > MaskRay wrote: > > > Why can't this `else

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

2018-09-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 166628. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D52331: [Index] Report specialization bases as references when IndexImplicitInstantiation is true

2018-09-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen accepted this revision. devnexen added a comment. This revision is now accepted and ready to land. LGTM to me Repository: rC Clang https://reviews.llvm.org/D52331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

2018-09-23 Thread David CARLIER via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC342832: [CStringSyntaxChecker] Check strlcat sizeof check (authored by devnexen, committed by ). Repository: rC Clang

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-01 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. The compiler-rt part had been committed. Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping compiler-rt component committed :-) Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-08 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping. Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58324: Enable esan for the cache frag support

2019-02-16 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added a reviewer: bsdjhb. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, emaste. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D58324 Files: lib/Driver/ToolChains/FreeBSD

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-04-12 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

2018-04-14 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: dberris, alexfh, alekseyshl. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. - On platform supported by clang, libcxx is too. - Adding explicitly to avoid to have to add manually. Repository: rC Clang https://r

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

2018-04-15 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:678-679 TC.AddCXXStdlibLibArgs(Args, CmdArgs); + if (TC.getTriple().getOS() == llvm::Triple::OpenBSD) +CmdArgs.push_back(Args.hasArg(options::OPT_pg) ? "-lc++_p" : "-lc++"); +

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

2018-04-15 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:678-679 TC.AddCXXStdlibLibArgs(Args, CmdArgs); + if (TC.getTriple().getOS() == llvm::Triple::OpenBSD) +CmdArgs.push_back(Args.hasArg(options::OPT_pg) ? "-lc++_p" : "-lc++"); +

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

2018-04-16 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 142686. devnexen added a comment. - Putting the change on the driver itself. https://reviews.llvm.org/D45662 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib/Driver/ToolChains/OpenBSD.cpp =

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

2018-04-16 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 142740. devnexen added a comment. - Making base gcc 4.2.1 stdc++ having profile version supported as well. https://reviews.llvm.org/D45662 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/ToolChains/OpenBSD.h Index: lib/Driver/ToolChains/OpenBSD.h

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

2018-04-17 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

2018-04-17 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

2018-04-17 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

2018-04-17 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 142811. devnexen retitled this revision from "Fuzzer, add libcxx for OpenBSD" to "OpenBSD add C++ runtime in a driver's standpoint". devnexen edited the summary of this revision. https://reviews.llvm.org/D45662 Files: lib/Driver/ToolChains/OpenBSD.cpp l

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

2018-04-17 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

2018-04-17 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-04-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. If anybody can land for me, I would appreciate. Thanks regardless :-) Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-05-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Sure ! looking into it. Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-05-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 144952. devnexen added a comment. The returned value is the number of character copied to the dst buffer. https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index: test/Analysis/bsd-string.

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-05-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D45149#1062279, @jdenny wrote: > Hi David. While I did make some superficial changes here recently, I'm no > authority on what belongs here. However, I would suggest that the > refactoring patch be split from the original patch. Thanks.

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-05-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 144981. devnexen added a comment. New test to check the length https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index: test/Analysis/bsd-string.c =

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-05-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 145352. https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index: test/Analysis/bsd-string.c === --- /dev/null +++ test/Analysi

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-05-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1485 + state = CheckOverlap(C, state, CE->getArg(2), Dst, srcExpr); + NoQ wrote: > This crashes on the old tests for the checker. I guess that's because the > normal `s

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

2018-06-25 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added a reviewer: dberris. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - Base GNU ld is pretty old and does not support --dynamic-list flag. - For conveniency we can add it automatically when compile wit

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

2018-06-28 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping :) Repository: rC Clang https://reviews.llvm.org/D48574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

2018-06-28 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D48574#1146619, @dberris wrote: > LGTM > > PS. I really wish at some point this will lead to an OpenBSD build bot! Would be interesting, it can even launch ubsan minimal tests and this change will simplify things a bit. Repository: rC C

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

2018-06-28 Thread David CARLIER via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC335856: OpenBSD driver needs ld.lld in sanitizer context (authored by devnexen, committed by ). Repository: rC Clang https://reviews.llvm.org/D48574 Files: lib/Driver/ToolChains/OpenBSD.cpp Index:

[PATCH] D69373: [Clang] Fix Sema class build fix

2019-10-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. - DefaultedComparisonKind not being a classic enum, setting as a so small bitfield triggers gcc warning. Repository: rC Clang https://reviews.llvm.org/D69

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

2019-08-27 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:240 + +- The Static Analyzer recieved a + :ref:`developer documentation `. typo `recieved` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6676

[PATCH] D66792: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

2019-08-27 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: sylvestre.ledru, kcc. devnexen created this object with visibility "All Users". Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D66792 Files: clang/docs/MemorySaniti

[PATCH] D66792: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

2019-08-27 Thread David CARLIER via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbccbd74c6255: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD (authored by devnexen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66792/new/ htt

[PATCH] D89690: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases.

2020-10-19 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: sepavloff, jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. devnexen requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89690 Files: clang/lib/Driver/ToolCh

[PATCH] D89690: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases.

2020-10-19 Thread David CARLIER via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG13e22961f8b4: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases (authored by devnexen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89690/

[PATCH] D110017: [clang] Removes leak sanitizer support on FreeBSD since it is unsupported

2021-09-17 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added a reviewer: emaste. devnexen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110017 Files: clang/lib/Driver/ToolChains/FreeBS

[PATCH] D44878: libFuzzer OpenBSD support

2018-03-25 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: brad, thakis. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D44878 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib/Driver/ToolChains/OpenBSD.cpp ===

[PATCH] D45002: [test] Conservatively re-enable a FreeBSD/XRay test

2018-03-28 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: test/Driver/XRay/xray-instrument-os.c:2 // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s -// XFAIL: -linux- +// XFAIL: -linux-, -freebsd // REQUIRES-ANY: amd64, x86_64, x86_64h, arm, aarch64, arm64 What outp

[PATCH] D44878: libFuzzer OpenBSD support

2018-03-28 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45002: [test] Conservatively re-enable a FreeBSD/XRay test

2018-03-29 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Looks ok to me except I would change a bit the title maybe. Repository: rC Clang https://reviews.llvm.org/D45002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D45002: [test] Fix an XRay test on FreeBSD

2018-03-29 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Since I do not have commit permissions hopefully @dberris will come by or kamil if he s less busy. Repository: rC Clang https://reviews.llvm.org/D45002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D45126: Xray, OpenBSD support

2018-03-31 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added a reviewer: brad. Herald added subscribers: cfe-commits, krytarowski, dberris. Enabling Xray in OpenBSD Repository: rC Clang https://reviews.llvm.org/D45126 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-04-01 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: NoQ, jdenny. Herald added a subscriber: cfe-commits. - reallocarray/recallocarray - freezero Repository: rC Clang https://reviews.llvm.org/D45149 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/bsd-malloc.c Ind

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-04-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 140607. devnexen added a comment. Using groups of functions. https://reviews.llvm.org/D45149 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/bsd-malloc.c Index: test/Analysis/bsd-malloc.c

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-04-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: george.karpenkov, NoQ. Herald added a subscriber: cfe-commits. strlcpy/strlcat are bounded but unlike their strn* counterparts, they can overlap. Repository: rC Clang https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checke

[PATCH] D45126: Xray, OpenBSD support

2018-04-03 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D45126#1055266, @dberris wrote: > LGTM -- at some point, it would be good to refactor all these flag settings > to a single place. Maybe file a bug so that we can track that issue on XRay? > If you can't do it now, I'd be happy to do it late

[PATCH] D45126: Xray, OpenBSD support

2018-04-03 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 140762. https://reviews.llvm.org/D45126 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp === --- lib/Driver/XRayArgs.cpp +++ lib/Driver/XRayA

[PATCH] D45126: Xray, OpenBSD support

2018-04-03 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. > Fixed: http://llvm.org/PR36985 Nice ! The NetBSD version will benefit it as well (not sure it s really done in the frontend side). https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D44878: libFuzzer OpenBSD support

2018-04-03 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

2018-04-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Do the unit tests have same outcome with these changes ? Otherwise, appreciate the simplification. https://reviews.llvm.org/D45243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D45126: Xray, OpenBSD support

2018-04-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Just realised he s not active since February, hopes it will make it somehow :-) https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D45126: Xray, OpenBSD support

2018-04-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Yes I can t land anything myself :-) thanks ! https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

2018-04-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. That's good enough for me the changes look neat. We ll see what others think. https://reviews.llvm.org/D45243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D44878: libFuzzer OpenBSD support

2018-04-08 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 141534. https://reviews.llvm.org/D44878 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib/Driver/ToolChains/OpenBSD.cpp === --- lib/Driver/ToolChains/OpenBSD.cpp +++ lib/Driver/ToolChains/

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

2018-04-09 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-04-09 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping https://reviews.llvm.org/D45149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44878: libFuzzer OpenBSD support

2018-04-09 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. the sanitizer part had been accepted https://reviews.llvm.org/D44877 https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45458: MallocChecker refactoring of calls checkers

2018-04-09 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: NoQ, thakis. Herald added a subscriber: cfe-commits. - Splitting some by family to reduce the list of function identifiers. Repository: rC Clang https://reviews.llvm.org/D45458 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp I

[PATCH] D45458: MallocChecker refactoring of calls checkers

2018-04-09 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Splitting from https://reviews.llvm.org/D45149 as requested. Repository: rC Clang https://reviews.llvm.org/D45458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D44878: libFuzzer OpenBSD support

2018-04-09 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Thanks ! anybody who can land it for me I ll be grateful. https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44878: Adding fuzzer flags support to OpenBSD driver

2018-04-10 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Hope it s good enough now :-) https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41809: Clang counterpart change for fuzzer FreeBSD support

2018-01-12 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D41809#969475, @kimgr wrote: > Typo in the commit title: buzzer :) Changed ... just to follow-up the now accepted change of this one https://reviews.llvm.org/D41642 https://reviews.llvm.org/D41809 __

[PATCH] D42467: FreeBSD needs also execinfo

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: joerg, vitalybuka. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, krytarowski, emaste. As NetBSD, FreeBSD needs execinfo for backtrace's matters. Repository: rC Clang https://reviews.ll

[PATCH] D42467: FreeBSD needs also execinfo and libutil

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131220. devnexen retitled this revision from "FreeBSD needs also execinfo" to "FreeBSD needs also execinfo and libutil". devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/Com

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D42467#986214, @krytarowski wrote: > Do you plan to use MSan? If so, `-lkvm` might be useful as well. This is indeed the plan. Updated. Repository: rC Clang https://reviews.llvm.org/D42467

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131229. devnexen retitled this revision from "FreeBSD needs also execinfo and libutil" to "FreeBSD needs also execinfo, libutil and libkvm". devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/D

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D42467#986279, @krytarowski wrote: > Please update the `-lutil` comment in the code according to the comment. I > can land this for you once it will be accepted. In fact the review comment is wrong/confusing :-) lutil is for forkpty only as

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131239. devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131356. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp === --- lib/Driver/ToolChains/CommonAr

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131358. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp === --- lib/Driver/ToolChains/CommonAr

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D42467#987140, @krytarowski wrote: > I propose to skip now `-lkvm` and `-lutil` for FreeBSD. I'm researching now > an option to rebuild these libraries against sanitizers and so stop teaching > the world how to handle its API. > > Please kee

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131359. devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D42645: New simple Checker for mmap calls

2018-01-29 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: dcoughlin, dergachev.a. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, hintonda, mgorny. This new checker tests if both PROT_WRITE and PROT_EXEC have been set. Repository: rC Clang http

[PATCH] D42645: New simple Checker for mmap calls

2018-01-29 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131813. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index: lib/StaticAnalyzer/Checkers

<    1   2   3   >