devnexen added inline comments.
================
Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189
if (getToolChain().ShouldLinkCXXStdlib(Args))
- getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs);
+ ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
if (Args.hasArg(options::OPT_pg))
----------------
dberris wrote:
> devnexen wrote:
> > dberris wrote:
> > > Do you actually need this change? Why isn't
> > > `getToolChain().AddCXXStdlibLibArgs(...)` not sufficient here?
> > That s the thing, I wish it was simple as FreeBSD, but seemingly in OpenBSD
> > needs both c++98 gcc runtime and libc++ for fuzzer (I tried libc++ alone
> > already)
> Right, but this comment is on this specific line change. I don't think you
> need to reach into `Toolchain.` direcly, since you can already use
> `getToolChain()` just from the above line (188).
Right, so I guess this diff https://reviews.llvm.org/D45662?id=142686 is
sufficient then ?
https://reviews.llvm.org/D45662
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
