[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 367840. cor3ntin added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. - Add more tests - Add a table for format codepoints - which we want to output as is. These include among other ZWJ (for emojis) an

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 367844. cor3ntin added a comment. Remove superfluous assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D108526: [clang][nfc] Mark as P0692R1 as implemented.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P0692R1 was implemented in https://reviews.llvm.org/D92024 but the status page was not updated. Repository: rG LLVM Github Monorepo https://review

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:702 // Helper functions to lex the remainder of a token of the specific type. - bool LexIdentifier (Token &Result, const char *CurPtr); + bool LexIdentifierContinue(Token &Result, const char

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin updated this revision to Diff 368746. cor3ntin added a comment. Fix comments following Aaron's feedback, remove braces deemed unecessary by the guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin marked 4 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:702 // Helper functions to lex the remainder of a token of the specific type. - bool LexIdentifier (Token &Result, const char *CurPtr); + bool LexId

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:422-423 -ExprResult ArgExpr( -Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); +ExprResult ArgExpr(Actions.CorrectDelayedTyposInExpr( +ParseAttribut

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin created this revision. Herald added a subscriber: dexonsmith. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to The Unicode standard, line feed and vertical tab should be considered line breaks. See notably htt

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin updated this revision to Diff 368826. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108742/new/ https://reviews.llvm.org/D108742 Files: clang/lib/Basic/CharInfo.cpp clang/unittests/Basic/CharInfoTes

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin added inline comments. Comment at: clang/unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp:170-173 ASSERT_FALSE( - minimizeSourceToDependencyDirectives("#define MACRO(a\\\n" + minimizeSourceToDependencyDirectives("#define MACRO(a \\\

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin updated this revision to Diff 368958. cor3ntin added a comment. - Add tests and fix existing tests (again) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108742/new/ https://reviews.llvm.org/D108742 Files: clang/lib/Basic/CharInfo.cpp

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin added a comment. In D108742#2970218 , @hubert.reinterpretcast wrote: > I find the lack of changes to tests other than API unittests to be somewhat > concerning. > Indeed, I applied the patch and did not notice behaviour changes in how `\f` > o

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin added a comment. In D108742#2970263 , @rsmith wrote: > I assume this is intended to form part of the implementation of > https://wg21.link/p2348 and so shouldn't be considered for review right now? Yes, I wanted your feedback anyway but that wa

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin added a comment. In D108742#2970302 , @rsmith wrote: > In D108742#2970283 , @cor3ntin > wrote: > >>> Drive-by observation: under P2348 , Clang's >>> behavior of treating

[PATCH] D108308: Cleanup identifier parsing.

cor3ntin updated this revision to Diff 369446. cor3ntin added a comment. Move a comment to the header file per Aaron request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 Files: clang-tools-extra/clan

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added a comment. At @aaron.ballman request, here are some data collection trying to assert the amount of breakage On a corpus of 78M lines of C++ code corresponding to all the packages in vcpkg - Number of strings with encoding prefix in `_Pragma`: 3/3383 (all in test suits) - Number

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin planned changes to this revision. cor3ntin added a comment. I'll fix the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 ___ cfe-commits mailing

[PATCH] D109854: Support Unicode 14 identifiers This update the UAX tables to support new Unicode 14 identifiers

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109854 Files: clang/lib/Lex/UnicodeCharSets.h Index: clang/lib/Lex/UnicodeCharSets

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

cor3ntin added a comment. Thanks! For which platforms did you had issue? This is suppose to work in all language modes (we might want to use C99/C++98 to make sure that's the case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https:/

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

cor3ntin added a comment. Okay, what's happening is that utf literals are only available for c++11 onward and the tests do not account for that. Would you mind dropping the minimum version to C++11 and C11? I think that would be reasonable. I could do a more extensive fix but I don't know how u

<    12   13   14   15   16   17