cor3ntin added inline comments.
================
Comment at:
clang/unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp:170-173
ASSERT_FALSE(
- minimizeSourceToDependencyDirectives("#define MACRO(a \\\n"
+ minimizeSourceToDependencyDirectives("#define MACRO(a
\\\n\\\v\\\f"
" )",
Out));
----------------
dexonsmith wrote:
> Please don't modify this assertion to test `\v` and `\f`. Instead add new
> assertions. I'm not sure if they belong in `DefineMultilineArgs`, or if
> `DefineSpacing` might be a better spot, or maybe a new test
> `DefineVerticalWhitespace`?
I think this test is useful, you are right I should add more somewhere else. I
will also add that new test without removing the old one!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108742/new/
https://reviews.llvm.org/D108742
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
