[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 89. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd - [Support] update zstd interface to use uint8_t * and ArrayRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcef07169ec9f: [llvm] add zstd to `llvm::compression` namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3651025 , @aemerson wrote: > I just reverted this in 6e6be5f9504d > because > it seems to have broken macOS builds: > > llvm/lib/Support/Compres

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. @aemerson can you let me know if https://reviews.llvm.org/D129786 works on MacOS? I am continuing work on that revision because this one has a lot of outdated unrelated history. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3653051 , @jasonmolenda wrote: > In D128465#3652525 , @ckissane > wrote: > >> In D128465#3651025 , @aemerson >> wrote: >> >>> I jus

[PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3660714 , @MaskRay wrote: > Instead of marking a differential `[OLD] ` (which may confuse readers whether > this is to be abandoned), you can mark a differential `Request > Reviews`/`Request Changes`. Then it will no

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 445615. ckissane added a comment. - move try_find_dependency into it's own file - add newline to end of TryFindDependencyMacro.cmake - clarify comment in TryFindDependencyMacro.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 445623. ckissane added a comment. - remove extra cmake info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt llvm/cmake/config-ix.cmake

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3661049 , @MaskRay wrote: > Does this address the macOS build failure? I believe so! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe939bf67e340: [llvm] add zstd to `llvm::compression` namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D130516: [Support] compression classes

ckissane created this revision. ckissane added a reviewer: dblaikie. Herald added subscribers: wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. Herald add

[PATCH] D130516: [Support] compression classes

ckissane updated this revision to Diff 447469. ckissane added a comment. - format - merge fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/index/Serialization.cpp cl

[PATCH] D130516: [Support] compression classes

ckissane added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:2003-2004 // consumers will not want its contents. + llvm::compression::CompressionAlgorithm CompressionScheme = + llvm::compression::ZlibCompressionAlgorithm(); + dblaikie

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane created this revision. ckissane added reviewers: dblaikie, MaskRay. Herald added subscribers: StephenFan, wenlei, kadircet, arphaman, hiraditya, arichardson, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. H

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane added inline comments. Comment at: llvm/lib/Object/Decompressor.cpp:50 +return createError( +"Decompressor provided nullptr (None) CompressionScheme*"); + if (!CompressionScheme->Implementation) dblaikie wrote: > This probably isn't a useful

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453136. ckissane added a comment. - remove Supported member of CompressionSpec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/inde

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453139. ckissane added a comment. - move compression level members from spec to impl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clang

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked an inline comment as done. ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:48-50 + const int BestSpeedLevel; + const int DefaultLevel; + const int BestSizeLevel; dblaikie wrote: > These could/should probably

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453140. ckissane added a comment. - compression: remove some usage sugar from Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/index

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:95-98 + static CompressionSpecRef Unknown; + static CompressionSpecRef None; + static CompressionSpecRef Zlib; + static CompressionSpecRef ZStd; dblaikie wrote: > Generally we

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453143. ckissane added a comment. - remove extra includes of ADT/Optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/index/Ser

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:95-98 + static CompressionSpecRef Unknown; + static CompressionSpecRef None; + static CompressionSpecRef Zlib; + static CompressionSpecRef ZStd; dblaikie wrote: > ckissane wro

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453379. ckissane added a comment. - remove CompressionSpecRefs::{Zlib,ZStd} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/index/S

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked 6 inline comments as done. ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:40 +CompressionSpecRef getCompressionSpec(CompressionKind Kind); +CompressionSpecRef getSchemeDetails(CompressionImplRef Implementation); + -

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453404. ckissane marked 3 inline comments as done. ckissane added a comment. - remove Compression{Spec,Impl}Ref typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D13199

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453409. ckissane added a comment. - small compression test cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/index/Serializat

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453723. ckissane added a comment. - fix static initialization skip errors in getCompressionSpec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked an inline comment as done. ckissane added inline comments. Comment at: llvm/include/llvm/Object/Decompressor.h:52-53 uint64_t DecompressedSize; + compression::CompressionSpecRef CompressionScheme = + compression::CompressionSpecRefs::Zlib; }; ---

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453774. ckissane marked an inline comment as done. ckissane added a comment. - CompressionImplementation member on Decompressor instead of Spec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https:/

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked an inline comment as done. ckissane added a comment. @dblaikie I've handled most of your comments, can you take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 __

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453803. ckissane added a comment. - shorten compression related variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/inde

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked 2 inline comments as done. ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:38-39 + +CompressionSpecRef getCompressionSpec(uint8_t Kind); +CompressionSpecRef getCompressionSpec(CompressionKind Kind); +CompressionSpecRef getScheme

[PATCH] D128465: [WIP] Zstandard as a second compression method to LLVM

ckissane created this revision. ckissane added reviewers: phosek, leonardchan. ckissane added a project: LLVM. Herald added subscribers: Enna1, abrachet, wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a r

<    1   2