ckissane added a comment. In D128465#3653051 <https://reviews.llvm.org/D128465#3653051>, @jasonmolenda wrote:
> In D128465#3652525 <https://reviews.llvm.org/D128465#3652525>, @ckissane > wrote: > >> In D128465#3651025 <https://reviews.llvm.org/D128465#3651025>, @aemerson >> wrote: >> >>> I just reverted this in 6e6be5f9504d >>> <https://reviews.llvm.org/rG6e6be5f9504d3de7a5e94bdc3c8ba96d2f6a88a8> >>> because it seems to have broken macOS builds: >>> >>> llvm/lib/Support/Compression.cpp:24:10: fatal error: 'zstd.h' file not >>> found >>> #include <zstd.h> >>> ^~~~~~~~ >> >> @aemerson Could you provide the output of your cmake command? >> (I can't easily reproduce because I don't have a mac on hand) > > FWIW I hit this last night on my mac desktop - it looked like I had zstd > installed by homebrew (as a dependency on something I installed), and cmake > was able to find it in /opt/homebrew (somehow) but when Compression.cpp was > built, nothing had added -I/opt/homebrew/include so the header wasn't found. > I hacked the FindZSTD.cmake to not find it, to finish what I was working on > before bedtime. This might not be related to what @aemerson saw though. @jasonmolenda Thank you for the info, I believe it is similar, could you try: https://reviews.llvm.org/D129786 for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
