ckissane added inline comments.
================ Comment at: llvm/include/llvm/Support/Compression.h:95-98 + static CompressionSpecRef Unknown; + static CompressionSpecRef None; + static CompressionSpecRef Zlib; + static CompressionSpecRef ZStd; ---------------- dblaikie wrote: > Generally we don't want more variables that need global constructors in LLVM > - so these should probably be function-local statics in functions instead. > (I don't think we need a CompressionSpecRef for `Unknown` or `None`, though) these are just shortcuts to the function local statics of `CompressionSpecRef getCompressionSpec(uint8_t Kind)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
