bcraig added a subscriber: bcraig.
bcraig added a comment.
I like the rationale here, but can we avoid pulling in headers at all?
You could test _ _STDC_NO_ATOMICS_ _. You could also have some code like
this...
_Atomic int x;
int main() {
x += 1;
return x;
}
https://reviews.llvm
bcraig added a comment.
In https://reviews.llvm.org/D23719#520952, @rsmith wrote:
> Are we really guaranteed that the C and C++ compiler behave the same way
> here? I don't see why that would necessarily be the case.
For libc++, std::atomic is implemented in terms of _Atomic. So as long as th
bcraig added a comment.
In https://reviews.llvm.org/D23719#520953, @smeenai wrote:
> @bcraig: `__STDC_NO_ATOMICS__` wouldn't be defined for pre-C11 compilers
> either, right?
>
> From what I understand of the original code sample, one of the purposes was
> to check for 64-bit atomic support on
bcraig added a comment.
In https://reviews.llvm.org/D23719#520969, @rsmith wrote:
> In https://reviews.llvm.org/D23719#520954, @bcraig wrote:
>
> > In https://reviews.llvm.org/D23719#520952, @rsmith wrote:
> >
> > > Are we really guaranteed that the C and C++ compiler behave the same way
> > > h
bcraig added a comment.
I will note that I'm only really looking at the tests, mostly from the
perspective of a potential user.
Thanks for getting C++ initializer lists in.
The tests in general look fine. The omission of cross visibility reordering is
fine as an initial step.
Once multi-TU s
bcraig added a comment.
In https://reviews.llvm.org/D23279#522504, @djasper wrote:
> In the meantime, I don't know whether we should check this in as a
> standalone-tool and then merge into clang-refactor once ready. Ben, what do
> you think?
Well, I don't know how much you should count my op
bcraig added a comment.
In https://reviews.llvm.org/D23279#523449, @alexshap wrote:
> @djasper, @bcraig, @aaron.ballman - many thanks for the comments and
> suggestions,
> please, let me know if you are waiting for any other changes on my side (for
> v0) or if there is anything else i can do t
bcraig added a comment.
In https://reviews.llvm.org/D21803#530678, @tavianator wrote:
> Ping?
Well, I still think it's fine. Maybe a direct message to @mclow.lists or
@EricWF?
https://reviews.llvm.org/D21803
___
cfe-commits mailing list
cfe-com
bcraig added a comment.
The "@" will do a ping through phabricator, but a direct email is probably
going to be your best bet at this point.
https://reviews.llvm.org/D21803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
bcraig added inline comments.
Comment at: src/condition_variable.cpp:86
@@ +85,3 @@
+if (tl_ptr.get() == nullptr) {
+tl_ptr.set_pointer(new __thread_struct);
+}
The standard synopsis of notify_all_at_thread_exit in the standard doesn't have
a "Thr
bcraig added a comment.
LGTM
Comment at: src/condition_variable.cpp:86
@@ +85,3 @@
+if (tl_ptr.get() == nullptr) {
+tl_ptr.set_pointer(new __thread_struct);
+}
EricWF wrote:
> bcraig wrote:
> > The standard synopsis of notify_all_at_thread_exit i
bcraig added a subscriber: bcraig.
bcraig added a comment.
This seems related:
https://reviews.llvm.org/D20596
In that (stale) review, I switch away from unique_ptr in general for locale
related operations.
https://reviews.llvm.org/D24374
___
cfe-
bcraig added a comment.
In https://reviews.llvm.org/D24374#538521, @smeenai wrote:
> @bcraig thanks for pointing me to that diff; there's a lot of nice cleanup
> going on there. Were you planning on updating and following up on it?
>
> I also realized I forgot to adjust `locale_win32.cpp` for th
bcraig added a subscriber: bcraig.
bcraig added a comment.
Neat! I would have liked to have had this for the Excess Padding Checker.
Currently, the padding checker has a very long diagnostic that recommends a new
order for data members. I think a note (or fixit) would be more appropriate,
bu
Author: bcraig
Date: Tue Apr 11 09:06:39 2017
New Revision: 299942
URL: http://llvm.org/viewvc/llvm-project?rev=299942&view=rev
Log:
[libc++] Fix unknown pragma warning on MSVC
Modified:
libcxx/trunk/include/limits
Modified: libcxx/trunk/include/limits
URL:
http://llvm.org/viewvc/llvm-proje
Author: bcraig
Date: Tue Jul 11 18:45:13 2017
New Revision: 307751
URL: http://llvm.org/viewvc/llvm-project?rev=307751&view=rev
Log:
Fix unrepresentable enum for clang-cl unstable ABI
When using LIBCXX_ABI_UNSTABLE=YES, clang-cl gave the following warning:
P:\llvm_master\src\llvm\projects\libcxx
Author: bcraig
Date: Mon May 8 08:15:22 2017
New Revision: 302421
URL: http://llvm.org/viewvc/llvm-project?rev=302421&view=rev
Log:
Fix Windows tests when __config_site is present.
Previously, the force includes would complain about a missing _DEBUG symbol.
Now we dump macros before adding the fo
Author: bcraig
Date: Mon May 8 20:26:39 2017
New Revision: 302496
URL: http://llvm.org/viewvc/llvm-project?rev=302496&view=rev
Log:
Revert "Fix Windows tests when __config_site is present."
It's 2017, and line endings are still an issue.
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Mo
Author: bcraig
Date: Mon May 8 20:34:12 2017
New Revision: 302497
URL: http://llvm.org/viewvc/llvm-project?rev=302497&view=rev
Log:
Fix Windows tests when __config_site is present.
Previously, the force includes would complain about a missing _DEBUG symbol.
Now we dump macros before adding the fo
bcraig added a subscriber: bcraig.
bcraig added a comment.
For what it's worth, our internal branch installs these by default, and I was
unpleasantly surprised when I found that upstream didn't.
http://reviews.llvm.org/D14403
___
cfe-commits mailin
bcraig added a subscriber: bcraig.
bcraig added a comment.
Does this affect the presence or functionality of the "INSTALL" project?
http://reviews.llvm.org/D14502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
bcraig created this revision.
bcraig added reviewers: zaks.anna, rsmith.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
RecursiveASTVisitor allows visitors to specify whether they wish to visit
implicitly created code or not. I have ported that code over to
DataRecursi
bcraig added a comment.
In a text file, I have a big long cmake invocation. Part of that invocation is
the following:
-DCMAKE_INSTALL_PREFIX=c:/install/Tools
The VC "INSTALL" project copies files there, in a very unix-y hierarchy (i.e.
c:\install\Tools\bin, c:\install\Tools\include, c:\inst
bcraig added a subscriber: bcraig.
bcraig added a comment.
Looks good to me, but since this is in the LLVMSupport library, you should
probably add llvm-commits to the subscriber list.
http://reviews.llvm.org/D14583
___
cfe-commits mailing list
cfe-
bcraig created this revision.
bcraig added reviewers: jfb, mclow.lists, EricWF.
bcraig added a subscriber: cfe-commits.
If the last destruction is uncontended, skip the atomic store on
__shared_weak_owners_.
For x86_64, this results in an 8% improvement in shared_ptr ctor+dtor
performance.
Old be
bcraig added a subscriber: bcraig.
Comment at: src/UnwindRegistersRestore.S:325
@@ -324,4 +324,3 @@
DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv)
-#if !defined(__ARM_ARCH_ISA_ARM)
- ldr r2, [r0, #52]
- ldr r3, [r0, #60]
+#if !defined(_
bcraig updated the summary for this revision.
bcraig updated this revision to Diff 64504.
bcraig added a comment.
Added weak_ptr benchmark, as that's where the cost shifted.
https://reviews.llvm.org/D22470
Files:
benchmarks/shared_ptr_create_destroy.cpp
benchmarks/shared_ptr_inc_dec_ref.cpp
bcraig added a subscriber: bcraig.
Comment at: include/atomic:569
@@ +568,3 @@
+__attribute__ ((__enable_if__(__m == memory_order_release \
+ || __m == memory_order_acq_rel, ""))) \
+__attribute__ ((__unavailable__("me
bcraig added inline comments.
Comment at: include/atomic:569
@@ +568,3 @@
+__attribute__ ((__enable_if__(__m == memory_order_release \
+ || __m == memory_order_acq_rel, ""))) \
+__attribute__ ((__unavailable__("memory
bcraig added a comment.
I am going to submit the code changes and the tests independently. I'm having
trouble getting cmake to use the right compiler for the libcxx-benchmarks
target.
https://reviews.llvm.org/D22470
___
cfe-commits mailing list
c
Author: bcraig
Date: Mon Aug 1 12:51:26 2016
New Revision: 277357
URL: http://llvm.org/viewvc/llvm-project?rev=277357&view=rev
Log:
Improve shared_ptr dtor performance
If the last destruction is uncontended, skip the atomic store on
__shared_weak_owners_. This shifts some costs from normal
share
bcraig closed this revision.
bcraig added a comment.
committed https://reviews.llvm.org/rL277357: Improve shared_ptr dtor
performance.
https://reviews.llvm.org/D22470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: bcraig
Date: Mon Aug 1 14:56:39 2016
New Revision: 277373
URL: http://llvm.org/viewvc/llvm-project?rev=277373&view=rev
Log:
Adding smart_ptr benchmark
Initial draft here:
https://reviews.llvm.org/D22470
... though this is Eric Fiselier's rewrite to fit in with Google
Benchmark.
Added:
Author: bcraig
Date: Tue Aug 2 08:43:48 2016
New Revision: 277456
URL: http://llvm.org/viewvc/llvm-project?rev=277456&view=rev
Log:
Fixing 'Aquire' typo and libcxx build.
Modified:
libcxx/trunk/src/include/atomic_support.h
libcxx/trunk/src/memory.cpp
Modified: libcxx/trunk/src/include/a
bcraig added a subscriber: bcraig.
bcraig added a comment.
In https://reviews.llvm.org/D23279#509017, @Eugene.Zelenko wrote:
> Do we really need standalone tool for this purpose? If I'm not mistaken,
> Static Analyzer already has clang-analyzer-optin.performance.Padding check,
> which is also a
bcraig added a comment.
It is very common for developers to put comments near a field. If this tool
doesn't move the "anchored" comments, then its utility will be severely limited.
Does this tool also reorder C++ member initializer lists? If it doesn't, then
running this tool will introduce w
bcraig added a comment.
In https://reviews.llvm.org/D23279#510178, @omtcyfz wrote:
> In https://reviews.llvm.org/D23279#510167, @alexshap wrote:
>
> > my point is the following: this tool helps perform some operation (changing
> > the order of fields),
> > if smb decides to do it manually - th
bcraig added a comment.
In https://reviews.llvm.org/D23279#511187, @omtcyfz wrote:
> In https://reviews.llvm.org/D23279#510234, @alexshap wrote:
>
> > > I do think that an automated tool will do a better job of changing field
> > > orderings in a non-breaking way than most people would, mostly d
bcraig added a comment.
In https://reviews.llvm.org/D23279#511266, @omtcyfz wrote:
> In https://reviews.llvm.org/D23279#511202, @bcraig wrote:
>
> > In https://reviews.llvm.org/D23279#511187, @omtcyfz wrote:
> >
> > > In https://reviews.llvm.org/D23279#510234, @alexshap wrote:
> > >
> > > > > I d
bcraig added a comment.
Note: In the future, try to provide more context lines in the patch.
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
I'm mostly fine with the algorithmic changes. I'm not thrilled with the
formatting of the error message, but I'm not sur
bcraig added a comment.
I am kind of interested in what the warning message for clang::Sema in
clang/include/clang/Sema/Sema.h looks like. When I last analyzed that file,
there was a bunch of padding. It's a very long class though, so it can stress
the usability of your messages.
https://re
bcraig added a comment.
LGTM. Thanks for the patch!
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217
@@ +216,3 @@
+// then large field indices to small field indices
+return std::make_tuple(Align, -Size,
+ Field ?
-st
bcraig added a comment.
LGTM
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217
@@ +216,3 @@
+// then large field indices to small field indices
+return std::make_tuple(Align, -Size,
+ Field ?
-static_cast(Field->getFiel
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
@mclow.lists ping
http://reviews.llvm.org/D15539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
Any objections to using the original sizes, but constructing the objects at
global scope? That fixes the stack usage without significantly changing the
layout characteristics of the test?
http://reviews.llvm.org/D15539
___
bcraig updated the summary for this revision.
bcraig updated this revision to Diff 47327.
http://reviews.llvm.org/D15539
Files:
test/dynamic_cast14.pass.cpp
Index: test/dynamic_cast14.pass.cpp
===
--- test/dynamic_cast14.pass.cpp
bcraig updated the summary for this revision.
bcraig updated this revision to Diff 47328.
bcraig added a comment.
Moved the CATOPEN config check back to __config. Saving a larger locale
refactor for later (but oh boy is it coming).
http://reviews.llvm.org/D16639
Files:
include/__config
Ind
Author: bcraig
Date: Wed Feb 10 07:47:25 2016
New Revision: 260381
URL: http://llvm.org/viewvc/llvm-project?rev=260381&view=rev
Log:
Limit catopen usage to unix-like OSes
Operating systems that are not unix-like are unlikely to have access to
catopen. Instead of black-listing each one, we now fil
bcraig added a comment.
ping
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added inline comments.
Comment at: test/libcxx/test/config.py:469
@@ +468,3 @@
+if cxx_library_root:
+abs_path = cxx_library_root + "/libc++.a"
+self.cxx.link_flags += [abs_path]
EricWF wrote:
> Why no
bcraig added a comment.
In http://reviews.llvm.org/D17146#350382, @mclow.lists wrote:
> > I'm open to recommendations on ways to test this that are better than
> > "Submit, watch build bots, revert as necessary".
>
>
> My suggestion is to do this incrementally.
> Implement the infrastructure bi
bcraig updated this revision to Diff 48112.
bcraig added a comment.
Addressed EricWF's feedback.
http://reviews.llvm.org/D16545
Files:
CMakeLists.txt
test/CMakeLists.txt
test/libcxxabi/test/config.py
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
=
bcraig updated this revision to Diff 48113.
bcraig added a comment.
Addressed EricWF's feedback (hopefully).
http://reviews.llvm.org/D16544
Files:
test/CMakeLists.txt
test/libcxx/test/config.py
test/libcxx/test/target_info.py
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
===
bcraig marked 6 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig marked an inline comment as done.
bcraig added a comment.
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
So does this latest revision get the check-mark of approval?
http://reviews.llvm.org/D15539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig created this revision.
bcraig added reviewers: howard.hinnant, mclow.lists.
bcraig added a subscriber: cfe-commits.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is going.
For the locale refactor, the locale management functio
bcraig created this revision.
bcraig added reviewers: jroelofs, mclow.lists.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: jfb.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is going.
For the locale refactor, the
Author: bcraig
Date: Thu Feb 18 11:40:16 2016
New Revision: 261231
URL: http://llvm.org/viewvc/llvm-project?rev=261231&view=rev
Log:
Split locale management out of newlib/xlocale.h. NFCI
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is
Author: bcraig
Date: Thu Feb 18 11:37:33 2016
New Revision: 261230
URL: http://llvm.org/viewvc/llvm-project?rev=261230&view=rev
Log:
Split locale management out of ibm/xlocale.h. NFCI
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is go
bcraig created this revision.
bcraig added reviewers: mclow.lists, EricWF, danalbert, jroelofs.
bcraig added a subscriber: cfe-commits.
Prior to this patch, setting LIBCXXABI_LIBDIR_SUFFIX would confuse the
check-libcxxabi target. libc++abi.* would get output to lib instead of
lib${LIBCXXABI_LI
bcraig updated this revision to Diff 48396.
bcraig added a comment.
Prior version doesn't apply to master. The context was dirty from some
unsubmitted patches.
http://reviews.llvm.org/D17410
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
bcraig created this revision.
bcraig added reviewers: jroelofs, danalbert, mclow.lists.
bcraig added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer, jfb.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where th
bcraig created this revision.
bcraig added reviewers: rubenvb, yaron.keren, jroelofs, howard.hinnant,
mclow.lists.
bcraig added a subscriber: cfe-commits.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is going.
For the locale refactor
bcraig created this revision.
bcraig added reviewers: scshunt, howard.hinnant, jroelofs, mclow.lists.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: jfb.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is going.
Inst
bcraig added a comment.
In http://reviews.llvm.org/D17456#357232, @jroelofs wrote:
> > The private redirector symbol names are all prefixed with _CXX_* so that
> > they won't conflict with user symbols,
>
>
> This is more @mclow.lists/@ericwf's domain, but I think __libcxx_ prefixes
> would be
bcraig updated the summary for this revision.
bcraig removed a reviewer: scshunt.
bcraig updated this revision to Diff 48520.
bcraig added a comment.
Switched from _CXX_* prefix to _libcxx_* prefix to avoid link time conflicts
with other C++ library implementations.
Removed Sean Hunt from the re
bcraig abandoned this revision.
bcraig added a comment.
Breaking this up into smaller chunks.
http://reviews.llvm.org/D17146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated the summary for this revision.
bcraig added a reviewer: joerg.
bcraig updated this revision to Diff 48687.
bcraig added a comment.
Changed libcxx prefix to libcpp.
Changed BSD forwarding macros to macro functions.
http://reviews.llvm.org/D17456
Files:
include/__bsd_locale_defau
bcraig added a comment.
@mclow.lists ping
http://reviews.llvm.org/D15539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
LGTM. You will still need to get approval from one of your original reviewers
though.
http://reviews.llvm.org/D19415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
bcraig added a comment.
LGTM. You will still need to get approval from one of your original reviewers
though.
http://reviews.llvm.org/D19412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
bcraig added inline comments.
Comment at: src/algorithm.cpp:51
@@ -50,3 +50,3 @@
#ifndef _LIBCPP_HAS_NO_THREADS
-static pthread_mutex_t __rs_mut = PTHREAD_MUTEX_INITIALIZER;
+static mutex __rs_mut;
#endif
rmaprath wrote:
> mclow.lists wrote:
> > What happened to
bcraig added a subscriber: bcraig.
bcraig added a comment.
Is there an associated patch on the consuming side for this data?
http://reviews.llvm.org/D19667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
bcraig added a comment.
In http://reviews.llvm.org/D19412#414374, @rmaprath wrote:
> > On a bikeshed note: is `<__os_support>` the right name? Or should it be
> > something like `<__thread>` or `<__threading_support>`?
>
>
> I went with `__os_support` in case if we'd want to group further exte
bcraig added a comment.
LGTM. You'll still need to wait for one of the other reviewers though
(probably @mclow.lists )
http://reviews.llvm.org/D19412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
bcraig added a comment.
LGTM
http://reviews.llvm.org/D19856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a subscriber: bcraig.
bcraig added a comment.
> We could, on the other hand, do this tightening for all the supported
> architectures (for the new, native-only libunwind build suggested by
> @jroelofs) with appropriate asserts in place so that we maintain these tight
> bounds as we
bcraig created this revision.
bcraig added reviewers: olista01, t.p.northover.
bcraig added a subscriber: cfe-commits.
note_fe_backend_invalid_loc expects three arguments (file, line, column), and
will assert when only given two. The other two places in this file that use
note_fe_backend_invali
Author: bcraig
Date: Fri May 6 08:29:46 2016
New Revision: 268732
URL: http://llvm.org/viewvc/llvm-project?rev=268732&view=rev
Log:
Adding omitted column to invalid loc diagnostic.
note_fe_backend_invalid_loc expects three arguments (file, line, column),
and will assert when only given two. The
bcraig added a comment.
r268732
http://reviews.llvm.org/D19936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated this revision to Diff 57520.
http://reviews.llvm.org/D17416
Files:
include/support/android/locale_bionic.h
include/support/newlib/xlocale.h
include/support/xlocale/__posix_l_fallback.h
include/support/xlocale/__strtonum_fallback.h
include/support/xlocale/xlocale.h
Index:
bcraig updated this revision to Diff 57521.
bcraig marked 2 inline comments as done.
http://reviews.llvm.org/D17416
Files:
include/support/android/locale_bionic.h
include/support/newlib/xlocale.h
include/support/xlocale/__posix_l_fallback.h
include/support/xlocale/__strtonum_fallback.h
bcraig added a comment.
I'll be submitting this Friday morning, barring any objections (I'm out of the
office the next couple of days).
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: bcraig
Date: Fri May 20 07:58:41 2016
New Revision: 270213
URL: http://llvm.org/viewvc/llvm-project?rev=270213&view=rev
Log:
Reorganize locale extension fallbacks. NFCI
The various _l locale extension functions originate from very
different places. Some come from POSIX, some are BSD exte
bcraig closed this revision.
bcraig added a comment.
r270213
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D17410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping @danalbert, @mclow.lists
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a subscriber: bcraig.
bcraig added a comment.
Is this checker able to connect a std::string with a pre-declared string
literal (i.e. constant propagation)? For example...
const char *bad_chars = "\0\1\2\3";
std::string bad_str = bad_chars;
I've had real code make that mistake
bcraig added a comment.
In http://reviews.llvm.org/D17410#403263, @EricWF wrote:
> So we already do this for the standalone builds but not for in-tree builds.
> Before committing please make sure to remove the code on CMakeLists.txt line
> 99 that does this same thing.
Done
> I'm assuming c
Author: bcraig
Date: Mon Apr 18 08:30:38 2016
New Revision: 266611
URL: http://llvm.org/viewvc/llvm-project?rev=266611&view=rev
Log:
Respect LIBCXXABI_LIBDIR_SUFFIX before an install
Prior to this patch, setting LIBCXXABI_LIBDIR_SUFFIX would confuse the
check-libcxxabi target. libc++abi.* would g
bcraig closed this revision.
bcraig added a comment.
r266611
http://reviews.llvm.org/D17410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
In http://reviews.llvm.org/D16544#403273, @EricWF wrote:
> Just spitballing but have you considered simply passing the full path,
> including the library name, to LIT? Instead of needing `enable_shared`
> variables we would simply use the named library, be it DSO or arch
1 - 100 of 257 matches
Mail list logo
