bcraig added inline comments.
================
Comment at: test/libcxx/test/config.py:469
@@ +468,3 @@
+ if cxx_library_root:
+ abs_path = cxx_library_root + "/libc++.a"
+ self.cxx.link_flags += [abs_path]
----------------
EricWF wrote:
> Why not just wrap it in '-B,-static'?
I know exactly which binary I want to link against. Running through the linker
search path can't make this work better, but it can make it work worse.
================
Comment at: test/libcxx/test/target_info.py:173
@@ -164,2 +172,3 @@
llvm_unwinder = self.full_config.get_lit_bool('llvm_unwinder', False)
+ shared_libcxx = self.full_config.get_lit_bool('enable_shared', False)
flags += ['-lm']
----------------
EricWF wrote:
> Hmm... this would have a different default compared to elsewhere after my
> suggested edits.
When testing libcxx, it's going to be difficult to get an unset enable_shared,
so the default doesn't matter that much in that situation. It might matter
more with libcxxabi. I will investigate.
Regardless, I'm pretty sure "False" is the default here due to copy / paste
rather than long, careful consideration.
http://reviews.llvm.org/D16544
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
