Author: abataev
Date: Mon Feb 8 07:02:00 2016
New Revision: 260091
URL: http://llvm.org/viewvc/llvm-project?rev=260091&view=rev
Log:
[OPENMP] Fixed test incompat with MSVC
Modified:
cfe/trunk/test/OpenMP/parallel_private_codegen.cpp
Modified: cfe/trunk/test/OpenMP/parallel_private_codegen.c
Author: abataev
Date: Mon Feb 8 07:47:46 2016
New Revision: 260092
URL: http://llvm.org/viewvc/llvm-project?rev=260092&view=rev
Log:
[OPENMP] Fix test incompatibility with arm buildbots
Modified:
cfe/trunk/test/OpenMP/parallel_private_codegen.cpp
Modified: cfe/trunk/test/OpenMP/parallel_pri
=
Software Engineer
Intel Compiler Team
08.02.2016 15:43, NAKAMURA Takumi пишет:
The test is incompatible to i686-pc-win32. See also
http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/5498
On Mon, Feb 8, 2016 at 6:33 PM Alexey Bataev via cfe-commits
mailto:cfe-commits@lists.llvm.org>>
ABataev added a comment.
Ping
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Ping
http://reviews.llvm.org/D10599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Tue Feb 9 02:51:26 2016
New Revision: 260211
URL: http://llvm.org/viewvc/llvm-project?rev=260211&view=rev
Log:
Fixed preprocessed output of the first token for pragmas.
Clang did not expanded macros in the very first token of the pragmas
during preprocessed output
Modified:
Author: abataev
Date: Tue Feb 9 03:41:33 2016
New Revision: 260214
URL: http://llvm.org/viewvc/llvm-project?rev=260214&view=rev
Log:
Do not mark variable as threadprivate if it was marked already.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
Author: abataev
Date: Tue Feb 9 03:41:09 2016
New Revision: 260213
URL: http://llvm.org/viewvc/llvm-project?rev=260213&view=rev
Log:
[OPENMP] Allow to reference threadprivate variable in same directive.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
cfe/trunk/test/OpenMP/threadprivate_messa
Author: abataev
Date: Tue Feb 9 03:41:42 2016
New Revision: 260215
URL: http://llvm.org/viewvc/llvm-project?rev=260215&view=rev
Log:
[OPENMP] Allow to use the variable in the same 'threadprivate'
directive.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.
Author: abataev
Date: Tue Feb 9 05:01:58 2016
New Revision: 260219
URL: http://llvm.org/viewvc/llvm-project?rev=260219&view=rev
Log:
Fix possible OOB access found by buildbot
Modified:
cfe/trunk/lib/Frontend/PrintPreprocessedOutput.cpp
Modified: cfe/trunk/lib/Frontend/PrintPreprocessedOutpu
t;
> cheers,
> --renato
>
>
> On 8 February 2016 at 14:25, Alexey Bataev via cfe-commits
> wrote:
>> Ok, thanks a lot! Hope it will fix win-based buildbots completely.
>>
>> Best regards,
>> Alexey Bataev
>> =
>> Software Engineer
>>
Author: abataev
Date: Tue Feb 9 06:16:42 2016
New Revision: 260220
URL: http://llvm.org/viewvc/llvm-project?rev=260220&view=rev
Log:
[OPENMP] Fix test incompatibility with arm buildbots.
Modified:
cfe/trunk/test/OpenMP/parallel_private_codegen.cpp
Modified: cfe/trunk/test/OpenMP/parallel_pr
Author: abataev
Date: Wed Feb 10 04:50:12 2016
New Revision: 260370
URL: http://llvm.org/viewvc/llvm-project?rev=260370&view=rev
Log:
Fix PR26543: add a check for definition in CXXRecordDecl.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
cfe/trunk/test/OpenMP/parallel_messages.cpp
Modified
Author: abataev
Date: Wed Feb 10 05:29:16 2016
New Revision: 260374
URL: http://llvm.org/viewvc/llvm-project?rev=260374&view=rev
Log:
[OPENMP 4.5] Initial support for data members in 'firstprivate' clause.
OpenMP 4.5 allows privatization of non-static data members of current
class in non-static me
Author: abataev
Date: Wed Feb 10 23:35:55 2016
New Revision: 260492
URL: http://llvm.org/viewvc/llvm-project?rev=260492&view=rev
Log:
[OPENMP] Rename OMPCapturedFieldDecl to OMPCapturedExprDecl, NFC.
OMPCapturedExprDecl allows caopturing not only of fielddecls, but also
other expressions. It also
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4378-4398
@@ +4377,23 @@
+
+ const OMPNumTeamsClause *NT = TD.getSingleClause();
+ const OMPThreadLimitClause *TL = TD.getSingleClause();
+ if (NT || TL) {
+NumTeamsVal = (NT) ? CGF.EmitScalarExpr(NT
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:669-692
@@ -668,1 +668,26 @@
+ /// \brief Schedule types for 'omp for' loops (these enumerators are taken
from
+ /// the enum sched_type in kmp.h).
+ enum OpenMPSchedType {
+ /// \brief Lower boun
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D17197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: abataev
Date: Mon Feb 15 02:07:17 2016
New Revision: 260877
URL: http://llvm.org/viewvc/llvm-project?rev=260877&view=rev
Log:
[OPENMP] Remove extra sync barriers for 'firstprivate' clause.
Sync barrier will be emitted after generation of firstprivate variables
only if one of the firstpriva
ABataev added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2937-2943
@@ -2936,2 +2936,9 @@
QualType BaseTy = Base.getType();
+ // If the base is a pointer, we actually need to compute the offset in the
+ // pointee.
+ if (BaseTy->isAnyPointerType()) {
+auto RBase
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:1009-1015
@@ +1008,9 @@
+
+ /// \brief Emits call to void __kmpc_push_num_teamss(ident_t *loc, kmp_int32
+ /// global_tid, kmp_int32 num_teams, kmp_int32 thread_limit) to generate code
+ /// for num_teams
Author: abataev
Date: Tue Feb 16 05:18:12 2016
New Revision: 260954
URL: http://llvm.org/viewvc/llvm-project?rev=260954&view=rev
Log:
[OPENMP] Improved handling of pseudo-captured expressions in OpenMP.
Expressions inside 'schedule'|'dist_schedule' clause must be captured in
combined directives to
Author: abataev
Date: Tue Feb 16 06:13:49 2016
New Revision: 260957
URL: http://llvm.org/viewvc/llvm-project?rev=260957&view=rev
Log:
[OPENMP] Allow to use compound assignment operators.
Loop-based directives allow to use iterators as loop counters. Iterators are
allowed to define their own opera
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3811-3818
@@ -3789,1 +3810,10 @@
DeviceID, FileID, ParentName, Line, Column, OutlinedFn, OutlinedFnID);
+
+ // If the current target region has a teams region enclosed, we need to get
+ // the numb
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given that an
ABataev added a comment.
Carlo, thanks for the patch! Please update the code to trunk HEAD
Comment at: lib/CodeGen/CGOpenMPRuntime.h:677
@@ -676,1 +676,3 @@
+ virtual bool isStaticNonchunked(OpenMPDistScheduleClauseKind ScheduleKind,
+ bool Ch
Author: abataev
Date: Wed Feb 17 04:29:05 2016
New Revision: 261080
URL: http://llvm.org/viewvc/llvm-project?rev=261080&view=rev
Log:
[OPENMP] Fix handling loop-based directives with arrays.
Patch fixes possible problems with correct handling arrays as
expressions in initialization, conditions etc
Author: abataev
Date: Wed Feb 17 07:19:37 2016
New Revision: 261089
URL: http://llvm.org/viewvc/llvm-project?rev=261089&view=rev
Log:
[OPENMP 4.5] Codegen support for data members in 'firstprivate' clause.
Added codegen for captured data members in non-static member functions.
Modified:
cfe/
Author: abataev
Date: Wed Feb 17 09:36:39 2016
New Revision: 261098
URL: http://llvm.org/viewvc/llvm-project?rev=261098&view=rev
Log:
[OPENMP] Fix tests incompatibility with ARM buildbots.
Modified:
cfe/trunk/test/OpenMP/parallel_firstprivate_codegen.cpp
cfe/trunk/test/OpenMP/parallel_pri
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given that an
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams clause
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4426-4431
@@ +4425,8 @@
+ SourceLocation Loc) {
+ llvm::Value *PushNumTeamsArgs[] = {
+ emitUpdateLocation(CGF, Loc), getThreadID(CGF, Loc), NumTeams,
+ Th
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1876-1878
@@ +1875,5 @@
+ SourceLocation Loc,
+ OpenMPScheduleClauseKind ForSchedKind,
+ OpenMPDistSchedule
Author: abataev
Date: Thu Feb 18 07:48:15 2016
New Revision: 261209
URL: http://llvm.org/viewvc/llvm-project?rev=261209&view=rev
Log:
[OPENMP] Fix codegen for lastprivate loop counters.
Patch fixes bug with codegen for lastprivate loop counters. Also it may
improve performance for lastprivates ca
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given that an
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams clause
Author: abataev
Date: Fri Feb 19 04:38:26 2016
New Revision: 261315
URL: http://llvm.org/viewvc/llvm-project?rev=261315&view=rev
Log:
[OPENMP] Improved layout of CGOpenMPRuntime class, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
Modifi
Author: abataev
Date: Fri Feb 19 05:23:28 2016
New Revision: 261321
URL: http://llvm.org/viewvc/llvm-project?rev=261321&view=rev
Log:
pr26544: Bitfield layout with pragma pack and attributes "packed" and
"aligned", by Vladimir Yakovlev
Fix clang/gcc incompatibility of bitfields layout in the pres
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261321: pr26544: Bitfield layout with pragma pack and
attributes "packed" and (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D17023?vs=47308&id=48474#toc
Repository:
rL LLVM
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given that an
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams clause
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: abataev
Date: Fri Feb 19 22:09:36 2016
New Revision: 261412
URL: http://llvm.org/viewvc/llvm-project?rev=261412&view=rev
Log:
[OPENMP 4.5] Initial support for data members in 'lastprivate' clause.
OpenMP 4.5 allows to privatize non-static data members of current class
in non-static member
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2126
@@ +2125,3 @@
+ OpenMPSchedType ScheduleNum = getRuntimeSchedule(ScheduleKind, Chunk !=
nullptr,
+Ordered);
+ auto *UpdatedLocation = emitUpdateLocati
Author: abataev
Date: Wed Feb 24 21:59:29 2016
New Revision: 261820
URL: http://llvm.org/viewvc/llvm-project?rev=261820&view=rev
Log:
[OPENMP 4.5] Support fielddecls in 'shared' clause.
OpenMP 4.5 allows to use non-static data members of current class in
non-static member functions in different k
Author: abataev
Date: Wed Feb 24 23:25:57 2016
New Revision: 261824
URL: http://llvm.org/viewvc/llvm-project?rev=261824&view=rev
Log:
[OPENMP 4.5] Codegen for member decls in 'lastprivate' clause.
OpenMP 4.5 allows to privatize non-static member decls in non-static
member functions. Patch capture
ABataev added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7767-7768
@@ -7766,4 +7766,4 @@
"bit fields cannot be used to specify storage in a map clause">;
-def err_omp_array_section_in_rightmost_expression : Error<
- "array section can only be assoc
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4002
@@ +4001,3 @@
+static llvm::Value *
+emitNumTeamsClauseForTargetDirective(CodeGenFunction &CGF,
+ const OMPExecutableDirective &D,
I still don't lik
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
ABataev accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2781-2783
@@ +2780,5 @@
+ const Expr *IfCond = nullptr;
+ if (auto *C = S.getSingleClause()) {
+IfCond = C->getCondition();
+ }
+
Remov
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D17629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2758-2760
@@ +2757,5 @@
+ const Expr *IfCond = nullptr;
+ if (auto *C = S.getSingleClause()) {
+IfCond = C->getCondition();
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2736-2738
@@ +2735,5 @@
+ const Expr *IfCond = nullptr;
+ if (auto *C = S.getSingleClause()) {
+IfCond = C->getCondition();
Author: abataev
Date: Wed Apr 27 02:56:03 2016
New Revision: 267677
URL: http://llvm.org/viewvc/llvm-project?rev=267677&view=rev
Log:
[OPENMP] Fix for codegen of captured variables in inlined directives.
Currently there is a problem with codegen of inlined directives inside
lambdas, it may cause
ABataev accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4421-4423
@@ +4420,5 @@
+ llvm::Value *ElemSize;
+ if (auto *PTy = BaseTy->getAs()) {
+ElemSize = CGF.getTypeSize(PTy->getPointeeType().ge
Author: abataev
Date: Wed Apr 27 06:38:05 2016
New Revision: 267695
URL: http://llvm.org/viewvc/llvm-project?rev=267695&view=rev
Log:
[OPENMP] Fix crash on initialization of classes with no init clause in
declare reductions.
If reduction clause is applied to instance of class with user-defined
re
Author: abataev
Date: Thu Apr 28 04:15:06 2016
New Revision: 267862
URL: http://llvm.org/viewvc/llvm-project?rev=267862&view=rev
Log:
[OPENMP 4.5] Codegen for 'grainsize/num_tasks' clauses of 'taskloop'
directive.
OpenMP 4.5 defines 'taskloop' directive and 2 additional clauses
'grainsize' and 'n
Author: abataev
Date: Thu Apr 28 04:23:51 2016
New Revision: 267863
URL: http://llvm.org/viewvc/llvm-project?rev=267863&view=rev
Log:
[OPENMP] Simplified interface for codegen of tasks, NFC.
Reduced number of arguments in member functions of runtime support
library for task-based directives.
Mod
Author: abataev
Date: Thu Apr 28 07:14:51 2016
New Revision: 267872
URL: http://llvm.org/viewvc/llvm-project?rev=267872&view=rev
Log:
[OPENMP 4.5] Initial codegen for 'taskloop simd' directive.
OpenMP 4.5 defines 'taskloop simd' directive, which is combined
directive for 'taskloop' and 'simd' dir
Author: abataev
Date: Fri Apr 29 04:39:50 2016
New Revision: 268018
URL: http://llvm.org/viewvc/llvm-project?rev=268018&view=rev
Log:
Implementation of VlA of GNU C++ extension, by Vladimir Yakovlev.
This enables GNU C++ extension "Variable length array" by default.
Differential Revision: http://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268018: Implementation of VlA of GNU C++ extension, by
Vladimir Yakovlev. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D18823?vs=53658&id=4#toc
Repository:
rL LLVM
htt
Author: abataev
Date: Fri Apr 29 04:56:11 2016
New Revision: 268020
URL: http://llvm.org/viewvc/llvm-project?rev=268020&view=rev
Log:
[OPENMP] Fix detection of explicit data-sharing attributes in templates.
Fixes a bug with analysis of data-sharing attributes in templates.
Modified:
cfe/trun
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D19812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: abataev
Date: Thu May 5 03:46:22 2016
New Revision: 268618
URL: http://llvm.org/viewvc/llvm-project?rev=268618&view=rev
Log:
[OPENMP 4.5] Codegen for 'lastprivate' clauses in 'taskloop' directives.
OpenMP 4.5 adds taskloop/taskloop simd directives. These directives
allow to use lastpriva
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: abataev
Date: Fri May 6 04:40:08 2016
New Revision: 268721
URL: http://llvm.org/viewvc/llvm-project?rev=268721&view=rev
Log:
[OPENMP 4.0] Codegen for 'declare simd' directive.
OpenMP 4.0 adds support for elemental functions using declarative
directive '#pragma omp declare simd'. Patch ad
Author: abataev
Date: Fri May 6 07:04:14 2016
New Revision: 268729
URL: http://llvm.org/viewvc/llvm-project?rev=268729&view=rev
Log:
[OPENMP 4.5] Tests for 'private|firstprivates' clauses in 'taskloop' directive.
Added tests for codegen for private|firstprivate clauses in taskloop-based
directi
Author: abataev
Date: Tue May 10 04:57:36 2016
New Revision: 269035
URL: http://llvm.org/viewvc/llvm-project?rev=269035&view=rev
Log:
[OPENMP 4.5] Add codegen support in runtime for '[non]monotonic'
schedule modifiers.
Runtime library expects some additional data in schedule argument for
loop-bas
Author: abataev
Date: Tue May 10 05:36:51 2016
New Revision: 269039
URL: http://llvm.org/viewvc/llvm-project?rev=269039&view=rev
Log:
[OPENMP 4.0] Fixed codegen for destructors in task-based directives.
If private variables require destructors call at the deletion of the
task, additional flag in
Author: abataev
Date: Tue May 10 07:21:02 2016
New Revision: 269050
URL: http://llvm.org/viewvc/llvm-project?rev=269050&view=rev
Log:
[OPENMP 4.5] Initial codegen for 'priority' clause in task-based
directives.
OpenMP 4.5 supports clause 'priority' in task-based directives. Patch
adds initial cod
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5452
@@ +5451,3 @@
+ // in there.
+ for (const auto *C : D.getClausesOfKind()) {
+for (const auto *D : C->varlists()) {
I think this is too greedy. You're rescanning list of firstpriv
rn value. The SLP vectorizer will then
> vectorize the function if profitable.
>
> Thanks again,
> Hal
>
> - Original Message -
>> From: "Alexey Bataev via cfe-commits"
>> To: cfe-commits@lists.llvm.org
>> Sent: Friday, May 6, 2016 4:40:08 AM
>> S
;> types. Does it generate these "simd" functions taking scalar
>>> arguments? I'd expect that what this does is that it generates
>>> functions taking vector arguments and producing vector results. It
>>> would then extract the scalar values from those
Author: abataev
Date: Wed May 18 04:06:38 2016
New Revision: 269891
URL: http://llvm.org/viewvc/llvm-project?rev=269891&view=rev
Log:
Support for MSVS default calling convention options (/Gd, /Gz, /Gv,
/Gr), by Alexander Makarov
Patch for bug #27711
Differential Revision: http://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269891: Support for MSVS default calling convention options
(/Gd, /Gz, /Gv, (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D20171?vs=57344&id=57579#toc
Repository:
rL LLVM
h
ABataev added a comment.
Please, update to latest revision. I made some changes in firstprivates that
may affect your patch. Will review it after it.
http://reviews.llvm.org/D20112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4873-4877
@@ -4880,1 +4872,7 @@
+OMP_MAP_IS_PTR = 0x10,
+/// \brief This flags signals that an argument is the first one relating to
+/// a map/private clause expression. For some cases a single
ABataev added a comment.
Thinking more about this patch I think it is a right solution to override void
`llvm::Value *emitParallelOrTeamsOutlinedFunction()` and `void emitTeamsCall()`
for `CGOpenMPRuntimeNVPTX` class:
llvm::Value *CGOpenMPRuntimeNVPTX::emitParallelOrTeamsOutlinedFunction() {
ABataev added a comment.
Update patch to the latest version. It is not allowed to override CodeGen
sequemces in runtime. They must be universal and all must be defined in
CGStmtOpenMP.cpp only
Repository:
rL LLVM
http://reviews.llvm.org/D18470
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257
@@ +4256,3 @@
+hasEnclosingOpenMPDirective(const Stmt *Body) {
+ const SK *S = nullptr;
+ // keep iterating until we find an LF or not an SK or a nullptr
You don't need `SK`, because
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:816-822
@@ -801,6 +815,9 @@
+
+ // A DSA refers to this captured region if the parent contexts match.
+ auto *ParentContext = RSI->TheCapturedDecl->getParent();
for (auto I = Stack.rbegin(), EE = Stack.rend();
Author: abataev
Date: Wed Mar 30 05:43:55 2016
New Revision: 264853
URL: http://llvm.org/viewvc/llvm-project?rev=264853&view=rev
Log:
[OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.
Initial parsing/sema/serialization/deserialization support for '#pragma
omp declare simd' di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264853: [OPENMP 4.0] Initial support for '#pragma omp
declare simd' directive. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D10599?vs=44833&id=52034#toc
Repository:
rL LLVM
Author: abataev
Date: Thu Mar 31 04:30:50 2016
New Revision: 265004
URL: http://llvm.org/viewvc/llvm-project?rev=265004&view=rev
Log:
[OPENMP] Support dumping OpenMP specific constructs.
Add proper dumping support for OpenMP declarations, directives and
clauses.
Added:
cfe/trunk/test/OpenMP/
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:816-822
@@ -801,6 +815,9 @@
+
+ // A DSA refers to this captured region if the parent contexts match.
+ auto *ParentContext = RSI->TheCapturedDecl->getParent();
for (auto I = Stack.rbegin(), EE = Stack.rend();
Author: abataev
Date: Fri Apr 1 04:23:34 2016
New Revision: 265121
URL: http://llvm.org/viewvc/llvm-project?rev=265121&view=rev
Log:
[OPENMP 4.5] Allow data members as loop counters in loop-based
directives.
OpenMP 4.5 allows privatization of non-static data members in non-static
member function
Author: abataev
Date: Fri Apr 1 05:12:06 2016
New Revision: 265127
URL: http://llvm.org/viewvc/llvm-project?rev=265127&view=rev
Log:
[OPENMP] Fixed documentation category for 'declare simd' attribute, NFC.
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include/clang
ABataev added a comment.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:816-822
@@ -801,6 +815,9 @@
+
+ // A DSA refers to this captured region if the parent contexts match.
+ auto *ParentContext = RSI->TheCapturedDecl->getParent();
for (auto I = Stack.rbegin(), EE = Stack.rend();
Carlo,
Again you're talking about performance loss. I don't think that
performance loss violates some parsing/semantic/operation rules. If we
won't pass the argument by value the code will not work properly? OpenMP
4.5 does not specify anything about passing firstprivate args by value
or by ref
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4393-4431
@@ +4392,41 @@
+/// retrieved from the provided map clause expression.
+DeclarationMapInfoEntry(const Expr *MCE, OpenMPMapClauseKind MapType,
+OpenMPMapClauseKi
Author: abataev
Date: Mon Apr 4 05:12:15 2016
New Revision: 265287
URL: http://llvm.org/viewvc/llvm-project?rev=265287&view=rev
Log:
[OPENMP 4.0] Support for 'inbranch|noinbranch' clauses in 'declare
simd'.
Added parsing/semantic analysis for 'inbranch|notinbranch' clauses of
'#pragma omp declar
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D18286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Carlo,
I don't agree with your analysis.
1. This is how it works now. It does not say that the argument must be
passed by value. Later we may add some generic optimization to optimize
not only target specific code, but also non-target specific code.
2. In this case such constructs must be gathere
I think this code must be removed and we need to start with the basic
general solution. I missed this part of the code accidentally, but it
does not mean that I agree with it.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
05.04.2016 0:39, Samuel Antao пишет:
>
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: abataev
Date: Thu Apr 7 07:45:37 2016
New Revision: 265668
URL: http://llvm.org/viewvc/llvm-project?rev=265668&view=rev
Log:
[OPENMP 4.0] Parsing/sema analysis for 'simdlen' clause in 'declare simd'
construct.
OpenMP 4.0 defines '#pragma omp declare simd' construct that may have
associat
Author: abataev
Date: Tue Apr 12 00:28:34 2016
New Revision: 266041
URL: http://llvm.org/viewvc/llvm-project?rev=266041&view=rev
Log:
[OPENMP 4.0] Support for 'uniform' clause in 'declare simd' directive.
OpenMP 4.0 defines clause 'uniform' in 'declare simd' directive:
'uniform' '(' ')'
The unif
Author: abataev
Date: Tue Apr 12 04:35:56 2016
New Revision: 266052
URL: http://llvm.org/viewvc/llvm-project?rev=266052&view=rev
Log:
[OPENMP 4.0] Support for 'aligned' clause in 'declare simd' directive.
The aligned clause declares that the object to which each list item points is
aligned to th
Author: abataev
Date: Tue Apr 12 06:02:11 2016
New Revision: 266056
URL: http://llvm.org/viewvc/llvm-project?rev=266056&view=rev
Log:
[OPENMP 4.0] Support for 'linear' clause in 'declare simd' directive.
The linear clause declares one or more list items to be private to a SIMD lane
and to have a
1201 - 1300 of 2198 matches
Mail list logo
