Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

[Alexey Bataev via cfe-commits]

ABataev added inline comments.

================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5452
@@ +5451,3 @@
+  // in there.
+  for (const auto *C : D.getClausesOfKind<OMPFirstprivateClause>()) {
+    for (const auto *D : C->varlists()) {
----------------
I think this is too greedy. You're rescanning list of firstprivates 
clauses/variables for each variable.

================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5458
@@ +5457,3 @@
+      // 'private ptr' and 'map to' flag.
+      if (CurVD == VD)
+        return MappableExprsHandler::OMP_MAP_PRIVATE_PTR |
----------------
What if the variable is also referenced in lastprivate clause?


http://reviews.llvm.org/D20112



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits