sfantao marked an inline comment as done.
sfantao added a comment.
Hi Alexey,
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeT
sfantao marked an inline comment as done.
Comment at: test/OpenMP/target_map_codegen.cpp:1705
@@ +1704,3 @@
+ // CK19-DAG: [[SEC000]] = getelementptr {{.*}}[4 x [5 x [6 x i32]]]*
[[VAR0]], i{{.+}} 0, i{{.+}} 1
+
+ // CK19: call void [[CALL25:@.+]]([4 x [5 x [6 x i32]]]* {{[^,]+
sfantao updated this revision to Diff 48229.
sfantao marked 4 inline comments as done.
sfantao updated the summary for this revision.
sfantao added a comment.
Separate emission of num_teams and thread_limit into functions.
http://reviews.llvm.org/D17019
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3811-3818
@@ -3789,1 +3810,10 @@
DeviceID, FileID, ParentName, Line, Column, OutlinedFn, OutlinedFnID);
+
+ // If the current target region has a teams region enclosed
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
This patch adds support for the target data directive code generation.
Part of the already existent functionality related
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
This patch adds support for the target enter data directive code generation.
http://reviews.llvm.org/D17368
Files:
lib/
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
This patch adds support for the target exit data directive code generation.
Given that, apart from the employed runtime ca
sfantao added a comment.
Hi Alexey,
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams
sfantao added a comment.
Hi Alexey,
Thanks for the feedback!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonic
sfantao added a comment.
Hi Alexey
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams c
sfantao added a comment.
Hi Alexey,
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams clause
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
In some cases it can be proved statically that multidimensional array section
refer to contiguous storage and can therefor
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given that an
sfantao updated this revision to Diff 48831.
sfantao updated the summary for this revision.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D17367
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_data_codegen.c
sfantao updated this revision to Diff 48834.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D17368
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_enter_data_codegen.cpp
Index: test/OpenMP/target_enter_data_
sfantao updated this revision to Diff 48835.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D17369
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_exit_data_codegen.cpp
Index: test/OpenMP/target_exit_data_co
sfantao updated this revision to Diff 48839.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D17019
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/teams_codegen.cpp
Index: test/OpenMP/teams_codegen.cpp
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
The map modifier 'delete' is parser in c++ mode as a delete keyword, which
requires special handling in the map clause par
Author: sfantao
Date: Wed Apr 27 17:28:32 2016
New Revision: 267805
URL: http://llvm.org/viewvc/llvm-project?rev=267805&view=rev
Log:
Remove unused LangOpts private variable in HeaderSearch.
Was causing warnings during the build.
Modified:
cfe/trunk/include/clang/Lex/HeaderSearch.h
cfe/
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4692-4694
@@ +4691,5 @@
+ llvm::Value *ElemSize;
+ if (auto *PTy = BaseTy->getAs()) {
+ElemSize = CGF.getTypeSize(PTy->getPointeeType().getCanonicalType());
sfantao updated this revision to Diff 55347.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D17367
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_data_codegen.cpp
Index: test/OpenMP/target_data_codegen.cp
Author: sfantao
Date: Wed Apr 27 17:58:19 2016
New Revision: 267811
URL: http://llvm.org/viewvc/llvm-project?rev=267811&view=rev
Log:
[OpenMP] Code generation for target data directive
Summary:
This patch adds support for the target data directive code generation.
Part of the already existent fu
Author: sfantao
Date: Wed Apr 27 18:07:29 2016
New Revision: 267812
URL: http://llvm.org/viewvc/llvm-project?rev=267812&view=rev
Log:
[OpenMP] Code generation for target enter data directive
Summary: This patch adds support for the target enter data directive code
generation.
Reviewers: hfinkel
sfantao updated this revision to Diff 55349.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D17368
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_enter_data_codegen.cpp
Index: test/OpenMP/target_enter_dat
sfantao updated this revision to Diff 55352.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D17369
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_exit_data_codegen.cpp
Index: test/OpenMP/target_exit_data_
Author: sfantao
Date: Wed Apr 27 18:14:30 2016
New Revision: 267814
URL: http://llvm.org/viewvc/llvm-project?rev=267814&view=rev
Log:
[OpenMP] Code generation for target exit data directive
Summary:
This patch adds support for the target exit data directive code generation.
Given that, apart fro
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, cfe-commits.
`getAssociatedStmt()` contains an assertion that assumes the statement always
exists. In device code scanning, we need to look into the
Author: sfantao
Date: Sun May 8 01:43:56 2016
New Revision: 268870
URL: http://llvm.org/viewvc/llvm-project?rev=268870&view=rev
Log:
[OpenMP] Check for associated statements with hasAssociatedStmt() when scanning
for device code.
Summary: `getAssociatedStmt()` contains an assertion that assumes
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch changes the bits used to specify the map types according to the
latest version of the libomptarget document and add the suppo
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
If a variable is implicitly mapped (doesn't show in a map clause), the runtime
library has to be informed if the corresponding capture s
sfantao updated this revision to Diff 57419.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D20111
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_codegen.cpp
test/OpenMP/target_codegen_registration.cpp
test/OpenMP/target_data_codegen.cpp
test/OpenMP/target_enter
sfantao updated this revision to Diff 57420.
sfantao added a comment.
- Move the flags adjustment for first private declarations to the mappable
expressions handler.
http://reviews.llvm.org/D20112
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_firstprivate_codegen.cpp
test/Ope
sfantao marked 2 inline comments as done.
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5452
@@ +5451,3 @@
+ // in there.
+ for (const auto *C : D.getClausesOfKind()) {
+for (const auto *D : C->varlists()) {
---
sfantao added a comment.
Hi Alexey,
Thanks for the review.
Comment at: lib/Sema/SemaOpenMP.cpp:816-822
@@ -801,6 +815,9 @@
+
+ // A DSA refers to this captured region if the parent contexts match.
+ auto *ParentContext = RSI->TheCapturedDecl->getParent();
for (auto I = Sta
sfantao added a comment.
Hi Alexey,
Comment at: lib/Sema/SemaOpenMP.cpp:816-822
@@ -801,6 +815,9 @@
+
+ // A DSA refers to this captured region if the parent contexts match.
+ auto *ParentContext = RSI->TheCapturedDecl->getParent();
for (auto I = Stack.rbegin(), EE = Stack.
sfantao added a comment.
I just wanted to add to what Carlo just said, that the feature to capture by
value is already used in the offloading upstreamed code. This is not a new
feature we are proposing , it is already there used in the code and tested in
relevant regression tests. This patch is
sfantao updated this revision to Diff 52878.
sfantao marked 6 inline comments as done.
sfantao added a comment.
Address Art and Eric comments.
http://reviews.llvm.org/D18170
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/
sfantao added a comment.
Hi Art,
Thanks for the the review!
Comment at: include/clang/Driver/Action.h:79
@@ +78,3 @@
+OFFLOAD_None = 0x00,
+OFFLOAD_CUDA = 0x01,
+ };
tra wrote:
> Nit: All-caps CUDA looks weird here. _Cuda may be better choice.
> If you
sfantao updated this revision to Diff 52879.
sfantao marked 15 inline comments as done.
sfantao added a comment.
Address Art, Justin and Eric comments.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
li
sfantao added a comment.
Hi Art, Justin,
Thanks for the review and feedback! Tried to address your concerns. Let me know
other suggestion you may have.
Thanks again,
Samuel
Comment at: include/clang/Driver/Action.h:95
@@ +94,3 @@
+ /// same host. Therefore, the host offloadi
sfantao marked 8 inline comments as done.
sfantao added a comment.
Hi Eric,
Thanks for the review!
As you are probably a aware, I started partitioning this patch following your
initial concern related with the size of this patch and the feedback I got from
http://lists.llvm.org/pipermail/cfe-d
sfantao updated this revision to Diff 52881.
sfantao updated the summary for this revision.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
=
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, cfe-commits.
This patch adds logic to save the components of mappable expressions in the
clause that uses it, so that they don't have to be recompute
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4393-4431
@@ +4392,41 @@
+/// retrieved from the provided map clause expression.
+DeclarationMapInfoEntry(const Expr *MCE, OpenMPMapClauseKind MapType,
+
sfantao updated this revision to Diff 54672.
sfantao marked 15 inline comments as done.
sfantao added a comment.
- Address review comments. Fix bug in the evaluation of the unique declarations.
http://reviews.llvm.org/D19382
Files:
include/clang/AST/OpenMPClause.h
lib/AST/OpenMPClause.cpp
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: include/clang/AST/OpenMPClause.h:2789-2797
@@ +2788,11 @@
+// \brief Expression associated with the component.
+Expr *AssociatedExpression;
+// \brief Declaration associated with the declaration.
sfantao updated this revision to Diff 54941.
sfantao added a comment.
- Use canonical declarations associated with mappable expressions.
http://reviews.llvm.org/D19382
Files:
include/clang/AST/OpenMPClause.h
lib/AST/OpenMPClause.cpp
lib/Sema/SemaOpenMP.cpp
lib/Serialization/ASTReaderStm
sfantao marked an inline comment as done.
Comment at: lib/AST/OpenMPClause.cpp:546
@@ +545,3 @@
+ for (auto *D : Declarations) {
+assert(
+(!D || D->isCanonicalDecl()) &&
Ok, using canonical declarations now.
http://reviews.llvm.org/D19382
sfantao marked 2 inline comments as done.
sfantao added a comment.
Hi Alexey,
Thanks for the review.
Comment at: lib/AST/OpenMPClause.cpp:546
@@ +545,3 @@
+ for (auto *D : Declarations) {
+assert(
+(!D || D->isCanonicalDecl()) &&
ABataev wrote:
> s
sfantao updated this revision to Diff 55002.
sfantao marked an inline comment as done.
sfantao added a comment.
- Explicitelly store canonical declaration when looking for unique declarations.
http://reviews.llvm.org/D19382
Files:
include/clang/AST/OpenMPClause.h
lib/AST/OpenMPClause.cpp
Author: sfantao
Date: Tue Apr 26 09:54:23 2016
New Revision: 267560
URL: http://llvm.org/viewvc/llvm-project?rev=267560&view=rev
Log:
[OpenMP] Improve mappable expressions Sema.
Summary:
This patch adds logic to save the components of mappable expressions in the
clause that uses it, so that they
sfantao updated this revision to Diff 58252.
sfantao added a comment.
- Rebase after last changes related to first private.
http://reviews.llvm.org/D20111
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_codegen.cpp
test/OpenMP/target_codegen_registration.cpp
test/OpenMP/target
sfantao updated this revision to Diff 58253.
sfantao marked 2 inline comments as done.
sfantao added a comment.
- Rebase after last changes related to first private.
http://reviews.llvm.org/D20112
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_firstprivate_codegen.cpp
test/Open
sfantao updated this revision to Diff 58368.
sfantao added a comment.
Add parsing and sema support only for target update and already existing
clauses (if and device).
http://reviews.llvm.org/D15944
Files:
include/clang-c/Index.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/
sfantao updated this revision to Diff 58370.
sfantao added a comment.
Add implementation and tests only for the `to` clause. The implementation is
based on the existing infrastructure used by the `map` clause already available
upstream.
http://reviews.llvm.org/D18597
Files:
include/clang/AS
sfantao updated this revision to Diff 58371.
sfantao added a comment.
Implementation and tests only for the `from` clause. Similarly to the `to`
clause, the implementation is based on the infrastructure contributed before
for the `map` clause.
http://reviews.llvm.org/D18488
Files:
include/c
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4874-4878
@@ -4881,1 +4873,7 @@
+OMP_MAP_IS_PTR = 0x10,
+/// \brief This flags signals that an argument is the first one relating to
+/// a map/private clause expression. For some cases a single
sfantao updated this revision to Diff 58453.
sfantao marked an inline comment as done.
sfantao added a comment.
- Create function for the generation of the default map information.
http://reviews.llvm.org/D20112
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_firstprivate_codegen.
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5630-5639
@@ -5599,6 +5629,12 @@
// type, the default is 'tofrom'.
CurMapTypes.push_back(ElementType->isAggregateType()
sfantao updated this revision to Diff 58469.
sfantao marked an inline comment as done.
sfantao added a comment.
- Add nestings test.
http://reviews.llvm.org/D15944
Files:
include/clang-c/Index.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/StmtOpenMP.h
include/clang/Basic/D
sfantao added a comment.
Hi Alexey,
Thanks for the review.
Comment at: lib/Sema/SemaOpenMP.cpp:10218-10220
@@ +10217,5 @@
+Sema &SemaRef, DSAStackTy *DSAS, OpenMPClauseKind CKind,
+ArrayRef VarList, SmallVector &Vars,
+OMPClauseMappableExprCommon::MappableExprCompon
sfantao updated this revision to Diff 58486.
sfantao marked 7 inline comments as done.
sfantao added a comment.
- Address comments from the last review by Alexey.
http://reviews.llvm.org/D18597
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/B
sfantao updated this revision to Diff 58490.
sfantao marked an inline comment as done.
sfantao added a comment.
- Rebase and remove changes from the nesting tests.
http://reviews.llvm.org/D18488
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/
sfantao added a comment.
Hi Alexey,
Thanks for the review!
In http://reviews.llvm.org/D18488#438841, @ABataev wrote:
> Missed a test for printing and serialization/deserialization
Maybe it is `test/OpenMP/target_update_ast_print.cpp` what you were looking
for? Let me know if not.
Thanks aga
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch implements the code generation for the `target update` directive.
The implemntation relies on the logic already in place for
Author: sfantao
Date: Thu May 26 11:48:10 2016
New Revision: 270868
URL: http://llvm.org/viewvc/llvm-project?rev=270868&view=rev
Log:
[OpenMP] Adjust map type bits according to latest spec and use zero size array
sections for pointers.
Summary: This patch changes the bits used to specify the map
Author: sfantao
Date: Thu May 26 11:53:38 2016
New Revision: 270870
URL: http://llvm.org/viewvc/llvm-project?rev=270870&view=rev
Log:
[OpenMP] Add support for the 'private pointer' flag to signal variables
captured in target regions and used in first-private clauses.
Summary: If a variable is im
Author: sfantao
Date: Thu May 26 12:30:50 2016
New Revision: 270878
URL: http://llvm.org/viewvc/llvm-project?rev=270878&view=rev
Log:
[OpenMP] Parsing and sema support for target update directive
Summary:
This patch is to add parsing and sema support for `target update` directive.
Support for th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270878: [OpenMP] Parsing and sema support for target update
directive (authored by sfantao).
Changed prior to commit:
http://reviews.llvm.org/D15944?vs=58469&id=58647#toc
Repository:
rL LLVM
http://
sfantao updated this revision to Diff 58651.
sfantao added a comment.
- Mark MappableVarListInfo as final.
http://reviews.llvm.org/D18597
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/OpenMP
Author: sfantao
Date: Thu May 26 12:39:58 2016
New Revision: 270880
URL: http://llvm.org/viewvc/llvm-project?rev=270880&view=rev
Log:
[OpenMP] Parsing and sema support for the to clause
Summary:
The patch contains the parsing and sema support for the `to` clause.
Patch based on the original pos
Author: sfantao
Date: Thu May 26 12:49:04 2016
New Revision: 270882
URL: http://llvm.org/viewvc/llvm-project?rev=270882&view=rev
Log:
[OpenMP] Parsing and sema support for the from clause
Summary:
The patch contains the parsing and sema support for the `from` clause.
Patch based on the original
sfantao updated this revision to Diff 58658.
sfantao added a comment.
- Adapt target update tests bits to reflect latest changes in the trunk.
http://reviews.llvm.org/D20650
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/tar
Author: sfantao
Date: Thu May 26 13:30:22 2016
New Revision: 270886
URL: http://llvm.org/viewvc/llvm-project?rev=270886&view=rev
Log:
[OpenMP] Codegen for target update directive.
Summary: This patch implements the code generation for the `target update`
directive. The implemntation relies on th
sfantao updated this revision to Diff 58704.
sfantao updated the summary for this revision.
sfantao added a comment.
Remove most of the logic in the first diff. It is no longer necessary given
that all firstprivate
captures are now passed by value no matter the directive they are captured in.
S
sfantao added a comment.
In http://reviews.llvm.org/D18110#441959, @ABataev wrote:
> Hi Daniel,
> Will fix it ASAP
Hi Alexey,
Just to make sure: the bug I am talking about is fixed by this patch, that's
why I didn't abandon this patch, instead I just rebased it. Sorry if my comment
was misl
Author: sfantao
Date: Fri May 27 10:21:27 2016
New Revision: 271001
URL: http://llvm.org/viewvc/llvm-project?rev=271001&view=rev
Log:
[OpenMP] Fix SEMA bug in the capture of global variables in template functions.
Summary:
Target regions require globals to be captured. This patch fixes a bug expo
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, arpith-jacob, carlo.bertolli, kkwli0.
sfantao added subscribers: caomhin, cfe-commits.
This patch fixes an issue detected when firstprivate variables are passed to an
OpenMP outlined function vararg list. Currently they are
Author: sfantao
Date: Mon Jun 13 13:10:57 2016
New Revision: 272571
URL: http://llvm.org/viewvc/llvm-project?rev=272571&view=rev
Log:
[CUDA][OpenMP] Create generic offload toolchains
Summary:
This patch introduces the concept of offloading tool chain and offloading kind.
Each tool chain may have
sfantao updated this revision to Diff 60573.
sfantao added a comment.
Herald added a subscriber: mehdi_amini.
- Rebase.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver
sfantao added a comment.
Any more comments on this one?
Thanks!
Samuel
http://reviews.llvm.org/D18171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 60604.
sfantao added a comment.
Herald added a subscriber: mehdi_amini.
- Rebase.
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
==
Author: sfantao
Date: Thu Jun 16 10:09:31 2016
New Revision: 272900
URL: http://llvm.org/viewvc/llvm-project?rev=272900&view=rev
Log:
[OpenMP] Cast captures by copy when passed to fork call so that they are
compatible to what the runtime library expects.
Summary:
This patch fixes an issue detect
Author: sfantao
Date: Thu Jun 16 11:06:22 2016
New Revision: 272908
URL: http://llvm.org/viewvc/llvm-project?rev=272908&view=rev
Log:
Revert r272900 - [OpenMP] Cast captures by copy when passed to fork call so
that they are compatible to what the runtime library expects.
Was causing trouble in o
Author: sfantao
Date: Thu Jun 16 13:39:34 2016
New Revision: 272931
URL: http://llvm.org/viewvc/llvm-project?rev=272931&view=rev
Log:
Re-apply r272900 - [OpenMP] Cast captures by copy when passed to fork call so
that they are compatible to what the runtime library expects.
An issue in one of the
sfantao added a comment.
Hi David,
This fix looks good but you have to add a regression test for it.
Thanks,
Samuel
http://reviews.llvm.org/D21617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
sfantao added a comment.
Thanks David,
Let's wait for Alexey to see if he has any concerns related to this patch.
Thanks again,
Samuel
http://reviews.llvm.org/D21617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
sfantao updated this revision to Diff 62230.
sfantao added a comment.
- Better organize how the offload action is used and add more comments to
document what is going on.
- Rebase.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
incl
sfantao added a comment.
@tra, any other comments/suggestions about this patch?
Thanks!
Samuel
http://reviews.llvm.org/D18171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 62231.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Dri
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith.
sfantao added subscribers: carlo.bertolli, arpith-jacob, caomhin,
andreybokhanko, Hahnfeld, cfe-commits.
Herald added a subscriber: mehdi_amini.
This creates a tool selector in the driver that
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, Hahnfeld,
cfe-commits.
Herald added a subscriber: mehdi_amini.
This patch adds new logic to create the necessary tool chains t
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob,
andreybokhanko, Hahnfeld, cfe-commits.
Herald added a subscriber: mehdi_amini.
This patch adds a new specialized action builde
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob,
andreybokhanko, Hahnfeld, cfe-commits.
Herald added a subscriber: mehdi_amini.
This patch adds logic to create jobs for OpenMP
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob,
andreybokhanko, Hahnfeld, cfe-commits.
Herald added a subscriber: mehdi_amini.
This patch includes support for argument transl
sfantao updated this revision to Diff 62249.
sfantao added a comment.
Herald added a subscriber: mehdi_amini.
- Reorganize file handlers. Generate empty files if no components exist in the
bundle instead of just failing.
http://reviews.llvm.org/D13909
Files:
test/Driver/clang-offload-bundler
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, Hahnfeld,
andreybokhanko, cfe-commits.
Herald added a subscriber: mehdi_amini.
This patch adds the capability to bundle object files i
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob,
andreybokhanko, Hahnfeld, cfe-commits.
Herald added a subscriber: mehdi_amini.
In order to save the user from dealing with multiple ou
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob,
andreybokhanko, Hahnfeld, cfe-commits.
Herald added a subscriber: mehdi_amini.
Each time that offloading support is requested by the u
201 - 300 of 453 matches
Mail list logo
