sfantao marked 2 inline comments as done.
sfantao added a comment.
Hi Alexey,
Thanks for the review.
================
Comment at: lib/AST/OpenMPClause.cpp:546
@@ +545,3 @@
+ for (auto *D : Declarations) {
+ assert(
+ (!D || D->isCanonicalDecl()) &&
----------------
ABataev wrote:
> sfantao wrote:
> > Ok, using canonical declarations now.
> >
> No, I mean you'd better to check and store canonical decls in Cache, like:
> ```
> if (Cache.count(D->getCaonicalDecl())
> ```
> ```
> Cache.insert(D->getCanonicalDecl());
> ```
>
Oh, okay, I am doing as you say.
http://reviews.llvm.org/D19382
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
