[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Stephen Tozer via cfe-commits
SLTozer wrote: So just to makes sure my understanding is correct: we have an existing bug and an existing test which should exercise that bug, but the verifier doesn't catch it currently. This patch then fixes both the verifier and the bug, and therefore a new test isn't needed for the non-ver

[libclc] [libclc] Enable -fdiscard-value-names build flag to reduce bitcode size (PR #149016)

2025-07-16 Thread Wenju He via cfe-commits
wenju-he wrote: > I think this could optionally do with a comment before explaining what this > flag is helping to achieve, but it's not a blocker. it is explained at https://clang.llvm.org/docs/UsersManual.html#id72 and reducing size and verbosity is what this flag is intended for. I mean the

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: So, to be clear: * Verifier check was checking very few instructions per function * Fixing the check causes coro-dwarf-key-instrs.cpp to fail * Fixing the problem stops coro-dwarf-key-instrs.cpp failing I suppose I could add a check for the verifier condition independently of co

[clang] [clang][bytecode] Fix contains check using llvm::find (PR #149050)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes We need to compare to the end() interator. --- Full diff: https://github.com/llvm/llvm-project/pull/149050.diff 3 Files Affected: - (modified) clang/lib/AST/ByteCode/Interp.cpp (+2-1) - (modified) clang/t

[clang] [clang][docs] Add all clang-tools-extra (PR #148622)

2025-07-16 Thread via cfe-commits
@@ -89,14 +89,53 @@ they'll be tracked here. The focus of this documentation is on the scope and features of the tools for other tool developers; each tool should provide its own user-focused documentation. -``clang-tidy`` +``Clang-Doc`` +- + +`Clang-Doc

[clang] [clang][docs] Add all clang-tools-extra (PR #148622)

2025-07-16 Thread via cfe-commits
https://github.com/weirdsmiley updated https://github.com/llvm/llvm-project/pull/148622 >From ccbbe50c749274b1e69758f30b12a5d5586e344b Mon Sep 17 00:00:00 2001 From: Manas Date: Mon, 14 Jul 2025 18:08:36 +0530 Subject: [PATCH] [clang][docs] Add all clang-tools-extra The 'Extra Clang Tools' sec

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-clang Author: Orlando Cazalet-Hyams (OCHyams) Changes The verifier check was in the wrong place, meaning it wasn't actually checking many instructions. Fixing that causes a test failure (coro-dwarf-key-instrs.cpp) because

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/149043 The verifier check was in the wrong place, meaning it wasn't actually checking many instructions. Fixing that causes a test failure (coro-dwarf-key-instrs.cpp) because coros turn off the feature but still anno

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/149043 >From ff6ee73af63976c34d1628692d6bf07d4d7eef34 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 16 Jul 2025 10:13:25 +0100 Subject: [PATCH 1/2] fix for coro-dwarf-key-instrs.cpp --- clang/lib/Co

[clang] [SPIR] Set MaxAtomicInlineWidth minimum size to 32 for spir32 and 64 for spir64 (PR #148997)

2025-07-16 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck approved this pull request. https://github.com/llvm/llvm-project/pull/148997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse commented: Given that we've found a verifier error that necessitates this patch, it presumably wants a test. https://github.com/llvm/llvm-project/pull/149043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang] Introduce elementwise clz/ctz builtins (PR #131995)

2025-07-16 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/131995 >From 93112f0d5f0a8f6c8b1803a61d549701ba476f20 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Mon, 3 Feb 2025 16:54:17 + Subject: [PATCH 1/4] [clang] Introduce elementwise clz/ctz builtins These bu

[clang] [llvm] [RISCV] Implement Builtins for XAndesBFHCvt extension. (PR #148804)

2025-07-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `publish-sphinx-docs` running on `as-worker-4` while building `clang,llvm` at step 6 "Publish docs-llvm-html". Full details are available at: https://lab.llvm.org/buildbot/#/builders/45/builds/14393 Here is the relevant piec

[clang] [clang] Allow constexpr-unknown values pre C++23 (PR #129646)

2025-07-16 Thread A. Jiang via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: frederick-vs-ja wrote: Now many potentially useful error messages are merely adjusted. But `-Winvalid-constexpr` misbehaves due to some constexpr-unknown changes. This was not noticed perhaps because `-Winvalid-constexpr` is off by default sinc

[clang] bbfbe7d - [clang][bytecode][NFC] Remove unused function prototypes (#149031)

2025-07-16 Thread via cfe-commits
Author: Timm Baeder Date: 2025-07-16T11:25:19+02:00 New Revision: bbfbe7d789f7b6ade715f3656db0bdd657eeef68 URL: https://github.com/llvm/llvm-project/commit/bbfbe7d789f7b6ade715f3656db0bdd657eeef68 DIFF: https://github.com/llvm/llvm-project/commit/bbfbe7d789f7b6ade715f3656db0bdd657eeef68.diff L

[clang] [clang][bytecode][NFC] Remove unused function prototypes (PR #149031)

2025-07-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/149031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#149053 https://github.com/llvm/llvm-project/pull/149043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread via cfe-commits
https://github.com/duhbbx created https://github.com/llvm/llvm-project/pull/149059 Change the error message from "export declaration can only be used within a module purview" to "export declaration can only be used within a module interface" to be technically accurate. The previous message wa

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: duhbbx (duhbbx) Changes Change the error message from "export declaration can only be used within a module purview" to "export declaration can only be used within a module interface" to be technically accurate. The previous message was m

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: duhbbx (duhbbx) Changes Change the error message from "export declaration can only be used within a module purview" to "export declaration can only be used within a module interface" to be technically accurate. The previous messa

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-07-16 Thread via cfe-commits
Sirraide wrote: I’ved opened #149079 for this. https://github.com/llvm/llvm-project/pull/119269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Reintroduce obsolete libclang symbols to avoid an ABI break (PR #149079)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes For more context, see https://github.com/llvm/llvm-project/pull/119269#issuecomment-307593, but briefly, when removing ARCMigrate, I also removed some symbols in libclang, which constitutes an ABI break that w

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread Corentin Jabot via cfe-commits
cor3ntin wrote: > Should I submit another PR to convert the spaces in these two places? > @cor3ntin No, please add a commit to your branch (and push), it will update this PR! Thanks https://github.com/llvm/llvm-project/pull/149059 ___ cfe-commits ma

[clang] [llvm] [Clang] Reintroduce obsolete libclang symbols to avoid an ABI break (PR #149079)

2025-07-16 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/149079 For more context, see https://github.com/llvm/llvm-project/pull/119269#issuecomment-307593, but briefly, when removing ARCMigrate, I also removed some symbols in libclang, which constitutes an ABI break t

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread via cfe-commits
https://github.com/duhbbx updated https://github.com/llvm/llvm-project/pull/149059 >From f830f2828b296b02b523913c7c18ae6a3d00fdc8 Mon Sep 17 00:00:00 2001 From: duhbbx Date: Wed, 16 Jul 2025 18:27:01 +0800 Subject: [PATCH 1/2] [Clang] Fix export declaration diagnostic message Change the error

[clang] [llvm] [Clang] Reintroduce obsolete libclang symbols to avoid an ABI break (PR #149079)

2025-07-16 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: LGTM This obviously has to be cherry-picked to the release branch. https://github.com/llvm/llvm-project/pull/149079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread Corentin Jabot via cfe-commits
cor3ntin wrote: Thanks! I'll merge this later today, unless @Bigcheese has opinions https://github.com/llvm/llvm-project/pull/149059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Improve warning message for complex range overrides and GCC incompatibility (PR #149028)

2025-07-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @andykaylor @AaronBallman What do you think about making the warnings about > complex range behave as described above? Any feedback would be greatly > appreciated. CC @zahiraam @jcranmer-intel for additional opinion My first thought is that this is an improvement, but th

[clang] [Clang][CodeGen][X86] don't coerce int128 into `{i64,i64}` for SysV-like ABIs (PR #135230)

2025-07-16 Thread via cfe-commits
https://github.com/T0b1-iOS updated https://github.com/llvm/llvm-project/pull/135230 >From 16068fb6bce3443b608c6007ae0b9ea4eb18825d Mon Sep 17 00:00:00 2001 From: T0b1 Date: Fri, 11 Jul 2025 01:26:51 +0200 Subject: [PATCH 1/5] [Clang][CodeGen][X86] don't coerce int128 into `{i64,i64}` for SysV

[clang] [OpenMP] Don't emit redundant zero-sized mapping nodes for overlapped structs (PR #148947)

2025-07-16 Thread Julian Brown via cfe-commits
@@ -7080,6 +7080,111 @@ class MappableExprsHandler { return ConstLength.getSExtValue() != 1; } + /// A helper class to copy structures with overlapped elements, i.e. those + /// which have mappings of both "s" and "s.mem". Consecutive elements that + /// are not expl

[clang] [OpenMP] Don't emit redundant zero-sized mapping nodes for overlapped structs (PR #148947)

2025-07-16 Thread Julian Brown via cfe-commits
@@ -7080,6 +7080,111 @@ class MappableExprsHandler { return ConstLength.getSExtValue() != 1; } + /// A helper class to copy structures with overlapped elements, i.e. those + /// which have mappings of both "s" and "s.mem". Consecutive elements that + /// are not expl

[clang] [OpenMP] Don't emit redundant zero-sized mapping nodes for overlapped structs (PR #148947)

2025-07-16 Thread Julian Brown via cfe-commits
@@ -7080,6 +7080,111 @@ class MappableExprsHandler { return ConstLength.getSExtValue() != 1; } + /// A helper class to copy structures with overlapped elements, i.e. those + /// which have mappings of both "s" and "s.mem". Consecutive elements that + /// are not expl

[clang] [OpenMP] Don't emit redundant zero-sized mapping nodes for overlapped structs (PR #148947)

2025-07-16 Thread Julian Brown via cfe-commits
@@ -7080,6 +7080,111 @@ class MappableExprsHandler { return ConstLength.getSExtValue() != 1; } + /// A helper class to copy structures with overlapped elements, i.e. those + /// which have mappings of both "s" and "s.mem". Consecutive elements that + /// are not expl

[clang] [OpenMP] Don't emit redundant zero-sized mapping nodes for overlapped structs (PR #148947)

2025-07-16 Thread Julian Brown via cfe-commits
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/148947 >From c30dcc39a2b14eb0aef51e5f8bb34b7338e587d0 Mon Sep 17 00:00:00 2001 From: Julian Brown Date: Thu, 19 Jun 2025 07:47:38 -0500 Subject: [PATCH] [OpenMP] Don't emit redundant zero-sized mapping nodes for overlap

[clang] [OpenMP] Don't emit redundant zero-sized mapping nodes for overlapped structs (PR #148947)

2025-07-16 Thread Julian Brown via cfe-commits
@@ -0,0 +1,52 @@ +// RUN: %clang_cc1 -verify -triple x86_64-pc-linux-gnu -fopenmp-targets=amdgcn-amd-amdhsa -fopenmp -emit-llvm %s -o - | FileCheck %s jtb20 wrote: This one though I'm not sure how to do -- the check lines for the new copy-gaps tests are manuall

[clang] [Clang][CodeGen][X86] don't coerce int128 into `{i64,i64}` for SysV-like ABIs (PR #135230)

2025-07-16 Thread via cfe-commits
T0b1-iOS wrote: Fixed. Thanks for the review! As I don't have commit access, could you merge this for me?. And do you think this could be put onto the 21 release branch? I think it should be possible from a policy pov but I think you need to have commit access to make a backport request if I'm

[clang] [clang][deps] Stop lexing if hit a failure while loading a PCH/module in a submodule. (PR #146976)

2025-07-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > Seems like this should have a release note? > > > > > > What is the bar for a change to be release noted? This change is pretty > > much "make clang-scan-deps less likely to crash" and personally I don't > > think it deserves a release note. > > If a user can see di

[clang] [LifetimeSafety] Make the dataflow analysis generic (PR #148222)

2025-07-16 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: > One question for the future: sometimes it might be better to run certain > analyses side by side in the same worklist rather than running them > sequentially after each other. Do you think there are some analysis steps > that will be beneficial to be combined in that way? That

[clang] [clang][driver] Improve warning message for complex range overrides and GCC incompatibility (PR #149028)

2025-07-16 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: **IMHO** this is going to be way too complicated, and we should stick to have the last command wins in clang even when incompatibility with GCC occurs. IIRC GCC is not even consistent with the combination of these flags. Adding the `-ffast-math` flag on top of all this, will de

[clang] [OpenACC][Sema] Implement warning for non-effective 'private' (PR #149004)

2025-07-16 Thread Erich Keane via cfe-commits
@@ -624,6 +624,66 @@ void SemaOpenACC::CheckDeclReference(SourceLocation Loc, Expr *E, Decl *D) { // loop (or we aren't in a loop!) so skip the diagnostic. } +namespace { +// Check whether the type of the thing we are referencing is OK for things like +// private, firstpriv

[clang] [OpenACC][Sema] Implement warning for non-effective 'private' (PR #149004)

2025-07-16 Thread Erich Keane via cfe-commits
@@ -13478,6 +13478,12 @@ def err_acc_invalid_default_type def err_acc_device_type_multiple_archs : Error<"OpenACC 'device_type' clause on a 'set' construct only permits " "one architecture">; +def warn_acc_var_referenced_lacks_op +: Warning<"variable of type

[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #147342)

2025-07-16 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,29 @@ +// RUN: %clang_cc1 -O1 -triple spirv-pc-vulkan-compute %s -emit-llvm -o - | FileCheck %s + +typedef float float2 __attribute__((ext_vector_type(2))); +typedef float float3 __attribute__((ext_vector_type(3))); +typedef float float4 __attribute__((ext_vector_type(

[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #147342)

2025-07-16 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/147342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 85349b4 - [clang][amdgpu] Add builtin for struct buffer lds load (#148950)

2025-07-16 Thread via cfe-commits
Author: zGoldthorpe Date: 2025-07-16T07:23:09-06:00 New Revision: 85349b49364d240a2e82981a7d7e0d01b13b1284 URL: https://github.com/llvm/llvm-project/commit/85349b49364d240a2e82981a7d7e0d01b13b1284 DIFF: https://github.com/llvm/llvm-project/commit/85349b49364d240a2e82981a7d7e0d01b13b1284.diff L

[clang] [llvm] [clang][amdgpu] Add builtin for struct buffer lds load (PR #148950)

2025-07-16 Thread via cfe-commits
https://github.com/zGoldthorpe closed https://github.com/llvm/llvm-project/pull/148950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a regression of annotating PointerOrReference (PR #149039)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #149010 --- Full diff: https://github.com/llvm/llvm-project/pull/149039.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+4-1) - (modified) clang/unittests/Format/TokenAnno

[clang] [clang-format] Fix a regression of annotating PointerOrReference (PR #149039)

2025-07-16 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/149039 Fixes 149010 >From 2418846a33683555f2e14de91aa42c1ec38b3fdb Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 16 Jul 2025 01:59:40 -0700 Subject: [PATCH] [clang-format] Fix a regression of annotating PointerOr

[clang] [clang-format] Fix a regression of annotating PointerOrReference (PR #149039)

2025-07-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/149039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/149043 >From ff6ee73af63976c34d1628692d6bf07d4d7eef34 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 16 Jul 2025 10:13:25 +0100 Subject: [PATCH 1/3] fix for coro-dwarf-key-instrs.cpp --- clang/lib/Co

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Stephen Tozer via cfe-commits
@@ -5492,6 +5486,14 @@ void Verifier::visitInstruction(Instruction &I) { if (MDNode *N = I.getDebugLoc().getAsMDNode()) { CheckDI(isa(N), "invalid !dbg metadata attachment", &I, N); visitMDNode(*N, AreDebugLocsAllowed::Yes); + +if (auto *DL = dyn_cast(N)) { +

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/149043 >From ff6ee73af63976c34d1628692d6bf07d4d7eef34 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 16 Jul 2025 10:13:25 +0100 Subject: [PATCH 1/4] fix for coro-dwarf-key-instrs.cpp --- clang/lib/Co

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer edited https://github.com/llvm/llvm-project/pull/149043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer approved this pull request. LGTM with some inline nits. https://github.com/llvm/llvm-project/pull/149043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Stephen Tozer via cfe-commits
@@ -7,6 +7,8 @@ define dso_local void @f() !dbg !10 { entry: +; include non-key location to check verifier is checking the whole function. SLTozer wrote: ```suggestion ; Include non-key location to check verifier is checking the whole function. ``` https://g

[clang] [llvm] [RISCV] Implement Builtins for XAndesBFHCvt extension. (PR #148804)

2025-07-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/23601 Here

[libclc] [libclc] Enable -fdiscard-value-names build flag to reduce bitcode size (PR #149016)

2025-07-16 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck approved this pull request. LGTM, nice find. I think this could optionally do with a comment before explaining what this flag is helping to achieve, but it's not a blocker. https://github.com/llvm/llvm-project/pull/149016 _

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/149043 >From ff6ee73af63976c34d1628692d6bf07d4d7eef34 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 16 Jul 2025 10:13:25 +0100 Subject: [PATCH 1/5] fix for coro-dwarf-key-instrs.cpp --- clang/lib/Co

[clang] 653872f - [KeyInstr] Fix verifier check (#149043)

2025-07-16 Thread via cfe-commits
Author: Orlando Cazalet-Hyams Date: 2025-07-16T10:43:09+01:00 New Revision: 653872f782e1faaabc1da23769e6b35b10e74bde URL: https://github.com/llvm/llvm-project/commit/653872f782e1faaabc1da23769e6b35b10e74bde DIFF: https://github.com/llvm/llvm-project/commit/653872f782e1faaabc1da23769e6b35b10e74b

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/149043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams milestoned https://github.com/llvm/llvm-project/pull/149043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Fix verifier check (PR #149043)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: /cherry-pick 653872f782e1faaabc1da23769e6b35b10e74bde https://github.com/llvm/llvm-project/pull/149043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Fix contains check using llvm::find (PR #149050)

2025-07-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/149050 We need to compare to the end() interator. >From 361077f6389b7764f1b9ea3084a6caeb51d4cd52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 16 Jul 2025 11:40:07 +0200 Subject: [PATCH] [cl

[clang] 3b8a18c - [clang][bytecode] Fix contains check using llvm::find (#149050)

2025-07-16 Thread via cfe-commits
Author: Timm Baeder Date: 2025-07-16T13:26:10+02:00 New Revision: 3b8a18c27a1e70895feac15d48b3a6122e6b377f URL: https://github.com/llvm/llvm-project/commit/3b8a18c27a1e70895feac15d48b3a6122e6b377f DIFF: https://github.com/llvm/llvm-project/commit/3b8a18c27a1e70895feac15d48b3a6122e6b377f.diff L

[clang] [clang][bytecode] Fix contains check using llvm::find (PR #149050)

2025-07-16 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/149050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread Corentin Jabot via cfe-commits
@@ -10642,7 +10642,7 @@ def warn_dangling_reference_captured_by_unknown : Warning< "the full-expression">, InGroup; def warn_experimental_lifetime_safety_dummy_warning : Warning< - "todo: remove this warning after we have atleast one warning based on the lifetime analys

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/149059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread Corentin Jabot via cfe-commits
@@ -12540,7 +12540,7 @@ def warn_zero_as_null_pointer_constant : Warning< InGroup>, DefaultIgnore; def warn_not_eliding_copy_on_return : Warning< - "not eliding copy on return">, + "not eliding copy on return">, cor3ntin wrote: Can you revert this whites

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo the whitespace-only changes https://github.com/llvm/llvm-project/pull/149059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/149059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Lay the basic infrastructure for pretty printing of types (PR #148701)

2025-07-16 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,59 @@ +// RUN: clang-repl "int i = 10;" 'extern "C" int printf(const char*,...);' \ +// RUN:'auto r1 = printf("i = %d\n", i);' | FileCheck --check-prefix=CHECK-DRIVER %s +// UNSUPPORTED: system-aix +// CHECK-DRIVER: i = 10 +// RUN: cat %s | clang-repl -Xcc

[clang] [clang-repl] Lay the basic infrastructure for pretty printing of types (PR #148701)

2025-07-16 Thread Aaron Ballman via cfe-commits
@@ -3,9 +3,80 @@ // RUN: cat %s | clang-repl -Xcc -xc | FileCheck %s // RUN: cat %s | clang-repl -Xcc -std=c++11 | FileCheck %s -// Fails with `Symbols not found: [ __clang_Interpreter_SetValueNoAlloc ]`. // UNSUPPORTED: hwasan + +char c = 'a'; c +// CHECK: (char) 'a' + c

[clang] [clang-repl] Lay the basic infrastructure for pretty printing of types (PR #148701)

2025-07-16 Thread Aaron Ballman via cfe-commits
@@ -3,9 +3,80 @@ // RUN: cat %s | clang-repl -Xcc -xc | FileCheck %s // RUN: cat %s | clang-repl -Xcc -std=c++11 | FileCheck %s -// Fails with `Symbols not found: [ __clang_Interpreter_SetValueNoAlloc ]`. // UNSUPPORTED: hwasan + +char c = 'a'; c +// CHECK: (char) 'a' + c

[clang] [clang-repl] Lay the basic infrastructure for pretty printing of types (PR #148701)

2025-07-16 Thread Aaron Ballman via cfe-commits
@@ -3,9 +3,80 @@ // RUN: cat %s | clang-repl -Xcc -xc | FileCheck %s // RUN: cat %s | clang-repl -Xcc -std=c++11 | FileCheck %s -// Fails with `Symbols not found: [ __clang_Interpreter_SetValueNoAlloc ]`. // UNSUPPORTED: hwasan + +char c = 'a'; c +// CHECK: (char) 'a' + c

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo whitespaces changes. Thanks for the fix https://github.com/llvm/llvm-project/pull/149059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [llvm] [ARM] enable FENV_ACCESS pragma support for hard-float targets (PR #137101)

2025-07-16 Thread Erik Enikeev via cfe-commits
Varnike wrote: Hello! Thank you for the comments and sorry for the delayed response. I've now returned to this task and plan to work towards full support for strict fp on hard-float ARM targets. Based on @john-brawn-arm's example and suggestions, I was able to add support for STRICT_FDIV. Wi

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-07-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman Do you happen to know if there’s precedent for this? We recently started [documenting our guarantees](https://clang.llvm.org/docs/LibClang.html#abi-and-api-stability), and I think this falls under "Removing an explicitly deprecated API after a suitably long

[clang] fix: replace report_fatal_error with Diags and exit (PR #147959)

2025-07-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/147959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix: replace report_fatal_error with Diags and exit (PR #147959)

2025-07-16 Thread Aaron Ballman via cfe-commits
@@ -30,11 +30,16 @@ SanitizerSpecialCaseList::create(const std::vector &Paths, std::unique_ptr SanitizerSpecialCaseList::createOrDie(const std::vector &Paths, - llvm::vfs::FileSystem &VFS) { + llvm::vfs

[clang] fix: replace report_fatal_error with Diags and exit (PR #147959)

2025-07-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Ugh, sorry for the delayed review! I had a comment several days ago but forgot to hit Submit. :-/ https://github.com/llvm/llvm-project/pull/147959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [Clang] Fix export declaration diagnostic message (PR #149059)

2025-07-16 Thread via cfe-commits
duhbbx wrote: Should I submit another PR to convert the spaces in these two places? @cor3ntin https://github.com/llvm/llvm-project/pull/149059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [NFC][Clang][FMV] Refactor sema checking of target_version/clones attributes. (PR #149067)

2025-07-16 Thread Phoebe Wang via cfe-commits
@@ -1056,4 +1056,62 @@ void SemaX86::handleForceAlignArgPointerAttr(Decl *D, const ParsedAttr &AL) { X86ForceAlignArgPointerAttr(getASTContext(), AL)); } +enum FirstParam { Unsupported, Duplicate, Unknown }; +enum SecondParam { None, CPU, Tune }; +enum ThirdP

[clang] [clang] improve consistency with GCC vector comparison (PR #148954)

2025-07-16 Thread Erich Keane via cfe-commits
@@ -12901,24 +12901,24 @@ QualType Sema::GetSignedVectorType(QualType V) { return Context.getExtVectorType(Context.LongLongTy, VTy->getNumElements()); } - if (TypeSize == Context.getTypeSize(Context.Int128Ty)) -return Context.getVectorType(Context.Int128Ty, VTy->get

[clang] [clang] Introduce elementwise clz/ctz builtins (PR #131995)

2025-07-16 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/131995 >From 93112f0d5f0a8f6c8b1803a61d549701ba476f20 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Mon, 3 Feb 2025 16:54:17 + Subject: [PATCH 1/5] [clang] Introduce elementwise clz/ctz builtins These bu

[clang] [OpenACC][Sema] Implement warning for non-effective 'private' (PR #149004)

2025-07-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/149004 >From fc35a6148e45f2a0b17fc362a1143077b93ad294 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Tue, 15 Jul 2025 18:08:10 -0700 Subject: [PATCH 1/2] [OpenACC][Sema] Implement warning for non-effective 'privat

[clang] [llvm] [Clang] Reintroduce obsolete libclang symbols to avoid an ABI break (PR #149079)

2025-07-16 Thread via cfe-commits
https://github.com/Sirraide milestoned https://github.com/llvm/llvm-project/pull/149079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1600450 - [Clang] Reintroduce obsolete libclang symbols to avoid an ABI break (#149079)

2025-07-16 Thread via cfe-commits
Author: Sirraide Date: 2025-07-16T15:48:53+02:00 New Revision: 1600450f9098e5c9cb26840bd53f1be8a2559b7d URL: https://github.com/llvm/llvm-project/commit/1600450f9098e5c9cb26840bd53f1be8a2559b7d DIFF: https://github.com/llvm/llvm-project/commit/1600450f9098e5c9cb26840bd53f1be8a2559b7d.diff LOG:

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
@@ -1233,3 +1233,34 @@ void ExprEngine::VisitAttributedStmt(const AttributedStmt *A, getCheckerManager().runCheckersForPostStmt(Dst, EvalSet, A, *this); } + +void ExprEngine::VisitCXXParenListInitExpr(const CXXParenListInitExpr *E, +

[clang] [llvm] [Clang] Reintroduce obsolete libclang symbols to avoid an ABI break (PR #149079)

2025-07-16 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/149079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-16 Thread Sirui Mu via cfe-commits
@@ -2898,6 +2898,45 @@ def ByteSwapOp : CIR_BitOpBase<"byte_swap", CIR_UIntOfWidths<[16, 32, 64]>> { }]; } +//===--===// +// RotateOp +//===--

[clang] [llvm] [Clang] Reintroduce obsolete libclang symbols to avoid an ABI break (PR #149079)

2025-07-16 Thread via cfe-commits
Sirraide wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/1600450f9098e5c9cb26840bd53f1be8a2559b7d https://github.com/llvm/llvm-project/pull/149079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [CIR] Add rotate operation (PR #148426)

2025-07-16 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/148426 >From 06a18f792e92ea4ff7f576f33d92c26c30045f85 Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Sun, 13 Jul 2025 20:14:41 +0800 Subject: [PATCH] [CIR] Add rotate operation --- clang/include/clang/CIR/Dialect/IR/C

[clang] [KeyInstr] goto stmt atoms (PR #149101)

2025-07-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/149101 None >From eb49bd853b9d3c099a2d3e8dd8656095a4c1a424 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 16 Jul 2025 14:57:22 +0100 Subject: [PATCH] [KeyInstr] goto stmt atoms --- clang/lib/CodeGen

[clang] [Analyzer] support parenthesized list initialization (PR #148988)

2025-07-16 Thread Oleksandr T. via cfe-commits
@@ -1233,3 +1233,34 @@ void ExprEngine::VisitAttributedStmt(const AttributedStmt *A, getCheckerManager().runCheckersForPostStmt(Dst, EvalSet, A, *this); } + +void ExprEngine::VisitCXXParenListInitExpr(const CXXParenListInitExpr *E, +

[clang] [LifetimeSafety] Make the dataflow analysis generic (PR #148222)

2025-07-16 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/148222 >From 3130ad5f5eb0d4df7bba305264cf9d5865f46bc6 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 11 Jul 2025 11:11:47 + Subject: [PATCH 1/3] [LifetimeSafety] Add expired loans analysis --- clang/lib/A

[clang] [clang] improve consistency with GCC vector comparison (PR #148954)

2025-07-16 Thread Imple Lee via cfe-commits
@@ -12901,24 +12901,24 @@ QualType Sema::GetSignedVectorType(QualType V) { return Context.getExtVectorType(Context.LongLongTy, VTy->getNumElements()); } - if (TypeSize == Context.getTypeSize(Context.Int128Ty)) -return Context.getVectorType(Context.Int128Ty, VTy->get

[clang] 752e31c - [LifetimeSafety] Make the dataflow analysis generic (#148222)

2025-07-16 Thread via cfe-commits
Author: Utkarsh Saxena Date: 2025-07-16T16:19:51+02:00 New Revision: 752e31c27c0d2888e23db9db63dedc316dbaa1a4 URL: https://github.com/llvm/llvm-project/commit/752e31c27c0d2888e23db9db63dedc316dbaa1a4 DIFF: https://github.com/llvm/llvm-project/commit/752e31c27c0d2888e23db9db63dedc316dbaa1a4.diff

[clang] [LifetimeSafety] Make the dataflow analysis generic (PR #148222)

2025-07-16 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/148222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve checker 'unix.cstring.NotNullTerminated' (PR #149106)

2025-07-16 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/149106 Check for non-presence of terminating zero in simple cases. From ba535f818b36e5ab758b4148e46816e8f3ee6550 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Wed, 2 Jul 2025 11:09:58 +0200

[clang] [clang] improve consistency with GCC vector comparison (PR #148954)

2025-07-16 Thread Imple Lee via cfe-commits
@@ -12901,24 +12901,24 @@ QualType Sema::GetSignedVectorType(QualType V) { return Context.getExtVectorType(Context.LongLongTy, VTy->getNumElements()); } - if (TypeSize == Context.getTypeSize(Context.Int128Ty)) -return Context.getVectorType(Context.Int128Ty, VTy->get

  1   2   3   4   5   >