[clang] [KeyInstr][Clang] Static variable init atom (PR #134636)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread WÁNG Xuěruì via cfe-commits
https://github.com/xen0n commented: LGTM, thanks! https://github.com/llvm/llvm-project/pull/141037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)

2025-05-22 Thread Carlos Alberto Enciso via cfe-commits
CarlosAlbertoEnciso wrote: > Could you remove the LLVM tests? They don't add coverage since tnhis isn't an > LLVM feature - as far as LLVM is concerned, this is another static member > variable like any other. Removed all the LLVM tests. > > Why do some of the test cases use distinct input f

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/141058 >From 381c2219e346acfbf5b61e93fcc3233af6b7c3a7 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 21 May 2025 23:09:00 +0200 Subject: [PATCH 1/9] try optimize --- clang/lib/AST/Expr.cpp | 11 ++-

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Aaron Ballman via cfe-commits
@@ -2901,34 +2907,44 @@ class CallExpr : public Expr { // // * An optional of type FPOptionsOverride. // - // Note that we store the offset in bytes from the this pointer to the start - // of the trailing objects. It would be perfectly possible to compute it - // based

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Aaron Ballman via cfe-commits
@@ -1510,41 +1519,41 @@ CallExpr *CallExpr::Create(const ASTContext &Ctx, Expr *Fn, unsigned NumArgs = std::max(Args.size(), MinNumArgs); unsigned SizeOfTrailingObjects = CallExpr::sizeOfTrailingObjects( /*NumPreArgs=*/0, NumArgs, FPFeatures.requiresTrailingStorage()

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Aaron Ballman via cfe-commits
@@ -1510,41 +1519,41 @@ CallExpr *CallExpr::Create(const ASTContext &Ctx, Expr *Fn, unsigned NumArgs = std::max(Args.size(), MinNumArgs); unsigned SizeOfTrailingObjects = CallExpr::sizeOfTrailingObjects( /*NumPreArgs=*/0, NumArgs, FPFeatures.requiresTrailingStorage()

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Aaron Ballman via cfe-commits
@@ -3187,9 +3216,59 @@ class CallExpr : public Expr { SourceLocation getRParenLoc() const { return RParenLoc; } void setRParenLoc(SourceLocation L) { RParenLoc = L; } - SourceLocation getBeginLoc() const LLVM_READONLY; - SourceLocation getEndLoc() const LLVM_READONLY; +

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Aaron Ballman via cfe-commits
@@ -2901,34 +2907,44 @@ class CallExpr : public Expr { // // * An optional of type FPOptionsOverride. // - // Note that we store the offset in bytes from the this pointer to the start - // of the trailing objects. It would be perfectly possible to compute it - // based

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! https://github.com/llvm/llvm-project/pull/141058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Aaron Ballman via cfe-commits
@@ -3187,9 +3216,59 @@ class CallExpr : public Expr { SourceLocation getRParenLoc() const { return RParenLoc; } void setRParenLoc(SourceLocation L) { RParenLoc = L; } - SourceLocation getBeginLoc() const LLVM_READONLY; - SourceLocation getEndLoc() const LLVM_READONLY; +

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: undef deprecator found issues in your code. :warning: You can test this locally with the following command: ``bash git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 'HEAD~1' HEAD llvm/test/CodeGen/LoongArc

[clang] [clang][bytecode] Fix self-init diagnostics in C++23 (PR #141044)

2025-05-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/141044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d45f1d0 - [clang][bytecode] Fix self-init diagnostics in C++23 (#141044)

2025-05-22 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-22T14:26:52+02:00 New Revision: d45f1d08272ead39700d54dc800ce78d97170bde URL: https://github.com/llvm/llvm-project/commit/d45f1d08272ead39700d54dc800ce78d97170bde DIFF: https://github.com/llvm/llvm-project/commit/d45f1d08272ead39700d54dc800ce78d97170bde.diff L

[clang] [C2y] Add stdcountof.h (PR #140890)

2025-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/140890 >From 10cb78bd9f361dd442c40702dad3c7809f466615 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 21 May 2025 08:59:47 -0400 Subject: [PATCH 1/3] [C2y] Add stdcountof.h WG14 N3469 changed _Lengthof to

[clang] [C2y] Add stdcountof.h (PR #140890)

2025-05-22 Thread Aaron Ballman via cfe-commits
@@ -49,6 +49,11 @@ module cstd [system] [no_undeclared_includes] { export * } + module stdcountof { +header "stdcountof.h" +export * + } + AaronBallman wrote: Good catch! I've updated that test as well. https://github.com/llvm/llvm-project/pu

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Pierre van Houtryve via cfe-commits
@@ -0,0 +1,45 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -O0 -cl-std=CL2.0 -triple amdgcn-amd-amdhsa -target-cpu gfx942 \ +// RUN: %s -emit-llvm -o - | FileCheck %s + +// REQUIRES: amdgpu-register

[clang] [llvm] [AMDGPU][Clang] Allow amdgpu-waves-per-eu attribute to lower target occupancy range (PR #138284)

2025-05-22 Thread Lucas Ramirez via cfe-commits
@@ -279,7 +268,7 @@ define amdgpu_kernel void @kernel_3_6() #12 { ; 3,6 -> 6,9 define internal void @refine_upper_func_3_6() #13 { ; CHECK-LABEL: define internal void @refine_upper_func_3_6 -; CHECK-SAME: () #[[ATTR9]] { +; CHECK-SAME: () #[[ATTR14:[0-9]+]] { l

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/141058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Timm Baeder via cfe-commits
@@ -2901,34 +2907,43 @@ class CallExpr : public Expr { // // * An optional of type FPOptionsOverride. // - // Note that we store the offset in bytes from the this pointer to the start - // of the trailing objects. It would be perfectly possible to compute it - // based

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
@@ -1510,41 +1519,41 @@ CallExpr *CallExpr::Create(const ASTContext &Ctx, Expr *Fn, unsigned NumArgs = std::max(Args.size(), MinNumArgs); unsigned SizeOfTrailingObjects = CallExpr::sizeOfTrailingObjects( /*NumPreArgs=*/0, NumArgs, FPFeatures.requiresTrailingStorage()

[clang] [C2y] Add stdcountof.h (PR #140890)

2025-05-22 Thread via cfe-commits
@@ -389,6 +389,7 @@ SYMBOL(cosh, None, ) SYMBOL(coshf, None, ) SYMBOL(coshl, None, ) SYMBOL(cosl, None, ) +SYMBOL(countof, None, ) cor3ntin wrote: That file is code-generated, right? https://github.com/llvm/llvm-project/pull/140890 ___

[clang] [libTooling] Fix `constructExprArgs` for direct-init and implicit construction (PR #139990)

2025-05-22 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. Nice! https://github.com/llvm/llvm-project/pull/139990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
@@ -1638,43 +1647,6 @@ CallExpr::getUnusedResultAttr(const ASTContext &Ctx) const { return {nullptr, nullptr}; } -SourceLocation CallExpr::getBeginLoc() const { - if (const auto *OCE = dyn_cast(this)) -return OCE->getBeginLoc(); - - // A non-dependent call to a member

[clang] [llvm] [llvm][DebugInfo][clang] Finalize all declaration subprograms in DIBuilder::finalize() (PR #139914)

2025-05-22 Thread Vladislav Dzhidzhoev via cfe-commits
dzhidzhoev wrote: > I suppose what this is encoding is a (subtle?) assumption about how > definition-subprograms are modelled: they're created once and are immutable. > Wheras declaration-functions can be forwarded declared and then have extra > information added to them when a definition is e

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-22 Thread Gedare Bloom via cfe-commits
@@ -3373,6 +3409,51 @@ the configuration (without a prefix: ``Auto``). +.. _BreakBeforeCloseBracketIf: + +**BreakBeforeCloseBracketIf** (``Boolean``) :versionbadge:`clang-format 21` :ref:`¶ ` + Force break before the right parenthesis of an if control statement + when the

[clang] b048f3f - [clang] Use llvm::is_contained (NFC) (#140985)

2025-05-22 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-22T07:25:02-07:00 New Revision: b048f3f8d7a6ff178dafa82e47f275c95258 URL: https://github.com/llvm/llvm-project/commit/b048f3f8d7a6ff178dafa82e47f275c95258 DIFF: https://github.com/llvm/llvm-project/commit/b048f3f8d7a6ff178dafa82e47f275c95258.diff L

[clang] [clang] Use llvm::is_contained (NFC) (PR #140985)

2025-05-22 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] Fix matching `CXXOperatorCallExpr` of `->` (PR #139994)

2025-05-22 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/139994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-05-22 Thread Alex Voicu via cfe-commits
@@ -13338,4 +13338,23 @@ def err_acc_device_type_multiple_archs // AMDGCN builtins diagnostics def err_amdgcn_load_lds_size_invalid_value : Error<"invalid size value">; def note_amdgcn_load_lds_size_valid_value : Note<"size must be %select{1, 2, or 4|1, 2, 4, 12 or 16}0">; +de

[clang] [clang][SPIR-V] Fix OpenCL addrspace mapping when using non-zero default AS (PR #137187)

2025-05-22 Thread Nick Sarnie via cfe-commits
sarnex wrote: @yingcong-wu Hi, I'm not totally sure what you mean, did this change break something for you or did it fix something? Feel free to email me internally as well. Thanks https://github.com/llvm/llvm-project/pull/137187 ___ cfe-commits mail

[clang] [llvm] [openmp] [clang][OpenMP] New OpenMP 6.0 threadset clause (PR #135807)

2025-05-22 Thread via cfe-commits
https://github.com/Ritanya-B-Bharadwaj updated https://github.com/llvm/llvm-project/pull/135807 >From 9c56e59ba9984c14c15a8d5a95a02e7192a64e8f Mon Sep 17 00:00:00 2001 From: Ritanya B Bharadwaj Date: Sun, 6 Apr 2025 09:33:06 -0500 Subject: [PATCH 1/4] [OpenMP] Parsing Support of ThreadSets in T

[clang] [XRay] Fix argument parsing with offloading (#140748) (PR #141043)

2025-05-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. We'll now be creating the XRayArgs class when we do this every time, but I don't think it's expensive enough or done enough times to be an issue. Thanks. https://github.com/llvm/llvm-project/pull/141043 _

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,45 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -O0 -cl-std=CL2.0 -triple amdgcn-amd-amdhsa -target-cpu gfx942 \ +// RUN: %s -emit-llvm -o - | FileCheck %s + +// REQUIRES: amdgpu-register

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
cor3ntin wrote: https://llvm-compile-time-tracker.com/compare.php?from=f4cebe5d73c24ab53917bd58aedc9db892a164ae&to=99d11a55c0222e8ed64aa35a068a3f08673baaba&stat=instructions%3Au https://github.com/llvm/llvm-project/pull/141058 ___ cfe-commits mailing l

[clang] [KeyInstr][Clang] Agg init atom (PR #134635)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134635 >From c4029c3503f565ab6c2faa9cdec129c79133ff4f Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 15:40:58 +0100 Subject: [PATCH 1/7] [KeyInstr][Clang] Agg init atom This patch is part o

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh updated https://github.com/llvm/llvm-project/pull/141053 >From 68db9fad42369be31d935257a2d80962a4018892 Mon Sep 17 00:00:00 2001 From: pvanhout Date: Thu, 22 May 2025 14:13:54 +0200 Subject: [PATCH 1/3] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicA

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh updated https://github.com/llvm/llvm-project/pull/141053 >From 68db9fad42369be31d935257a2d80962a4018892 Mon Sep 17 00:00:00 2001 From: pvanhout Date: Thu, 22 May 2025 14:13:54 +0200 Subject: [PATCH 1/2] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicA

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/141037 >From 1148711cdfdd5a58960564790509559fa86e2649 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Thu, 22 May 2025 09:59:53 +0800 Subject: [PATCH 1/4] [Clang][LoongArch] Add inline asm support for the `q` constraint

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/141037 >From 1148711cdfdd5a58960564790509559fa86e2649 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Thu, 22 May 2025 09:59:53 +0800 Subject: [PATCH 1/5] [Clang][LoongArch] Add inline asm support for the `q` constraint

[clang] [Sema] Warn about omitting deprecated enumerator in switch (PR #138562)

2025-05-22 Thread Hans Wennborg via cfe-commits
https://github.com/zmodem updated https://github.com/llvm/llvm-project/pull/138562 >From e221ba3b0f7b08bcfc56bf75f7505265c332637d Mon Sep 17 00:00:00 2001 From: Hans Wennborg Date: Mon, 5 May 2025 20:24:15 +0200 Subject: [PATCH 1/9] [Sema] Warn about omitting deprecated enumerator in switch T

[clang] 229aa66 - [KeyInstr][Clang] Agg init atom (#134635)

2025-05-22 Thread via cfe-commits
Author: Orlando Cazalet-Hyams Date: 2025-05-22T13:49:15+01:00 New Revision: 229aa6627a63012ac5e0b3587c87e94c2b5ad36f URL: https://github.com/llvm/llvm-project/commit/229aa6627a63012ac5e0b3587c87e94c2b5ad36f DIFF: https://github.com/llvm/llvm-project/commit/229aa6627a63012ac5e0b3587c87e94c2b5ad3

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Matt Arsenault via cfe-commits
@@ -1,8 +1,6 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 -// RUN: %clang_cc1 -O0 -cl-std=CL2.0 -triple amdgcn-amd-amdhsa -target-cpu gfx942 \ -// RUN: %s -emit-llvm -o - | FileCheck %s - -// REQUIRES: amdgpu-registere

[clang] [KeyInstr][Clang] Agg init atom (PR #134635)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
@@ -2901,34 +2907,44 @@ class CallExpr : public Expr { // // * An optional of type FPOptionsOverride. // - // Note that we store the offset in bytes from the this pointer to the start - // of the trailing objects. It would be perfectly possible to compute it - // based

[clang] [Clang] Allow parsing arbitrary order of attributes for declarations (PR #133107)

2025-05-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > I think we need to understand what we want before we can make decisions on > > what needs changing, though. Are there invariants we want to introduce, > > like the source range for the AST node should encompass the source > > locations tracked within the AST node? Or ar

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. Doesn't seem right that this is looking to the IR for the size instead of directly at the source type https://github.com/llvm/llvm-project/pull/141053 ___ cfe-commits mailing list cfe-commits@list

[clang] [clang-tools-extra] [clang][dataflow] Add bugprone-dataflow-dead-code check (PR #139068)

2025-05-22 Thread via cfe-commits
https://github.com/Discookie edited https://github.com/llvm/llvm-project/pull/139068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Erich Keane via cfe-commits
@@ -3187,9 +3215,48 @@ class CallExpr : public Expr { SourceLocation getRParenLoc() const { return RParenLoc; } void setRParenLoc(SourceLocation L) { RParenLoc = L; } - SourceLocation getBeginLoc() const LLVM_READONLY; - SourceLocation getEndLoc() const LLVM_READONLY; +

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/141058 >From 381c2219e346acfbf5b61e93fcc3233af6b7c3a7 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 21 May 2025 23:09:00 +0200 Subject: [PATCH 01/10] try optimize --- clang/lib/AST/Expr.cpp | 11 +

[clang] [llvm] Add macro to suppress -Wunnecessary-virtual-specifier (PR #139614)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux-multistage` running on `systemz-1` while building `clang,llvm` at step 4 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/98/builds/1425 Here is the relevant piece o

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-22 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/108332 >From 5972376f719665225b04bf121cda6c769e3392d9 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Thu, 20 Jun 2024 17:35:39 -0600 Subject: [PATCH 1/9] Format: add AlignAfterControlStatement Introduce new style op

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
@@ -3028,6 +3043,19 @@ class CallExpr : public Expr { bool hasStoredFPFeatures() const { return CallExprBits.HasFPFeatures; } + bool usesMemberSyntax() const { +return CallExprBits.ExplicitObjectMemFunUsingMemberSyntax; + } + void setUsesMemberSyntax(bool V = true) {

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Younan Zhang via cfe-commits
@@ -563,17 +563,21 @@ class alignas(void *) Stmt { unsigned HasFPFeatures : 1; /// True if the call expression is a must-elide call to a coroutine. +LLVM_PREFERRED_TYPE(bool) unsigned IsCoroElideSafe : 1; -/// Padding used to align OffsetToTrailingObject

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Younan Zhang via cfe-commits
@@ -1638,43 +1647,6 @@ CallExpr::getUnusedResultAttr(const ASTContext &Ctx) const { return {nullptr, nullptr}; } -SourceLocation CallExpr::getBeginLoc() const { - if (const auto *OCE = dyn_cast(this)) -return OCE->getBeginLoc(); - - // A non-dependent call to a member

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Erich Keane via cfe-commits
@@ -3028,6 +3043,19 @@ class CallExpr : public Expr { bool hasStoredFPFeatures() const { return CallExprBits.HasFPFeatures; } + bool usesMemberSyntax() const { +return CallExprBits.ExplicitObjectMemFunUsingMemberSyntax; + } + void setUsesMemberSyntax(bool V = true) {

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Younan Zhang via cfe-commits
@@ -296,14 +298,18 @@ class NestedNameSpecifierLoc { /// Retrieve the location of the beginning of this /// nested-name-specifier. SourceLocation getBeginLoc() const { -return getSourceRange().getBegin(); +if (!Qualifier) + return SourceLocation(); + +Nes

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Younan Zhang via cfe-commits
@@ -542,7 +542,8 @@ bool SemaOpenCL::checkBuiltinToAddr(unsigned BuiltinID, CallExpr *Call) { auto RT = Call->getArg(0)->getType(); if (!RT->isPointerType() || RT->getPointeeType().getAddressSpace() == LangAS::opencl_constant) { -Diag(Call->getBeginLoc(), diag::e

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-22 Thread Gedare Bloom via cfe-commits
@@ -3373,6 +3409,51 @@ the configuration (without a prefix: ``Auto``). +.. _BreakBeforeCloseBracketIf: + +**BreakBeforeCloseBracketIf** (``Boolean``) :versionbadge:`clang-format 21` :ref:`¶ ` + Force break before the right parenthesis of an if control statement + when the

[clang] [clang][analyzer] Refine modeling of 'getcwd' in StdCLibraryFunctions checker (PR #141076)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balázs Kéri (balazske) Changes Add extra branches for the case when the buffer argument is NULL. --- Full diff: https://github.com/llvm/llvm-project/pull/141076.diff 2 Files Affected: - (modified) clang/lib/StaticAnaly

[clang] [flang] [lld] [lldb] [llvm] [mlir] [polly] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS in standalone builds (PR #138587)

2025-05-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `bolt,clang,flang,lld,lldb,mlir,polly` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/37

[clang] [Preprocessor] Do not expand macros if the input is already preprocessed (PR #137665)

2025-05-22 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/137665 From 72bc06251047bb92a5bc6a068670b047c078a3c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= Date: Mon, 28 Apr 2025 17:05:46 +0200 Subject: [PATCH 1/4] Pre-commit test: [Pr

[clang] [Preprocessor] Do not expand macros if the input is already preprocessed (PR #137665)

2025-05-22 Thread Juan Manuel Martinez Caamaño via cfe-commits
@@ -1558,6 +1558,13 @@ void clang::InitializePreprocessor(Preprocessor &PP, const PCHContainerReader &PCHContainerRdr, const FrontendOptions &FEOpts, const CodeGenOptions &C

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread via cfe-commits
https://github.com/bd1976bris edited https://github.com/llvm/llvm-project/pull/140956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Matt Arsenault via cfe-commits
@@ -274,9 +274,10 @@ Value *EmitFromInt(CodeGenFunction &CGF, llvm::Value *V, Address CheckAtomicAlignment(CodeGenFunction &CGF, const CallExpr *E) { ASTContext &Ctx = CGF.getContext(); Address Ptr = CGF.EmitPointerWithAlignment(E->getArg(0)); + const llvm::DataLayout &DL

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,45 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -O0 -cl-std=CL2.0 -triple amdgcn-amd-amdhsa -target-cpu gfx942 \ +// RUN: %s -emit-llvm -o - | FileCheck %s + +// REQUIRES: amdgpu-register

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,45 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -O0 -cl-std=CL2.0 -triple amdgcn-amd-amdhsa -target-cpu gfx942 \ arsenm wrote: -disable-llvm-passes, and can you use -cl-st

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-22 Thread Daan De Meyer via cfe-commits
@@ -1647,7 +1647,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_Leave; LLVMStyle.ShortNamespaceLines = 1; LLVMStyle.SkipMacroDefinitionBody = false; - LLVMStyle.SortIncludes = {/*Enabled=*/true,

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh updated https://github.com/llvm/llvm-project/pull/141053 >From 68db9fad42369be31d935257a2d80962a4018892 Mon Sep 17 00:00:00 2001 From: pvanhout Date: Thu, 22 May 2025 14:13:54 +0200 Subject: [PATCH 1/4] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicA

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/141058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang_EvalResult_getAsCXString impl (PR #134551)

2025-05-22 Thread via cfe-commits
cor3ntin wrote: @AaronBallman I missed most of the discussion here, but the underlying object is an array. Trying to find the null terminator once the pointer has decayed is asking for trouble. Is there a way to evaluate as an array? If not, that might be a better direction. That would be les

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/141058 The bulk of the changes are in `CallExpr` We cache Begin/End source locs in the trailing objects, in the space left by making the offset to the trailing objects static. We also set a flag to indicate that we a

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes The bulk of the changes are in `CallExpr` We cache Begin/End source locs in the trailing objects, in the space left by making the offset to the trailing objects static. We als

[clang] [XRay] Fix argument parsing with offloading (#140748) (PR #141043)

2025-05-22 Thread Sebastian Kreutzer via cfe-commits
sebastiankreutzer wrote: Pinging potential reviewers: @jhuber6 @MaskRay https://github.com/llvm/llvm-project/pull/141043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang_EvalResult_getAsCXString impl (PR #134551)

2025-05-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > We could keep `CXString` as it was before, but `const void *data` could > actually point to a dynamically allocated struct that has roughly this > definition: > > ```c > struct Data { > size_t length; > char data[1]; > }; > ``` > > This wouldn't change the curre

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > https://llvm-compile-time-tracker.com/compare.php?from=f4cebe5d73c24ab53917bd58aedc9db892a164ae&to=99d11a55c0222e8ed64aa35a068a3f08673baaba&stat=instructions%3Au There is so much green! https://github.com/llvm/llvm-project/pull/141058 __

[clang] [llvm] Revert "[lit][clang] Avoid realpath on Windows due to MAX_PATH limitations" (PR #139739)

2025-05-22 Thread Tristan Labelle via cfe-commits
tristanlabelle wrote: Hi @michael-jabbour-sonarsource , thanks for the ping! I agree with your views on how canonicalization should be defined and work in theory, but I am concerned about reconciliating it with the reality that: 1. Code pervasively access files through canonicalized paths rath

[clang] [llvm] [AMDGPU][Clang] Allow amdgpu-waves-per-eu attribute to lower target occupancy range (PR #138284)

2025-05-22 Thread Lucas Ramirez via cfe-commits
https://github.com/lucas-rami updated https://github.com/llvm/llvm-project/pull/138284 >From 9906334cbabf160221dea11aa93e2cf7a154e6da Mon Sep 17 00:00:00 2001 From: Lucas Ramirez Date: Thu, 22 May 2025 13:26:57 + Subject: [PATCH] Rebase on main (integrate changes from 1b34722) --- clang/l

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Erich Keane via cfe-commits
@@ -1510,41 +1519,41 @@ CallExpr *CallExpr::Create(const ASTContext &Ctx, Expr *Fn, unsigned NumArgs = std::max(Args.size(), MinNumArgs); unsigned SizeOfTrailingObjects = CallExpr::sizeOfTrailingObjects( /*NumPreArgs=*/0, NumArgs, FPFeatures.requiresTrailingStorage()

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Erich Keane via cfe-commits
@@ -3187,9 +3215,48 @@ class CallExpr : public Expr { SourceLocation getRParenLoc() const { return RParenLoc; } void setRParenLoc(SourceLocation L) { RParenLoc = L; } - SourceLocation getBeginLoc() const LLVM_READONLY; - SourceLocation getEndLoc() const LLVM_READONLY; +

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Erich Keane via cfe-commits
@@ -3028,6 +3043,19 @@ class CallExpr : public Expr { bool hasStoredFPFeatures() const { return CallExprBits.HasFPFeatures; } + bool usesMemberSyntax() const { +return CallExprBits.ExplicitObjectMemFunUsingMemberSyntax; + } + void setUsesMemberSyntax(bool V = true) {

[clang] [Clang] Optimize some `getBeginLoc` implementations (PR #141058)

2025-05-22 Thread Erich Keane via cfe-commits
@@ -1510,41 +1519,41 @@ CallExpr *CallExpr::Create(const ASTContext &Ctx, Expr *Fn, unsigned NumArgs = std::max(Args.size(), MinNumArgs); unsigned SizeOfTrailingObjects = CallExpr::sizeOfTrailingObjects( /*NumPreArgs=*/0, NumArgs, FPFeatures.requiresTrailingStorage()

[clang] clang_EvalResult_getAsCXString impl (PR #134551)

2025-05-22 Thread Damian Andrei via cfe-commits
xTachyon wrote: > It means all such string accesses would require two indirections to get to > the string data I don't think that's true. Getting the pointer would be `ptr+sizeof(size_t)`. > I also wonder if we want to be slightly less memory efficient and add a > version field in case we nee

[clang] [clang][CodeGen] Fix crash on non-natural type in CheckAtomicAlignment (PR #141053)

2025-05-22 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh closed https://github.com/llvm/llvm-project/pull/141053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Refine modeling of 'getcwd' in StdCLibraryFunctions checker (PR #141076)

2025-05-22 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/141076 Add extra branches for the case when the buffer argument is NULL. From a82a775585ea473d6c29457b260848436071d0ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Thu, 22 May 2025 16:41:4

[clang] [clang][analyzer] Refine modeling of 'getcwd' in StdCLibraryFunctions checker (PR #141076)

2025-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balázs Kéri (balazske) Changes Add extra branches for the case when the buffer argument is NULL. --- Full diff: https://github.com/llvm/llvm-project/pull/141076.diff 2 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/StdLi

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-22 Thread Jon Chesterfield via cfe-commits
JonChesterfield wrote: I think we could do with an additional overload here. Currently a bunch of code (notably CK but probably elsewhere) uses the v4i32 version of the LDS intrinsics. I think this patch lets one use the addrspace(7) pointer of 128 bits alternative. So callers could transform

[clang] [Clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed updated https://github.com/llvm/llvm-project/pull/141036 >From 0eb754713a8c2994144417f9d5ce12cbfefe19d0 Mon Sep 17 00:00:00 2001 From: omarahmed Date: Thu, 22 May 2025 11:19:53 +0100 Subject: [PATCH] [Clang] Move opt level in clang toolchain to beginning --

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread via cfe-commits
https://github.com/bd1976bris edited https://github.com/llvm/llvm-project/pull/140956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][LoongArch] Add inline asm support for the `q` constraint (PR #141037)

2025-05-22 Thread via cfe-commits
heiher wrote: cc @xry111 @xen0n https://github.com/llvm/llvm-project/pull/141037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed edited https://github.com/llvm/llvm-project/pull/141036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [LLVM][Windows] Elide `PrettyStackTrace` output for usage errors (PR #140956)

2025-05-22 Thread via cfe-commits
https://github.com/bd1976bris edited https://github.com/llvm/llvm-project/pull/140956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang_EvalResult_getAsCXString impl (PR #134551)

2025-05-22 Thread Damian Andrei via cfe-commits
xTachyon wrote: That's pretty much what I was thinking of in terms of implementation. > and we'd need the versioning information if we had Clang N tracking length + > contents and Clang N + 1 was tracking length + contents + encoding because > the newer Clang would be casting to a pointer of t

[clang] Fixed issue #128882: don't warn if 1st argument to 'getcwd' is NULL (PR #135720)

2025-05-22 Thread Balázs Kéri via cfe-commits
@@ -105,9 +105,6 @@ void errno_getcwd(char *Buf, size_t Sz) { clang_analyzer_eval(errno != 0); // expected-warning{{TRUE}} clang_analyzer_eval(Path == NULL); // expected-warning{{TRUE}} if (errno) {} // no warning - } else if (Path == NULL) {

[clang] [clang][analyzer] Refine modeling of 'getcwd' in StdCLibraryFunctions checker (PR #141076)

2025-05-22 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/141076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fixed issue #128882: don't warn if 1st argument to 'getcwd' is NULL (PR #135720)

2025-05-22 Thread Balazs Benics via cfe-commits
steakhal wrote: Superseded by #141076 https://github.com/llvm/llvm-project/pull/135720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fixed issue #128882: don't warn if 1st argument to 'getcwd' is NULL (PR #135720)

2025-05-22 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/135720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fixed issue #128882: don't warn if 1st argument to 'getcwd' is NULL (PR #135720)

2025-05-22 Thread Balazs Benics via cfe-commits
@@ -105,9 +105,6 @@ void errno_getcwd(char *Buf, size_t Sz) { clang_analyzer_eval(errno != 0); // expected-warning{{TRUE}} clang_analyzer_eval(Path == NULL); // expected-warning{{TRUE}} if (errno) {} // no warning - } else if (Path == NULL) {

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-22 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: @JonChesterfield This builtin, semantically, cannot accommodate the v4i32 usage When you have a v4i32, you need to also specify, as an additional argument, the `voffset` that gets used to index into that v4i32. This builtin doesn't have room for that, because it takes either a

[clang] [Clang] Add missing macro undefs in AttributeSpellingList emitter (PR #141090)

2025-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/141090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >