CarlosAlbertoEnciso wrote:

> Could you remove the LLVM tests? They don't add coverage since tnhis isn't an 
> LLVM feature - as far as LLVM is concerned, this is another static member 
> variable like any other.

Removed all the LLVM tests.

> 
> Why do some of the test cases use distinct input files/headers? I'd have 
> thought these could all be written as standalone files with classes all 
> written in a single file? (easier to read the test case in isolation, no 
> implication that the header-ness matters (like this shouldn't be behaving 
> differently because some content exists in a header V not, right?))

Moved all the code into a single file. The performed checks are the same.
Uploaded updated patch.



https://github.com/llvm/llvm-project/pull/130255
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to