[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-22 Thread Thomas Fransham via cfe-commits
fsfod wrote: > What are the implications/requirements for users of DataflowAnalysis? Every > instance specifices it's own lattice, which is converted to/from llvm::Any. > Will every lattice definition require these new declarations? If you think they will be used from external from the llvm li

[clang] [HLSL][NFC] Move IsIntangibleType from SemaHLSL to Type to make it accessible outside of Sema (PR #113206)

2024-10-22 Thread Damyan Pepper via cfe-commits
@@ -5030,6 +5030,29 @@ bool Type::hasSizedVLAType() const { return false; } +bool Type::isHLSLIntangibleType() const { + const Type *Ty = getUnqualifiedDesugaredType(); + + // check if it's a builtin type first (simple check, no need to cache it) damyanp w

[clang] [HLSL][NFC] Move IsIntangibleType from SemaHLSL to Type to make it accessible outside of Sema (PR #113206)

2024-10-22 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp commented: LGTM https://github.com/llvm/llvm-project/pull/113206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Define CLANG_ABI and LLVM_ABI for z/OS (PR #113333)

2024-10-22 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM, just needs to include the suggested formatting fix https://github.com/llvm/llvm-project/pull/11 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [llvm] Define CLANG_ABI and LLVM_ABI for z/OS (PR #113333)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: None (muiez) Changes This patch fixes the build failure seen on z/OS: ``` llvm/clang/include/clang/ASTMatchers/ASTMatchers.h:7212:1: error: unknown type name 'CLANG_ABI' ``` --- Full diff: https://github.com/llvm/llvm-project/pull

[clang] [llvm] Define CLANG_ABI and LLVM_ABI for z/OS (PR #113333)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (muiez) Changes This patch fixes the build failure seen on z/OS: ``` llvm/clang/include/clang/ASTMatchers/ASTMatchers.h:7212:1: error: unknown type name 'CLANG_ABI' ``` --- Full diff: https://github.com/llvm/llvm-project/pull/11

[clang] [PS5][Driver] Pass default -z options to PS5 linker (PR #113162)

2024-10-22 Thread Edd Dawson via cfe-commits
@@ -240,11 +242,32 @@ void tools::PS5cpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back( Args.MakeArgString("--sysroot=" + TC.getSDKLibraryRootDir())); - // Default to PIE for non-static executables. - const bool PIE = - !Args.hasA

[clang] [PS5][Driver] Pass default -z options to PS5 linker (PR #113162)

2024-10-22 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd edited https://github.com/llvm/llvm-project/pull/113162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-22 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/2] [Clang] fix range calculation for conditionals with throw

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-22 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,15 @@ +; RUN: not opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s 2>&1 | FileCheck %s + +; DXIL operation splitdouble doesn't support vector types. + +define noundef <3 x i32> @test_vector_double_split(<3 x double> noundef %D) local_unnamed_addr { +en

[clang] [llvm] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

2024-10-22 Thread Steven Wu via cfe-commits
cachemeifyoucan wrote: @zmodem Sorry I totally missed you comments. I thought no one was reviewing so I kind of abandoned the process. Recreate the PR in a stack for new reviews. All of your comments should be addressed: ``` 3713985 Support: Add proxies for raw_ostream and raw_pwrite_stream

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-22 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > > > It's my understanding that text=auto does not override core.autocrlf. As > > > far as I can tell from the documentation it honours the user's > > > configuration for core.eol in combination with core.autocrlf - from git > > > config --help: > > > This doesn't match my ex

[clang] [clang][OpenCL][CodeGen][AMDGPU] Do not use `private` as the default AS for when `generic` is available (PR #112442)

2024-10-22 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/112442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add KeepFormFeed option (PR #113268)

2024-10-22 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. wow I've never seen this used, but this looks fine to me. https://github.com/llvm/llvm-project/pull/113268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [NFC][Clang] Fix enumerated mismatch warning (PR #112816)

2024-10-22 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-22 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > So if I've read that correctly, `core.autocrlf=false` is a red herring and > you should really set `core.eol=lf` if you want git to use `lf` on windows. That perhaps may be the case, but all common docs and all common practices around this revolve around setting `core.autocrl

[clang-tools-extra] [clang-tidy][NFC] Replace usages of `DeclSpec::TQ` with `Qualifiers::TQ` (PR #113295)

2024-10-22 Thread Vlad Serebrennikov via cfe-commits
@@ -71,15 +72,20 @@ static std::optional fixIfNotDangerous(SourceLocation Loc, // Build a string that can be emitted as FixIt with either a space in before // or after the qualifier, either ' const' or 'const '. -static std::string buildQualifier(DeclSpec::TQ Qualifier, +stat

[clang-tools-extra] [clang-tidy][NFC] Replace usages of `DeclSpec::TQ` with `Qualifiers::TQ` (PR #113295)

2024-10-22 Thread via cfe-commits
@@ -71,15 +72,20 @@ static std::optional fixIfNotDangerous(SourceLocation Loc, // Build a string that can be emitted as FixIt with either a space in before // or after the qualifier, either ' const' or 'const '. -static std::string buildQualifier(DeclSpec::TQ Qualifier, +stat

[clang] [NFC][Clang] Fix enumerated mismatch warning (PR #112816)

2024-10-22 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/112816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-22 Thread Alex Voicu via cfe-commits
@@ -1,12 +1,14 @@ ; This test aims to check ability to support "Arithmetic with Overflow" intrinsics ; in the special case when those intrinsics are being generated by the CodeGenPrepare; -; pass during translations with optimization (note -O3 in llc arguments). +; pass during

[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-22 Thread via cfe-commits
c8ef wrote: Friendly ping~ @cor3ntin @hubert-reinterpretcast @tbaederr @philnik777 https://github.com/llvm/llvm-project/pull/113020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci plugin (PR #113290)

2024-10-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113290 >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/5] [ci] Write test results to unique file names In this

[clang-tools-extra] [clang-tidy][NFC] Replace usages of `DeclSpec::TQ` with `Qualifiers::TQ` (PR #113295)

2024-10-22 Thread via cfe-commits
@@ -71,15 +72,20 @@ static std::optional fixIfNotDangerous(SourceLocation Loc, // Build a string that can be emitted as FixIt with either a space in before // or after the qualifier, either ' const' or 'const '. -static std::string buildQualifier(DeclSpec::TQ Qualifier, +stat

[clang] Clang tooling generated visibility macros for Clang (PR #109702)

2024-10-22 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @efriedma-quic, @rnk, @compnerd, @AaronBallman can we make another round of review here? https://github.com/llvm/llvm-project/pull/109702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [CLANG][AArch64]Add Neon vectors for mfloat8_t (PR #99865)

2024-10-22 Thread via cfe-commits
@@ -2580,6 +2580,8 @@ void NeonEmitter::runVectorTypes(raw_ostream &OS) { OS << "typedef __fp16 float16_t;\n"; OS << "#if defined(__aarch64__) || defined(__arm64ec__)\n"; + OS << "typedef __MFloat8x8_t mfloat8x8_t;\n"; + OS << "typedef __MFloat8x16_t mfloat8x16_t;\n"; --

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-22 Thread via cfe-commits
ldrumm wrote: >> It's my understanding that text=auto does not override core.autocrlf. As far >> as I can tell from the documentation it honours the user's configuration for >> core.eol in combination with core.autocrlf - from git config --help: > This doesn't match my experience. I think thi

[clang-tools-extra] [clang-tidy][NFC] Replace usages of `DeclSpec::TQ` with `Qualifiers::TQ` (PR #113295)

2024-10-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/113295 This patch improves, but doens't fully resolve the layering violation, which stems from relying on Sema. There's one function that needs to convert enumerator to a string (`buildQualifier` in `FixItHintUtils.cp

[clang] [clang-format] Fix working -assume-filename with .clang-format-ignore (PR #113100)

2024-10-22 Thread via cfe-commits
https://github.com/mydeveloperday commented: I get what you are doing here, simply passing the input to the output even if we've said ignore the file.. Its not that I don't think this is ok I'm just wondering why the fix is here and not in the VS Code extension. I'd like to hear @owenca opini

[clang-tools-extra] [clang-tidy][NFC] Replace usages of `DeclSpec::TQ` with `Qualifiers::TQ` (PR #113295)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Vlad Serebrennikov (Endilll) Changes This patch improves, but doens't fully resolve the layering violation, which stems from relying on Sema. There's one function that needs to convert enumerator to a string (`buildQualifier` in `Fix

[clang] [clang][OpenCL][CodeGen][AMDGPU] Do not use `private` as the default AS for when `generic` is available (PR #112442)

2024-10-22 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > LLVM Buildbot has detected a new failure on builder > `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building > `clang` at step 7 "Add check check-offload". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/30/builds/8694 > > Here

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-22 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > This patch is about respecting local config, which is the exact opposite of > that suggestion. It would be a way to solve the line-ending issue by fiat, > not by co-operation, so I'm against it on principle. To be clear I very much > don't like CRLF, but I also very much don'

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-22 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > I think this is due to a subtly of config. Setting `core.autocrlf` to `false` > doesn't actually do anything since it's the default. In Git for Windows, the default actually is `core.autocrlf` set to `true`. When manually installing, the installer wizard used to ask the user

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-22 Thread via cfe-commits
Sirraide wrote: @AaronBallman ping https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Move `concepts::createSubstDiagAt` from AST to Sema (PR #113294)

2024-10-22 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/113294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS5][Driver] Pass default -z options to PS5 linker (PR #113162)

2024-10-22 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd updated https://github.com/llvm/llvm-project/pull/113162 >From 0d931fb93485472e2e7263496eb6d2bc71a9ae73 Mon Sep 17 00:00:00 2001 From: Edd Dawson Date: Mon, 21 Oct 2024 13:08:31 +0100 Subject: [PATCH 1/2] [PS5][Driver] Pass default -z options to PS5 linker Un

[clang] [llvm] [FMV][AArch64] Expand feature dependencies using AArch64::ExtensionSet. (PR #113281)

2024-10-22 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. Looks like a good improvement. https://github.com/llvm/llvm-project/pull/113281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci plugin (PR #113290)

2024-10-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/113290 do not commit - testing plugins >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/3] [ci] Write test resu

[clang] [llvm] [FMV][AArch64] Expand feature dependencies using AArch64::ExtensionSet. (PR #113281)

2024-10-22 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Thanks. IMHO this counts as supporting evidence to why some FMV features are obsolete and should be unified with others or removed from the ACLE spec. https://github.com/llvm/llvm-project/pull/113281 ___ cfe-commits mailing list cfe-co

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-22 Thread via cfe-commits
ldrumm wrote: > It always ends like this. Ends Like what? As far as I can see all this has done has exposed latent bugs in our testing and in clang's parser https://github.com/llvm/llvm-project/pull/86318 ___ cfe-commits mailing list cfe-commits@lis

[clang] [clang] Lifetimebound in assignment operator should work for non-gsl annotated types. (PR #113180)

2024-10-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot3` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/4528 Here is the relevant piece o

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-22 Thread Yitzhak Mandelbaum via cfe-commits
ymand wrote: What are the implications/requirements for users of DataflowAnalysis? Every instance specifices it's own lattice, which is converted to/from llvm::Any. Will every lattice definition require these new declarations? https://github.com/llvm/llvm-project/pull/108051 __

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-22 Thread Yitzhak Mandelbaum via cfe-commits
ymand wrote: > @ymand, is your concern resolved? Sorry, it isn't -- a) we still need comments with at least minimal explanation and b) I'm not sure why the definition is now in TypeErasedDataflowAnalysis.cpp -- is this because we lack NoopAnalysis.cpp? If so, why is TypeErasedDataflowAnalysis

[clang] [analyzer] Untangle subcheckers of CStringChecker (PR #113312)

2024-10-22 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus created https://github.com/llvm/llvm-project/pull/113312 It turns out, that some checks for cstring functions happened as a side effect of other checks. For example, whether the arguments to memcpy were uninitialized happened during buffer overflow checking. The w

[clang] [analyzer] Untangle subcheckers of CStringChecker (PR #113312)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Kristóf Umann (Szelethus) Changes It turns out, that some checks for cstring functions happened as a side effect of other checks. For example, whether the arguments to memcpy were uninitialized happened during buffer ove

[clang] [clang][transformer] Add `join` stencil. (PR #107366)

2024-10-22 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. Sorry for the delay! I missed the notification... https://github.com/llvm/llvm-project/pull/107366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] d005be3 - [clang-format] Handle C# `goto case` constructs (#113257)

2024-10-22 Thread via cfe-commits
Author: Owen Pan Date: 2024-10-22T18:39:32-07:00 New Revision: d005be33ee776c5d788693f5c1cf4f6bc242e13c URL: https://github.com/llvm/llvm-project/commit/d005be33ee776c5d788693f5c1cf4f6bc242e13c DIFF: https://github.com/llvm/llvm-project/commit/d005be33ee776c5d788693f5c1cf4f6bc242e13c.diff LOG:

[clang] [clang-format] Handle C# `goto case` constructs (PR #113257)

2024-10-22 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/113257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add alpha.cplusplus.BoundsInformation checker (PR #112784)

2024-10-22 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: > a function that returns a pointer and takes a reference (or a pointer) to a > length variable Yes, this one should be easy to catch. Both values will be `SymbolConjured` pointing to the same function call expression / program point. (The out-parameter value may also be `Symbol

[clang] Remove support for RenderScript (PR #112916)

2024-10-22 Thread Stephen Hines via cfe-commits
https://github.com/stephenhines approved this pull request. Thank you for taking care of the cleanup CL. It is much appreciated. https://github.com/llvm/llvm-project/pull/112916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang-tools-extra] [clang-tidy] Fix for cppcoreguidelines-pro-type-union-access if memLoc is invalid (PR #104540)

2024-10-22 Thread Konstantin Romanov via cfe-commits
ksromanov wrote: Thanks a lot! https://github.com/llvm/llvm-project/pull/104540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf ready_for_review https://github.com/llvm/llvm-project/pull/113274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [libclc] [llvm] [AMDGPU] Add a new target for gfx1153 (PR #113138)

2024-10-22 Thread Carl Ritson via cfe-commits
https://github.com/perlfu closed https://github.com/llvm/llvm-project/pull/113138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 076aac5 - [AMDGPU] Add a new target for gfx1153 (#113138)

2024-10-22 Thread via cfe-commits
Author: Carl Ritson Date: 2024-10-23T12:56:58+09:00 New Revision: 076aac59acbe7555b922e77886e4428f1aa1cd0b URL: https://github.com/llvm/llvm-project/commit/076aac59acbe7555b922e77886e4428f1aa1cd0b DIFF: https://github.com/llvm/llvm-project/commit/076aac59acbe7555b922e77886e4428f1aa1cd0b.diff L

[libclc] 076aac5 - [AMDGPU] Add a new target for gfx1153 (#113138)

2024-10-22 Thread via cfe-commits
Author: Carl Ritson Date: 2024-10-23T12:56:58+09:00 New Revision: 076aac59acbe7555b922e77886e4428f1aa1cd0b URL: https://github.com/llvm/llvm-project/commit/076aac59acbe7555b922e77886e4428f1aa1cd0b DIFF: https://github.com/llvm/llvm-project/commit/076aac59acbe7555b922e77886e4428f1aa1cd0b.diff L

[clang] [clang][bytecode] Diagnose non-const initialiers in diagnoseUnknownDecl (PR #113276)

2024-10-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/113276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 46ad7ff - [clang][bytecode] Diagnose non-const initialiers in diagnoseUnknownDecl (#113276)

2024-10-22 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-23T05:50:30+02:00 New Revision: 46ad7ff4b78fd7e6540d9eebe7e17ae423b29dd9 URL: https://github.com/llvm/llvm-project/commit/46ad7ff4b78fd7e6540d9eebe7e17ae423b29dd9 DIFF: https://github.com/llvm/llvm-project/commit/46ad7ff4b78fd7e6540d9eebe7e17ae423b29dd9.diff L

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-10-22 Thread via cfe-commits
@@ -3141,6 +3148,10 @@ def warn_attribute_ignored_no_calls_in_stmt: Warning< "statement">, InGroup; +def warn_attribute_needs_aggregate : Warning< higher-performance wrote: @AaronBallman bump? https://github.com/llvm/llvm-project/pull/102040

[clang] [HLSL] Change StructuredBuffer resource class to SRV (PR #113397)

2024-10-22 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/113397 >From 7e7812cff9c1d82c8402e840975e3fc5fd726001 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Tue, 22 Oct 2024 16:18:24 -0700 Subject: [PATCH 1/2] [HLSL] Update resource class of StructuredBuffer to SRV ---

[clang] [clang-repl][CMake][MSVC] Wrap /EXPORT linker option for ICX (PR #112867)

2024-10-22 Thread Wu Yingcong via cfe-commits
https://github.com/yingcong-wu approved this pull request. https://github.com/llvm/llvm-project/pull/112867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Harden incomingCalls() against possible misinterpretation of a range as pertaining to the wrong file (PR #111616)

2024-10-22 Thread Nathan Ridge via cfe-commits
@@ -2272,18 +2273,14 @@ incomingCalls(const CallHierarchyItem &Item, const SymbolIndex *Index) { // Initially store the ranges in a map keyed by SymbolID of the caller. // This allows us to group different calls with the same caller // into the same CallHierarchyIncoming

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,64 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc < %s -verify-machineinstrs -mtriple=x86_64-- --show-mc-encoding -mattr=+sm4,+avx10.2-512 | FileCheck %s +; RUN: llc < %s -verify-machineinstrs -mtriple=i686-- --show-mc-enc

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -1647,3 +1647,23 @@ let isCodeGenOnly = 1, ForceDisassemble = 1, hasSideEffects = 0 in def : InstAlias<"vmovw.s\t{$src, $dst|$dst, $src}", (VMOVZPWILo2PWIZrr2 VR128X:$dst, VR128X:$src), 0>; } + +// SM4(EVEX) +multiclass avx10_sm4_base { + // SM4_Base is

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,170 @@ +# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s --check-prefixes=ATT phoebewang wrote: The file name is mistaken with sm4-evex-64.txt https://github.com/llvm/llvm-project/pull/113402 _

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -1647,3 +1647,23 @@ let isCodeGenOnly = 1, ForceDisassemble = 1, hasSideEffects = 0 in def : InstAlias<"vmovw.s\t{$src, $dst|$dst, $src}", (VMOVZPWILo2PWIZrr2 VR128X:$dst, VR128X:$src), 0>; } + +// SM4(EVEX) +multiclass avx10_sm4_base { + // SM4_Base is

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,224 @@ +// RUN: llvm-mc -triple x86_64-unknown-unknown --show-encoding %s | FileCheck %s phoebewang wrote: The same to below. https://github.com/llvm/llvm-project/pull/113402 ___ cfe-commits mailing list cf

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -196,6 +196,8 @@ Changes to the X86 Backend * Support ISA of `AVX10.2-256` and `AVX10.2-512`. +* Support ISA of `SM4(EVEX)`. phoebewang wrote: We should mainly add in Clang release note. https://github.com/llvm/llvm-project/pull/113402 __

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -6109,6 +6109,12 @@ let TargetPrefix = "x86" in { DefaultAttrsIntrinsic<[llvm_v8i32_ty], [llvm_v8i32_ty, llvm_v8i32_ty], [IntrNoMem]>; +def int_x86_vsm4key4512 : ClangBuiltin<"__builtin_ia32_vsm4key4512">, +Intrinsic<[llvm_v16i32_ty], [llvm_v1

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -6109,6 +6109,12 @@ let TargetPrefix = "x86" in { DefaultAttrsIntrinsic<[llvm_v8i32_ty], [llvm_v8i32_ty, llvm_v8i32_ty], [IntrNoMem]>; +def int_x86_vsm4key4512 : ClangBuiltin<"__builtin_ia32_vsm4key4512">, +Intrinsic<[llvm_v16i32_ty], [llvm_v1

[clang] [llvm] [llvm] Deprecate Type::getPointerTo() (PR #113331)

2024-10-22 Thread Yanzuo Liu via cfe-commits
@@ -471,8 +471,9 @@ class Type { static Type *getWasm_FuncrefTy(LLVMContext &C); /// Return a pointer to the current type. This is equivalent to - /// PointerType::get(Foo, AddrSpace). + /// PointerType::get(Ctx, AddrSpace). /// TODO: Remove this after opaque pointer

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -665,6 +665,9 @@ _storebe_i64(void * __P, long long __D) { #include #include #include +#if (defined(__SM4__)) phoebewang wrote: Checking macro is not always working, e.g., function multi-versioning. It's fine to remove it. https://github.com/llvm/llvm-

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,170 @@ +# RUN: llvm-mc --disassemble %s -triple=i386-unknown-unknown | FileCheck %s --check-prefixes=ATT phoebewang wrote: ditto. https://github.com/llvm/llvm-project/pull/113402 ___ cfe-commits mailing lis

[clang-tools-extra] [clangd] Harden incomingCalls() against possible misinterpretation of a range as pertaining to the wrong file (PR #111616)

2024-10-22 Thread Nathan Ridge via cfe-commits
@@ -2292,9 +2289,26 @@ incomingCalls(const CallHierarchyItem &Item, const SymbolIndex *Index) { Index->lookup(ContainerLookup, [&](const Symbol &Caller) { auto It = CallsIn.find(Caller.ID); assert(It != CallsIn.end()); -if (auto CHI = symbolToCallHierarchyItem(Ca

[clang] [Clang][RISCV] Support -fcf-protection=return for RISC-V (PR #112477)

2024-10-22 Thread Jesse Huang via cfe-commits
@@ -899,6 +899,10 @@ void CodeGenFunction::StartFunction(GlobalDecl GD, QualType RetTy, if (CodeGenOpts.PointerAuth.IndirectGotos) Fn->addFnAttr("ptrauth-indirect-gotos"); + // Add return control flow integrity attributes. + if (CodeGenOpts.CFProtectionReturn) +Fn

[clang] [Clang][RISCV] Support -fcf-protection=return for RISC-V (PR #112477)

2024-10-22 Thread Jesse Huang via cfe-commits
https://github.com/jaidTw updated https://github.com/llvm/llvm-project/pull/112477 >From fe4a28fb691b69d9af384f1dc2f0667761adef44 Mon Sep 17 00:00:00 2001 From: Jesse Huang Date: Sun, 13 Oct 2024 15:11:06 +0800 Subject: [PATCH 1/2] [Clang][RISCV] Support -fcf-protection=return for RISC-V ---

[clang] [clang][modules] Shrink the size of `Module::Headers` (PR #113395)

2024-10-22 Thread via cfe-commits
@@ -271,8 +271,22 @@ class alignas(8) Module { DirectoryEntryRef Entry; }; - /// The headers that are part of this module. - SmallVector Headers[5]; +private: + unsigned HeaderKindBeginIndex[6] = {}; cor3ntin wrote: Why 6 rather than 5? https://gith

[clang] [clang][modules] Shrink the size of `Module::Headers` (PR #113395)

2024-10-22 Thread via cfe-commits
@@ -271,8 +271,22 @@ class alignas(8) Module { DirectoryEntryRef Entry; }; - /// The headers that are part of this module. - SmallVector Headers[5]; +private: + unsigned HeaderKindBeginIndex[6] = {}; + SmallVector HeadersStorage; + +public: + ArrayRef getHeaders(Hea

[clang] [clang][modules] Shrink the size of `Module::Headers` (PR #113395)

2024-10-22 Thread via cfe-commits
@@ -271,8 +271,22 @@ class alignas(8) Module { DirectoryEntryRef Entry; }; - /// The headers that are part of this module. - SmallVector Headers[5]; +private: + unsigned HeaderKindBeginIndex[6] = {}; cor3ntin wrote: actually, it should be `NumHeaderK

[clang] [clang][modules] Shrink the size of `Module::Headers` (PR #113395)

2024-10-22 Thread via cfe-commits
@@ -271,8 +271,22 @@ class alignas(8) Module { DirectoryEntryRef Entry; }; - /// The headers that are part of this module. - SmallVector Headers[5]; +private: + unsigned HeaderKindBeginIndex[6] = {}; + SmallVector HeadersStorage; + +public: + ArrayRef getHeaders(Hea

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,98 @@ +/*=== movrs_avx10_2_512intrin.h - AVX512MOVRS intrinsics ---=== phoebewang wrote: `AVX512MOVRS` -> `AVX10.2-512-MOVRS` https://github.com/llvm/llvm-project/pull/113274 ___ cfe-commits

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -7572,3 +7572,42 @@ def int_x86_avx10_vfnmsub231nepbf16128 : ClangBuiltin<"__builtin_ia32_vfnmsub231 DefaultAttrsIntrinsic<[llvm_v8bf16_ty], [llvm_v8bf16_ty, llvm_v8bf16_ty, llvm_v8bf16_ty ], [IntrNoMem]>; } + +let TargetPrefix = "x86"

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -261,6 +261,7 @@ X86_FEATURE_COMPAT(AVX10_1, "avx10.1-256", 36) X86_FEATURE_COMPAT(AVX10_1_512, "avx10.1-512", 37) X86_FEATURE_COMPAT(AVX10_2, "avx10.2-256",0) X86_FEATURE_COMPAT(AVX10_2_512, "avx10.2-512",

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,174 @@ +/*===-- movrs_avx10_2intrin.h - AVX512MOVRS intrinsics -=== phoebewang wrote: AVX10.2-MOVRS https://github.com/llvm/llvm-project/pull/113274 ___ cfe-commits mailing list cfe-commi

[clang] [Clang][RISCV] Support -fcf-protection=return for RISC-V (PR #112477)

2024-10-22 Thread Jesse Huang via cfe-commits
https://github.com/jaidTw updated https://github.com/llvm/llvm-project/pull/112477 >From fe4a28fb691b69d9af384f1dc2f0667761adef44 Mon Sep 17 00:00:00 2001 From: Jesse Huang Date: Sun, 13 Oct 2024 15:11:06 +0800 Subject: [PATCH 1/2] [Clang][RISCV] Support -fcf-protection=return for RISC-V ---

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add alpha.cplusplus.BoundsInformation checker (PR #112784)

2024-10-22 Thread Artem Dergachev via cfe-commits
@@ -0,0 +1,199 @@ +//== BoundsInformationChecker.cpp - bounds information checker --*- C++ -*--==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [mlir] [flang][OpenMP] Support `target enter|update|exit .. nowait` (PR #113305)

2024-10-22 Thread via cfe-commits
https://github.com/NimishMishra approved this pull request. LGTM. Thanks for this. https://github.com/llvm/llvm-project/pull/113305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add KeepFormFeed option (PR #113268)

2024-10-22 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/113268 >From 0d1c2446a225d73e014e711b0d74931bff9237bc Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 21 Oct 2024 23:27:35 -0700 Subject: [PATCH 1/2] [clang-format] Add KeepFormFeed option Closes #113170. --- clang

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b90ea5caade7b92796276937467a0dabc355a62e dc9387dbf69b806180702465c406630194c27bee --e

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Freddy Ye (FreddyLeaf) Changes Ref.: https://cdrdv2.intel.com/v1/dl/getContent/671368 --- Patch is 83.30 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/113274.diff 30 Files Affected:

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Freddy Ye (FreddyLeaf) Changes Ref.: https://cdrdv2.intel.com/v1/dl/getContent/671368 --- Patch is 83.30 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/113274.diff 30 Files Affected:

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/113274 >From 19c6400ac7127860ac1712941acbd1585614d17d Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Mon, 21 Oct 2024 10:24:14 +0800 Subject: [PATCH 1/3] [X86] Support MOVRS and AVX10.2 instructions. Ref.: https://

[clang] b69ac31 - [clang-format] Use RemoveEmptyLinesInUnwrappedLines in clang-format s… (#113260)

2024-10-22 Thread via cfe-commits
Author: Owen Pan Date: 2024-10-22T18:37:43-07:00 New Revision: b69ac31a3b858f6a77744adfa31ad53edecbdb7e URL: https://github.com/llvm/llvm-project/commit/b69ac31a3b858f6a77744adfa31ad53edecbdb7e DIFF: https://github.com/llvm/llvm-project/commit/b69ac31a3b858f6a77744adfa31ad53edecbdb7e.diff LOG:

[clang] [clang-format] Use RemoveEmptyLinesInUnwrappedLines in clang-format s… (PR #113260)

2024-10-22 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/113260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Freddy Ye (FreddyLeaf) Changes Ref.: https://cdrdv2.intel.com/v1/dl/getContent/671368 --- Patch is 59.96 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/113402.diff 16 Files Affected: - (mod

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf created https://github.com/llvm/llvm-project/pull/113402 Ref.: https://cdrdv2.intel.com/v1/dl/getContent/671368 >From 83a2ef421831dec1790c3c6adf3141ed1ac9a0d5 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Mon, 21 Oct 2024 09:30:26 +0800 Subject: [PATCH] [X86] Su

[clang] [llvm] [X86] Support SM4 EVEX version intrinsics/instructions. (PR #113402)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Freddy Ye (FreddyLeaf) Changes Ref.: https://cdrdv2.intel.com/v1/dl/getContent/671368 --- Patch is 59.96 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/113402.diff 16 Files Affected:

[clang] [analyzer] Add alpha.cplusplus.BoundsInformation checker (PR #112784)

2024-10-22 Thread Artem Dergachev via cfe-commits
@@ -0,0 +1,199 @@ +//== BoundsInformationChecker.cpp - bounds information checker --*- C++ -*--==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [compiler-rt] [llvm] [X86] Support MOVRS and AVX10.2 instructions. (PR #113274)

2024-10-22 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/113274 >From 19c6400ac7127860ac1712941acbd1585614d17d Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Mon, 21 Oct 2024 10:24:14 +0800 Subject: [PATCH 1/2] [X86] Support MOVRS and AVX10.2 instructions. Ref.: https://

[clang] [analyzer] Untangle subcheckers of CStringChecker (PR #113312)

2024-10-22 Thread via cfe-commits
https://github.com/isuckatcs edited https://github.com/llvm/llvm-project/pull/113312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Untangle subcheckers of CStringChecker (PR #113312)

2024-10-22 Thread via cfe-commits
https://github.com/isuckatcs commented: Apart from a few nits and the question about seeing new warning with a certain combination of checks, the patch looks good to me. https://github.com/llvm/llvm-project/pull/113312 ___ cfe-commits mailing list cfe

<    1   2   3   4   5   >