[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-07-12 Thread Vassil Vassilev via cfe-commits
@@ -905,6 +912,7 @@ void Preprocessor::Lex(Token &Result) { // This token is injected to represent the translation of '#include "a.h"' // into "import a.h;". Mimic the notional ';'. case tok::annot_module_include: +case tok::annot_repl_input_end: ---

[clang] [llvm] [RISCV] Add -m[no-]scalar-strict-align and -m[no-]vector-strict-align. (PR #95024)

2024-07-12 Thread Craig Topper via cfe-commits
topperc wrote: Ping https://github.com/llvm/llvm-project/pull/95024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 77fd30f - [CUDA][HIP] Fix template static member (#98580)

2024-07-12 Thread via cfe-commits
Author: Yaxun (Sam) Liu Date: 2024-07-12T10:08:34-04:00 New Revision: 77fd30f7ce0795b4bbc22e65b3ff42856839d708 URL: https://github.com/llvm/llvm-project/commit/77fd30f7ce0795b4bbc22e65b3ff42856839d708 DIFF: https://github.com/llvm/llvm-project/commit/77fd30f7ce0795b4bbc22e65b3ff42856839d708.dif

[clang] [CUDA][HIP] Fix template static member (PR #98580)

2024-07-12 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/98580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Build release binaries for multiple targets (PR #98431)

2024-07-12 Thread Tom Stellard via cfe-commits
tstellar wrote: Summary of the test failures: [AArch64 MacOS](https://github.com/llvm/llvm-project/actions/runs/9893093291/job/27346084277?pr=98431): ``` ld64.lld: error: undefined symbol: __divsc3 >>> referenced by lib/libFortranRuntime.a(complex-powi.cpp.o):(symbol float >>> complex tgpowi

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-asan` running on `sanitizer-buildbot8` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/449 Here is the relevant

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

2024-07-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: I think this mostly looks good, but I am concerned with the line number matching. It appears that whenever you’ve up’s the file you’ve had to update all the line numbers. Is it feasible to rewrite some of the checks to use the @LINE directive? Perhaps i

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

2024-07-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/97681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

2024-07-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/97681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

2024-07-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/97681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 98edc0c - [clang][Interp] Fix member pointer temporaries

2024-07-12 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-12T16:37:04+02:00 New Revision: 98edc0cb1f4ca53bd2d490916566ff7d217110f8 URL: https://github.com/llvm/llvm-project/commit/98edc0cb1f4ca53bd2d490916566ff7d217110f8 DIFF: https://github.com/llvm/llvm-project/commit/98edc0cb1f4ca53bd2d490916566ff7d217110f8.diff LO

[clang] Fix a regression with alignas on structure members in C (PR #98642)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes This was a 19.x regression and thus has no release note. Fixes #95032 --- Full diff: https://github.com/llvm/llvm-project/pull/98642.diff 5 Files Affected: - (modified) clang/include/clang/Sema/Decl

[clang-tools-extra] [clang-doc] add enum test (PR #97679)

2024-07-12 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: clang-doc --format=html --doxygen --output=%t/docs --executor=standalone %s +// RUN: clang-doc --format=md --doxygen --output=%t/docs --executor=standalone %s +// RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/index.html -check-prefix=HTML-INDEX

[clang] Fix a regression with alignas on structure members in C (PR #98642)

2024-07-12 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/98642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add -m[no-]scalar-strict-align and -m[no-]vector-strict-align. (PR #95024)

2024-07-12 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng approved this pull request. LGTM :) https://github.com/llvm/llvm-project/pull/95024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 007e32d - [clang][Interp][NFC] Simplify record creation

2024-07-12 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-12T16:45:18+02:00 New Revision: 007e32d024f31ef157e3e16117a6c000bfaa2754 URL: https://github.com/llvm/llvm-project/commit/007e32d024f31ef157e3e16117a6c000bfaa2754 DIFF: https://github.com/llvm/llvm-project/commit/007e32d024f31ef157e3e16117a6c000bfaa2754.diff LO

[clang] ac2426e - [C2y] Claim conformance to WG14 N3232

2024-07-12 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-07-12T10:50:48-04:00 New Revision: ac2426e08e6f7c1eb97725f1d6cc35a8a6ddc5ef URL: https://github.com/llvm/llvm-project/commit/ac2426e08e6f7c1eb97725f1d6cc35a8a6ddc5ef DIFF: https://github.com/llvm/llvm-project/commit/ac2426e08e6f7c1eb97725f1d6cc35a8a6ddc5ef.diff

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-12 Thread Paul Kirth via cfe-commits
@@ -13,12 +13,17 @@ #include "clang/Index/USRGeneration.h" #include "llvm/ADT/StringExtras.h" #include "llvm/Support/Error.h" +#include "llvm/Support/TimeProfiler.h" namespace clang { namespace doc { void MapASTVisitor::HandleTranslationUnit(ASTContext &Context) { + if

[clang] [llvm] [llvm][AArch64] apple-m4 is armv9.2-a (PR #98267)

2024-07-12 Thread Jon Roelofs via cfe-commits
@@ -161,14 +161,10 @@ struct CpuInfo { StringRef Name; // Name, as written for -mcpu. const ArchInfo &Arch; AArch64::ExtensionBitset - DefaultExtensions; // Default extensions for this CPU. These will be - // ORd with the architecture defaults

[clang] [llvm] [AArch64] Make user-visible Arm architecture version strings consistent (PR #98550)

2024-07-12 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/98550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][NEON] Add intrinsics for LUTI (PR #96883)

2024-07-12 Thread via cfe-commits
@@ -545,6 +545,25 @@ let TargetPrefix = "aarch64", IntrProperties = [IntrNoMem] in { def int_aarch64_neon_vcmla_rot270 : AdvSIMD_3VectorArg_Intrinsic; } +let TargetPrefix = "aarch64" in { +def int_aarch64_neon_vluti2_lane : DefaultAttrsIntrinsic<[llvm_anyvector_ty], ---

[clang] [llvm] [AArch64][NEON] Add intrinsics for LUTI (PR #96883)

2024-07-12 Thread via cfe-commits
@@ -0,0 +1,433 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 +#include +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +neon -target-feature +lut -target-feature +bf16 -O3 -emit-llvm -o - %s | FileChec

[clang] [llvm] [AArch64][NEON] Add intrinsics for LUTI (PR #96883)

2024-07-12 Thread via cfe-commits
@@ -0,0 +1,433 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 +#include +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +neon -target-feature +lut -target-feature +bf16 -O3 -emit-llvm -o - %s | FileChec

[clang] [llvm] [AArch64] Make user-visible Arm architecture version strings consistent (PR #98550)

2024-07-12 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs commented: lgtm https://github.com/llvm/llvm-project/pull/98550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AARCH64][SVE] Add intrinsics for SVE LUTI instructions (PR #97058)

2024-07-12 Thread via cfe-commits
https://github.com/Lukacma updated https://github.com/llvm/llvm-project/pull/97058 >From 4a6c4033f7deddcd4094ebde81402960de85bd80 Mon Sep 17 00:00:00 2001 From: Marian Lukac Date: Fri, 28 Jun 2024 10:13:16 + Subject: [PATCH 1/3] [AARCH64][SVE] Add intrinsics for SVE LUTI instructions ---

[clang] [clang] Inject tokens containing #embed back into token stream (PR #97274)

2024-07-12 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/97274 >From 4d5008fcf3ac37fa213c8f2cf42c3cce6369c83d Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Thu, 20 Jun 2024 06:04:07 -0700 Subject: [PATCH 1/3] [clang] Inject tokens containing #embed back int

[clang] [clang] Inject tokens containing #embed back into token stream (PR #97274)

2024-07-12 Thread Mariya Podchishchaeva via cfe-commits
@@ -3644,9 +3644,11 @@ bool Sema::CheckLoopHintExpr(Expr *E, SourceLocation Loc, bool AllowZero) { ExprResult Sema::ActOnNumericConstant(const Token &Tok, Scope *UDLScope) { // Fast path for a single digit (which is quite common). A single digit // cannot have a trigraph,

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-12 Thread Paul Kirth via cfe-commits
@@ -681,6 +683,7 @@ llvm::Error ClangDocBitcodeReader::readRecord(unsigned ID, Reference *I) { // Read a block of records into a single info. template llvm::Error ClangDocBitcodeReader::readBlock(unsigned ID, T I) { + llvm::TimeTraceScope("readBlock", "ClangDocBitcodeReader"

[clang] [llvm] [llvm][AArch64] apple-m4 is armv9.2-a (PR #98267)

2024-07-12 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs edited https://github.com/llvm/llvm-project/pull/98267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][AArch64] apple-m4 is armv9.2-a (PR #98267)

2024-07-12 Thread Jon Roelofs via cfe-commits
@@ -161,14 +161,10 @@ struct CpuInfo { StringRef Name; // Name, as written for -mcpu. const ArchInfo &Arch; AArch64::ExtensionBitset - DefaultExtensions; // Default extensions for this CPU. These will be - // ORd with the architecture defaults

[clang] [clang] Use different memory layout type for _BitInt(N) in LLVM IR (PR #91364)

2024-07-12 Thread Momchil Velikov via cfe-commits
momchil-velikov wrote: This solves 5-6 issues we had downstream, many thanks! https://github.com/llvm/llvm-project/pull/91364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Undefined behaviour pointer arithmetic with null pointer (PR #98648)

2024-07-12 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss created https://github.com/llvm/llvm-project/pull/98648 Fixes #91144 >From 240add341b2c0a1be3d1ebf21938e70e51669126 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Fri, 12 Jul 2024 15:56:40 +0200 Subject: [PATCH] [libunwind] Fix ubsan issue --- libunwind

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-07-12 Thread Chris B via cfe-commits
llvm-beanz wrote: > I think at the time we started doing this, Clang's builtin includes lookup > basically did `$dirname($0)/../lib/llvm-$version/clang/$version/include`. So > when building `include-what-you-use` in a separate tree, the resulting binary > didn't have the builtin headers in the

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-07-12 Thread Chris B via cfe-commits
llvm-beanz wrote: (cc @compnerd, @gottesmm, & @etcwilde who have played roles in building and maintaining all the build-tree stuff for Swift). https://github.com/llvm/llvm-project/pull/97197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] 1752b7b - [clang][Interp][NFC] Apply some clang-tidy suggestions

2024-07-12 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-12T17:18:26+02:00 New Revision: 1752b7bc521ae878355a1c9e48644b0ad320dbe5 URL: https://github.com/llvm/llvm-project/commit/1752b7bc521ae878355a1c9e48644b0ad320dbe5 DIFF: https://github.com/llvm/llvm-project/commit/1752b7bc521ae878355a1c9e48644b0ad320dbe5.diff LO

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-07-12 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree created https://github.com/llvm/llvm-project/pull/98652 This fixes the following error when reading source and header files: error: source file is not valid UTF-8 >From 539af083a22ccdeaa64ccc85d6ffc08b48c9432f Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharaja

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Abhina Sree (abhina-sree) Changes This fixes the following error when reading source and header files: error: source file is not valid UTF-8 --- Full diff: https://github.com/llvm/llvm-project/pull/98652.diff 6 Files Affected: -

[libunwind] [libunwind] Undefined behaviour pointer arithmetic with null pointer (PR #98648)

2024-07-12 Thread Nikita Popov via cfe-commits
@@ -230,8 +230,13 @@ void DwarfFDECache::iterateCacheEntries(void (*func)( } #endif // defined(_LIBUNWIND_SUPPORT_DWARF_UNWIND) - -#define arrayoffsetof(type, index, field) ((size_t)(&((type *)0)[index].field)) +template +__attribute__((no_sanitize("undefined"))) static inlin

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-07-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9e261c5bee4c5618723c243986c4b39236713378 539af083a22ccdeaa64ccc85d6ffc08b48c9432f --e

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-07-12 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From 716a8c95d0059eaf616d9c179708ac4e02c17220 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH] update autoconversion functionality to fix error: s

[clang] [Clang][AArch64] Add missing SME/SVE2.1 feature macros (PR #98285)

2024-07-12 Thread via cfe-commits
https://github.com/SpencerAbson updated https://github.com/llvm/llvm-project/pull/98285 >From 67b6e8379db4a8c28feb0e49bba994338a8a99bd Mon Sep 17 00:00:00 2001 From: Spencer Abson Date: Tue, 9 Jul 2024 11:07:03 + Subject: [PATCH] [Clang][AArch64] Add missing SME/SVE2.1 feature macros ---

[clang] 840c7c6 - [clang][Interp] Fix Pointer::expand() checking for metadata size

2024-07-12 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-12T17:18:26+02:00 New Revision: 840c7c6e1fba52748e3ceccd2842e5d96f658f2e URL: https://github.com/llvm/llvm-project/commit/840c7c6e1fba52748e3ceccd2842e5d96f658f2e DIFF: https://github.com/llvm/llvm-project/commit/840c7c6e1fba52748e3ceccd2842e5d96f658f2e.diff LO

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-12 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: @budimirarandjelovicsyrmia Any updates? Should we revert the patch? https://github.com/llvm/llvm-project/pull/70024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c784abf - [clang][Interp] Delay compiling functions that don't have a body yet

2024-07-12 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-12T17:32:39+02:00 New Revision: c784abf2007a98c5fea64a84b56fa21974983d90 URL: https://github.com/llvm/llvm-project/commit/c784abf2007a98c5fea64a84b56fa21974983d90 DIFF: https://github.com/llvm/llvm-project/commit/c784abf2007a98c5fea64a84b56fa21974983d90.diff LO

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-07-12 Thread Evan Wilde via cfe-commits
etcwilde wrote: So, Swift actually has/had a similar issue. We embed a copy of clang in Swift, so we needed to find the corresponding clang resource headers and install them with our compiler which is why I wrote https://github.com/llvm/llvm-project/pull/88317 to expose them. It adds the clan

[clang] [Clang][NFCI] Remove records of unsatisfied atomic expressions in ConstraintSatisfaction (PR #98654)

2024-07-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/98654 This expression doesn't appear to be ever used, so let's remove it from the data structure. Fixed some spelling issues as well. >From 1f64b3872686054a57618fd584331a56c344c895 Mon Sep 17 00:00:00 2001 From: You

[clang] [Clang][NFCI] Remove records of unsatisfied atomic expressions in ConstraintSatisfaction (PR #98654)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes This expression doesn't appear to be ever used, so let's remove it from the data structure. Fixed some spelling issues as well. --- Full diff: https://github.com/llvm/llvm-project/pull/98654.diff 6 Files

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-07-12 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/96844 >From 038b39d3235c6c8151127c34d34f498dd298273c Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Wed, 26 Jun 2024 10:03:25 -0700 Subject: [PATCH 1/2] Performance optimizations for function effects: - Put new Fun

[clang] [Clang][NFCI] Remove records of unsatisfied atomic expressions in ConstraintSatisfaction (PR #98654)

2024-07-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/98654 >From 1f64b3872686054a57618fd584331a56c344c895 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 12 Jul 2024 23:41:18 +0800 Subject: [PATCH 1/2] [Clang][NFC] Remove records of unsatisfied atomic expressions

[clang] Add __builtin_fmaf16. (PR #97424)

2024-07-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/97424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propagate the result object location for CXXDefaultInitExpr. (PR #98490)

2024-07-12 Thread Samira Bazuzi via cfe-commits
https://github.com/bazuzi updated https://github.com/llvm/llvm-project/pull/98490 >From 8f51730d1f4bbca740a01b89780b6ed9bee3c3d7 Mon Sep 17 00:00:00 2001 From: Samira Bazuzi Date: Thu, 11 Jul 2024 09:56:17 -0400 Subject: [PATCH 1/2] Propagate the result object location for CXXDefaultInitExpr.

[clang] Add __builtin_fmaf16. (PR #97424)

2024-07-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97424 >From 417d72fdd88fddbd843ff3c19681a07e680852c7 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 2 Jul 2024 07:41:42 -0700 Subject: [PATCH 1/3] Add __builtin_fma16. --- clang/include/clang/Basic/Bu

[clang] [clang][dataflow]Propagate the result object location for CXXDefaultInitExpr. (PR #98490)

2024-07-12 Thread Samira Bazuzi via cfe-commits
https://github.com/bazuzi edited https://github.com/llvm/llvm-project/pull/98490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add __builtin_fmaf16. (PR #97424)

2024-07-12 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Changes LGTM but please be sure to add a release note when landing so users > know about the improvement. Thanks for the review. https://github.com/llvm/llvm-project/pull/97424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [Clang][AST] Move NamespaceDecl bits to DeclContext (PR #98567)

2024-07-12 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM, as a clean up, and I see no notable performance implications. Is there any follow up work for this? https://github.com/llvm/llvm-project/pull/98567 ___ cfe-commits mailing list cfe-commits@

[clang] [clang][dataflow]Propagate the result object location for CXXDefaultInitExpr. (PR #98490)

2024-07-12 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/98490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Disallow explicit object parameters in more contexts (PR #89078)

2024-07-12 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/89078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Disallow explicit object parameters in more contexts (PR #89078)

2024-07-12 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM modulo nit Thanks for working on this https://github.com/llvm/llvm-project/pull/89078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [Clang] Disallow explicit object parameters in more contexts (PR #89078)

2024-07-12 Thread via cfe-commits
@@ -4845,6 +4845,61 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state, // Check for auto functions and trailing return type and adjust the // return type accordingly. if (!D.isInvalidType()) { +auto IsClassType = [&](CXXSco

[clang] Reapply "[Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads" (#97002) (PR #97894)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/97894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @budimirarandjelovicsyrmia Any updates? Should we revert the patch? I already reverted in 9d1017204a253782a82d1b7d16c59eea3f811a11 so the bots have been slowly getting back to green https://github.com/llvm/llvm-project/pull/70024 __

[clang] Reapply "[Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads" (#97002) (PR #97894)

2024-07-12 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/97894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c6e996a - Reapply "[Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads" (#97002) (#97894)

2024-07-12 Thread via cfe-commits
Author: Nikolas Klauser Date: 2024-07-12T18:29:39+02:00 New Revision: c6e996a931f810db9b43c24f74931cea79337511 URL: https://github.com/llvm/llvm-project/commit/c6e996a931f810db9b43c24f74931cea79337511 DIFF: https://github.com/llvm/llvm-project/commit/c6e996a931f810db9b43c24f74931cea79337511.dif

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-12 Thread Michael Toguchi via cfe-commits
@@ -3295,7 +3295,17 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues, NanValues = true; + auto processArg = [&](const auto *Arg) { +if (Strin

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-12 Thread Michael Toguchi via cfe-commits
@@ -3295,7 +3295,17 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues, NanValues = true; mdtoguchi wrote: `InfValues` isn't initi

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-12 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Thank you! Sorry, I should search for reverts before complaining. https://github.com/llvm/llvm-project/pull/70024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [C23] Fix typeof_unqual for qualified array types (PR #92767)

2024-07-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Just making sure that this didn't fall off your radar; it seems like a good fix for us to get into Clang 19 before the branch, if possible. https://github.com/llvm/llvm-project/pull/92767 ___ cfe-commits mailing list cfe-commits@li

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-07-12 Thread David Blaikie via cfe-commits
dwblaikie wrote: > I think the appropriate tag for such commits would be NFCI, and should still > require PR and review. Clarifying a couple of things here 1) I tend to agree the patch might've been a bit subtle and maybe split up into smaller, independent parts (usual rules: [be an isolated c

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-12 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/98419 >From b740aa9da3baf4fbd32b5a2c59d70bf2f224f700 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 10 Jul 2024 17:10:26 -0700 Subject: [PATCH 1/8] split out resource class data from resource attr, add some

[clang] [clang][dataflow]Propagate the result object location for CXXDefaultInitExpr. (PR #98490)

2024-07-12 Thread Samira Bazuzi via cfe-commits
bazuzi wrote: Thanks for the review. Could you merge for me? I don't have commit access. https://github.com/llvm/llvm-project/pull/98490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix the docs for the boost/modernize use-ranges checks (PR #98662)

2024-07-12 Thread Nathan James via cfe-commits
https://github.com/njames93 created https://github.com/llvm/llvm-project/pull/98662 The formatting looked a little off in the Release notes webpage. This should address those issues >From 58b0b788be914e6317be02a52322b2d2c2b3ffa6 Mon Sep 17 00:00:00 2001 From: Nathan James Date: Fri, 12 Jul 20

[clang-tools-extra] Fix the docs for the boost/modernize use-ranges checks (PR #98662)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Nathan James (njames93) Changes The formatting looked a little off in the Release notes webpage. This should address those issues --- Full diff: https://github.com/llvm/llvm-project/pull/98662.diff 2 Files Affected: - (modified) c

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/5] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang-tools-extra] Fix the docs for the boost/modernize use-ranges checks (PR #98662)

2024-07-12 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/98662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Add missing SME/SVE2.1 feature macros (PR #98285)

2024-07-12 Thread David Sherwood via cfe-commits
david-arm wrote: Is it worth adding a link to the ACLE that describes the features in the commit message? https://github.com/llvm/llvm-project/pull/98285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-12 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. https://github.com/llvm/llvm-project/pull/98419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Don't display the offset value in underflows (PR #98621)

2024-07-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: This makes sense. I wonder if we could have something in between. I'm thinking of having the concrete offset as a separate note, instead of having it part of the primary message. That way after BR selection, we would still deterministically pick the shorte

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-07-12 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/98652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reset PostAllocaInsertPt when the AllocaInsertPt is changed in clang::CodeGenFunction (PR #98668)

2024-07-12 Thread Eric Wright via cfe-commits
https://github.com/efwright created https://github.com/llvm/llvm-project/pull/98668 Clang's CodeGenFunction tracks two insert points for "allocas". One where the alloca instructions are placed, and another (immediately following the allocas) where any address space casts are placed. For code o

[clang] Reset PostAllocaInsertPt when the AllocaInsertPt is changed in clang::CodeGenFunction (PR #98668)

2024-07-12 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Reset PostAllocaInsertPt when the AllocaInsertPt is changed in clang::CodeGenFunction (PR #98668)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Eric Wright (efwright) Changes Clang's CodeGenFunction tracks two insert points for "allocas". One where the alloca instructions are placed, and another (immediately following the allocas) where any addr

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-07-12 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/96844 >From 038b39d3235c6c8151127c34d34f498dd298273c Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Wed, 26 Jun 2024 10:03:25 -0700 Subject: [PATCH 1/4] Performance optimizations for function effects: - Put new Fun

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-07-12 Thread Doug Wyatt via cfe-commits
dougsonos wrote: Added a further tweak: add a bool to ASTContext to track whether any FunctionProtoType's with effects have been created, so that Sema can short-circuit checks involving effects when it knows no one has any. This seems to have the desired effect of only paying for the feature w

[clang] [llvm] [Clang][Coroutines] Introducing the `[[clang::coro_inplace_task]]` attribute (PR #94693)

2024-07-12 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/94693 >From 4e4bcdc19268543a8348736dede46d8f8cad0066 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH 1/3] [Clang] Introduce [[clang::coro_inplace_task]] --- clan

[clang] [clang] Use different memory layout type for _BitInt(N) in LLVM IR (PR #91364)

2024-07-12 Thread John McCall via cfe-commits
rjmccall wrote: > > Okay, so x86_64 describes it in byte terms and says they're little-endian, > > which is consistent with the overall target. Interestingly, it does not > > guarantee the content of the excess bits. The code-generation in this patch > > is consistent with that: the extension

[clang] [clang] Use different memory layout type for _BitInt(N) in LLVM IR (PR #91364)

2024-07-12 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. https://github.com/llvm/llvm-project/pull/91364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix the docs for the boost/modernize use-ranges checks (PR #98662)

2024-07-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. Those functions could be listed as an bullet points. But anyway lest, merge this and check if this fixes issues. https://github.com/llvm/llvm-project/pull/98662 ___ cfe-commits mailing list cfe-co

[clang-tools-extra] Fix the docs for the boost/modernize use-ranges checks (PR #98662)

2024-07-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/98662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] a31b3de - Fix the docs for the boost/modernize use-ranges checks (#98662)

2024-07-12 Thread via cfe-commits
Author: Nathan James Date: 2024-07-12T19:57:56+02:00 New Revision: a31b3de9285b77de60521c94f176493ddfb1127c URL: https://github.com/llvm/llvm-project/commit/a31b3de9285b77de60521c94f176493ddfb1127c DIFF: https://github.com/llvm/llvm-project/commit/a31b3de9285b77de60521c94f176493ddfb1127c.diff

[clang-tools-extra] b9852ff - [clang-tidy] Ignore requires expr in bugprone-assignment-in-if-condition (#98079)

2024-07-12 Thread via cfe-commits
Author: Piotr Zegar Date: 2024-07-12T19:58:45+02:00 New Revision: b9852ff5fc4986c6cf8c4ecd1eb5726d55a08ea3 URL: https://github.com/llvm/llvm-project/commit/b9852ff5fc4986c6cf8c4ecd1eb5726d55a08ea3 DIFF: https://github.com/llvm/llvm-project/commit/b9852ff5fc4986c6cf8c4ecd1eb5726d55a08ea3.diff L

[clang-tools-extra] [clang-tidy] Ignore requires expr in bugprone-assignment-in-if-condition (PR #98079)

2024-07-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/98079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-12 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > max aligment [...] LLVM Verifier accepts is 2^14 The verifier limit in most places is 2^32. It looks like 2^14 is specifically for ByVal. And there isn't really any good reason for that limit; it was arbitrarily chosen in b567e3ffb0, nearly two decades ago, and could e

[clang] [llvm] [OpenMPIRBuilder][Clang][NFC] - Combine `emitOffloadingArrays` and `emitOffloadingArraysArgument` in OpenMPIRBuilder (PR #97088)

2024-07-12 Thread Jan Leyonberg via cfe-commits
https://github.com/jsjodin edited https://github.com/llvm/llvm-project/pull/97088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMPIRBuilder][Clang][NFC] - Combine `emitOffloadingArrays` and `emitOffloadingArraysArgument` in OpenMPIRBuilder (PR #97088)

2024-07-12 Thread Jan Leyonberg via cfe-commits
https://github.com/jsjodin approved this pull request. One nit, otherwise LGTM. https://github.com/llvm/llvm-project/pull/97088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMPIRBuilder][Clang][NFC] - Combine `emitOffloadingArrays` and `emitOffloadingArraysArgument` in OpenMPIRBuilder (PR #97088)

2024-07-12 Thread Jan Leyonberg via cfe-commits
@@ -9536,18 +9506,65 @@ static void emitTargetCallKernelLaunch( MEHandler.adjustMemberOfForLambdaCaptures( OMPBuilder, LambdaPointers, CombinedInfo.BasePointers, CombinedInfo.Pointers, CombinedInfo.Types); +} +static void +genMapInfo(MappableExprsHandler &MEHandle

[clang] Fix assertion failure during operator overload resolution. (PR #98671)

2024-07-12 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm created https://github.com/llvm/llvm-project/pull/98671 When clang is built with assertions, an otherwise silent (and seemingly innocuous) assertion failure from `SemaConcept.cpp` is triggered by the following program: ```cpp struct S { operator int(); template

[clang] Fix assertion failure during operator overload resolution. (PR #98671)

2024-07-12 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm updated https://github.com/llvm/llvm-project/pull/98671 >From 47db72077258ebe086059f116bbf7fb32c184c8d Mon Sep 17 00:00:00 2001 From: Dan Katz Date: Fri, 12 Jul 2024 13:57:33 -0400 Subject: [PATCH] Fix assertion failure during operator overload resolution. --- clang/

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-12 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: (The relevant bitfield is was renamed to MemAlign, and is now in llvm/include/llvm/CodeGen/TargetCallingConv.h) https://github.com/llvm/llvm-project/pull/98629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-07-12 Thread Alan Zhao via cfe-commits
alanzhao1 wrote: > @alanzhao1 do you think it's reasonable for the workaround to only apply to > code in system headers, or does the NDK get included as regular headers > generally? Having it only apply to system headers should be OK - in our case, chrome imports these headers as part of a `

[clang] [llvm] IR: Store the default subtarget info in named metadata instead of the context. (PR #98673)

2024-07-12 Thread via cfe-commits
https://github.com/pcc created https://github.com/llvm/llvm-project/pull/98673 None >From 6976f169ec1befd902d0a0d0cc05b375d6ae094b Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Fri, 12 Jul 2024 11:11:44 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?

<    1   2   3   4   5   >