https://github.com/ilovepi commented:
I think this mostly looks good, but I am concerned with the line number matching. It appears that whenever you’ve up’s the file you’ve had to update all the line numbers. Is it feasible to rewrite some of the checks to use the @LINE directive? Perhaps it also makes sense to move those checks close to the lines they expect to match? Another thought is to leave the test as is, but drop the line numbers(or just match any number) and have a small set of check in line with the code that checks the line numbers with the LINE directive and uses a new prefix. https://github.com/llvm/llvm-project/pull/97681 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
