[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-12 Thread Martin Storsjö via cfe-commits
@@ -77,13 +77,3 @@ // XTOR: {{llvm-spirv.*"}} // BACKEND-NOT: {{llvm-spirv.*"}} - -//- -// Check llvm-spirv- is used if it is found in PATH. -// RUN: mkdir -p %t/versioned -// RUN: touch %t/versioned/l

[clang] [Clang] Fix conseval propagation in templated entities (PR #95233)

2024-06-12 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/95233 * Lambdas were not considered immediate escalating in a template * Calls to an immediate function whose arguments were dependent were incorrectly treated as immediate escalating. Fixes #94935 >From f567bbcafc2

[clang] [Clang] Fix conseval propagation in templated entities (PR #95233)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes * Lambdas were not considered immediate escalating in a template * Calls to an immediate function whose arguments were dependent were incorrectly treated as immediate escalating. Fixes #94935 --- Full diff: ht

[clang] [Clang] Fix immediate escalation in templated entities (PR #95233)

2024-06-12 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/95233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Let DefineOutline tweak handle member functions (PR #95235)

2024-06-12 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler created https://github.com/llvm/llvm-project/pull/95235 ... of class templates. >From fc3a907ab2550a999801d37400268fdc31df054d Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 14 Nov 2023 16:35:46 +0100 Subject: [PATCH] [clangd] Let DefineOutline tweak

[clang-tools-extra] [clangd] Let DefineOutline tweak handle member functions (PR #95235)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Christian Kandeler (ckandeler) Changes ... of class templates. --- Full diff: https://github.com/llvm/llvm-project/pull/95235.diff 3 Files Affected: - (modified) clang-tools-extra/clangd/AST.cpp (+6-1) - (modified) clang-tools-extra/c

[clang] [analyzer] Finish moving alpha.core.SizeofPtr to clang-tidy (PR #95118)

2024-06-12 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > We should remember to mention this transfer explicitly in the release notes > one day. Yes, I'll try to remember it. By the way, it is already mentioned in the clang-tidy release notes (apparently there the release notes are kept in sync with active development), but it's d

[clang] d9a508d - [analyzer] Finish moving alpha.core.SizeofPtr to clang-tidy (#95118)

2024-06-12 Thread via cfe-commits
Author: Donát Nagy Date: 2024-06-12T14:26:47+02:00 New Revision: d9a508db55f986518983aaba18c1b7f9ce67536a URL: https://github.com/llvm/llvm-project/commit/d9a508db55f986518983aaba18c1b7f9ce67536a DIFF: https://github.com/llvm/llvm-project/commit/d9a508db55f986518983aaba18c1b7f9ce67536a.diff LO

[clang] [analyzer] Finish moving alpha.core.SizeofPtr to clang-tidy (PR #95118)

2024-06-12 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/95118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-12 Thread via cfe-commits
alexfh wrote: The report is about compilation timeouts rather than runtime performance. The code being compiled is outside the tree. We're working on a shareable reproducer. https://github.com/llvm/llvm-project/pull/92083 ___ cfe-commits mailing list

[clang] [Driver] Add winsysroot alias to the GNU driver (PR #94731)

2024-06-12 Thread via cfe-commits
https://github.com/Andarwinux updated https://github.com/llvm/llvm-project/pull/94731 >From 331dbb9991729c82f7a60c5e93887825925b144b Mon Sep 17 00:00:00 2001 From: Andarwinux <144242044+andarwi...@users.noreply.github.com> Date: Fri, 7 Jun 2024 07:07:40 + Subject: [PATCH] [Driver] Add winsys

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-12 Thread via cfe-commits
alexfh wrote: As the architecture is concerned, it's AArch64, which is 64 bit. https://github.com/llvm/llvm-project/pull/92083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-06-12 Thread Vikram Hegde via cfe-commits
vikramRH wrote: > > > @jayfoad's testcase fails and the same test should be repeated for all 3 > > > intrinsics > > > > > > added MIR tests for 3 intrinsics. The issue is that Im not able to attach > > the glue nodes to newly created laneop pieces since they fail at selection. > > #87509 sho

[clang] [llvm] [AArch64] Add support for Cortex-A725 and Cortex-X925 (PR #95214)

2024-06-12 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/95214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-06-12 Thread Vikram Hegde via cfe-commits
vikramRH wrote: > > > > @jayfoad's testcase fails and the same test should be repeated for all > > > > 3 intrinsics > > > > > > > > > added MIR tests for 3 intrinsics. The issue is that Im not able to attach > > > the glue nodes to newly created laneop pieces since they fail at > > > selecti

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-12 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/95025 >From 6fc09d022a0e4e395a1b8e17166641dffc7c12eb Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Mon, 10 Jun 2024 22:17:29 +0300 Subject: [PATCH 1/4] [clang-format] Don't count template template parameter as decla

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-12 Thread Emilia Kond via cfe-commits
@@ -584,6 +584,23 @@ TEST_F(TokenAnnotatorTest, UnderstandsNonTemplateAngleBrackets) { EXPECT_TOKEN(Tokens[20], tok::greater, TT_BinaryOperator); } +TEST_F(TokenAnnotatorTest, UnderstandsTemplateTemplateParameters) { + auto Tokens = annotate("template typename X,\n" +

[clang] [clang] Don't print extra space when dumping template names (PR #95213)

2024-06-12 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/95213 >From 3c96bf1b16360f52b235d31c08644a2749e7c808 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Wed, 12 Jun 2024 11:24:10 +0200 Subject: [PATCH] [clang] Don't print extra blank when dump the template name. --- cl

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-12 Thread Emilia Kond via cfe-commits
@@ -1269,10 +1269,17 @@ class AnnotatingParser { if (CurrentToken && CurrentToken->is(tok::less)) { CurrentToken->setType(TT_TemplateOpener); next(); - if (!parseAngle()) + TemplateDeclarationDepth++; + if (!parseAngle()) { +TemplateDeclar

[clang] [llvm] [AArch64] Add support for Cortex-A725 and Cortex-X925 (PR #95214)

2024-06-12 Thread David Green via cfe-commits
@@ -723,6 +746,9 @@ def ProcessorFeatures { FeaturePerfMon, FeatureETE, FeatureTRBE, FeatureSPE, FeatureMTE, FeatureSVE2BitPerm, FeatureFP16FML, FeatureSPE_EEF]; + list X925 = [H

[clang] [X86] Enable constexpr on LZCNT & BMI intrinsics (PR #94161)

2024-06-12 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: @aniplcc if the x86 builtins handling is causing a problem - could we split this so the generic c code intrinsics (andn, blsr etc.) are done first? https://github.com/llvm/llvm-project/pull/94161 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-06-12 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,46 @@ +# RUN: not --crash llc -mtriple=amdgcn -run-pass=none -verify-machineinstrs -o /dev/null %s 2>&1 | FileCheck %s arsenm wrote: I'd still test all 3, but yes an IR test https://github.com/llvm/llvm-project/pull/89217 ___

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-06-12 Thread Matt Arsenault via cfe-commits
arsenm wrote: > Or drop the new nodes altogether and legelaize to intrinsics directly ? That's another option. The only real plus to the intermediate is it's slightly less annoying to write combines for. But there are limited combining opportunities for these https://github.com/llvm/llvm-p

[clang] [llvm] [AArch64] Add support for Cortex-A725 and Cortex-X925 (PR #95214)

2024-06-12 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/95214 >From f48ed213e7c1c9e8ab32f4916622c2089e67a628 Mon Sep 17 00:00:00 2001 From: Jonathan Thackray Date: Wed, 29 May 2024 22:14:28 +0100 Subject: [PATCH 1/2] [AArch64] Add support for Cortex-A725 and Cortex-X925

[clang] [clang] SourceLocIdentKind::Function should not be dependent (PR #94942)

2024-06-12 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > SourceLocation needs to be dependent because we want to make the name of the > function and any template parameter refers to the instantiated function > rather than that of the function template. This was changed in #78436 > > The issue is that SourceLocation then is a dependen

[clang] [Clang][AMDGPU] Add a new builtin type for buffer rsrc (PR #94830)

2024-06-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/94830 >From 1b06131a10e1f8067961624b02bba3354d5057c0 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Wed, 12 Jun 2024 09:18:49 -0400 Subject: [PATCH] [Clang][AMDGPU] Add a new builtin type for buffer rsrc --- clang

[clang] [llvm] [AArch64] Add support for Cortex-A725 and Cortex-X925 (PR #95214)

2024-06-12 Thread Jonathan Thackray via cfe-commits
@@ -723,6 +746,9 @@ def ProcessorFeatures { FeaturePerfMon, FeatureETE, FeatureTRBE, FeatureSPE, FeatureMTE, FeatureSVE2BitPerm, FeatureFP16FML, FeatureSPE_EEF]; + list X925 = [H

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-12 Thread John McCall via cfe-commits
@@ -325,14 +325,19 @@ Address SparcV9ABIInfo::EmitVAArg(CodeGenFunction &CGF, Address VAListAddr, break; case ABIArgInfo::Ignore: -return Address(llvm::UndefValue::get(ArgPtrTy), ArgTy, TypeInfo.Align); +return CGF.EmitLoadOfAnyValue( +CGF.MakeAddrLValue

[clang] [Clang] Fix immediate escalation in templated entities (PR #95233)

2024-06-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: `Sema.h` changes look good. https://github.com/llvm/llvm-project/pull/95233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload][CUDA] Allow CUDA kernels to use LLVM/Offload (PR #94549)

2024-06-12 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert updated https://github.com/llvm/llvm-project/pull/94549 >From 094dbf3e01a62136db6be1afd6194f1d84ca8494 Mon Sep 17 00:00:00 2001 From: Johannes Doerfert Date: Wed, 12 Jun 2024 02:14:32 -0700 Subject: [PATCH 1/3] [Offload][AMDGPU] Impose more restrictions for implicit

[clang] [clang] Catch missing format attributes (PR #70024)

2024-06-12 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovicsyrmia updated https://github.com/llvm/llvm-project/pull/70024 From f751c9f2aa48d80cd7facca289317fc306068f38 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribut

[clang] [clang] Catch missing format attributes (PR #70024)

2024-06-12 Thread Budimir Aranđelović via cfe-commits
@@ -0,0 +1,303 @@ +// RUN: %clang_cc1 -fsyntax-only -verify=expected,beforeCxx2b -Wmissing-format-attribute %s +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++2b -Wmissing-format-attribute %s +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++23 -Wmissing-format-attribute %s +

[clang] [flang] [flang] Add -mlink-builtin-bitcode option to fc1 (PR #94763)

2024-06-12 Thread Jan Leyonberg via cfe-commits
@@ -0,0 +1,15 @@ +! Test -mlink-builtin-bitcode flag +! RUN: %flang -emit-llvm -c -o %t.bc %S/Inputs/libfun.f90 +! RUN: %flang_fc1 -emit-llvm -o - -mlink-builtin-bitcode %t.bc %s 2>&1 | FileCheck %s + +! CHECK: define internal void @libfun_ + +! RUN: not %flang_fc1 -emit-llvm -tr

[clang] [clang] Catch missing format attributes (PR #70024)

2024-06-12 Thread Budimir Aranđelović via cfe-commits
@@ -0,0 +1,277 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -Wmissing-format-attribute %s + +typedef unsigned short char16_t; +typedef unsigned int char32_t; +typedef __WCHAR_TYPE__ wchar_t; +typedef __SIZE_TYPE__ size_t; +typedef __builtin_va_list va_list; + +__attribute__((__for

[clang] [flang] [flang] Add -mlink-builtin-bitcode option to fc1 (PR #94763)

2024-06-12 Thread Jan Leyonberg via cfe-commits
https://github.com/jsjodin updated https://github.com/llvm/llvm-project/pull/94763 >From adfeb69ba312e971cb4eae71f185f38b1cac9b8f Mon Sep 17 00:00:00 2001 From: Jan Leyonberg Date: Wed, 5 Jun 2024 10:56:41 -0400 Subject: [PATCH 1/3] [flang] Add -mlink-builtin-bitcode option to fc1 This patch e

[clang] [llvm] [AArch64] Add support for Cortex-A725 and Cortex-X925 (PR #95214)

2024-06-12 Thread David Green via cfe-commits
https://github.com/davemgreen approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/95214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-06-12 Thread Mariya Podchishchaeva via cfe-commits
@@ -1533,9 +1533,17 @@ void CodeGenFunction::EmitReturnStmt(const ReturnStmt &S) { Builder.CreateStore(Result.getScalarVal(), ReturnValue); } else { switch (getEvaluationKind(RV->getType())) { -case TEK_Scalar: - Builder.CreateStore(EmitScalarExpr(RV), Retur

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= Message-ID: In-Reply-To: @@ -0,0 +1,31 @@ +.. title:: clang-tidy - cppcoreguidelines-prefer-at-over-subscript-operator + +cpp

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= Message-ID: In-Reply-To: @@ -0,0 +1,31 @@ +.. title:: clang-tidy - cppcoreguidelines-prefer-at-over-subscript-operator + +cpp

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread via cfe-commits
Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= Message-ID: In-Reply-To: @@ -0,0 +1,31 @@ +.. title:: clang-tidy - cppcoreguidelines-prefer-at-over-

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= Message-ID: In-Reply-To: @@ -0,0 +1,124 @@ +//===--- PreferAtOverSubscriptOperatorCheck.cpp - clang-tidy --===//

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-12 Thread via cfe-commits
bgra8 wrote: @ChuanqiXu9 the description of the change says that the maximum expected PCMs size increase is 6.6%. In our testing at google we see noticed for some large targets the total combined PCM size increase by more than 25% (both ARM64 and x86_64). https://github.com/llvm/llvm-project/

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread Carlos Galvez via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= Message-ID: In-Reply-To: carlosgalvezp wrote: The check certainly doesn't need to fully implement the guideline right now, it can be done in

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-06-12 Thread John McCall via cfe-commits
@@ -1533,9 +1533,17 @@ void CodeGenFunction::EmitReturnStmt(const ReturnStmt &S) { Builder.CreateStore(Result.getScalarVal(), ReturnValue); } else { switch (getEvaluationKind(RV->getType())) { -case TEK_Scalar: - Builder.CreateStore(EmitScalarExpr(RV), Retur

[clang] added regcall struct by reg support (PR #95257)

2024-06-12 Thread via cfe-commits
https://github.com/mahesh-attarde created https://github.com/llvm/llvm-project/pull/95257 In Context of __regcall, Whenever struct can fit in a register we must use single register to pass whole struct object. Without this patch, it uses separate registers for each field. With Patch, if Struc

[clang] added regcall struct by reg support (PR #95257)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (mahesh-attarde) Changes In Context of __regcall, Whenever struct can fit in a register we must use single register to pass whole struct object. Without this patch, it uses separate registers for each field. With Patch, if Struct si

[clang] [clang] Skip auto-init on scalar vars that have a non-constant Init and no self-ref (PR #94642)

2024-06-12 Thread Alexander Potapenko via cfe-commits
ramosian-glider wrote: Drive-by comment: can you please either merge the two commits together, or change their descriptions so that they are not 100% identical? https://github.com/llvm/llvm-project/pull/94642 ___ cfe-commits mailing list cfe-commits@l

[clang] [clang] Skip auto-init on scalar vars that have a non-constant Init and no self-ref (PR #94642)

2024-06-12 Thread Alexander Potapenko via cfe-commits
@@ -15,7 +15,7 @@ struct Foo { int foo(unsigned n) { bool var_size_1; - long var_size_8 = 123; ramosian-glider wrote: Can we have both the test cases in which scalar variables are auto-inited and where the initialization is skipped? Something along the li

[clang] 7051073 - Reland "[AArch64] Decouple feature dependency expansion. (#94279)" (#95231)

2024-06-12 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-06-12T16:07:35+01:00 New Revision: 70510733af33c70ff7877eaf30d7718b9358a725 URL: https://github.com/llvm/llvm-project/commit/70510733af33c70ff7877eaf30d7718b9358a725 DIFF: https://github.com/llvm/llvm-project/commit/70510733af33c70ff7877eaf30d7718b9358a7

[clang] [llvm] Reland "[AArch64] Decouple feature dependency expansion. (#94279)" (PR #95231)

2024-06-12 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/95231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread Paul Heidekrüger via cfe-commits
@@ -0,0 +1,31 @@ +.. title:: clang-tidy - cppcoreguidelines-prefer-at-over-subscript-operator + +cppcoreguidelines-prefer-at-over-subscript-operator += + +This check flags all uses of ``operator[]`` where an equivalent (same parameter and retur

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread Paul Heidekrüger via cfe-commits
https://github.com/PBHDK edited https://github.com/llvm/llvm-project/pull/95220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread Paul Heidekrüger via cfe-commits
https://github.com/PBHDK edited https://github.com/llvm/llvm-project/pull/95220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Expose `-fno-eliminate-unused-debug-types` to clang-cl (PR #95259)

2024-06-12 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea created https://github.com/llvm/llvm-project/pull/95259 This is used to set DebugInfoKind to "UnusedTypeInfo". This helps in the context Unreal Engine and NATVIS files that reference unused otherwise `static constexpr` class members. See https://udn.unrealengine.com/

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-06-12 Thread Akash Banerjee via cfe-commits
TIFitis wrote: Ping for review. https://github.com/llvm/llvm-project/pull/80343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Expose `-fno-eliminate-unused-debug-types` to clang-cl (PR #95259)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Alexandre Ganea (aganea) Changes This is used to set DebugInfoKind to "UnusedTypeInfo". This helps in the context Unreal Engine and NATVIS files that reference unused otherwise `static constexpr` class members. See https://udn.unr

[clang] [Clang][Driver] Expose `-fno-eliminate-unused-debug-types` to clang-cl (PR #95259)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexandre Ganea (aganea) Changes This is used to set DebugInfoKind to "UnusedTypeInfo". This helps in the context Unreal Engine and NATVIS files that reference unused otherwise `static constexpr` class members. See https://udn.unrealengi

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= Message-ID: In-Reply-To: @@ -0,0 +1,31 @@ +.. title:: clang-tidy - cppcoreguidelines-prefer-at-over-subscript-operator + +cpp

[clang] [HLSL] Fix FileCheck annotation typos (PR #95155)

2024-06-12 Thread via cfe-commits
klensy wrote: Btw, can anyone summon me clang reviewers? Few weeks without any review is sad. https://github.com/llvm/llvm-project/pull/95155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread Paul Heidekrüger via cfe-commits
https://github.com/PBHDK updated https://github.com/llvm/llvm-project/pull/95220 From 37292995de0c5aa87408586749795a97468d4725 Mon Sep 17 00:00:00 2001 From: Sebastian Wolf Date: Wed, 17 Apr 2024 16:16:35 +0200 Subject: [PATCH 01/11] Enforce SL.con.3: Add check to replace operator[] with at() o

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Alexis Perry-Holby via cfe-commits
https://github.com/AlexisPerry updated https://github.com/llvm/llvm-project/pull/95043 >From 2312d31b14aecc6eeea2e81d221ee004e5de3efc Mon Sep 17 00:00:00 2001 From: Alexis Perry-Holby Date: Thu, 6 Jun 2024 14:02:52 -0600 Subject: [PATCH 1/4] [flang] Add basic -mtune support --- clang/include/

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread Congcong Cai via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= Message-ID: In-Reply-To: HerrCai0907 wrote: > I

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Alexis Perry-Holby via cfe-commits
https://github.com/AlexisPerry updated https://github.com/llvm/llvm-project/pull/95043 >From 2312d31b14aecc6eeea2e81d221ee004e5de3efc Mon Sep 17 00:00:00 2001 From: Alexis Perry-Holby Date: Thu, 6 Jun 2024 14:02:52 -0600 Subject: [PATCH 1/4] [flang] Add basic -mtune support --- clang/include/

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-12 Thread Congcong Cai via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= Message-ID: In-Reply-To: HerrCai0907 wrote: > >

[clang] [flang] [flang] Add -mlink-builtin-bitcode option to fc1 (PR #94763)

2024-06-12 Thread Mats Petersson via cfe-commits
https://github.com/Leporacanthicus approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/94763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] fix appropriate cast (PR #95261)

2024-06-12 Thread via cfe-commits
https://github.com/mahesh-attarde created https://github.com/llvm/llvm-project/pull/95261 NFC fix for appropriate function call. Requested by aaron while discussing [added regcall struct by reg support](https://github.com/llvm/llvm-project/pull/95257) #95257 >From 6d6619f8f7a37906ac45791487a4d

[clang] [NFC] fix appropriate cast (PR #95261)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang Author: None (mahesh-attarde) Changes NFC fix for appropriate function call. Requested by aaron while discussing [added regcall struct by reg support](https://github.com/llvm/llvm-project/pull/95257) #95257 --- Fu

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: Why do you have the first `target-cpu` check on its own? Is it intended to check for the _absence_ of the `tune-cpu` attribute when `target-cpu` is provided on the command line? If so, there should be a `CPU-NOT` annotation as well. Otherwi

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: Consider replacing `#0` with `#{{[0-9]+}}`. While the attributes are almost certainly going to be in `#0` for such a small function, you don't actually _require_ this to match `#0`, so you it might be better to let it match any number. Al

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu edited https://github.com/llvm/llvm-project/pull/95043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ConstantFold] Drop gep of gep fold entirely (PR #95126)

2024-06-12 Thread via cfe-commits
agozillon wrote: Hey, @jplehr notified me of this issue (thank you), I've had a little look at it and it's related to an issue this PR fixes: https://github.com/llvm/llvm-project/pull/94541 which you are currently a reviewer of ironically (as I use and alter slightly a piece of functionality

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-12 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/95164 >From 67dd473d7d1e23177caad0cd722eeb341cf63ebc Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 11 Jun 2024 11:04:00 -0700 Subject: [PATCH] Bump the DWARF version number to 5 on Darwin. The default

[clang] ad7a9d6 - [CodeGen] Remove IsVolatile from DominatingValue::save_type (#95165)

2024-06-12 Thread via cfe-commits
Author: Akira Hatanaka Date: 2024-06-12T08:49:53-07:00 New Revision: ad7a9d6af3523ae6e75658562ec510368f5f8df4 URL: https://github.com/llvm/llvm-project/commit/ad7a9d6af3523ae6e75658562ec510368f5f8df4 DIFF: https://github.com/llvm/llvm-project/commit/ad7a9d6af3523ae6e75658562ec510368f5f8df4.diff

[clang] [CodeGen] Remove IsVolatile from DominatingValue::save_type (PR #95165)

2024-06-12 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/95165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] ignoring macro with hash preprocessing token in cppcoreguidelines-macro-usage (PR #95265)

2024-06-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/95265 `#` and `##` preprocessing tokens cannot be replaced by constexpr function. It should be ignored in check. >From eaeb5b6493e0c3980a60f9acbc5572de0d619419 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Th

[clang-tools-extra] [clang-tidy] ignoring macro with hash preprocessing token in cppcoreguidelines-macro-usage (PR #95265)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes `#` and `##` preprocessing tokens cannot be replaced by constexpr function. It should be ignored in check. --- Full diff: https://github.com/llvm/llvm-project/pull/95265.diff 4 Files Affect

[clang-tools-extra] [clang-tidy] ignoring macro with hash preprocessing token in cppcoreguidelines-macro-usage (PR #95265)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes `#` and `##` preprocessing tokens cannot be replaced by constexpr function. It should be ignored in check. --- Full diff: https://github.com/llvm/llvm-project/pull/95265.diff 4 Files Affected: -

[clang] [llvm] [clang][Driver] Add HIPAMD Driver support for AMDGCN flavoured SPIR-V (PR #95061)

2024-06-12 Thread Yaxun Liu via cfe-commits
@@ -128,12 +128,13 @@ enum class CudaArch { GFX12_GENERIC, GFX1200, GFX1201, + AMDGCNSPIRV, Generic, // A processor model named 'generic' if the target backend defines a // public one. LAST, CudaDefault = CudaArch::SM_52, - HIPDefault = CudaArch::

[clang] [clang-format] Add BinPackBinaryOperations configuration (PR #95013)

2024-06-12 Thread Ameer J via cfe-commits
@@ -27492,6 +27492,86 @@ TEST_F(FormatTest, SpaceBetweenKeywordAndLiteral) { verifyFormat("return sizeof \"5\";"); } +TEST_F(FormatTest, BinPackBinaryOperations) { + auto Style = getLLVMStyle(); + Style.BinPackBinaryOperations = false; + + // Logical operations + verifyF

[clang] [clang-tools-extra] [libcxx] [lldb] [llvm] Add clang basic module directory (PR #93388)

2024-06-12 Thread Louis Dionne via cfe-commits
ldionne wrote: For tidying up the libc++ review queue, please remove the `libc++` tag once you rebase this (the small changes in `libcxx` will go away). https://github.com/llvm/llvm-project/pull/93388 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [llvm] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-12 Thread Ilya Leoshkevich via cfe-commits
iii-i wrote: This is still failing for me on Debian. The problem seems to be that `/etc/lsb-release` does not exist. There are ``` # cat /etc/os-release PRETTY_NAME="Debian GNU/Linux bookworm/sid" NAME="Debian GNU/Linux" VERSION_CODENAME=bookworm ID=debian HOME_URL="https://www.debian.org/"; SU

[clang] [Serialization] No transitive identifier change (PR #92085)

2024-06-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM, but I think it would be better to split out the `LazyIdentifierInfoPtr` change into a separate commit. https://github.com/llvm/llvm-project/pull/92085 ___ cfe-commits mailing list cfe-c

[clang] [NFC] fix appropriate cast (PR #95261)

2024-06-12 Thread via cfe-commits
mahesh-attarde wrote: ping @AaronBallman https://github.com/llvm/llvm-project/pull/95261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] fix appropriate cast (PR #95261)

2024-06-12 Thread via cfe-commits
https://github.com/mahesh-attarde closed https://github.com/llvm/llvm-project/pull/95261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][Driver] Add HIPAMD Driver support for AMDGCN flavoured SPIR-V (PR #95061)

2024-06-12 Thread Matt Arsenault via cfe-commits
@@ -128,12 +128,13 @@ enum class CudaArch { GFX12_GENERIC, GFX1200, GFX1201, + AMDGCNSPIRV, Generic, // A processor model named 'generic' if the target backend defines a // public one. LAST, CudaDefault = CudaArch::SM_52, - HIPDefault = CudaArch::

[clang] [llvm] [RISCV] Add -m[no-]scalar-strict-align and -m[no-]vector-strict-align. Alias -m[no-]strict-align to scalar. (PR #95024)

2024-06-12 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/95024 >From cda94f996a75b9cb4f7a53dce5845926b084af0e Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Mon, 10 Jun 2024 12:05:26 -0700 Subject: [PATCH 1/2] [RISCV] Add -m[no-]scalar-strict-align and -m[no-]vector-stri

[clang] [llvm] [RISCV] Add -m[no-]scalar-strict-align and -m[no-]vector-strict-align. (PR #95024)

2024-06-12 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/95024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add -m[no-]scalar-strict-align and -m[no-]vector-strict-align. (PR #95024)

2024-06-12 Thread Craig Topper via cfe-commits
topperc wrote: Kito tells me gcc is now going to make -m[no-]strict-align apply to scalar and vector, but add separate options. Updated to that direction. The PRs for the doc updates have not been changed yet. https://github.com/llvm/llvm-project/pull/95024 ___

[clang] [Driver] Add winsysroot alias to the GNU driver (PR #94731)

2024-06-12 Thread via cfe-commits
https://github.com/Andarwinux updated https://github.com/llvm/llvm-project/pull/94731 >From f7f12f9b026c0c290456d403d59911734ba05b57 Mon Sep 17 00:00:00 2001 From: Andarwinux <144242044+andarwi...@users.noreply.github.com> Date: Fri, 7 Jun 2024 07:07:40 + Subject: [PATCH] [Driver] Add winsys

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Alexis Perry-Holby via cfe-commits
https://github.com/AlexisPerry updated https://github.com/llvm/llvm-project/pull/95043 >From 2312d31b14aecc6eeea2e81d221ee004e5de3efc Mon Sep 17 00:00:00 2001 From: Alexis Perry-Holby Date: Thu, 6 Jun 2024 14:02:52 -0600 Subject: [PATCH 1/5] [flang] Add basic -mtune support --- clang/include/

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Alexis Perry-Holby via cfe-commits
AlexisPerry wrote: Thank you for the catch! Yes, the CPU-NOT line was missing. I have rectified this. https://github.com/llvm/llvm-project/pull/95043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Alexis Perry-Holby via cfe-commits
AlexisPerry wrote: Those are great suggestions, thank you. I have made the appropriate updates. https://github.com/llvm/llvm-project/pull/95043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Tarun Prabhu via cfe-commits
@@ -371,7 +371,7 @@ static mlir::LogicalResult convertFortranSourceToMLIR( ctx, semanticsContext, defKinds, semanticsContext.intrinsics(), semanticsContext.targetCharacteristics(), parsing.allCooked(), targetTriple, kindMap, loweringOptions, envDefaults, -

[clang] [clang-tools-extra] [Clang] Implement CWG2813: Class member access with prvalues (PR #95112)

2024-06-12 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/95112 >From e53dfbc9b2c6b7f30c1378731d7de284fa99d568 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Tue, 11 Jun 2024 14:26:38 +0100 Subject: [PATCH 1/3] [Clang] Implement CWG2813 --- clang/docs/ReleaseNotes.rst

[clang] [NFC] use appropriate castas (PR #95272)

2024-06-12 Thread via cfe-commits
https://github.com/mahesh-attarde created https://github.com/llvm/llvm-project/pull/95272 NFC fix for appropriate function call. Requested by aaron while discussing https://github.com/llvm/llvm-project/pull/95257 https://github.com/llvm/llvm-project/pull/95257 >From 4baa0826b1aede21d0fc0e4f90

[clang] [NFC] use appropriate castas (PR #95272)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (mahesh-attarde) Changes NFC fix for appropriate function call. Requested by aaron while discussing https://github.com/llvm/llvm-project/pull/95257 https://github.com/llvm/llvm-project/pull/95257 --- Full diff: https://githu

[clang] [NFC] use appropriate castas (PR #95272)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (mahesh-attarde) Changes NFC fix for appropriate function call. Requested by aaron while discussing https://github.com/llvm/llvm-project/pull/95257 https://github.com/llvm/llvm-project/pull/95257 --- Full diff: https://github.

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-12 Thread Tobias Gysi via cfe-commits
@@ -1796,6 +1797,10 @@ void ModuleImport::processFunctionAttributes(llvm::Function *func, attr.isStringAttribute()) funcOp.setTargetCpuAttr(StringAttr::get(context, attr.getValueAsString())); + if (llvm::Attribute attr = func->getFnAttribute("tune-cpu"); + att

[clang] buffer rsrc builtin (PR #95276)

2024-06-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/95276 - **[Clang][AMDGPU] Add a new builtin type for buffer rsrc** - **[Clang][AMDGPU] Add a builtin for `llvm.amdgcn.make.buffer.rsrc` intrinsic** >From 1b06131a10e1f8067961624b02bba3354d5057c0 Mon Sep 17 00:00:00 2

[clang] buffer rsrc builtin (PR #95276)

2024-06-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang @llvm/pr-subscribers-debuginfo Author: Shilei Tian (shiltian) Changes - **[Clang][AMDGPU] Add a new builtin type for buffer rsrc** - **[Clang][AMDGPU] Add a builtin for `llvm.amdgcn.make.buffer.rsrc` intrinsic**

<    1   2   3   4   5   >