================

----------------
tarunprabhu wrote:

Why do you have the first `target-cpu` check on its own? Is it intended to 
check for the _absence_ of the `tune-cpu` attribute when `target-cpu` is 
provided on the command line? If so, there should be a `CPU-NOT` annotation as 
well. Otherwise, it is odd to test for `target-cpu` when this file is intended 
to test `tune-cpu`. 

The third test which checks the case when both `target -cpu` and `tune-cpu` are 
provided is good.

https://github.com/llvm/llvm-project/pull/95043
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to