[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan created this revision. zyounan added reviewers: sammccall, nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[clang] 779353e - [Driver] Improve legibility of ld -z options on Solaris

Author: Rainer Orth Date: 2023-08-28T09:25:47+02:00 New Revision: 779353e576eaa6ababdfc242784484f3656ecfe0 URL: https://github.com/llvm/llvm-project/commit/779353e576eaa6ababdfc242784484f3656ecfe0 DIFF: https://github.com/llvm/llvm-project/commit/779353e576eaa6ababdfc242784484f3656ecfe0.diff L

[PATCH] D158955: [Driver] Improve legibility of ld -z options on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG779353e576ea: [Driver] Improve legibility of ld -z options on Solaris (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] ab090e9 - [include-cleaner] Make handling of enum constants similar to members

Author: Kadir Cetinkaya Date: 2023-08-28T09:31:58+02:00 New Revision: ab090e9e49ff85d031a263abf327e9e436ce3873 URL: https://github.com/llvm/llvm-project/commit/ab090e9e49ff85d031a263abf327e9e436ce3873 DIFF: https://github.com/llvm/llvm-project/commit/ab090e9e49ff85d031a263abf327e9e436ce3873.dif

[PATCH] D158515: [include-cleaner] Make handling of enum constants similar to members

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rGab090e9e49ff: [include-cleaner] Make handling of enum constants similar to members (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D158968: [analyzer] Fix assertion on casting SVal to NonLoc inside the IteratorRange checker

steakhal created this revision. steakhal added reviewers: NoQ, donat.nagy, xazax.hun, Szelethus. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revision. Herald

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked 3 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/AST/ASTLambda.h:45 + return isLambdaCallOperator(DC) && + !cast(DC)->getType().isNull() && + !cast(DC)->isExplicitObjectMemberFunction(); e

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

cor3ntin added a comment. Still missing a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158808/new/ https://reviews.llvm.org/D158808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

mboehme accepted this revision. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:113 + // Don't do anything special for CXXForRangeStmt, because the condition (being + // implicitly generated) isn't visible from the loo

[PATCH] D158855: [analyzer][NFC] Remove useless class BuiltinBug

donat.nagy marked an inline comment as done. donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp:27 class BoolAssignmentChecker : public Checker< check::Bind > { -mutable std::unique_ptr BT; +mutable std::unique_ptr

[PATCH] D158968: [analyzer] Fix assertion on casting SVal to NonLoc inside the IteratorRange checker

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM. I'm not familiar with the Iterator checker family, but this is a very straightforward change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:841 const auto *ParamTy = - Method->getParamDecl(0)->getType()->getAs(); + Method->getNonObjectParameter(0)->getType()->getAs(); if (!ParamTy || ParamTy->getPointeeType().isConst

[clang] 7590b76 - Revert "[clang-format] Annotate constructor/destructor names"

Author: Kadir Cetinkaya Date: 2023-08-28T10:31:07+02:00 New Revision: 7590b7657004b33b1a12b05f8e9174db3e192f8c URL: https://github.com/llvm/llvm-project/commit/7590b7657004b33b1a12b05f8e9174db3e192f8c DIFF: https://github.com/llvm/llvm-project/commit/7590b7657004b33b1a12b05f8e9174db3e192f8c.dif

[PATCH] D158967: [clangd] Record the stack bottom before building AST

ilya-biryukov added a comment. Would it be better to do this in the code that runs the parser? This should help not only Clangd, but all the tools as well. `clang::ParseAST` or `ASTFrontendAction::ExecuteAction` look like good candidates to me. Repository: rG LLVM Github Monorepo CHANGES SI

[clang] b32aa72 - Recommit [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

Author: Chuanqi Xu Date: 2023-08-28T17:07:30+08:00 New Revision: b32aa72afc1d6a094fde6ca04d8a1124af34a2ad URL: https://github.com/llvm/llvm-project/commit/b32aa72afc1d6a094fde6ca04d8a1124af34a2ad DIFF: https://github.com/llvm/llvm-project/commit/b32aa72afc1d6a094fde6ca04d8a1124af34a2ad.diff LO

[clang] 5ade434 - [clang] Fix assertion fail when function has cleanups and fatal errors

Author: Podchishchaeva, Mariya Date: 2023-08-28T02:25:57-07:00 New Revision: 5ade434a7e74f44d59a3863ddaf4762c97e1181b URL: https://github.com/llvm/llvm-project/commit/5ade434a7e74f44d59a3863ddaf4762c97e1181b DIFF: https://github.com/llvm/llvm-project/commit/5ade434a7e74f44d59a3863ddaf4762c97e11

[PATCH] D158827: [clang] Fix assertion fail when function has cleanups and fatal errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ade434a7e74: [clang] Fix assertion fail when function has cleanups and fatal errors (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D158827?vs=553420&id=553872#toc Repositor

[PATCH] D158855: [analyzer][NFC] Remove useless class BuiltinBug

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I haven't checked the details, but it makes sense. It's reassuring that all the tests pass :D, which is good enough for me. Thanks for the cleanup! Repository: rG LLVM Github Monorepo

[clang] 985e399 - [analyzer] Fix assertion on casting SVal to NonLoc inside the IteratorRange checker

Author: Balazs Benics Date: 2023-08-28T12:02:48+02:00 New Revision: 985e399647d591d6130ba6fe08c5b5f6cb87d9f6 URL: https://github.com/llvm/llvm-project/commit/985e399647d591d6130ba6fe08c5b5f6cb87d9f6 DIFF: https://github.com/llvm/llvm-project/commit/985e399647d591d6130ba6fe08c5b5f6cb87d9f6.diff

[PATCH] D158968: [analyzer] Fix assertion on casting SVal to NonLoc inside the IteratorRange checker

This revision was automatically updated to reflect the committed changes. Closed by commit rG985e399647d5: [analyzer] Fix assertion on casting SVal to NonLoc inside the IteratorRange… (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D158968?vs=553858&id=553879#toc Repo

[PATCH] D158968: [analyzer] Fix assertion on casting SVal to NonLoc inside the IteratorRange checker

steakhal added a comment. In D158968#4620721 , @donat.nagy wrote: > LGTM. I'm not familiar with the Iterator checker family, but this is a very > straightforward change. Thanks for the review! Well, it's an Ericsson checker ;) Repository: rG LLVM G

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

eddyz87 added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:2432 ImmArg>]>; +def int_context_marker_bpf : DefaultAttrsIntrinsic<[llvm_ptr_ty], + [llvm_ptr_ty], -

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

mstorsjo added a comment. This new test is failing on Windows, due to `__kmpc_set_thread_limit` not being exported - see e.g. https://github.com/mstorsjo/llvm-mingw/actions/runs/5994183421/job/16264501555. Can someone add it to `openmp/runtime/src/dllexports`? Repository: rG LLVM Github Mon

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a comment. > `clang::ParseAST` or `ASTFrontendAction::ExecuteAction` look like good > candidates to me. We had already placed the initialization in ASTFrontendAction::ExecuteAction

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. Thanks for the updates! I didn't spot any important issue, so I'm accepting this commit, but let's wait for the opinion of @steakhal before merging this. In D158707#4613955

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/test/CodeGenCXX/cxx2b-deducing-this.cpp:4 + +struct TrivialStruct { +void explicit_object_function(this TrivialStruct) {} cor3ntin wrote: > aaron.ballman wrote: > > I'd like to see more codegen tests in genera

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 added a comment. Hi @MaskRay , thank you for reviewing this patch last time. Is it possible to review updated this patch again? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813

[PATCH] D158977: [clang][dataflow] Don't associate prvalue expressions with storage locations.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead, map prvalue expressions directly to val

[clang] aebe312 - Silence a "not all control paths return a value" warning; NFC

Author: Aaron Ballman Date: 2023-08-28T07:52:47-04:00 New Revision: aebe312c03a686af397c5e572e1ac9f325624734 URL: https://github.com/llvm/llvm-project/commit/aebe312c03a686af397c5e572e1ac9f325624734 DIFF: https://github.com/llvm/llvm-project/commit/aebe312c03a686af397c5e572e1ac9f325624734.diff

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 43ca99a - Silence an illegal conversion warning in MSVC; NFC

Author: Aaron Ballman Date: 2023-08-28T08:06:03-04:00 New Revision: 43ca99a2516f107847271652a9be2cc694f1e6e5 URL: https://github.com/llvm/llvm-project/commit/43ca99a2516f107847271652a9be2cc694f1e6e5 DIFF: https://github.com/llvm/llvm-project/commit/43ca99a2516f107847271652a9be2cc694f1e6e5.diff

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

aaron.ballman added a comment. In D112921#4620399 , @wangpc wrote: > Gentle ping. Can I move forward and land this? What name and email address would you like us to use for patch attribution? @ldionne do you have any remaining concerns (I think all the

[PATCH] D158967: [clangd] Record the stack bottom before building AST

ilya-biryukov added a comment. In D158967#4620931 , @zyounan wrote: > We had already placed the initialization in ASTFrontendAction::ExecuteAction >

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. In D112921#4621019 , @aaron.ballman wrote: > In D112921#4620399 , @wangpc wrote: > >> Gentle ping. Can I move forward and land this? > > What name and email address would you like us to us

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

aaron.ballman added a comment. In D112921#4621039 , @wangpc wrote: > In D112921#4621019 , @aaron.ballman > wrote: > >> In D112921#4620399 , @wangpc wrote: >> >>> Gentle p

[PATCH] D158981: [clang][dataflow][NFC] Eliminate `getStorageLocation()` / `setStorageLocation()` in `DataflowAnalysisContext`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead, inline them into the `getStableStorageL

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff updated this revision to Diff 553908. sepavloff added a comment. Herald added a subscriber: sunshaoce. Use representation of logical vectors similar to OpenCL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/ https://reviews.llvm.

[PATCH] D158855: [analyzer][NFC] Remove useless class BuiltinBug

This revision was automatically updated to reflect the committed changes. donat.nagy marked an inline comment as done. Closed by commit rG8a5cfdf7851d: [analyzer][NFC] Remove useless class BuiltinBug (authored by donat.nagy). Changed prior to commit: https://reviews.llvm.org/D158855?vs=553498&i

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff added a comment. In D153339#4489025 , @aaron.ballman wrote: > This seems reasonable to me, but I do wonder if changing the return type from > int to bool will cause surprises for anyone. I see why it's done, but this > seems more like a C int

[clang] 8a5cfdf - [analyzer][NFC] Remove useless class BuiltinBug

Author: Donát Nagy Date: 2023-08-28T15:20:14+02:00 New Revision: 8a5cfdf7851dcdb4e16c510b133d7d0e79e43fc4 URL: https://github.com/llvm/llvm-project/commit/8a5cfdf7851dcdb4e16c510b133d7d0e79e43fc4 DIFF: https://github.com/llvm/llvm-project/commit/8a5cfdf7851dcdb4e16c510b133d7d0e79e43fc4.diff LO

[PATCH] D158824: [RISCV][MC] MC layer support for xcvmem and xcvelw extensions

liaolucy updated this revision to Diff 553911. liaolucy added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments from Jim, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158824/new/ https://rev

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal added a comment. Oh, so we would canonicalize towards a signed extent type. I see. I think I'm okay with that. However, I think this needs a little bit of polishing and testing when the region does not point to the beginning of an array or object, but rather inside an object, or like t

[PATCH] D158135: [Clang][CodeGen] Add __builtin_bcopy

cseo added a comment. FWIW, the pre-merge checks failed due to a problem with git-clang-format, not the tests themselves (they are all green). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158135/new/ https://reviews.llvm.org/D158135

[PATCH] D158985: [AST] Fix crash in evaluation of OpaqueExpr in Clangd

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added projects: clang, clang-tools-extra. The cod

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

aaron.ballman added a comment. In D158709#4617783 , @iana wrote: > In D158709#4617295 , @aaron.ballman > wrote: > >> I'm a bit concerned about the impact on (non-modules) build time >> performance. This splits s

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

HazardyKnusperkeks added a subscriber: kadircet. HazardyKnusperkeks added a comment. @kadircet shouldn't you at least say why it got reverted? Even better state your problem and give a chance to fix before you revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

donat.nagy added a comment. In D158707#4621135 , @steakhal wrote: > Oh, so we would canonicalize towards a signed extent type. I see. I think I'm > okay with that. > However, I think this needs a little bit of polishing and testing when the > region doe

[PATCH] D158990: [NFC][Clang] Remove unused function `CodeGenModule::addDefaultFunctionDefinitionAttributes`

jmmartinez created this revision. Herald added a project: All. jmmartinez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158990 Files: clang/lib/CodeGen/CGCall.cpp clang

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

ymandel updated this revision to Diff 553929. ymandel marked 2 inline comments as done. ymandel added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158848/new/ https://reviews.llvm.org/D158848 Files: clang/lib/

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1631 + const AnalysisOutputs &) { +EXPECT_THAT(Results.keys(), UnorderedElementsAre("after_loop")); + }); mboehme wrote: > I

[PATCH] D158991: [NFC][Clang] Add missing & to function argument

jmmartinez created this revision. Herald added a project: All. jmmartinez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158991 Files: clang/lib/CodeGen/CGCall.cpp Index

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

kadircet added a comment. In D157963#4621206 , @HazardyKnusperkeks wrote: > @kadircet shouldn't you at least say why it got reverted? Even better state > your problem and give a chance to fix before you revert? Hi, https://reviews.llvm.org/rG7590b76570

[PATCH] D158981: [clang][dataflow][NFC] Eliminate `getStorageLocation()` / `setStorageLocation()` in `DataflowAnalysisContext`.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. I love this! (specifically, that it simplifies the API surface) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158981/new/ https://reviews.llvm

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a subscriber: rsmith. zyounan added a comment. Thanks for the reply. And I understand (and agree with) the point that it's better to solve this problem once and for all. > Currently the code in CompilerInstance::ExecuteAction seems to acknowledge > that there should be a fallback.

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal added a comment. In D158707#4621270 , @donat.nagy wrote: > In D158707#4621135 , @steakhal > wrote: > >> Oh, so we would canonicalize towards a signed extent type. I see. I think >> I'm okay with that.

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a CI job for Clang on Windows that is separate from the monolithic job that gets added automatically via the

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne added a subscriber: aaron.ballman. ldionne added a comment. @aaron.ballman for awareness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 ___ cfe-commits

[clang-tools-extra] d703dcd - [AST] Fix crash in evaluation of OpaqueExpr in Clangd

Author: Ilya Biryukov Date: 2023-08-28T17:10:44+02:00 New Revision: d703dcdfb08dbd591589a12e0ca0852c5fd30a72 URL: https://github.com/llvm/llvm-project/commit/d703dcdfb08dbd591589a12e0ca0852c5fd30a72 DIFF: https://github.com/llvm/llvm-project/commit/d703dcdfb08dbd591589a12e0ca0852c5fd30a72.diff

[PATCH] D158985: [AST] Fix crash in evaluation of OpaqueExpr in Clangd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd703dcdfb08d: [AST] Fix crash in evaluation of OpaqueExpr in Clangd (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

donat.nagy added a comment. Yes, adding tests that demonstrate the current behavior is a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158707/new/ https://reviews.llvm.org/D158707 ___ cfe-comm

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a comment. > According to documentation of noteBottomOfStack, those should be tied to > thread creation, i.e. main and AsyncTaskRunner are two most common entry > points for threads that do parsing. Yeah, I was about to put this call there. But they both boil down to the single `

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added a comment. Just a few more nits. I think it's looking fine but I haven't tested it. Anyone else? Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:406 + // pass on -mllvm options to the clang + for (const opt::Arg *Arg : Args.filtered(OPT_ml

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

MasterCopy8GB added a comment. Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could you please commit these changes for me? Thank you for all of your time and effort! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 _

[PATCH] D158247: [CUDA][HIP] Fix overloading resolution in global variable initializer

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158247/new/ https://reviews.llvm.org/D158247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

zequanwu created this revision. zequanwu added reviewers: ellis, aeubanks. Herald added subscribers: Enna1, ormris. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Fixed the issue

[PATCH] D158071: [clang] Remove rdar links; NFC

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks like @NoQ wetted the remaining code changes. The rest LGTM. Thank you for preparing the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

ymandel updated this revision to Diff 553958. ymandel added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158848/new/ https://reviews.llvm.org/D158848 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff updated this revision to Diff 553960. sepavloff added a comment. Fix documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/ https://reviews.llvm.org/D153339 Files: clang/docs/LanguageExtensions.rst clang/lib/Sema/Sem

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

aaron.ballman added a comment. In D158995#4621441 , @ldionne wrote: > @aaron.ballman for awareness Thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D1

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

FlashSheridan added a comment. A couple of low-priority suggestions from Pylint 3 at 326 and 95: Comment at: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py:95 -def start_workers(max_tasks, tidy_caller, task_queue, lock, timeout): +def start_workers(max_tasks, tidy_calle

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 added a comment. Ping, Our customer fond problem I submit bug: in https://github.com/llvm/llvm-project/issues/65045 This issue related with big change of 5179eb78210a2ad01a18c37b75048ccfe78414ac Where internal linkage for inheriting ctor were set in change set at following code. Could s

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

enh added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1382 +return; +#if defined(__ANDROID__) + // ifunc resolvers don't have hwcaps in arguments on Android API lower srhines wrote: > MaskRay wrote: > > enh wrote: > > > ilinpv wrote: >

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 553964. bogner added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews.llvm.org/D158803 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Diagnosti

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. In D158071#4621631 , @zaks.anna wrote: > Looks like @NoQ wetted the remaining code changes. The rest LGTM. > > Thank you for preparing the patch! Thank you for the help with review (to both you and @NoQ)! I've landed the c

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

aeubanks added a comment. looks fine to me but I'll let ellis lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3008-3011 + void ActOnHLSLTopLevelFunction(FunctionDecl *FD); void CheckHLSLEntryPoint(FunctionDecl *FD); + void CheckHLSLSemanticAnnotation(FunctionDecl *EntryPoint, Decl *Param, +

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

aeubanks added a comment. I don't have all the context here, but seems fine once the commit description is updated with the new spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61670/new/ https://reviews.llvm.org/D61670

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. I Think this change makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158615/new/ https://reviews.llvm.org/D158615 ___

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

ellis accepted this revision. ellis added a comment. This revision is now accepted and ready to land. Thanks for adding the test case! Can you also link the original diff in the summary? Comment at: compiler-rt/test/profile/instrprof-merge-empty-data.test:1 +// Test +// RUN:

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 553968. ldionne added a comment. Run script through bash on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. + llvm::report

[clang] d4a9121 - Reland "[clang][modules] Use relative offsets for input files"

Author: Jan Svoboda Date: 2023-08-28T09:54:39-07:00 New Revision: d4a912153488308ea9ab96a0267150460cdfc697 URL: https://github.com/llvm/llvm-project/commit/d4a912153488308ea9ab96a0267150460cdfc697 DIFF: https://github.com/llvm/llvm-project/commit/d4a912153488308ea9ab96a0267150460cdfc697.diff L

[clang] 6fb08d8 - Reland "[clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file"

Author: Jan Svoboda Date: 2023-08-28T09:54:39-07:00 New Revision: 6fb08d8f558a6f28db7835acdb88cab83aea2eb4 URL: https://github.com/llvm/llvm-project/commit/6fb08d8f558a6f28db7835acdb88cab83aea2eb4 DIFF: https://github.com/llvm/llvm-project/commit/6fb08d8f558a6f28db7835acdb88cab83aea2eb4.diff L

[clang] b9b81e3 - [clang][modules] NFC: Use local instead of `ModuleFile` member

Author: Jan Svoboda Date: 2023-08-28T09:54:39-07:00 New Revision: b9b81e37fe63d661afa356eacc97208ccc85da29 URL: https://github.com/llvm/llvm-project/commit/b9b81e37fe63d661afa356eacc97208ccc85da29 DIFF: https://github.com/llvm/llvm-project/commit/b9b81e37fe63d661afa356eacc97208ccc85da29.diff L

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

ldionne accepted this revision. ldionne added a comment. Sorry for missing a couple of direct pings. I have no concerns with the patch, perhaps I should not have marked my review as blocking in the first place. Thanks for doing this work, it's about time we updated this default! Repository:

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4617504 , @aaron.ballman wrote: > In D157572#4614561 , @cjdb wrote: > >> In D157572#4613622 , >> @aaron.ballman wrote: >> >>> In D157572

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe added a comment. @PiotrZSL, I think that this is quite an important fix since without it the check completely mangles the code. Should it be put in the 17.x release branch too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156616/new/ h

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL added a comment. In D158787#4621587 , @MasterCopy8GB wrote: > Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could > you please commit these changes for me? Thank you for all of your time and > effort! Under which use

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

MasterCopy8GB added a comment. In D158787#4621915 , @PiotrZSL wrote: > In D158787#4621587 , @MasterCopy8GB > wrote: > >> Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. >> Could you pleas

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. Started a thread: https://discourse.llvm.org/t/exposing-the-diagnostic-engine-to-c/73092 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157572/new/ https://reviews.llvm.org/D157572

[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

MaskRay added a comment. Ping:) This is probably a good candidate for `release/17.x` backporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158688/new/ https://reviews.llvm.org/D158688 ___ cfe-commit

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

rnk added a comment. It took me a while to find this code to understand the issue. The problem is that there is an inconsistency between the GVA linkage and the LLVM IR linkage for these constructors. In this godbolt example , `??0?$TInputDataVertexModel..`

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. In D156616#4621914 , @mikecrowe wrote: > @PiotrZSL, I think that this is quite an important fix since without it the > check completely mangles th

[clang] d809920 - Reland "[Profile] Allow online merging with debug info correlation."

Author: Zequan Wu Date: 2023-08-28T13:32:55-04:00 New Revision: d80992032fd0d7da70b2bd1a59066703c3c21fbb URL: https://github.com/llvm/llvm-project/commit/d80992032fd0d7da70b2bd1a59066703c3c21fbb DIFF: https://github.com/llvm/llvm-project/commit/d80992032fd0d7da70b2bd1a59066703c3c21fbb.diff LOG

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rGd80992032fd0: Reland "[Profile] Allow online merging with debug info correlation." (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector &Features) { + // Defaults. + bool EnableVPU = true;

[clang] 824b136 - [clang][dataflow] Support range-for loops in fixpoint algorithm.

Author: Yitzhak Mandelbaum Date: 2023-08-28T17:35:34Z New Revision: 824b136591303a2bec62cc752ec89843fbbc0ca0 URL: https://github.com/llvm/llvm-project/commit/824b136591303a2bec62cc752ec89843fbbc0ca0 DIFF: https://github.com/llvm/llvm-project/commit/824b136591303a2bec62cc752ec89843fbbc0ca0.diff

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

This revision was automatically updated to reflect the committed changes. Closed by commit rG824b13659130: [clang][dataflow] Support range-for loops in fixpoint algorithm. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158848/ne

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe added a comment. In D156616#4621945 , @PiotrZSL wrote: > In D156616#4621914 , @mikecrowe > wrote: > >> @PiotrZSL, I think that this is quite an important fix since without it the >> check completely ma

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

MaskRay added a comment. > [VE][Clang] Change to enable VPU flag by default For components like llvm/, clang/, we usually use a more specific tag. I'd pick `[Driver]` over `[Clang]`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https

  1   2   3   >