donat.nagy marked an inline comment as done.
donat.nagy added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp:27
class BoolAssignmentChecker : public Checker< check::Bind > {
- mutable std::unique_ptr<BuiltinBug> BT;
+ mutable std::unique_ptr<BugType> BT;
void emitReport(ProgramStateRef state, CheckerContext &C,
----------------
xazax.hun wrote:
> In case you are down to some additional cleanup efforts, we no longer need
> lazy initialization for `BugType`s. This is an old pattern, we used to need
> it due to some initialization order problems, but those have been worked
> around in engine. See the FuchsiaHandleChecker as an example how we do it in
> newer checks:
> https://github.com/llvm/llvm-project/blob/ea82a822d990824c58c6fa4b503ca84c4870c940/clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp#L190
>
> Feel free to ignore this or do it in a follow-up PR.
Great news! I'll keep it in mind and I'll try to do this clean-up if I have
enough free time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158855/new/
https://reviews.llvm.org/D158855
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
