[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:722 +const_cast(cast(FD))); +// Captures are not checked from within the lambda. +LSI->AfterParameterList = false; shafik wrote: > This comment does not really explain to m

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13319 +Value *Features = Builder.CreateAlignedLoad( +Int32Ty, Builder.CreateGEP(ATy, CpuFeatures2, Idxs), +CharUnits::fromQuantity(4)); MaskRay wrote: > FreddyYe wrote

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13319 +Value *Features = Builder.CreateAlignedLoad( +Int32Ty, Builder.CreateGEP(ATy, CpuFeatures2, Idxs), +CharUnits::fromQuantity(4)); FreddyYe wrote: > MaskRay wrote:

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/Analysis/scopes-cfg-output.cpp:1473-1474 +// CHECK-NEXT:3: F f __attribute__((cleanup(cleanup_F))); +// CHECK-NEXT:4: [B1.3].~F() (Implicit destructor) +// CHECK-NEXT:5: Cl

[PATCH] D117929: [XRay] Add support for RISCV

MaskRay added a comment. > Context not available See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake:83 set(ALL_XRAY_SUPPORTED_ARCH ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS6

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. In D153114#4603579 , @sammccall wrote: > In D153114#4602414 , @ChuanqiXu > wrote: > >>> Don't attempt any cross-file or cross-version coordination: i.e. don't try >>> to reuse BMIs bet

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir updated this revision to Diff 552243. schittir added a comment. Fix errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 Files: clang/lib/AST/APValue.cpp clang/lib/CodeGen/CGDebugInfo.h clang/lib/Interpreter/Value.cpp Index

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir added a comment. @jplehr @michaelplatings @MitalAshok @tahonermann - sorry this one slipped through the cracks. I fixed the errors now. Thank you for your review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 __

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf added a comment. In D158066#4601785 , @nemanjai wrote: > It should be perfectly fine to provide pre-defined macros for these to match > GCC on PowerPC. The reason we went with the macro solution is to avoid > polluting the builtins namespace for o

[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

jacquesguan marked an inline comment as done. jacquesguan added inline comments. Comment at: clang/test/CodeGen/riscv-rvv-vla-arith-ops.c:90 +// +vfloat32m1_t add_f32(vfloat32m1_t a, vfloat32m1_t b) { + return a + b; Jim wrote: > Do we support operation for vflo

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail updated this revision to Diff 552251. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158487/new/ https://reviews.llvm.org/D158487 Files: clang/lib/Headers/altivec.h clang/test/CodeGen/PowerPC/builtins-ppc-vsx.c llvm/test/CodeGen/PowerPC/v

[PATCH] D157684: [clang][ASTImporter] Repeated friend templates are partially imported

danix800 added a comment. ping~ @balazske @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157684/new/ https://reviews.llvm.org/D157684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate added a comment. > Thanks @aaron.ballman for the detailed explanation! I have learnt it. > @lygstate maybe include Aaron's explanation in commit message? The commit message is updated, is that ready for merge? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https:

[PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy added a comment. Herald added a subscriber: sunshaoce. @bulbazord @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157497/new/ https://reviews.llvm.org/D157497 ___ cfe-commits mailing list

[PATCH] D157497: feat: Migrate isArch16Bit

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. This change looks strictly worse in isolation, the proposal on discourse did not reach consensus, and looking at the diagram in https://discourse

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

qiucf added inline comments. Comment at: clang/lib/Headers/altivec.h:14662 + vector unsigned char __res = + __builtin_shufflevector(__zero, __zero, -1, -1, -1, -1, -1, -1, -1, -1, + -1, -1, -1, -1, -1, -1, -1, -1); Could we just

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 552265. BeMg added a comment. Also remove the `-` operator from target attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Targets/RISCV.c

[PATCH] D158484: [PowerPC][altivec] Correct modulo number of vec_promote on vector char

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158484/new/ https://reviews.llvm.org/D158484

[PATCH] D158496: [WIP][clang][modules] module build daemon initial commit

cpsughrue created this revision. cpsughrue added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. cpsughrue requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Initial commit for module build daemon. The title will be up

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail added inline comments. Comment at: clang/lib/Headers/altivec.h:14662 + vector unsigned char __res = + __builtin_shufflevector(__zero, __zero, -1, -1, -1, -1, -1, -1, -1, -1, + -1, -1, -1, -1, -1, -1, -1, -1); qiucf wrote:

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail added inline comments. Comment at: clang/lib/Headers/altivec.h:14662 + vector unsigned char __res = + __builtin_shufflevector(__zero, __zero, -1, -1, -1, -1, -1, -1, -1, -1, + -1, -1, -1, -1, -1, -1, -1, -1); lkail wrote:

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158239/new/ https://reviews.llvm.org/D158239 ___ cfe

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158474/new/ https://reviews.llvm.org/D158474 ___ cf

[PATCH] D158426: [clangd] Bump timeouts for LSPServerTests

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:27 std::unique_lock Lock(Mu); - if (!clangd::wait(Lock, CV, timeoutSeconds(10), [this] { return Value.has_value(); })) { I think we're better of

[clang] 23459f1 - [Lex] Preambles should contain the global module fragment.

Author: Sam McCall Date: 2023-08-22T11:55:51+02:00 New Revision: 23459f13fcd9c424a41debb2d11eb56843d4e679 URL: https://github.com/llvm/llvm-project/commit/23459f13fcd9c424a41debb2d11eb56843d4e679 DIFF: https://github.com/llvm/llvm-project/commit/23459f13fcd9c424a41debb2d11eb56843d4e679.diff LO

[PATCH] D158439: [Lex] Preambles should contain the global module fragment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23459f13fcd9: [Lex] Preambles should contain the global module fragment. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] 31a8f84 - [clangd] Fix crash with sanitizers if blocking with no timeout

Author: Sam McCall Date: 2023-08-22T11:57:42+02:00 New Revision: 31a8f840f327694a6c74dac15702eeb85281c1e2 URL: https://github.com/llvm/llvm-project/commit/31a8f840f327694a6c74dac15702eeb85281c1e2 DIFF: https://github.com/llvm/llvm-project/commit/31a8f840f327694a6c74dac15702eeb85281c1e2.diff LO

[PATCH] D158426: [clangd] Bump timeouts for LSPServerTests

kadircet updated this revision to Diff 552284. kadircet marked 2 inline comments as done. kadircet added a comment. - Just bump the timeouts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158426/new/ https://reviews.llvm.org/D158426 Files: clang-

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t updated this revision to Diff 552281. d0nc1h0t added a comment. Added unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unitte

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t added a comment. In D158363#4604468 , @HazardyKnusperkeks wrote: > Please upload the patch with the full context. I'm creating a patch via 'git diff' from the root of the project. What does full context mean? Repository: rG LLVM Github Mon

[PATCH] D158499: [analyzer] Compute FAM dynamic size

danix800 created this revision. danix800 added a project: clang. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. danix800

[PATCH] D158499: [analyzer] Compute FAM dynamic size

danix800 updated this revision to Diff 552288. danix800 added a comment. Update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158499/new/ https://reviews.llvm.org/D158499 Files: clang/lib/StaticAnalyzer/Core/DynamicExtent.cpp clang/te

[clang] acc5db2 - [Thumb1] Do not allow Armv6-m XO and PI code

Author: Keith Walker Date: 2023-08-22T11:08:11+01:00 New Revision: acc5db2bedd50a66f156b63be8469271f7b19322 URL: https://github.com/llvm/llvm-project/commit/acc5db2bedd50a66f156b63be8469271f7b19322 DIFF: https://github.com/llvm/llvm-project/commit/acc5db2bedd50a66f156b63be8469271f7b19322.diff

[PATCH] D157620: [Thumb1] Do not allow Armv6-m XO and PI code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacc5db2bedd5: [Thumb1] Do not allow Armv6-m XO and PI code (authored by keith.walker.arm). Herald added a project: clang. Herald added a subscriber:

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since we have visitAPValue now, we might as well use

[PATCH] D158499: [analyzer] Compute FAM dynamic size

steakhal added a comment. Thanks for submitting this. A funny thing is that in my free time I was also working on this last week. I'll have a look at this more in depth during the week. For the mean time here is my version, committed pretty much a couple days ago to my fork. https://github.com/l

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

hans added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TNO-OS

[PATCH] D158499: [analyzer] Compute FAM dynamic size

danix800 added a comment. In D158499#4606291 , @steakhal wrote: > Thanks for submitting this. > A funny thing is that in my free time I was also working on this last week. > I'll have a look at this more in depth during the week. > For the mean time here

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 552305. void added a comment. Fix a segfault. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/Attr.td

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 552307. massberg added a comment. Resolve some of the reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/ https://reviews.llvm.org/D155858 Files: clang/include/clang/AST/ASTConcep

[PATCH] D155858: Add a concept AST node.

massberg marked 13 inline comments as done. massberg added a comment. I have resolved some of the comments, but I need another round to finish all of the, Thanks to all reviewers so far! Comment at: clang/include/clang/AST/ExprConcepts.h:90 + // NOTE(massberg): For the first

[PATCH] D158505: [clang-format] Fix weird handling of AfterColon

HazardyKnusperkeks created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks requested review of this revision. This fixes https://github.com/llvm/llvm-project/issues/6

[PATCH] D158505: [clang-format] Fix weird handling of AfterColon

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7995 verifyFormat("Constructor(aa ,\n" - "aa ) :\n" - "aa(aaa

[PATCH] D155858: Add a concept AST node.

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6824-6836 + unsigned size = TL.getTypePtr()->getTypeConstraintArguments().size(); + TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size]; +

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

mboehme added a comment. Sorry for the late response -- I was on vacation. In D156658#4554347 , @xazax.hun wrote: > In D156658#4552965 , @mboehme wrote: > >> I've investigated this in more detail. Unfortunately,

[PATCH] D158499: [analyzer] Compute FAM dynamic size

steakhal added a comment. In D158499#4606337 , @danix800 wrote: > In D158499#4606291 , @steakhal > wrote: > >> Thanks for submitting this. >> A funny thing is that in my free time I was also working on this last

[PATCH] D155776: [NFC] Add checks for self-assignment.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D155858: Add a concept AST node.

sammccall added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6824-6836 + unsigned size = TL.getTypePtr()->getTypeConstraintArguments().size(); + TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size]; + TemplateSpecializationTypeLoc::initi

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. In D158254#4605050 , @hchilama wrote: > Hi @abhina.sreeskantharajan can I please know the next process on how to land > this revision to opensource? Usually you need to have someone with commit access commit the

[PATCH] D158426: [clangd] Bump timeouts for LSPServerTests

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:42 [this] { return Value.has_value(); })) { ADD_FAILURE() << "No result from

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 552318. void added a comment. Support when doing a _bdos on the full structure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2606-2607 enum { INIT, CONDVAR, COND, INC, BODY, END_EXPR }; - Stmt* SubExprs[END_EXPR]; // SubExprs[INIT] is an expression or declstmt. + Stmt *SubExprs[END_EXPR] = { + nullptr}; // SubExpr

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer

victorkingi created this revision. Herald added subscribers: abrachet, phosek, s.egerton, simoncook, asb, fedor.sergeev, dschuff. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer

kiranchandramohan added a comment. For our immediate purpose, I think changing the visibility in the Driver to include `flang` is sufficient. After that, we can spend time implementing this properly by refactoring the code to llvm. Comment at: llvm/include/llvm/Frontend/Drive

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer

awarzynski added a comment. > Temporary fix for unknown argument error '-fomit-frame-pointer' when running > flang tests I don't follow - there's quite a lot going on here. More than the summary suggests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5337-5346 + if (AL.isC11AlignasAttribute()) { +// Don't use the message with placement with _Alignas. +// This is because C doesnt let you use _Alignas on type declarations. +

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi added a comment. In D158507#4606498 , @awarzynski wrote: >> Temporary fix for unknown argument error '-fomit-frame-pointer' when running >> flang tests > > I don't follow - there's quite a lot going on here. More than the summary > suggests

[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

ilya-biryukov abandoned this revision. ilya-biryukov added a comment. Thanks for clarifying! I misread the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157708/new/ https://reviews.llvm.org/D157708 ___

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

aaron.ballman added a comment. In D157572#4604595 , @philnik wrote: > In D157572#4604482 , @aaron.ballman > wrote: > >>> This allows standard libraries to mark symbols as extensions, so the >>> compiler can gene

[PATCH] D157879: [clang] Report missing designated initializers in C++

aaron.ballman added a subscriber: jwakely. aaron.ballman added a comment. In D157879#4604288 , @phosek wrote: > Note that there's an ongoing discussion on the GCC bug > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96868 whether > `-Wmissing-field-initia

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

cor3ntin updated this revision to Diff 552329. cor3ntin added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158433/new/ https://reviews.llvm.org/D158433 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaConce

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552330. victorkingi added a comment. Minimalized patch to only have update to Options.td as well as tests accompanying the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi added inline comments. Comment at: clang/include/clang/Driver/Options.td:7236-7240 +def mframe_pointer_EQ : Joined<["-"], "mframe-pointer=">, + HelpText<"Specify which frame pointers to retain.">, Values<"all,non-leaf,none">, + NormalizedValuesScope<"CodeGenOptions

[PATCH] D157684: [clang][ASTImporter] Repeated friend templates are partially imported

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4072 + + if (auto *TSI = FD1->getFriendType()) +return Importer.IsStructurallyEquivalent( According to the coding rules `auto` should not be used here. Comment at: c

[PATCH] D157331: [clang] Implement C23

aaron.ballman added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#define __STDC_VERSION_STDCKDINT_H__ 202311L + I think this should only be defined when the function-like macros are being defined, so this should move down into the `#if` block

[clang] f740bcb - [AIX] supporting -X options for llvm-ranlib in AIX OS

Author: zhijian Date: 2023-08-22T09:41:33-04:00 New Revision: f740bcb3707a17ed4ccd52157089011a586cc2a6 URL: https://github.com/llvm/llvm-project/commit/f740bcb3707a17ed4ccd52157089011a586cc2a6 DIFF: https://github.com/llvm/llvm-project/commit/f740bcb3707a17ed4ccd52157089011a586cc2a6.diff LOG:

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

This revision was automatically updated to reflect the committed changes. Closed by commit rGf740bcb3707a: [AIX] supporting -X options for llvm-ranlib in AIX OS (authored by zhijian ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:767-772 + std::optional T = classify(E->getType()); + if (T && E->hasAPValueResult() && + this->visitAPValue(E->getAPValueResult(), *T, E)) +return true; + return this->delegate(E->

[PATCH] D158513: [clang][dataflow] Add two repros for non-convergence involving pointers in loops.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These are broken out from https://reviews.llvm.org/D156658, which it now seems

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

mboehme added a comment. I've broken out the tests into https://reviews.llvm.org/D158513, as it seems clear we want to get these submitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156658/new/ https://reviews.llvm.org/D156658 ___

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 552344. saiislam marked 5 inline comments as done. saiislam added a comment. Used CreateConstInBoundsGEP1_32 for emitting GEP statements. Changed lambda function to simple fucntion body for defining the global variable. Repository: rG LLVM Github Monorep

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Hmmm, so this is effectively making a per-declaration version of `-fmerge-all-constants`? (How does this interact with the `common` attribute, if at all?) Comment at: clang/include/clang/Basic/AttrDocs

[PATCH] D158515: [include-cleaner] Make handling of enum constants similar to members

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. We were treating enum constants more like regular decls, which results i

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna updated this revision to Diff 552347. Manna retitled this revision from "[NFC][CLANG] Fix potential dereferencing of null return values" to "[NFC][Clang] Fix static code analyzer concern about null value dereference". Manna added a comment. Herald added subscribers: manas, ASDenysPetrov, dk

[PATCH] D151567: [Support] Report EISDIR when opening a directory

azhan92 updated this revision to Diff 552353. azhan92 retitled this revision from "[Support] Report EISDIR when opening a directory " to "[Support] Report EISDIR when opening a directory". azhan92 added a comment. Add unit test to verify patch. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] 8c21544 - [clangd] Bump timeouts for LSPServerTests

Author: Kadir Cetinkaya Date: 2023-08-22T16:20:15+02:00 New Revision: 8c21544286a0cf5eba7df67e23e3b7265364e752 URL: https://github.com/llvm/llvm-project/commit/8c21544286a0cf5eba7df67e23e3b7265364e752 DIFF: https://github.com/llvm/llvm-project/commit/8c21544286a0cf5eba7df67e23e3b7265364e752.dif

[PATCH] D158426: [clangd] Bump timeouts for LSPServerTests

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c21544286a0: [clangd] Bump timeouts for LSPServerTests (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D158426?vs=552284&id=552354#toc Repository: rG LLVM Github Monorepo

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2009-2010 (Line.MightBeFunctionDecl || Line.InPPDirective) && - Current.NestingLevel == 0 && + Current.NestingLevel == 0 && Current.Previous &&

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 552356. MitalAshok added a comment. Use C's definition of type compatibility even in C++ mode (to not warn about enums promoted to their underlying types) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156054

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 552357. MitalAshok added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156054/new/ https://reviews.llvm.org/D156054 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ASTContext.cp

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

Manna added a comment. Thank you @aaron.ballman for reviews and feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158227/new/ https://reviews.llvm.org/D158227 ___ cfe-commits mailing list cfe-comm

[PATCH] D158516: [clang][Interp] Only lazily visit constant globals

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok marked an inline comment as done. MitalAshok added inline comments. Comment at: clang/test/SemaCXX/varargs.cpp:34 enum Unscoped1 { One = 0x7FFF }; - (void)__builtin_va_arg(ap, Unscoped1); // ok + (void)__builtin_va_arg(ap, Unscoped1); // expected-warning {{sec

[PATCH] D157684: [clang][ASTImporter] Repeated friend templates are partially imported

danix800 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4114 SmallVector ImportedEquivalentFriends; - - while (ImportedFriend) { -bool Match = false; -if (D->getFriendDecl() && ImportedFriend->getFriendDecl()) { - Match = - IsStructural

[PATCH] D158135: [Clang][CodeGen] Add __builtin_bcopy

cseo updated this revision to Diff 552370. cseo added a comment. Fix builtin definition and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158135/new/ https://reviews.llvm.org/D158135 Files: clang/include/clang/Basic/Builtins.def clang/li

[PATCH] D155776: [NFC] Add checks for self-assignment.

tahonermann accepted this revision. tahonermann added a comment. Thank you for following up, Sindhu! Looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___ cfe-commits mailing list cfe-commi

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

tahonermann added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2606-2607 enum { INIT, CONDVAR, COND, INC, BODY, END_EXPR }; - Stmt* SubExprs[END_EXPR]; // SubExprs[INIT] is an expression or declstmt. + Stmt *SubExprs[END_EXPR] = { + nullptr}; // SubExprs[

[PATCH] D157684: [clang][ASTImporter] Repeated friend templates are partially imported

danix800 updated this revision to Diff 552372. danix800 added a comment. 1. Rebase; 2. Replace `auto` with explicit type; 3. Use local var without interrupting `Importer` state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157684/new/ https://revi

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552375. victorkingi added a comment. Added m64 visibility to flang in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files: clang/include/clang/Driv

[PATCH] D157747: Support Unicode Microsoft predefined macros

aaron.ballman added a comment. In D157747#4581933 , @cor3ntin wrote: > This does not appear to be valid under MSVC and I don't think we should > support features that MS does not (Nor can i find any documentation that it > ought to work) > https://godbo

[PATCH] D158519: [clangd] Move diagnostics from modules to main sources file

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: adamcz, sammccall, kadircet. DmitryPolukhin added a project: clang. Herald added subscribers: arphaman, javed.absar. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added subscribers: MaskRay

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

schittir marked 2 inline comments as done. schittir added inline comments. Comment at: clang/include/clang/AST/Stmt.h:2606-2607 enum { INIT, CONDVAR, COND, INC, BODY, END_EXPR }; - Stmt* SubExprs[END_EXPR]; // SubExprs[INIT] is an expression or declstmt. + Stmt *SubExprs[END

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

schittir updated this revision to Diff 552380. schittir added a comment. Remove unnecessary initialization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158488/new/ https://reviews.llvm.org/D158488 Files: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp Index: llvm/lib/Frontend/OpenMP/OM

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552381. victorkingi added a comment. revert addition of m64 visibility in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files: clang/include/clang/

[PATCH] D155858: Add a concept AST node.

erichkeane added a comment. Hi! I was away on vacation, so I didn't get a chance to take a look at this. I'm currently digging my way through my 'back to work' tasks, but will keep this on my list of things to review ASAP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir marked an inline comment as done. schittir added a comment. Thank you for the review, @aaron.ballman and @tahonermann Investigating the build failure... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

tahonermann added inline comments. Comment at: clang/lib/AST/Interp/InterpBlock.cpp:94-95 DeadBlock::DeadBlock(DeadBlock *&Root, Block *Blk) -: Root(Root), B(Blk->Desc, Blk->IsStatic, Blk->IsExtern, /*isDead=*/true) { +: Root(Root), B(Blk->Desc, Blk->IsExtern, Blk->IsS

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

bgamari added a comment. Herald added a project: All. @nickdesaulniers, this appears to be missing the corresponding documentation in the LLVM language reference. As someone who maintains GHC 's LLVM backend, this documentation is invaluable. Repository: rG LLVM Gith

[PATCH] D158521: [Flang][Driver] Add visibility for Flang for m64 option

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a project: All. victorkingi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158521 Files:

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:934 // Return value of the runtime offloading call. - Value *Return; + Value *Return =

  1   2   3   >