sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:42
[this] { return Value.has_value(); })) {
ADD_FAILURE() << "No result from call after 10 seconds!";
return llvm::json::Value(nullptr);
----------------
nit: 60 here too
================
Comment at: clang-tools-extra/clangd/unittests/LSPClient.h:37
~CallResult();
- // Blocks up to 10 seconds for the result to be ready.
+ // Blocks up to \p TimeoutSeconds seconds for the result to be ready. If \p
+ // TimeoutSeconds is zero, blocks indefinitely.
----------------
revert comment?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158426/new/
https://reviews.llvm.org/D158426
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
