cor3ntin added inline comments.
================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:767-772 + std::optional<PrimType> T = classify(E->getType()); + if (T && E->hasAPValueResult() && + this->visitAPValue(E->getAPValueResult(), *T, E)) + return true; + return this->delegate(E->getSubExpr()); ---------------- so if `visitAPValue` fails, we continue. Couldn't that lead to duplicated diagnostics? Shouldn't we simply return whatever `visitAPValue` returns unconditionally? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158502/new/ https://reviews.llvm.org/D158502 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
