[PATCH] D156588: feat: Add support for Rocky Linux to LLVM Distro

zkkxu added a comment. nice ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156588/new/ https://reviews.llvm.org/D156588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D156648: [Tooling/Inclusion] Add std::range symbols in the mapping.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/64191 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156648

[clang] f444f39 - [clang][Interp] Implement __builtin_isfinite

Author: Timm Bäder Date: 2023-07-31T09:12:32+02:00 New Revision: f444f396863ceba0e0572a721d102fb48e8ca1b3 URL: https://github.com/llvm/llvm-project/commit/f444f396863ceba0e0572a721d102fb48e8ca1b3 DIFF: https://github.com/llvm/llvm-project/commit/f444f396863ceba0e0572a721d102fb48e8ca1b3.diff LO

[PATCH] D155372: [clang][Interp] Implement __builtin_isfinite

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf444f396863c: [clang][Interp] Implement __builtin_isfinite (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d37f1e9 - [clang][Interp] Implement __builtin_isnormal

Author: Timm Bäder Date: 2023-07-31T09:14:16+02:00 New Revision: d37f1e9965bd07bb8e05388aec0140addaf15e40 URL: https://github.com/llvm/llvm-project/commit/d37f1e9965bd07bb8e05388aec0140addaf15e40 DIFF: https://github.com/llvm/llvm-project/commit/d37f1e9965bd07bb8e05388aec0140addaf15e40.diff LO

[PATCH] D155374: [clang][Interp] Implement __builtin_isnormal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd37f1e9965bd: [clang][Interp] Implement __builtin_isnormal (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155374?vs=540

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149013/new/ https://reviews.llvm.org/D149013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155393/new/ https://reviews.llvm.org/D155393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155430: [clang][Interp] Implement __arithmethic_fence for floating types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155430/new/ https://reviews.llvm.org/D155430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156650: [clangd] Respect IWYU keep pragma for standard headers.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. see the issue https://github.com

[clang] 3f75d38 - [clang] Improve hermeticity of clang header tests.

Author: Simi Pallipurath Date: 2023-07-31T08:25:36+01:00 New Revision: 3f75d38a4d4d9e30d6ad1f805b225f1e073d21e0 URL: https://github.com/llvm/llvm-project/commit/3f75d38a4d4d9e30d6ad1f805b225f1e073d21e0 DIFF: https://github.com/llvm/llvm-project/commit/3f75d38a4d4d9e30d6ad1f805b225f1e073d21e0.di

[PATCH] D156427: [clang] Improve hermeticity of clang header tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f75d38a4d4d: [clang] Improve hermeticity of clang header tests. (authored by simpal01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

nridge added a comment. I'm not sure how I feel about dropping the parameters from the signature in the `CanBeCall = false` case. I can see arguments in both directions: - On the one hand, dropping the parameters makes the text that is inserted more consistent with the text that is shown for t

[clang] 063b37e - Reapply [IR] Mark and/or constant expressions as undesirable

Author: Nikita Popov Date: 2023-07-31T09:54:24+02:00 New Revision: 063b37e7b40ace03184923213bc9ead6aadee540 URL: https://github.com/llvm/llvm-project/commit/063b37e7b40ace03184923213bc9ead6aadee540 DIFF: https://github.com/llvm/llvm-project/commit/063b37e7b40ace03184923213bc9ead6aadee540.diff

[clang] e90f4fc - [clang][ExprConstant] Print template arguments when describing stack frame

Author: Takuya Shimizu Date: 2023-07-31T17:05:56+09:00 New Revision: e90f4fc6acaffd216e06e47df0aee6a8b5b2d4a9 URL: https://github.com/llvm/llvm-project/commit/e90f4fc6acaffd216e06e47df0aee6a8b5b2d4a9 DIFF: https://github.com/llvm/llvm-project/commit/e90f4fc6acaffd216e06e47df0aee6a8b5b2d4a9.diff

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe90f4fc6acaf: [clang][ExprConstant] Print template arguments when describing stack frame (authored by hazohelet). Repository: rG LLVM Github Monor

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:198 bool isSugaredTemplateParameter(QualType QT) { static auto PeelWrappers = [](QualType QT) { // Neither `PointerType` nor `ReferenceType` is considered as sugared nit: s

[PATCH] D156650: [clangd] Respect IWYU keep pragma for standard headers.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:85-86 if (PI) { if (PI->shouldKeep(Inc.HashLine + 1)) return false; // Check if main f

[PATCH] D156648: [Tooling/Inclusion] Add std::range symbols in the mapping.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. can you also create a cherry-pick request for this patch once it lands? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156648/new/ https://re

[PATCH] D156650: [clangd] Respect IWYU keep pragma for standard headers.

kadircet added a comment. also we should get this cherry-picked too. `keep` pragmas on includes are not common, but people do have export pragmas often enough to cause some annoyance here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156650/new/

[PATCH] D156655: [clang-format] Handle goto labels preceded by C++11 attributes

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Fixes https://github.com/llvm/llvm-project/issues/64229. Reposito

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler updated this revision to Diff 545551. ckandeler added a comment. Addressed another review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files: clang-tools-extra/clangd/unittests/XRe

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. > I agree this is a bug in libc++ and we should fix it. As mentioned I'm not > too familiar with ranges. Thanks! I submitted https://github.com/llvm/llvm-project/issues/64250 so we don't forget about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The only entries in `ExprToLoc` that will be rea

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

mboehme added a comment. Retracting from review momentarily -- I've just realized that I should be comparing values the same way this is done for the `LocToVal` map. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156658/new/ https://reviews.llvm.or

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

mboehme updated this revision to Diff 545561. mboehme added a comment. Make check for `Value` equivalence consistent with the corresponding check for `LocToVal`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156658/new/ https://reviews.llvm.org/D15

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ilya-biryukov abandoned this revision. ilya-biryukov added a comment. Marking the revision as abandoned to reflect the status of the RFC. Thanks everyone for your feedback and sorry about the timing of this change again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D156660: [CodeGen] Assert that EmittedDeferredDecls is empty

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, junaire, rjmccall. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Its contents are transferred into `DeferredDecls` in `Release()

[PATCH] D156660: [CodeGen] Assert that EmittedDeferredDecls is empty

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156660/new/ https://reviews.llvm.org/D156660 __

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

mboehme updated this revision to Diff 545571. mboehme added a comment. Use `dyn_cast_or_null` instead of `dyn_cast`. (Children can be null.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156658/new/ https://reviews.llvm.org/D156658 Files: clang/

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. In D156363#4545474 , @MaskRay wrote: > In D156363#4545215 , @dyung wrote: > >> If you cannot reproduce this issue, I can take my buildbot offline and try >> to reproduce it to pinpoint whic

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

hazohelet added a comment. Thanks everyone for the comments! Comment at: clang/test/Lexer/cxx1z-trigraphs.cpp:24 // expected-error@11 {{}} expected-warning@11 {{trigraph ignored}} -// expected-error@13 {{failed}} expected-warning@13 {{trigraph ignored}} expected-note@13 {{eva

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2862-2866 + bool ShouldAddRedecl = !(IsFriendTemplate && IsDependentContext); + // We may already have a record of the same name; try to find and match it. RecordDecl *PrevDecl = nullptr; if (!DC-

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

hazohelet updated this revision to Diff 545582. hazohelet added a comment. Address review comments - Print the character representation only when the type of the expressions is `char` or `char8_t` - Use `pushEscapedString` in the printing so that we can reuse its escaping logic - Use `escapeCSt

[clang] 171868d - [Tooling/Inclusion] Add std::range symbols in the mapping.

Author: Haojian Wu Date: 2023-07-31T13:05:47+02:00 New Revision: 171868dc2cd60c6e3eaeb3861b18ba0e22461291 URL: https://github.com/llvm/llvm-project/commit/171868dc2cd60c6e3eaeb3861b18ba0e22461291 DIFF: https://github.com/llvm/llvm-project/commit/171868dc2cd60c6e3eaeb3861b18ba0e22461291.diff LO

[PATCH] D156648: [Tooling/Inclusion] Add std::range symbols in the mapping.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG171868dc2cd6: [Tooling/Inclusion] Add std::range symbols in the mapping. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156650: [clangd] Respect IWYU keep pragma for standard headers.

hokein updated this revision to Diff 545589. hokein marked an inline comment as done. hokein added a comment. address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156650/new/ https://reviews.llvm.org/D156650 Files: clang-tools-ex

[clang-tools-extra] dcb2824 - [clangd] Respect IWYU keep pragma for standard headers.

Author: Haojian Wu Date: 2023-07-31T13:21:54+02:00 New Revision: dcb28244faa88cb566a852533790bcac75daaa0f URL: https://github.com/llvm/llvm-project/commit/dcb28244faa88cb566a852533790bcac75daaa0f DIFF: https://github.com/llvm/llvm-project/commit/dcb28244faa88cb566a852533790bcac75daaa0f.diff LO

[PATCH] D156650: [clangd] Respect IWYU keep pragma for standard headers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb28244faa8: [clangd] Respect IWYU keep pragma for standard headers. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 5ea647d - [CodeGen] Assert that EmittedDeferredDecls is empty

Author: Jonas Hahnfeld Date: 2023-07-31T13:40:00+02:00 New Revision: 5ea647dea6355304b641bf7bc407db497c6d9d21 URL: https://github.com/llvm/llvm-project/commit/5ea647dea6355304b641bf7bc407db497c6d9d21 DIFF: https://github.com/llvm/llvm-project/commit/5ea647dea6355304b641bf7bc407db497c6d9d21.diff

[PATCH] D156660: [CodeGen] Assert that EmittedDeferredDecls is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea647dea635: [CodeGen] Assert that EmittedDeferredDecls is empty (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156660/new/ https://

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 545594. jp4a50 added a comment. Refactor DisallowLineBreaksOnThisLine lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:838-858 + if (UseUCN) +OutStream << "\\u" + << llvm::format_hex_no_prefix(CodepointValue, /*Width=*/4, +/*Upper=*/false); +

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 marked 3 inline comments as done. jp4a50 added a comment. All comments addressed. PTAL and let me know if there are any other blockers for merge. Comment at: clang/lib/Format/ContinuationIndenter.cpp:664-666 +if ((Style.Language == FormatStyle::LK_Cpp || + S

[PATCH] D156672: [clang][dataflow] Use `Strict` accessors where we weren't using them yet.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This eliminates all uses of the deprecated acces

[PATCH] D156673: [clang][dataflow] Remove deprecated accessors as well as `SkipPast`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D156672

[PATCH] D156674: [clang][dataflow] Remove `Strict` suffix from accessors.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the time being, we're keeping the `Strict` v

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:63 + bool shouldKeep(unsigned HashLineNumber) const; + bool shouldKeep(const FileEntry *FE) const; Why wouldn't you actually inline the implem

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:248 + if (Top.SeenAtFile == SM.getMainFileID() && IncludedFile) +Out->ShouldKeep.insert(IncludedFile->getUniqueID()); } If I understand correctly, you sh

[PATCH] D156597: [Clang] Handle static_assert messages with an expression started by a literal

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1019 -if (isTokenStringLiteral()) - AssertMessage = ParseUnevaluatedStringLiteralExpression(); -else if (getLangOpts().CPlusPlus26) +bool ParseAsExression = false; +if(getLangOpts(

[PATCH] D156648: [Tooling/Inclusion] Add std::range symbols in the mapping.

hokein added a comment. In D156648#4545863 , @kadircet wrote: > can you also create a cherry-pick request for this patch once it lands? Filed https://github.com/llvm/llvm-project/issues/64261. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D156650: [clangd] Respect IWYU keep pragma for standard headers.

hokein added a comment. In D156650#4545867 , @kadircet wrote: > also we should get this cherry-picked too. `keep` pragmas on includes are not > common, but people do have export pragmas often enough to cause some > annoyance here. Filed https://github.

[PATCH] D156672: [clang][dataflow] Use `Strict` accessors where we weren't using them yet.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:542 +State.Env.getStorageLocationStrict(*E)); +if (!Loc) { + Loc

[PATCH] D156672: [clang][dataflow] Use `Strict` accessors where we weren't using them yet.

mboehme updated this revision to Diff 545611. mboehme added a comment. Use `Loc == nullptr` instead of `!Loc`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156672/new/ https://reviews.llvm.org/D156672 Files: clang/lib/Analysis/FlowSensitive/Dat

[PATCH] D156672: [clang][dataflow] Use `Strict` accessors where we weren't using them yet.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:545 + &cast(State.Env.createStorageLocation(*E)); + State.Env.setStorageLocationStrict(*E, *Loc); +} --

[PATCH] D156674: [clang][dataflow] Remove `Strict` suffix from accessors.

mboehme updated this revision to Diff 545615. mboehme added a comment. Rebased to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156674/new/ https://reviews.llvm.org/D156674 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironme

[PATCH] D156597: [Clang] Handle static_assert messages with an expression started by a literal

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from minor nits. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1022 + for(unsigned I = 0; ; ++I) { +const Token & T = GetLookAheadToken(I

[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:225 + const CallExpr *CE = cast(E); + PrimType FPClassArgT = *S.getContext().classify(CE->getArgs()[1]->getType()); + APSInt FPClassArg = peekToAPSInt(S.Stk, FPClassArgT);

[PATCH] D155430: [clang][Interp] Implement __arithmethic_fence for floating types

aaron.ballman added a subscriber: Izaron. aaron.ballman added a comment. Hmmm, something is weird here. The original patch adding the LLVM intrinsic is https://reviews.llvm.org/D99675 and that says: `The invocation of __arithmetic_fence is not a C/C++ constant expression, even if the operands ar

[PATCH] D156286: [docs] Bump minimum GCC version to 7.5

aaron.ballman added a comment. In D156286#4544631 , @MaskRay wrote: > In D156286#4534968 , @aaron.ballman > wrote: > >> There's a mention on the RFC thread that Ubuntu 18.04 still ships with GCC >> 7.3. That's a

[PATCH] D156286: [docs] Bump minimum GCC version to 7.5

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG with the minor cleanup I found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156286/new/ https://reviews.llvm.org/D156286 ___

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

aaron.ballman added a comment. > As you can see I have a test case, but I didn't attach it in > test/Misc/constexpr-source-ranges.cpp because I can't get > -fdiagnostics-print-source-range-info to actually print anything for them. That's odd; have you investigated what's going on/filed an issue

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 545622. jp4a50 marked an inline comment as done. jp4a50 added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/docs/ReleaseNotes.r

[PATCH] D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC.

Jim created this revision. Herald added subscribers: ctetreau, s.egerton, simoncook. Herald added a project: All. Jim requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Reuse isSVESizelessBuiltinType() and isRVVSizelessBuiltinType().

[PATCH] D156597: [Clang] Handle static_assert messages with an expression started by a literal

cor3ntin updated this revision to Diff 545627. cor3ntin added a comment. Typo + format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156597/new/ https://reviews.llvm.org/D156597 Files: clang/lib/Parse/ParseDeclCXX.cpp clang/test/SemaCXX/static

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit this on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION https://review

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

dang added a comment. Looking pretty good, if you can address the last few bits of feedback I am happy to merge this. Comment at: clang/include/clang/ExtractAPI/API.h:770 +template <> +struct has_function_signature : public std::true_type {}; + Does `CXXInstan

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038 ___ cf

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian marked 4 inline comments as done. MrTrillian added a comment. Resolved remaining comments addressed with the FileManager.cpp change to branch on the native path format being Windows. This is ready to merge! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://re

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added a comment. Please add more details to the patch summary explaining why you're making these changes. Also, I assume this is to be backported to Clang 17? If so, I'd like @hubert.reinterpretcast to mention if this works

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154189/new/ https://reviews.llvm.org/D154189 ___ cfe-commits mailing list

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155809/new/ https://reviews.llvm.org/D155809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin added a comment. Oups, sorry, the context is this PR https://reviews.llvm.org/D105759#4543246 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156596/new/ https://reviews.llvm.org/D156596 ___ cfe-c

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman added a comment. In D156596#4546787 , @cor3ntin wrote: > Oups, sorry, the context is this PR https://reviews.llvm.org/D105759#4543246 I kind of figured. :-) But we want the context in the patch summary since that's what typically makes it

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

mboehme added a comment. Retracting from review. I think I was overly hasty with this change: - There are edges between expressions that cross CFG block boundaries but don't involve block terminators. Here's an example -- [B1 .1] ha

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. In D156363#4546171 , @dyung wrote: > In D156363#4545474 , @MaskRay wrote: > >> In D156363#4545215 , @dyung wrote: >> >>> If you cannot reproduce thi

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

AlexVlx added a comment. In D156539#4542836 , @rjmccall wrote: > We should probably write this code to work properly in case we add a target > that makes `__builtin_alloca` return a pointer in the private address space. > Could you recover the target A

[PATCH] D156693: [clang][ASTImporter]Don't add template decl as in friend decl

jcsxky created this revision. jcsxky added reviewers: a.sidorin, shafik, balazske, steakhal. jcsxky added a project: clang. Herald added a subscriber: martong. Herald added a project: All. jcsxky requested review of this revision. Herald added subscribers: cfe-commits, wangpc. There is no need to

[PATCH] D156588: feat: Add support for Rocky Linux to LLVM Distro

zkkxu added a comment. nice ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156588/new/ https://reviews.llvm.org/D156588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D156672: [clang][dataflow] Use `Strict` accessors where we weren't using them yet.

ymandel accepted this revision. ymandel added a comment. SGTM Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:545 + &cast(State.Env.createStorageLocation(*E)); + State.Env.setStorageLocationStrict(*E, *Loc); +} ---

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

xazax.hun added a comment. > It looks as if, instead, what we should be doing to improve convergence in a > sound manner is to implement widening for ExprToLoc. I'll submit a > corresponding patch shortly. +1, I believe we want `ExprToLoc` to converge. That being said, if we can get away with

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4546818 , @dyung wrote: > In D156363#4546171 , @dyung wrote: > >> In D156363#4545474 , @MaskRay >> wrote: >> >>> In D156363#4545215

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 545666. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptio

[PATCH] D156286: [docs] Bump minimum GCC version to 7.5

jyknight added a comment. Given that folks have successfully tested with GCC 7.4, and the lateness of the change in the release process for LLVM 17, I think it'd be better to require GCC 7.4 (the earliest that actually works), instead of increasing the requirement to 7.5. Repository: rG LLV

[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:232 + static_cast((F.classify() & FPClassArg).getZExtValue()); + S.Stk.push>(Integral<32, true>::from(Result)); + aaron.ballman wrote

[clang] ab68df5 - [Driver][test] Add -resource-dir= and -fvisibility=hidden to -fsanitize=cfi commands

Author: Fangrui Song Date: 2023-07-31T08:20:21-07:00 New Revision: ab68df505e5bb8808ee44f53044b50ca7575098e URL: https://github.com/llvm/llvm-project/commit/ab68df505e5bb8808ee44f53044b50ca7575098e DIFF: https://github.com/llvm/llvm-project/commit/ab68df505e5bb8808ee44f53044b50ca7575098e.diff

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

AlexVlx updated this revision to Diff 545679. AlexVlx added a reviewer: arsenm. AlexVlx added a comment. Herald added a subscriber: wdng. Incorporated review feedback. Updated test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156539/new/ https://reviews.llvm.org/D156539 Files: clan

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

gamesh411 added a comment. I like this, especially, that the functionality of UBOR can be merged and extended in a much cleaner way (architecturally). Comment at: clang/lib/StaticAnalyzer/Checkers/BitwiseShiftChecker.cpp:301-302 + pluralSuffix(MaximalAllow

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. In D156274#4545581 , @schittir wrote: > Test failure seems unrelated to change. Driver/fsanitize.c lit test passes in > my local testing. Restarting build. The build is now green. Landing the patch. CHANGES SINCE LAST ACTION

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG235390d930be: [NFC] Avoid potential dereferencing of nullptr. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/ https://revi

[clang] 235390d - [NFC] Avoid potential dereferencing of nullptr.

Author: Sindhu Chittireddy Date: 2023-07-31T08:33:26-07:00 New Revision: 235390d930be41c32c71f877d90470fc83e2cb89 URL: https://github.com/llvm/llvm-project/commit/235390d930be41c32c71f877d90470fc83e2cb89 DIFF: https://github.com/llvm/llvm-project/commit/235390d930be41c32c71f877d90470fc83e2cb89.

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. All callers will

[PATCH] D156705: [clang-format] Fix braced initializer formatting with templated base class initializer

galenelias created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. galenelias requested review of this revision. This fixes https://github.com/llvm/llvm-project/issu

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

arsenm added inline comments. Comment at: clang/test/CodeGen/dynamic-alloca-with-address-space.c:1 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + Can you add an opencl 1.2 and 2.0 run line too Comment at: clan

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

AlexVlx added inline comments. Comment at: clang/test/CodeGen/dynamic-alloca-with-address-space.c:1 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + arsenm wrote: > Can you add an opencl 1.2 and 2.0 run line too This is not valid

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

arsenm added inline comments. Comment at: clang/test/CodeGen/dynamic-alloca-with-address-space.c:1 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + AlexVlx wrote: > arsenm wrote: > > Can you add an opencl 1.2 and 2.0 run line too

[PATCH] D156711: [clang][ExprConstant] Fix assertion failure in constant expression folding

antmo created this revision. Herald added a project: All. antmo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D140059 , clang asserts on constant calls of string functions (memchr, strncmp, memcmp,

  1   2   3   >