arsenm added inline comments.
================ Comment at: clang/test/CodeGen/dynamic-alloca-with-address-space.c:1 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o - | FileCheck %s + ---------------- Can you add an opencl 1.2 and 2.0 run line too ================ Comment at: clang/test/CodeGen/dynamic-alloca-with-address-space.c:12 +// CHECK: store i64 %n, ptr %n.addr.ascast, align 8 +// CHECK: %0 = load i64, ptr %n.addr.ascast, align 8 +// CHECK: %1 = alloca i8, i64 %0, align 8, addrspace(5) ---------------- Use generated checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156539/new/ https://reviews.llvm.org/D156539 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits