nridge added a comment. I'm not sure how I feel about dropping the parameters from the signature in the `CanBeCall = false` case.
I can see arguments in both directions: - On the one hand, dropping the parameters makes the text that is inserted more consistent with the text that is shown for the proposal. - On the other hand, imagine you're typing in a `CanBeCall = false` context (e.g. `&ClassName::Prefix^`), and there are several matching method names that begin with `Prefix` that you are trying to choose from. Seeing their signatures might be a useful piece of additional context to help you choose the right one (e.g. maybe you're looking for one with a particular parameter type). On the whole, I think I lean towards the second point being more important, and therefore towards keeping the signatures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/ https://reviews.llvm.org/D155370 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
