[PATCH] D155148: [X86] Add SM4 instructions.

RKSimon added a comment. @pengfei Are you happy with the intrinsics doxygen descriptions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 ___ cfe-commits mailin

[PATCH] D155147: [X86] Add SM3 instructions.

RKSimon added a comment. @pengfei Are you happy with the intrinsics doxygen descriptions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 ___ cfe-commits mailin

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. In D142609#4507696 , @nathanchance wrote: > I took the most recent version for a spin against the Linux kernel. The > couple of issues that a previous revision of the warning flagged > (https://github.com/ClangBuiltLinux/linux/i

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1063 + OnlyFix->isPreferred = true; + if (LSPDiags.size() == 1 && LSPDiags.front().range == Sel

[PATCH] D155148: [X86] Add SM4 instructions.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. In D155148#4510472 , @RKSimon wrote: > @pengfei Are you happy with the intrinsics doxygen descriptions? LGTM except for one comment.

[PATCH] D155537: [ASTImporter] Fix import failed when anonymous union defined in class

danix800 added a comment. Already fixed by https://reviews.llvm.org/D154764 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155537/new/ https://reviews.llvm.org/D155537 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

On Tue, Jul 18, 2023 at 10:15:09PM +0900, JF Bastien wrote: > > > On Tue, Jul 18, 2023 at 8:41 PM serge via Phabricator <[1] > revi...@reviews.llvm.org> wrote: > > serge-sans-paille created this revision. > serge-sans-paille added reviewers: nickdesaulniers, jfb, aaron.ballman. > Her

[PATCH] D155368: [clang][Interp] __builtin_copysign

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155368/new/ https://reviews.llvm.org/D155368 ___ cfe-commits mailing list

[PATCH] D155147: [X86] Add SM3 instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:28 +/// \code +/// _mm_sm3msg1_epi32(__m128i __A, __m128i __B, __m128i __C) +/// \endcode Add return type too. Comment at: clang/lib/Headers/sm3intrin.h:85 +/// \code +///

[PATCH] D155372: [clang][Interp] Implement __builtin_isfinite

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:194 + + S.Stk.push>(Integral<32, true>::from(Arg.isFinite())); + return true; tbaeder

[PATCH] D155147: [X86] Add SM3 instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:69 +/// dst.dword[2] := P1(TMP2) +/// dst.dword[3] := P1(TMP3) +/// \endcode `DEST[MAX:128] := 0` the same to below. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM as far as the changes go, but did have a question about whether we need this for unsigned values as well. Comment at: clang/lib/AST/Interp/InterpBuiltin.c

[PATCH] D155547: [analyzer] Model lifetime of a variable declared in for condition in CFG correctly

tomasz-kaminski-sonarsource updated this revision to Diff 541519. tomasz-kaminski-sonarsource added a comment. Updated unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155547/new/ https://reviews.llvm.org/D155547 Files: clang/lib/Analysi

[PATCH] D155547: [analyzer] Model lifetime of a variable declared in for condition in CFG correctly

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/auto-obj-dtors-cfg-output.cpp:1231 A a; - for (A b; A c = b; ) { + for (A b; A c = b; ++c.x) { A d; xazax.hun wrote: > Would there be any value in also keeping a couple o

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

simpal01 updated this revision to Diff 541522. simpal01 added a comment. isArmBigEndian -> isARMBigEndian Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154786/new/ https://reviews.llvm.org/D154786 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D155547: [analyzer] Model lifetime of a variable declared in for condition in CFG correctly

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:3511 // go in this block as well. Block = Succ = TransitionBlock = createBlock(false); TransitionBlock->setLoopTa

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xbolva00 added a comment. I my opinion it makes sense to adjust that kernel code based on this warning in the current inplementation state. @aaron.ballman ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:122 + + using BlockOrderTy = llvm::DenseMap; + BlockOrderTy BlockOrder; Would it make sense to have a vector instead and use block ids to get the order? ===

[PATCH] D154559: [clang] Fix constant evaluation about static member function

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154559/new/ https://reviews.llvm.org/D154559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155547: [analyzer] Model lifetime of a variable declared in for condition in CFG correctly

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155547/new/ https://reviews.llvm.org/D155547 __

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet updated this revision to Diff 541528. hazohelet marked 8 inline comments as done. hazohelet edited the summary of this revision. hazohelet added a comment. Address review comments - Rename tablegen name of the diagnostics to follow other tautological warnings - Remove redundant modifica

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

aaron.ballman added subscribers: jcranmer-intel, hubert.reinterpretcast, rsmith. aaron.ballman added a comment. I'd like to see test coverage for treatment of NaNs. According to the C23 standard, a quiet NaN is treated as missing data for fmax and fmin; so if there's a quiet NaN and a numeric va

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro updated this revision to Diff 541537. pscoro marked an inline comment as done. pscoro added a comment. Updated documentation to address all nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 File

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 541538. to268 marked 17 inline comments as done. to268 added a comment. Added recommendations from @aaron.ballman. Adjusting diagnostic messages still need to be done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 added inline comments. Comment at: clang/test/Sema/c2x-auto.c:119 + return x; +} aaron.ballman wrote: > aaron.ballman wrote: > > Some additional test cases to consider: > > ``` > > _Complex auto i = 12.0; // Should be rejected because _Complex is a type >

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:36 +/// Pushes \p Val to the stack, as a target-dependent 'int'. +static void pushInt(InterpState &S, int32_t Val) { + const TargetInfo &TI = S.getCtx().getTargetInfo(); aaron.ball

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro marked 6 inline comments as done. pscoro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:934-936 + // Default to the /../lib and + // /../runtimes/runtimes-bins/lib directories. This works fine + // on the platforms that we have tested so f

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM but please allow a day for others to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154786/new/ https://reviews.l

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro updated this revision to Diff 541544. pscoro marked an inline comment as done. pscoro added a comment. Removed support for "fully standalone" Flang-rt builds (ie CMake builds targeting llvm-project/flang-rt). Flang-rt is now buildable via the `llvm` target or the `runtimes` target. See do

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro marked 3 inline comments as done. pscoro added inline comments. Comment at: flang-rt/CMakeLists.txt:17-23 +# Check if flang-rt is built as a standalone project. +if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR FLANG_RT_STANDALONE_BUILD) + project(FlangRT C CXX)

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

Sedeniono added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:643-646 + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias alias_var;\n" + "}"; // Format this line only owenp

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541546. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155173/new/ https://reviews.llvm.org/D155173 Files: clang-tools-extra/cl

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155539/new/ https://reviews.llvm.org/D155539 ___ cfe-commits mailing list cfe-c

[clang-tools-extra] f4f6c22 - [clangd] Refine the workflow for diagnostic Fixits.

Author: Haojian Wu Date: 2023-07-18T17:25:08+02:00 New Revision: f4f6c229bde8f42721482469bd5a3d050d254d82 URL: https://github.com/llvm/llvm-project/commit/f4f6c229bde8f42721482469bd5a3d050d254d82 DIFF: https://github.com/llvm/llvm-project/commit/f4f6c229bde8f42721482469bd5a3d050d254d82.diff LO

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4f6c229bde8: [clangd] Refine the workflow for diagnostic Fixits. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D155606: [Clang] Only emit CUDA version warnings when creating the CUDA toolchain

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, jdoerfert, tianshilei1992, JonChesterfield. Herald added a subscriber: mattd. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, wangpc, jplehr, sstefan1, MaskRay. Heral

[PATCH] D155606: [Clang] Only emit CUDA version warnings when creating the CUDA toolchain

jhuber6 updated this revision to Diff 541562. jhuber6 added a comment. Fix wrong comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155606/new/ https://reviews.llvm.org/D155606 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. BEFORE this patch, the values printed in `static_assert` were printed after ignoring the implicit type

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 541563. victorkingi added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td clang/lib

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

aaron.ballman added a comment. In D142609#4510596 , @xbolva00 wrote: > In my opinion it makes sense to adjust that kernel code based on this warning > in the current inplementation state. > > @aaron.ballman ? I think that use of macros for any of the co

[PATCH] D155614: [clangd] Make an include always refer to itself. Background: clang-review expects all referents to have definition, declaration or reference(s).

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

ymandel added a comment. I got up to Transfer.cpp and figured I should send along what I have. Looks very good so far! I should have the rest of the review in a few hours... Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:337-338 + /// Returns

[PATCH] D76477: [clang-tidy][NFC] Update path of main translation unit

This revision was automatically updated to reflect the committed changes. Closed by commit rG37937b8a040c: [clang-tidy][NFC] Update path of main translation unit (authored by j-carl, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] 37937b8 - [clang-tidy][NFC] Update path of main translation unit

Author: Jens Carl Date: 2023-07-18T15:49:01Z New Revision: 37937b8a040c5525a92c7ce23c329383e9d0c8e4 URL: https://github.com/llvm/llvm-project/commit/37937b8a040c5525a92c7ce23c329383e9d0c8e4 DIFF: https://github.com/llvm/llvm-project/commit/37937b8a040c5525a92c7ce23c329383e9d0c8e4.diff LOG: [cl

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi marked 4 inline comments as done. victorkingi added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:398 + if (const Arg *A = Args.getLastArg(options::OPT_fsave_optimization_record_EQ)) +Format = A->getValue(); + tblah wrote: >

[PATCH] D155501: Add new option -fkeep-persistent-storage-variables to Clang release notes

qianzhen updated this revision to Diff 541581. qianzhen added a comment. Update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155501/new/ https://reviews.llvm.org/D155501 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/Release

[PATCH] D155606: [Clang] Only emit CUDA version warnings when creating the CUDA toolchain

jdoerfert added a comment. I like it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155606/new/ https://reviews.llvm.org/D155606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D155606: [Clang] Only emit CUDA version warnings when creating the CUDA toolchain

jdoerfert added a comment. tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155606/new/ https://reviews.llvm.org/D155606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D155523: [clang] Fix a crash when casting to an array type

ayzhao updated this revision to Diff 541588. ayzhao marked an inline comment as done. ayzhao added a comment. quote C++20 standard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155523/new/ https://reviews.llvm.org/D155523 Files: clang/docs/Relea

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

vzakhari added inline comments. Comment at: flang-rt/CMakeLists.txt:17-23 +# Check if flang-rt is built as a standalone project. +if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR FLANG_RT_STANDALONE_BUILD) + project(FlangRT C CXX) + set(CMAKE_INCLUDE_CURRENT_DIR ON) +

[PATCH] D155619: [clangd] Always run preamble indexing on a separate thread

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This has bee

[PATCH] D155606: [Clang] Only emit CUDA version warnings when creating the CUDA toolchain

jhuber6 updated this revision to Diff 541594. jhuber6 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155606/new/ https://reviews.llvm.org/D155606 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D155523: [clang] Fix a crash when casting to an array type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155523/new/ https://reviews.llvm.org/D155523 _

[clang-tools-extra] e6b98b7 - [Clangd] Fix ambiguous use of 'Range'

Author: Joseph Huber Date: 2023-07-18T11:41:24-05:00 New Revision: e6b98b7eff28de52927fb2ce7030e97ac363e1c0 URL: https://github.com/llvm/llvm-project/commit/e6b98b7eff28de52927fb2ce7030e97ac363e1c0 DIFF: https://github.com/llvm/llvm-project/commit/e6b98b7eff28de52927fb2ce7030e97ac363e1c0.diff

[clang] fe0116a - [clang] Fix a crash when casting to an array type

Author: Alan Zhao Date: 2023-07-18T09:48:17-07:00 New Revision: fe0116aba833ee8597e2155d1e555c326acfaafc URL: https://github.com/llvm/llvm-project/commit/fe0116aba833ee8597e2155d1e555c326acfaafc DIFF: https://github.com/llvm/llvm-project/commit/fe0116aba833ee8597e2155d1e555c326acfaafc.diff LOG

[PATCH] D155523: [clang] Fix a crash when casting to an array type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe0116aba833: [clang] Fix a crash when casting to an array type (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D155222: [RISCV][AArch64][IRGen] Add scalable->fixed as a special case in CreateCoercedStore.

craig.topper abandoned this revision. craig.topper added a comment. Abandoning in favor of D155495 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155222/new/ https://reviews.llvm.org/D155222 __

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

aaron.ballman added a comment. In D155457#4510202 , @xgupta wrote: > In D155457#4507124 , @aaron.ballman > wrote: > >> In D155457#4507107 , @xgupta wrote: >> >>> In D1554

[clang] d53d842 - [RISCV][AArch64][IRGen] Add a special case to CodeGenFunction::EmitCall for scalable vector return being coerced to fixed vector.

Author: Craig Topper Date: 2023-07-18T10:04:33-07:00 New Revision: d53d842d12ceb182f1f5c12cc001b09f9000dbf4 URL: https://github.com/llvm/llvm-project/commit/d53d842d12ceb182f1f5c12cc001b09f9000dbf4 DIFF: https://github.com/llvm/llvm-project/commit/d53d842d12ceb182f1f5c12cc001b09f9000dbf4.diff

[PATCH] D155495: [RISCV][AArch64][IRGen] Add a special case to CodeGenFunction::EmitCall for scalable vector return being coerced to fixed vector.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd53d842d12ce: [RISCV][AArch64][IRGen] Add a special case to CodeGenFunction::EmitCall for… (authored by craig.topper). Changed prior to commit: ht

[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. no worries then Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155506/new/ https://reviews.llvm.org/D155506 ___ cfe-commits mailin

[PATCH] D155525: WIP

nickdesaulniers abandoned this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:362 // it. This makes the second scan not have to walk the AST again. +RecordJumpScope: LabelAndGotoScopes[S] = ParentScope;

[PATCH] D155522: [clang][JumpDiagnostics] refactor helper

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. prefer D155525 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155522/new/ https://reviews.llvm.org/D155522

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4511392 , @aaron.ballman wrote: > Whether `size_t` comes from the system header or whether it's manually > deduced from `decltype(sizeof(0))` should make no difference as far as the > frontend is concerned; they shoul

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

aaron.ballman added reviewers: cor3ntin, tahonermann. aaron.ballman added a comment. I wonder if we want to see whether the character is printable before deciding whether to show the numeric value for it or show a character value? For whitespace characters, printing the character leads to odd di

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 541619. nickdesaulniers added a comment. - squash D155525 as per @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. Thanks for the reviews and advice. Any parting thoughts @rjmccall ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342 _

[clang-tools-extra] 21558c8 - [clangd] Fix a build error for f4f6c229bde8f42721482469bd5a3d050d254d82

Author: Haojian Wu Date: 2023-07-18T19:20:06+02:00 New Revision: 21558c83dbe319deaea897895265d771c3111492 URL: https://github.com/llvm/llvm-project/commit/21558c83dbe319deaea897895265d771c3111492 DIFF: https://github.com/llvm/llvm-project/commit/21558c83dbe319deaea897895265d771c3111492.diff LO

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

carlosgalvezp updated this revision to Diff 541623. carlosgalvezp added a comment. Remove confusing comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155625/new/ https://reviews.llvm.org/D155625 Files: clang-tools-extra/clang-tidy/cppcoreg

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. In D142609#4510995 , @aaron.ballman wrote: > In D142609#4510596 , @xbolva00 > wrote: > >> In my opinion it makes sense to adjust that kernel code based on this >> warning in the current

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

carlosgalvezp updated this revision to Diff 541624. carlosgalvezp added a comment. Fix typo in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155625/new/ https://reviews.llvm.org/D155625 Files: clang-tools-extra/clang-tidy/cppcore

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

tbaeder added a comment. What if you switch from `IgnoreParenImpCasts` at the top of `DiagnoseStaticAssertDetails()` to just `IgnoreParens()`? That improve cases where we simply compare a character literal to an integer, since the literal should be implicitly cast to an integer. Repository:

[PATCH] D155509: Revert "Remove rdar links; NFC"

jroelofs added a comment. Do you think this and the other patch are good candidates for `.git-blame-ignore-revs` entries? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509 _

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

carlosgalvezp updated this revision to Diff 541626. carlosgalvezp added a comment. Remove extra newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155625/new/ https://reviews.llvm.org/D155625 Files: clang-tools-extra/clang-tidy/cppcoreguidel

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nickdesaulniers added a comment. In D142609#4507696 , @nathanchance wrote: > but I see a new one along a similar line as those: > > https://elixir.bootlin.com/linux/v6.5-rc2/source/drivers/gpu/drm/v3d/v3d_drv.h#L343 I only see 4 instances of `NSEC_PER_S

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a bit awkward, since we get an `APValue` from

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

efriedma added inline comments. Comment at: flang/lib/Decimal/CMakeLists.txt:54 + +if (DEFINED LLVM_ENABLE_PROJECTS AND "flang" IN_LIST LLVM_ENABLE_PROJECTS) + add_flang_library(FortranDecimal I think it would make sense to use explicit CMake variables for the "

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1858 +static bool isEmptyClass(VarDecl const &D) { + const Type *Ty = D.getType().getTypePtr(); inconsistent east const vs west const Comment at: clang/lib/CodeG

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

eopXD added a comment. Sorry for the late reply, I missed this in may mails. I see that the motivation start from where you spotted this type alias. However it was essentially just an act for convenience so we don't have to map a more irregular pattern of ( _Float16, float, double) when generat

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

aaron.ballman added a comment. In D155457#4511446 , @xgupta wrote: > In D155457#4511392 , @aaron.ballman > wrote: > >> Whether `size_t` comes from the system header or whether it's manually >> deduced from `decl

[PATCH] D155414: [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64

eopXD updated this revision to Diff 541636. eopXD marked an inline comment as done. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155414/new/ https://reviews.llvm.org/D155414 Files: clang/includ

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

rjmccall added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:658 +if (auto *G = dyn_cast(Jump)) { + for (AddrLabelExpr *L : G->labels()) { I think it would be good to leave a comment here like this: > We know the possible destination

[PATCH] D155509: Revert "Remove rdar links; NFC"

aaron.ballman added a comment. In D155509#4511568 , @jroelofs wrote: > Do you think this and the other patch are good candidates for > `.git-blame-ignore-revs` entries? I think so, yes. (I didn't add the original commit to the ignore list because I tho

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 541639. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - add comment as per @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.o

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:658 +if (auto *G = dyn_cast(Jump)) { + for (AddrLabelExpr *L : G->labels()) { rjmccall wrote: > I think it would be good to leave a comment here like this: > > > We

[PATCH] D155416: [Clang][RISCV] Improve diagnostic message for full multiply intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM for now, but long term I think we need a mechanism to do this builtins that require extensions like vector crypto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

tra accepted this revision. tra added a comment. We should probably update documentation that C++ standard version for CUDA/HIP compilation now matches C++ default instead of previously used c++14. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155539/new/ https://reviews.llvm.org/D1555

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

rjmccall added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:658 +if (auto *G = dyn_cast(Jump)) { + for (AddrLabelExpr *L : G->labels()) { nickdesaulniers wrote: > rjmccall wrote: > > I think it would be good to leave a comment here l

[PATCH] D154559: [clang] Fix constant evaluation about static member function

tra added a comment. @rsmith Richard, PTAL. This needs your language lawyering expertise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154559/new/ https://reviews.llvm.org/D154559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D153310: Add builtin_elementwise_pow

bob80905 updated this revision to Diff 541651. bob80905 added a comment. - remove unimportant part of test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/ https://reviews.llvm.org/D153310 Files: clang/docs/LanguageExtensions.rst clan

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 541652. ziqingluo-90 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-pra

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:658 +if (auto *G = dyn_cast(Jump)) { + for (AddrLabelExpr *L : G->labels()) { rjmccall wrote: > nickdesaulniers wrote: > > rjmccall wrote: > > > I think it would be g

[clang] d2ac006 - [Clang] Only emit CUDA version warnings when creating the CUDA toolchain

Author: Joseph Huber Date: 2023-07-18T13:48:11-05:00 New Revision: d2ac0069a21b79efdcd32ba4cc44dc7f08a25b8b URL: https://github.com/llvm/llvm-project/commit/d2ac0069a21b79efdcd32ba4cc44dc7f08a25b8b DIFF: https://github.com/llvm/llvm-project/commit/d2ac0069a21b79efdcd32ba4cc44dc7f08a25b8b.diff

[PATCH] D155606: [Clang] Only emit CUDA version warnings when creating the CUDA toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2ac0069a21b: [Clang] Only emit CUDA version warnings when creating the CUDA toolchain (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D155475: [Clang][Sema] Add -Wctad-selects-copy to diagnose copy deduction candidate

shafik added a reviewer: aaron.ballman. shafik added a comment. Adding Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155475/new/ https://reviews.llvm.org/D155475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris added a comment. > You can be more specific that multi-module bitcode files are for > -fsanitize=cfi and -fwhole-program-vtables. And it will be more useful to > include an example in the summary. Fixed. > This is a bit odd as the -o file may no longer an output. This could be > fixed,

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

rjmccall added a comment. > We need to check the scopes like we would for direct goto, because we don't > want to bypass non-trivial destructors. I think this is the basic misunderstanding here. Direct `goto` is allowed to jump out of scopes; it just runs destructors on the way. It is only a

[clang] 97c5381 - [RISCV] Remove 'Z' from Zbb builtin type strings. NFC

Author: Craig Topper Date: 2023-07-18T12:07:50-07:00 New Revision: 97c5381879d41cafaf36793e57e236da8a81791f URL: https://github.com/llvm/llvm-project/commit/97c5381879d41cafaf36793e57e236da8a81791f DIFF: https://github.com/llvm/llvm-project/commit/97c5381879d41cafaf36793e57e236da8a81791f.diff

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

efriedma added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:658 +if (auto *G = dyn_cast(Jump)) { + for (AddrLabelExpr *L : G->labels()) { nickdesaulniers wrote: > rjmccall wrote: > > nickdesaulniers wrote: > > > rjmccall wrote: > > >

<    1   2   3   4   >