vzakhari added inline comments.
================ Comment at: flang-rt/CMakeLists.txt:17-23 +# Check if flang-rt is built as a standalone project. +if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR FLANG_RT_STANDALONE_BUILD) + project(FlangRT C CXX) + set(CMAKE_INCLUDE_CURRENT_DIR ON) + set(FLANG_RT_STANDALONE_BUILD TRUE) + set_property(GLOBAL PROPERTY USE_FOLDERS ON) +endif() ---------------- pscoro wrote: > phosek wrote: > > pscoro wrote: > > > vzakhari wrote: > > > > phosek wrote: > > > > > I don't think we should support building FlangRT as a standalone > > > > > project. We've been moving all runtimes to the runtimes build, the > > > > > only leftover is compiler-rt and our hope is to address that soon. > > > > Hi @phosek, can you please explain what you mean by "We've been moving > > > > all runtimes to the runtimes build"? Can you please share references > > > > to the pipeline for the "runtimes build"? > > > If i understood correctly, i think @phosek is talking about building the > > > flang-rt target directly (`cmake llvm-project/flang-rt`) when he says > > > standalone. Meanwhile a runtimes build is `cmake llvm-project/runtimes > > > -DLLVM_ENABLE_RUNTIMES=flang-rt`. I chose not to change anything yet > > > because I was focused on some other bugs and was waiting for see if > > > anybody else had input on this first. Also, in case my understanding is > > > incorrect @phosek please correct me. > > Yes, that is correct. > I gave this a couple days in case anybody else in the community wanted to > voice their opinion but since there was no contradictions, I have removed > support for targeting flang-rt directly. Flang-rt is now only buildable via > the llvm target or the runtimes target. See documentation for details. Thank you for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
