pscoro marked 6 inline comments as done. pscoro added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:934-936 + // Default to the <driver-path>/../lib and + // <driver-path>/../runtimes/runtimes-bins/lib directories. This works fine + // on the platforms that we have tested so far. We will probably have to ---------------- awarzynski wrote: > pscoro wrote: > > awarzynski wrote: > > > Am I correct thinking that: > > > * "<driver-path>/../lib" is for `Fortran_main.a`, and > > > * "<driver-path>/../runtimes/runtimes-bins/lib " is for `libflang-rt`? > > > > > > Could you document this? Thanks! > > Yep thats right, documentation added > > Yep thats right, documentation added > > Could you document _where_ these libraries are located? Also, could you add > some relevant comments here? For example: > ``` > // Add search path for XYZ > llvm::sys::path::append(BuildLibPath, "lib"); > ``` > Could you document _where_ these libraries are located? I've made the information more explicit in the documentation and added clarification that the `../runtimes/runtimes-bins/lib` path happens for runtimes built as part of an llvm target build, but during standalone runtimes builds `../lib` is used. (I am not sure why this behavior is what it is, but I don't think we should by changing or overriding the existing infrastructure) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
