[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:671 + // FIMXE: this is tricky + llvm::StringRef(LSPDiag.Message) + .starts_with_insensitive(Diag.Message)) hokein wrote: > hokein wro

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541343. FreddyYe added a comment. Refine doxygen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Bui

[PATCH] D155552: [clang][Interp] Support __null

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

cor3ntin added a comment. I think this does make sense. Have you notice an impact on performance? I wonder if there are places where we should cache the result of evaluating a ConstantExpr, like in `ExprEvaluatorBase::VisitConstantExpr` How often do we construct a ConstantExpr without an initial

[PATCH] D155552: [clang][Interp] Support __null

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:16 +static_assert(__null == __null, ""); static_assert(1 == 1, ""); static_assert(1 == 3, ""); // expected-error{{failed}} ref-error{{failed}} Can you add a test along the lines of

[clang] 39670ae - [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

Author: Balázs Kéri Date: 2023-07-18T09:29:15+02:00 New Revision: 39670ae3b93470b2d29fe78e6d40c5d82a05e4a1 URL: https://github.com/llvm/llvm-project/commit/39670ae3b93470b2d29fe78e6d40c5d82a05e4a1 DIFF: https://github.com/llvm/llvm-project/commit/39670ae3b93470b2d29fe78e6d40c5d82a05e4a1.diff L

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

cor3ntin added a comment. Looks fine but where are the tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155546/new/ https://reviews.llvm.org/D155546 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] f12808a - [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

Author: Balázs Kéri Date: 2023-07-18T09:29:15+02:00 New Revision: f12808ab20369c85ddb602e5a78bab40d16bb83f URL: https://github.com/llvm/llvm-project/commit/f12808ab20369c85ddb602e5a78bab40d16bb83f DIFF: https://github.com/llvm/llvm-project/commit/f12808ab20369c85ddb602e5a78bab40d16bb83f.diff L

[clang] 6dccf5b - [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

Author: Balázs Kéri Date: 2023-07-18T09:29:15+02:00 New Revision: 6dccf5b8d550911f06e492a3a75c640c05efdab3 URL: https://github.com/llvm/llvm-project/commit/6dccf5b8d550911f06e492a3a75c640c05efdab3 DIFF: https://github.com/llvm/llvm-project/commit/6dccf5b8d550911f06e492a3a75c640c05efdab3.diff L

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG39670ae3b934: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D153612?vs=540015&id=541353#toc Reposito

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6dccf5b8d550: [clang][analyzer] Add all success/failure messages to… (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf12808ab2036: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if… (authored by balazske). Repository: rG LLVM Github Monorepo

[PATCH] D155445: [analyzer][docs] Add CSA release notes

steakhal updated this revision to Diff 541356. steakhal marked 2 inline comments as done. steakhal added a comment. In D155445#4508728 , @OikawaKirie wrote: > LGTM for my part. Thx. > > Since I am not very familiar with other changes, I have no detailed

[PATCH] D155445: [analyzer][docs] Add CSA release notes

steakhal added inline comments. Comment at: clang/docs/ReleaseNotes.rst:922-923 +- The ``CStringChecker`` will invalidate less if the copy operation is + inferable to be bounded. For example, if the argument of ``strcpy`` is known + to be of certain length and that is in-bounds

[PATCH] D109210: [obsolete][clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

PiotrZSL abandoned this revision. PiotrZSL added a comment. No longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109210/new/ https://reviews.llvm.org/D109210 ___ cfe-commits mailing list cfe-c

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

tbaeder added a comment. LGTM from my side, does anyone else still have a problem? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D76477: [clang-tidy] Update path of main translation unit

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. LGTM, probably LLVM_ATTRIBUTE_UNUSED need to be added to example before committing

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder updated this revision to Diff 541362. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155369/new/ https://reviews.llvm.org/D155369 Files: clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Function.h clang/lib/AST/Interp/Interp.cp

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

tbaeder added a comment. `clang/test/Sema/constant-builtins-fmin.cpp` actually needed quite a lot of builtins before it could succeed, so it's enabled in https://reviews.llvm.org/D155369 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155546/new/ h

[PATCH] D155552: [clang][Interp] Support __null

tbaeder updated this revision to Diff 541366. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12/new/ https://reviews.llvm.org/D12 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/I

[PATCH] D155558: [clangd][c++20] Add concept Hover tests.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Con

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

simpal01 added a comment. @MaskRay [Gentle Reminder] I have implemented the requested changes. Could you please have a look again. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154786/new/ https://reviews.llvm.org/D154786 ___

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 541373. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/Re

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

wangpc updated this revision to Diff 541374. wangpc added a comment. Update ReleaseNotes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155456/new/ https://reviews.llvm.org/D155456 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541389. hokein marked 2 inline comments as done. hokein added a comment. add LSPServer cache back and repurpose for lsp <=> naive diagnostic mapping, per offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D155495: [RISCV][AArch64][IRGen] Add a special case to CodeGenFunction::EmitCall for scalable vector return being coerced to fixed vector.

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. Thanks Craig this is a better solution, LLVM cleans up the store/load coercion nicely but better not to create them in the first place if possible. LGTM cheers Comment a

[clang-tools-extra] e9ab43d - [clangd][c++20] Add concept Hover tests.

Author: Jens Massberg Date: 2023-07-18T10:19:46+02:00 New Revision: e9ab43dd44cafe5a67f0a12b9ff1021d47074970 URL: https://github.com/llvm/llvm-project/commit/e9ab43dd44cafe5a67f0a12b9ff1021d47074970 DIFF: https://github.com/llvm/llvm-project/commit/e9ab43dd44cafe5a67f0a12b9ff1021d47074970.diff

[PATCH] D155558: [clangd][c++20] Add concept Hover tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9ab43dd44ca: [clangd][c++20] Add concept Hover tests. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541391. hokein added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155173/new/ https://reviews.llvm.org/D155173 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clang

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541392. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/Re

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] 5b99aa5 - [ASTImporter] Fix 'isVirtual()' assert failure while import overridden methods

Author: dingfei Date: 2023-07-18T16:29:56+08:00 New Revision: 5b99aa57f74e1432691f366d26a2ec21907a7a70 URL: https://github.com/llvm/llvm-project/commit/5b99aa57f74e1432691f366d26a2ec21907a7a70 DIFF: https://github.com/llvm/llvm-project/commit/5b99aa57f74e1432691f366d26a2ec21907a7a70.diff LOG:

[PATCH] D154701: [ASTImporter] Fix 'isVirtual()' assert failure while importing overridden methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b99aa57f74e: [ASTImporter] Fix 'isVirtual()' assert failure while import overridden methods (authored by dingfei ). Repository:

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

tbaeder added a comment. In D155548#4509056 , @cor3ntin wrote: > I think this does make sense. Have you notice an impact on performance? No, but my local builds are debug builds and I have sanitizers enabled. When compiling the sqlite amalgamation, I se

[clang] ef9421d - [LoongArch] Remove useless 'invalid' and 'none' feature and arch names. NFC

Author: Weining Lu Date: 2023-07-18T16:51:23+08:00 New Revision: ef9421dcf15fcd21ba121670ac0c7c7af15bc80f URL: https://github.com/llvm/llvm-project/commit/ef9421dcf15fcd21ba121670ac0c7c7af15bc80f DIFF: https://github.com/llvm/llvm-project/commit/ef9421dcf15fcd21ba121670ac0c7c7af15bc80f.diff LO

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

jhenderson added a comment. My apologies, this patch fell off my review queue somehow. I still have concerns about the option-parsing logic being duplicated, but I'm out of time to review it now. I'll try to look tomorrow. Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.

[clang] e953669 - [ASTImporter] Fields are imported first and reordered for correct layout

Author: dingfei Date: 2023-07-18T17:07:19+08:00 New Revision: e9536698720ec524cc8b72599363622bc1a31558 URL: https://github.com/llvm/llvm-project/commit/e9536698720ec524cc8b72599363622bc1a31558 DIFF: https://github.com/llvm/llvm-project/commit/e9536698720ec524cc8b72599363622bc1a31558.diff LOG:

[PATCH] D154764: [ASTImporter] Fields are imported first and reordered for correct layout.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9536698720e: [ASTImporter] Fields are imported first and reordered for correct layout (authored by dingfei ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 2c65118 - [clang-extdef-mapping] register necessary targest for ms-style asm block

Author: dingfei Date: 2023-07-18T17:09:58+08:00 New Revision: 2c651184a2b0ef1b0e24c6536e5befb65a0ae5ce URL: https://github.com/llvm/llvm-project/commit/2c651184a2b0ef1b0e24c6536e5befb65a0ae5ce DIFF: https://github.com/llvm/llvm-project/commit/2c651184a2b0ef1b0e24c6536e5befb65a0ae5ce.diff LOG:

[PATCH] D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c651184a2b0: [clang-extdef-mapping] register necessary targest for ms-style asm block (authored by dingfei ). Repository: rG LLV

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Integers might not be 32 bits wide, so check the Tar

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.h:77 bool isARMAProfile(const llvm::Triple &Triple); +bool isArmBigEndian(const llvm::Triple &Triple, const llvm::opt::ArgList &Args); Arm the company has rebranded but fo

[PATCH] D155147: [X86] Add SM3 instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:31 +/// +/// This intrinsic corresponds to the \c VPDPBSSD instruction. +/// VPDPBSSD ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/

[PATCH] D155146: [X86] Add SHA512 instructions.

RKSimon accepted this revision. RKSimon added a comment. LGTM - but I'd prefer more complete 32-bit vs 64-bit test coverage (similar to the SM3/SM4 patches) if its possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews

[PATCH] D155148: [X86] Add SM4 instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/sm4intrin.h:26 +/// +/// This intrinsic corresponds to the \c VPDPBSSD instruction. +/// VPDPBSSD ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc updated this revision to Diff 541415. wangpc added a comment. Rebase and fix libcxx tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools-extra/clangd/unittests/FindTargetTest

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

krasimir added a comment. It looks like this causes a regression in the following example: % cat test.cc struct A { std::unique_ptr operator()(const B& b) const; }; % clang-format -style=google test.cc # should be the same as the input struct A { std::unique_ptr operator()(cons

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

ManuelJBrito planned changes to this revision. ManuelJBrito added a comment. Hello @aqjune thanks for the comments !! Some users of SimplifyDemandedVectorElts might need some more tweaking to prevent regressions for the cases you noted. I'll work on this as soon as I can! Repository: rG LLVM

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

MyDeveloperDay added a comment. We should never make assumptions about what people do/don't use F28299562: image.png If you have this you have to honour it.. if 'SpacesInParentheses ' was true then 'InAttributeSpecifiers' needs to be true by default, shouldn

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155573: [Clang] Fix the location of default init expressions

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Default member initializations constructed from a parenthesized aggregate initialization should be constructed at the loca

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

rymiel added a comment. Shouldn't that regression already be handled by D155358 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 ___

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D155576: [NFC][clang-extdef-mapping] fix test failure on nonsupported targets

danix800 created this revision. Herald added a project: All. danix800 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specify a working target as POC Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155576 Files: clang/

[clang] fc43c4f - [Flang] Include logical default with default-integer-8

Author: Kiran Chandramohan Date: 2023-07-18T11:05:25Z New Revision: fc43c4f0181bfb7e7821e8b12fbd45e5178e884b URL: https://github.com/llvm/llvm-project/commit/fc43c4f0181bfb7e7821e8b12fbd45e5178e884b DIFF: https://github.com/llvm/llvm-project/commit/fc43c4f0181bfb7e7821e8b12fbd45e5178e884b.diff

[PATCH] D155279: [Flang] Include logical default with default-integer-8

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc43c4f0181b: [Flang] Include logical default with default-integer-8 (authored by kiranchandramohan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: http

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155574/new/ https://reviews.llvm.org/D155574 ___

[PATCH] D155195: [include-cleaner] Avoid a caching issue when running --edit mode on multiple files.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe861b64d941: [include-cleaner] Avoid a caching issue when running --edit mode on multiple… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D155195?vs=539988&id=541449#toc Repos

[clang-tools-extra] be861b6 - [include-cleaner] Avoid a caching issue when running --edit mode on multiple files.

Author: Haojian Wu Date: 2023-07-18T13:21:23+02:00 New Revision: be861b64d94198230d8f9889b17280e3cd215a0a URL: https://github.com/llvm/llvm-project/commit/be861b64d94198230d8f9889b17280e3cd215a0a DIFF: https://github.com/llvm/llvm-project/commit/be861b64d94198230d8f9889b17280e3cd215a0a.diff LO

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

krasimir added a comment. In D154184#4509744 , @rymiel wrote: > Shouldn't that regression already be handled by D155358 > ? Ah, I missed that. That fixes it. Thank you! Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

HazardyKnusperkeks added a comment. If you limit it to `Never` I don't see any value in the differentiation. You could just always use `Custom` (by dropping the custom and only having the nested options). But I think having at least the `Always` option would be nice. If you want **always** to

[PATCH] D155067: [clang][dataflow] Strengthen flow condition assertions.

mboehme updated this revision to Diff 541454. mboehme added a comment. Adapted to `Formula` changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155067/new/ https://reviews.llvm.org/D155067 Files: clang/unittests/Analysis/FlowSensitive/Transfer

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///true: false: +///__attribute__(( noreturn

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

MyDeveloperDay added a comment. In D154184#4509744 , @rymiel wrote: > Shouldn't that regression already be handled by D155358 > ? nice catch @rymiel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

serge-sans-paille created this revision. serge-sans-paille added reviewers: nickdesaulniers, jfb, aaron.ballman. Herald added a subscriber: kristof.beyls. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

serge-sans-paille added a comment. Comparison with GCC behavior here: https://godbolt.org/z/xc3j9jEsf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155580/new/ https://reviews.llvm.org/D155580 ___ cfe-co

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1014-1016 + llvm::ArrayRef LSPDiags = Params.context.diagnostics; + std::map + ToLSPDiagsIndex; we're already making a copy of `Params.context.diagnostics` when creati

[PATCH] D155581: [clangd][c++20] Add concept semantic highlighting test case

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Rep

[clang] c24f0f9 - [NFC][clang-extdef-mapping] fix test failure on unsupported targets

Author: dingfei Date: 2023-07-18T19:56:50+08:00 New Revision: c24f0f9bd6f4261d3ebdb34cbf4634026be0f2dc URL: https://github.com/llvm/llvm-project/commit/c24f0f9bd6f4261d3ebdb34cbf4634026be0f2dc DIFF: https://github.com/llvm/llvm-project/commit/c24f0f9bd6f4261d3ebdb34cbf4634026be0f2dc.diff LOG:

[PATCH] D155576: [NFC][clang-extdef-mapping] fix test failure on nonsupported targets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc24f0f9bd6f4: [NFC][clang-extdef-mapping] fix test failure on unsu

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1915-1924 LangOptions::TrivialAutoVarInitKind trivialAutoVarInit = (D.isConstexpr() ? LangOptions::TrivialAutoVarInitKind::Uninitialized : (D.getAttr() ?

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

MyDeveloperDay added a comment. We should never make assumptions about what people do/don't use F28299562: image.png If you have this you have to honour it.. if 'SpacesInParentheses ' was true then 'InAttributeSpecifiers' needs to be true by default, shouldn

[PATCH] D155584: [clang][NFC] Simplify SourceLocExpr::EvaluateInContext

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use ASTContext::MakeIntValue and remove the std::tie+lambda weirdness. Repository: rG

[PATCH] D155584: [clang][NFC] Simplify SourceLocExpr::EvaluateInContext

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I agree, this looks better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155584/new/ https://reviews.llvm.org/D155584 _

[PATCH] D155445: [analyzer][docs] Add CSA release notes

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/docs/ReleaseNotes.rst:908 + (`7cd1f3ad22e4 `_) +- Fixed a null-pointer dereference crash inside the ``MoveChecker``. + (`d172b65ef001 <

[PATCH] D155573: [Clang] Fix the location of default init expressions

aaron.ballman added a comment. Should this come with a release note or is it correcting functionality added for this release? Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} Shouldn'

[PATCH] D155573: [Clang] Fix the location of default init expressions

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} aaron.ballman wrote: > Shouldn't this test fail because `i != j`? > > Can you add a test that demonstrat

[PATCH] D155573: [Clang] Fix the location of default init expressions

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} cor3ntin wrote: > aaron.ballman wrote: > > Shouldn't this test fail because `i != j`? > > > > Can y

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

mstorsjo added subscribers: alvinhochun, jeremyd2019, jacek, aaron.ballman. mstorsjo added a comment. I'm looking to pick this up again - hopefully @rnk has time to discuss what would be a good way forward. So taking it from the top; both GCC and Clang generate `.refptr` stubs when referencing

[PATCH] D155573: [Clang] Fix the location of default init expressions

cor3ntin updated this revision to Diff 541473. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155573/new/ https://reviews.llvm.org/D155573 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D155573: [Clang] Fix the location of default init expressions

tbaeder added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} aaron.ballman wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > Shouldn't this test fail because `i

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

serge-sans-paille updated this revision to Diff 541475. serge-sans-paille added a comment. switch from cascading ternary operator to cascading if for readability. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155580/new/ https://reviews.llvm.org/D155580 Files: clang/lib/CodeGen/CGDec

[PATCH] D152793: [RISCV] Add MC layer support for Zicfisslp.

fakepaper56 updated this revision to Diff 541477. fakepaper56 added a comment. Herald added a subscriber: wangpc. Update instruction information and mark ssp as reserved register. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://re

[PATCH] D155573: [Clang] Fix the location of default init expressions

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} tbaeder wrote: > aaron.ballman wrote: > > cor3ntin wrote: > > > aaron.ballman wrote: > > > > Shouldn't th

[PATCH] D155573: [Clang] Fix the location of default init expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/SemaCXX/source_location.cpp:796 +static_assert(S(0).i == S{0}.i); +static_assert(S(0).j == S{0}.i); +} cor3ntin wro

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4507124 , @aaron.ballman wrote: > In D155457#4507107 , @xgupta wrote: > >> In D155457#4506405 , @xbolva00 >> wrote: >> >>> You should

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541480. hokein marked an inline comment as done. hokein added a comment. address comments - introduce `DiagKey` for the caching map - get rid of extra index conversion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein updated this revision to Diff 541481. hokein added a comment. more cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155173/new/ https://reviews.llvm.org/D155173 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/

[PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1913-1923 + if (D.isConstexpr()) +// Constexpr already initializes everything correctly. +trivialAutoVarInit = LangOptions::TrivialAutoVarInitKind::Uninitialized; + else if (D.getAttr()) +trivi

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541495. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Re

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 541496. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/Re

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

aaron.ballman added a comment. Just to clarify, this was a regression introduced during Clang 17 development and thus this doesn't need a release note? Comment at: clang/include/clang/Sema/Sema.h:6568 + CheckImmediateEscalatingFunctionDefinition(FunctionDecl *FD, +

Re: [PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

On Tue, Jul 18, 2023 at 8:41 PM serge via Phabricator < revi...@reviews.llvm.org> wrote: > serge-sans-paille created this revision. > serge-sans-paille added reviewers: nickdesaulniers, jfb, aaron.ballman. > Herald added a subscriber: kristof.beyls. > Herald added a project: All. > serge-sans-pail

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541502. FreddyYe added a comment. Split assembly tests and cover more registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541503. FreddyYe added a comment. Remove -x86-asm-syntax=intel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D155547: [analyzer] Model lifetime of a variable declared in for condition in CFG correctly

xazax.hun added inline comments. Comment at: clang/test/Analysis/auto-obj-dtors-cfg-output.cpp:1231 A a; - for (A b; A c = b; ) { + for (A b; A c = b; ++c.x) { A d; Would there be any value in also keeping a couple of the original test cases? (When we

[clang] 7324535 - [clang][NFC] Fix typos in sema builtins test

Author: Paweł Bylica Date: 2023-07-18T15:40:28+02:00 New Revision: 73245359847da385182dd3b3b2168e246a69a276 URL: https://github.com/llvm/llvm-project/commit/73245359847da385182dd3b3b2168e246a69a276 DIFF: https://github.com/llvm/llvm-project/commit/73245359847da385182dd3b3b2168e246a69a276.diff

[clang] 6236bf5 - [clang][dataflow] Strengthen flow condition assertions.

Author: Martin Braenne Date: 2023-07-18T13:41:43Z New Revision: 6236bf53418eb23c62a73d6346f0edec914084e7 URL: https://github.com/llvm/llvm-project/commit/6236bf53418eb23c62a73d6346f0edec914084e7 DIFF: https://github.com/llvm/llvm-project/commit/6236bf53418eb23c62a73d6346f0edec914084e7.diff LOG

[PATCH] D155067: [clang][dataflow] Strengthen flow condition assertions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6236bf53418e: [clang][dataflow] Strengthen flow condition assertions. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D154368: [Clang] Fix constraint checking of non-generic lambdas.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4718-4719 +def note_ovl_surrogate_constraints_not_satisfied : Note< +"candidate surrogate function %0 not viable: constraints " +"not satisfied">; def note_implicit_member_t

  1   2   3   4   >