xazax.hun accepted this revision. xazax.hun added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:908 + (`7cd1f3ad22e4 <https://github.com/llvm/llvm-project/commit/7cd1f3ad22e4>`_) +- Fixed a null-pointer dereference crash inside the ``MoveChecker``. + (`d172b65ef001 <https://github.com/llvm/llvm-project/commit/d172b65ef001>`_) ---------------- steakhal wrote: > xazax.hun wrote: > > steakhal wrote: > > > xazax.hun wrote: > > > > I think we usually do not mention crash fixes in the changelog. We have > > > > them in almost every release and sometimes there are quite a few of > > > > them. > > > I won't mention the explicit commit where it was fixed. > > > However, downstream users might wanna know about crashes and fixes that > > > happened in this release. > > > And speaking about past practices about release notes, I think we can > > > improve on that TBH. > > > We can move it down on the list if you want, but I'd rather keep it. > > Is this the only crash fix we had? Moving crash fixes to the bottom of the > > list sounds good to me. > No, it wasn't. We also had one for init-expr global variable initializers. [[ > https://github.com/llvm/llvm-project/commit/558b46fde2db | See ]] > I swept that fix under the carpet of "Fixed some bugs around the handling of > constant global arrays and their initializer expressions". I made it more > explicit now. > > However, at this point, I think it's okay to simply omit the mention of the > null deref crash fix. > Second thoughts? I have no strong preference, I am fine with both :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155445/new/ https://reviews.llvm.org/D155445 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
