[clang] 5f038e0 - [Clang][NFC] Fix "initalizer" typo

Author: Corentin Jabot Date: 2023-07-10T09:06:19+02:00 New Revision: 5f038e0e20641515fe412e1df298a62eb657f554 URL: https://github.com/llvm/llvm-project/commit/5f038e0e20641515fe412e1df298a62eb657f554 DIFF: https://github.com/llvm/llvm-project/commit/5f038e0e20641515fe412e1df298a62eb657f554.diff

[clang] 29f630a - [RISCV][MC] MC layer support for the experimental zacas extension

Author: Alex Bradbury Date: 2023-07-10T08:26:31+01:00 New Revision: 29f630a1ddcbb03caa31b5002f0cbc105ff3a869 URL: https://github.com/llvm/llvm-project/commit/29f630a1ddcbb03caa31b5002f0cbc105ff3a869 DIFF: https://github.com/llvm/llvm-project/commit/29f630a1ddcbb03caa31b5002f0cbc105ff3a869.diff

[PATCH] D149248: [RISCV][MC] MC layer support for the experimental zacas extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29f630a1ddcb: [RISCV][MC] MC layer support for the experimental zacas extension (authored by asb). Changed prior to commit: https://reviews.llvm.o

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon updated this revision to Diff 538531. Fznamznon added a comment. Rebase, add tests for dependent NameInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154689/new/ https://reviews.llvm.org/D154689 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D154736: [Driver][ARM] Warn about -mabi= for assembler input with -fno-integrated-as

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154736/new/ https://reviews.llvm.org/D154736 _

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin added a comment. > but right now I'm confused by the distinction… Why don't always evaluate the > message? 2 reasons - it would be a rather important breaking change for compiler who don't always use utf-8 at their literal encoding - we do not want to limit static_assert to the capabi

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. One problem this does not fix (but rather introduce) is that the `InterpState` will also free initmaps of global variables which haven't been fully initialized. When the initialization fails midway throught, the `InterpState` will free the `InitMap`, leaving the global

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

tbaeder added a comment. > Maybe you can show an example how this might look like in practice? AFAIU, the real-world case is more a C "class" struct with a couple of function pointers (a vtable), which might be different depending on circumstances. So, the problem with this (type of) analysis i

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 538545. cor3ntin added a comment. Add more lookup tests, including designated initializers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://reviews.llvm.org/D153536 Files: clang/docs/Releas

[PATCH] D154822: Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA

boxu-zhang created this revision. Herald added subscribers: mattd, yaxunl. Herald added a project: All. boxu-zhang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154822 File

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. Ok, then I think you can finally merge this commit and its two predecessors. I'm happy to see that this improvement is complete. I hope that you can later add a special case for the st

[clang] 36a1e99 - [ARM][Driver] Partial revert of D154578

Author: Michael Platings Date: 2023-07-10T10:10:38+01:00 New Revision: 36a1e998030d47097c4651e0b88595363a057952 URL: https://github.com/llvm/llvm-project/commit/36a1e998030d47097c4651e0b88595363a057952 DIFF: https://github.com/llvm/llvm-project/commit/36a1e998030d47097c4651e0b88595363a057952.di

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153776/new/ https://reviews.llvm.org/D153776 __

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 538549. cor3ntin added a comment. Add missing designated initializer test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://reviews.llvm.org/D153536 Files: clang/docs/ReleaseNotes.rst clan

[clang-tools-extra] 7ec9e20 - [clangd][c++20]Check for correct auto location in DeducedTypeVisitor

Author: Jens Massberg Date: 2023-07-10T11:33:42+02:00 New Revision: 7ec9e2048024daa2fbd02a1b64f62194326abbbd URL: https://github.com/llvm/llvm-project/commit/7ec9e2048024daa2fbd02a1b64f62194326abbbd DIFF: https://github.com/llvm/llvm-project/commit/7ec9e2048024daa2fbd02a1b64f62194326abbbd.diff

[PATCH] D154623: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec9e2048024: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1546

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added a comment. Following D148094 , the patch does not apply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146242/new/ https://reviews.llvm.org/D146242 ___ cfe-

[clang] a0130fc - [clang] Correct calculation of MemberExpr's dependence

Author: Mariya Podchishchaeva Date: 2023-07-10T06:00:11-04:00 New Revision: a0130fc51cbc0b0bbeca378a27430eba5136f142 URL: https://github.com/llvm/llvm-project/commit/a0130fc51cbc0b0bbeca378a27430eba5136f142 DIFF: https://github.com/llvm/llvm-project/commit/a0130fc51cbc0b0bbeca378a27430eba5136f1

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0130fc51cbc: [clang] Correct calculation of MemberExpr's dependence (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

skatrak updated this revision to Diff 538564. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154591/new/ https://reviews.llvm.org/D154591 Files: clang/docs/OffloadingDesign.rst clang/include/clang/Basic/LangOpti

[PATCH] D154827: [analyzer] NonParamVarRegion should prefer definition over canonical decl

steakhal created this revision. steakhal added reviewers: xazax.hun, donat.nagy, NoQ. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a reviewer: Szelethus. Herald added a project: All. steakhal reques

[PATCH] D154827: [analyzer] NonParamVarRegion should prefer definition over canonical decl

tomasz-kaminski-sonarsource accepted this revision. tomasz-kaminski-sonarsource added a comment. This revision is now accepted and ready to land. Looks good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154827/new/ https://reviews.llvm.org

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

JonChesterfield added a comment. The right thing to do on Linux for this is to query the driver directly. That is, the kernel should populate some string under /sys that we read. That isn't yet implemented. Does windows happen to have that functionality available? (landed here while trying to w

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

JonChesterfield added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:50 +#else + return printGPUsByHSA(); +#endif yaxunl wrote: > jhuber6 wrote: > > arsenm wrote: > > > The HIP path should work on linux too. I generally think we should build

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

arsenm added a comment. In D153725#4484711 , @JonChesterfield wrote: > The right thing to do on Linux for this is to query the driver directly. That > is, the kernel should populate some string under /sys that we read. That > isn't yet implemented. It

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

arsenm added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArchByHIP.cpp:80 +if (err != hipSuccess) { + llvm::errs() << "Failed to get device id for ordinal " << i << "\n"; + return 1; yaxunl wrote: > arsenm wrote: > > single quotes aro

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

JonChesterfield added a comment. In D153725#4484747 , @arsenm wrote: > In D153725#4484711 , > @JonChesterfield wrote: > >> The right thing to do on Linux for this is to query the driver directly. >> That is, the

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin updated this revision to Diff 538579. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. Address Sergei's feedback - Add more tests - Support non const member functions - Make sure diagnostics messages are never produced twice - Support returning intermediate objects fr

[PATCH] D154833: [clang][dataflow] Add `AnalysisInputs::withSolverFactory()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154833 Files

[PATCH] D154834: [clang][dataflow][NFC] Expand a comment.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added a comment. In D152495#4481588 , @aaron.ballman wrote: > This is a bit of an odd situation -- the condition variable *is* used (e.g., > its value is loaded to determine whether to go into the if branch or the else > branch), so we should

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet updated this revision to Diff 538591. hazohelet marked 5 inline comments as done. hazohelet added a comment. - Stop marking condition variable declarations as unused and diagnose all `VarDecl` that is marked used but not referenced - Added test not to warn when the declaration is not ag

[PATCH] D153738: Add LibClang guide

manuel5975p added a comment. I guess manuel5975p (manuel.wink...@gmx.ch) would be nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153738/new/ https://reviews.llvm.org/D153738 ___ cfe-commits mailing l

[PATCH] D154833: [clang][dataflow] Add `AnalysisInputs::withSolverFactory()`.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:180 + /// SAT solver factory. + std::function()> SolverFactory = [] { +return std::make_un

[PATCH] D154833: [clang][dataflow] Add `AnalysisInputs::withSolverFactory()`.

mboehme added a comment. libcxx failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154833/new/ https://reviews.llvm.org/D154833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

skatrak added a comment. This patch has been triggering a seemingly unrelated build error in libcxx, even after multiple rebases. Can I land it as-is or is this error something I should address first? Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

jhuber6 added a comment. Yeah that happens sometimes, if it's working on your system it's safe to assume it's fine. Worst case scenario you can always revert, it's not a big deal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154591/new/ https://r

[PATCH] D152554: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder

TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D154838: [analyzer] Add check for null pointer passed to %p of printf family

CuriousGeorgiy added a comment. Hi! This is my first time contributing to the LLVM project and particularly the clang static analyzer. This patch is based off https://reviews.llvm.org/D139604?id=481154. I have several questions regarding the reviewers comments (most of which I tried to address)

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

arsenm added a comment. In D153725#4484754 , @JonChesterfield wrote: > - if you open the driver too many times at once it fails to open, so running > a parallel build that uses this tool doesn't work on fast machines Why would this happen? Seems like a

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

arsenm added a comment. In D153725#4484754 , @JonChesterfield wrote: > The problem with using the proper API via HSA or similar is twofold: > > - we use this tool to enable tests, which means HSA has to exist before > building clang or the tests don't r

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 added a comment. In D153725#4484966 , @arsenm wrote: > In D153725#4484754 , > @JonChesterfield wrote: > >> - if you open the driver too many times at once it fails to open, so running >> a parallel build

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63ca93c7d1d1: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags (authored by skatrak). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske added a comment. It would be more simple to handle the standard streams in `StreamChecker` only. There it is possible to detect standard streams (should be variables with the known names) as arguments to functions. If `StreamChecker` eliminates the failure branch of `fileno` it will di

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c:100 struct packed_struct on_callee_stack; on_callee_stack = va_arg(vl, struct packed_struct); } Can we add some `CHECK:` lines here and to other variadic functi

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

arsenm added a comment. In D153725#4484973 , @arsenm wrote: > In D153725#4484754 , > @JonChesterfield wrote: > >> The problem with using the proper API via HSA or similar is twofold: >> >> - we use this tool to e

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

JonChesterfield added a comment. In D153725#4484966 , @arsenm wrote: > In D153725#4484754 , > @JonChesterfield wrote: > >> - if you open the driver too many times at once it fails to open, so running >> a parall

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

JonChesterfield added a comment. The test detection is an awkward compromise between people who want to run the GPU tests and people who don't, and reflects diverse hardware in use and variation on whether cuda / hsa are installed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 added a comment. In D153725#4485039 , @arsenm wrote: > And the libomptarget build is in fact doing that, but it shouldn't have to. > What it's doing actually seems really unreasonable. It's only building the > locally found targets when it shoul

[PATCH] D154833: [clang][dataflow] Add `AnalysisInputs::withSolverFactory()`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc13c884727: [clang][dataflow] Add `AnalysisInputs::withSolverFactory()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 8bc13c8 - [clang][dataflow] Add `AnalysisInputs::withSolverFactory()`.

Author: Martin Braenne Date: 2023-07-10T13:43:13Z New Revision: 8bc13c884727f0b9be876303d654dd1eda300dc3 URL: https://github.com/llvm/llvm-project/commit/8bc13c884727f0b9be876303d654dd1eda300dc3 DIFF: https://github.com/llvm/llvm-project/commit/8bc13c884727f0b9be876303d654dd1eda300dc3.diff LOG

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 538633. v.g.vassilev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41416/new/ https://reviews.llvm.org/D41416 Files: clang/include/clang/AST/DeclTemplate.h clang/lib/AST/DeclTemplate.cpp clang/lib/AST/ODRHash.cpp

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:85 auto Task = [FIndex(FIndex), Path(Path.str()), Version(Version.str()), - ASTCtx(std::move(ASTCtx)), - CanonIncludes(CanonIncludes)]() mutable { +

[PATCH] D154850: [libc] Remove GPU string functions incompatible with C++

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, sivachandra, lntue, michaelrj, ronlieb. Herald added projects: libc-project, All. Herald added a subscriber: libc-commits. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a su

[PATCH] D154850: [libc] Remove GPU string functions incompatible with C++

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Is this a const thing? If so I'd naively hope we can declare both in C++ mode and alias them, but I can believe that is detectably broken. How does glibc manage their hack?

[clang] 12d72e4 - Add libClang guide

Author: manuel5975p Date: 2023-07-10T11:15:48-04:00 New Revision: 12d72e4fdee91b3f1e314759d6aa33d25fb38f86 URL: https://github.com/llvm/llvm-project/commit/12d72e4fdee91b3f1e314759d6aa33d25fb38f86 DIFF: https://github.com/llvm/llvm-project/commit/12d72e4fdee91b3f1e314759d6aa33d25fb38f86.diff L

[PATCH] D153738: Add LibClang guide

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12d72e4fdee9: Add libClang guide (authored by manuel5975p, committed by aaron.ballman). Herald added a subscriber: arphaman. Changed prior to commit

[PATCH] D153738: Add LibClang guide

aaron.ballman added a comment. In D153738#4484865 , @manuel5975p wrote: > I guess manuel5975p (manuel.wink...@gmx.ch) would be nice Thank you for the new documentation, it's really appreciated! I've landed this on your behalf in 12d72e4fdee91b3f1e31475

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2436 +CF.getVarDecl()->getLocation()); + break; +} tbaeder wrote: > aaronpuchert wrote: > > aaronpuchert wrote: > > > tbaeder wrote

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

aaron.ballman added a comment. In D154675#4484194 , @cor3ntin wrote: > Thanks, this looks good! (the libc++ test seems completely unrelated, it > happens before compilation starts). > Can you add re release note though? Thanks! +1 to both of these sente

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Thi

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

aaron.ballman accepted this revision. aaron.ballman added a comment. I think this is a good NFC change as it brings us one TINY step closer towards supporting platforms where `CHAR_BIT != 8`. But I agree with Corentin that a lot more work needs to happen to support that kind of target; restartin

[clang] b454e7a - [libc] Remove GPU string functions incompatible with C++

Author: Joseph Huber Date: 2023-07-10T10:40:10-05:00 New Revision: b454e7aa7ceb35a0070406ebd7ffdf1ed85f5ef8 URL: https://github.com/llvm/llvm-project/commit/b454e7aa7ceb35a0070406ebd7ffdf1ed85f5ef8 DIFF: https://github.com/llvm/llvm-project/commit/b454e7aa7ceb35a0070406ebd7ffdf1ed85f5ef8.diff

[PATCH] D154850: [libc] Remove GPU string functions incompatible with C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb454e7aa7ceb: [libc] Remove GPU string functions incompatible with C++ (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 86943d8 - Formula.h - fix MSVC "'clang::dataflow::Formula::numOperands': not all control paths return a value". NFC.

Author: Simon Pilgrim Date: 2023-07-10T16:55:52+01:00 New Revision: 86943d863ef66d68bf79d3e2f0ec2c205814b235 URL: https://github.com/llvm/llvm-project/commit/86943d863ef66d68bf79d3e2f0ec2c205814b235 DIFF: https://github.com/llvm/llvm-project/commit/86943d863ef66d68bf79d3e2f0ec2c205814b235.diff

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

tejohnson created this revision. tejohnson added reviewers: snehasish, davidxl. Herald added subscribers: wlei, Enna1, ormris, wenlei, steven_wu, hiraditya. Herald added a project: All. tejohnson requested review of this revision. Herald added a subscriber: MaskRay. Herald added projects: clang, LL

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao updated this revision to Diff 538678. rZhBoYao edited the summary of this revision. rZhBoYao added a comment. Defaults to on for C++23 only. Enable for all the language modes in another patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdFormatCheck.cpp:46 +void UseStdFormatCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(argumentCountAtLeast(1), hasArgument(0, stringLiteral()), --

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rZhBoYao updated this revision to Diff 538688. rZhBoYao edited the summary of this revision. rZhBoYao added a comment. Reverse the dependency chain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153156/new/ https://reviews.llvm.org/D153156 Files: clang/docs/ReleaseNotes.rst clang/i

[PATCH] D154822: Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA

tra added a reviewer: tra. tra added a comment. Looking at CUDA headers, it appears that changing only compiler-generated-glue may be insufficient. A lot of other CUDA API calls need to be changed to `_ptsz` variant and for that we need to have `CUDA_API_PER_THREAD_DEFAULT_STREAM` defined. Re

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

steakhal added a comment. Please, let me have a look at this stack tomorrow or the day after prior landing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153612/new/ https://reviews.llvm.org/D153612

[PATCH] D154861: [clang][AST] Propagate the contains-errors bit to DeclRefExpr from VarDecl's initializer.

hokein created this revision. hokein added reviewers: aaron.ballman, shafik, sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Similar to the https://reviews.llvm.org/D86048 (it only sets the bit for C++ code), we propagate the contain

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153969/new/ https://reviews.llvm.org/D153969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

aaron.ballman added a comment. In general, I think this is a good approach. However, it sort of kicks the can down the road a bit; we will still overflow the member if there are enough fields. Would it make sense to also add a diagnostic to Sema so that overflow with the widened fields is diagn

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao marked 6 inline comments as done. rZhBoYao added a comment. In D152632#4443284 , @shafik wrote: > I am wondering why we don't fold this into `-Wreserved-identifier` The "ud-suffix" of the user-defined-string-literal or the identifier in a liter

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

tra added a comment. Looks good in general. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7221-7223 +bool UseApproxTranscendentals = false; +if (Args.hasFlag(options::OPT_ffast_math, options::OPT_fno_fast_math, + false)) ``` bool

[clang] bbd0d12 - Implement -frecord-command-line for XCOFF

Author: Jake Egan Date: 2023-07-10T12:47:07-04:00 New Revision: bbd0d123d3aaa67d8bed9d16d9001b33540fc04d URL: https://github.com/llvm/llvm-project/commit/bbd0d123d3aaa67d8bed9d16d9001b33540fc04d DIFF: https://github.com/llvm/llvm-project/commit/bbd0d123d3aaa67d8bed9d16d9001b33540fc04d.diff LOG

[PATCH] D153600: Implement -frecord-command-line for XCOFF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbd0d123d3aa: Implement -frecord-command-line for XCOFF (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154861: [clang][AST] Propagate the contains-errors bit to DeclRefExpr from VarDecl's initializer.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please be sure to add a release note (and the newline at the end of the test file). Thank you for the fix! Comment at: clang/test/AST/ast-dump-recove

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

jroelofs added a comment. I don't think those failures look related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rZhBoYao updated this revision to Diff 538707. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153156/new/ https://reviews.llvm.org/D153156 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/Lex/Lexer.cpp clang/lib/Sema/SemaExprCXX.cpp cl

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin updated this revision to Diff 538709. yronglin added a comment. Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784 Files: clang/docs/ReleaseNotes.rst clang/include/clan

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

tmgross added a comment. Herald added a subscriber: wangpc. What is the current status of this patch? Are the reviewers here OK with this fix in general but just need to see changes to autoupgrade? @craig.topper or @hvdijk since you worked on it, are you interested in doing these changes, or is

[clang] 26718d9 - [Driver][ARM] Warn about -mabi= for assembler input with -fno-integrated-as

Author: Fangrui Song Date: 2023-07-10T10:02:27-07:00 New Revision: 26718d931feea5b72fafa2e91a15ee5080db4c22 URL: https://github.com/llvm/llvm-project/commit/26718d931feea5b72fafa2e91a15ee5080db4c22 DIFF: https://github.com/llvm/llvm-project/commit/26718d931feea5b72fafa2e91a15ee5080db4c22.diff

[PATCH] D154736: [Driver][ARM] Warn about -mabi= for assembler input with -fno-integrated-as

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26718d931fee: [Driver][ARM] Warn about -mabi= for assembler input with -fno-integrated-as (authored by MaskRay). Repository: rG LLVM Github Monore

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin updated this revision to Diff 538712. yronglin marked 2 inline comments as done. yronglin added a comment. Update comments in PseudoObjectExpr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784 Fil

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

MaskRay added a comment. > At Indel, we have been building bare-metal embedded applications that run on > custom PowerPC and ARM systems with Clang and LLD for a couple of years now, > using target triples powerpc-indel-eabi, powerpc-indel-eabi750, > arm-indel-eabi, aarch64-indel-eabi (which I

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin added a comment. In D154784#4485752 , @aaron.ballman wrote: > In general, I think this is a good approach. However, it sort of kicks the > can down the road a bit; we will still overflow the member if there are > enough fields. Would it make s

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

craig.topper added a comment. In D86310#4485837 , @tmgross wrote: > What is the current status of this patch? Are the reviewers here OK with this > fix in general but just need to see changes to autoupgrade? > > @craig.topper or @hvdijk since you worked o

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

jroelofs added a comment. gcc docs seem to indicate that these are valid triples: https://gcc.gnu.org/install/specific.html#powerpc-x-eabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

hvdijk added a comment. In D86310#4485837 , @tmgross wrote: > What is the current status of this patch? Are the reviewers here OK with this > fix in general but just need to see changes to autoupgrade? > @craig.topper or @hvdijk since you worked on it,

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

hubert.reinterpretcast added a comment. In D153536#4483191 , @hubert.reinterpretcast wrote: > Similarly, only one local variable out of two in the same line reported: I can confirm that adding a lexical block scope causes both variables to be recorded

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

snehasish added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemProfiler.cpp:912 +const TargetLibraryInfo &TLI = FAM.getResult(F); +readMemprof(M, F, MemProfReader.get(), TLI); + } I think we can we split this patch into two to make t

[clang] d77588d - [llvm][vfs] For virtual directories, use the virtual path as the real path

Author: Jan Svoboda Date: 2023-07-10T10:41:15-07:00 New Revision: d77588df4553f0e93a74e6eab33e1ce87b576320 URL: https://github.com/llvm/llvm-project/commit/d77588df4553f0e93a74e6eab33e1ce87b576320 DIFF: https://github.com/llvm/llvm-project/commit/d77588df4553f0e93a74e6eab33e1ce87b576320.diff L

[PATCH] D135849: [llvm][vfs] For virtual directories, use the virtual path as the real path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd77588df4553: [llvm][vfs] For virtual directories, use the virtual path as the real path (authored by jansvoboda11). Repository: rG LLVM Github Mo

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro created this revision. Herald added subscribers: sunshaoce, mstorsjo. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. pscoro requested review of this revision. Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits, jpl

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

tejohnson added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemProfiler.cpp:912 +const TargetLibraryInfo &TLI = FAM.getResult(F); +readMemprof(M, F, MemProfReader.get(), TLI); + } snehasish wrote: > I think we can we split this patch

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

MaskRay added inline comments. Comment at: clang/test/Driver/hip-options.hip:179 +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -nogpuinc -nogpulib -fgpu-approx-transcendentals \ +// RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefixes=APPROX %s + -

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:382-383 on overload resolution, when the actual reason for the failure is loss of other qualifiers. +- Clang contexpr evaluator now displays notes as well as an error when a constructor + of base c

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro added inline comments. Comment at: flang/cmake/modules/AddFlang.cmake:68 llvm_add_library(${name} ${LIBTYPE} ${ARG_UNPARSED_ARGUMENTS} ${srcs}) + set_target_properties(${name} PROPERTIES POSITION_INDEPENDENT_CODE ON) This is something I am still inve

  1   2   3   >