aaron.ballman accepted this revision.
aaron.ballman added a comment.

I think this is a good NFC change as it brings us one TINY step closer towards 
supporting platforms where `CHAR_BIT != 8`. But I agree with Corentin that a 
lot more work needs to happen to support that kind of target; restarting the 
discussion on the linked RFC would be a good idea if you plan to aim for full 
support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154773/new/

https://reviews.llvm.org/D154773

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to