arsenm added a comment.

In D153725#4484754 <https://reviews.llvm.org/D153725#4484754>, @JonChesterfield 
wrote:

> The problem with using the proper API via HSA or similar is twofold:
>
> - we use this tool to enable tests, which means HSA has to exist before 
> building clang or the tests don't run and HSA now requires clang to build

I don't follow this. You don't need this to work to perform the build and test 
build. You may need it to execute the tests, but if HSA doesn't exist they 
won't be able to run anyway. If a build is invoking these tools at cmake time 
it's just broken


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153725/new/

https://reviews.llvm.org/D153725

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to