[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder added a comment. The changes in https://reviews.llvm.org/D149828 missed one case, the `(E->getStorageDuration() == SD_Static) && SubExprT` one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475 ___

[clang] ddd8c61 - [clang][Interp][NFC] Add Descriptor::isCompositeArray()

Author: Timm Bäder Date: 2023-07-05T09:05:53+02:00 New Revision: ddd8c61ee5540bb7f428ea47018c4e88aea8fd87 URL: https://github.com/llvm/llvm-project/commit/ddd8c61ee5540bb7f428ea47018c4e88aea8fd87 DIFF: https://github.com/llvm/llvm-project/commit/ddd8c61ee5540bb7f428ea47018c4e88aea8fd87.diff LO

[clang] 3edc419 - [clang][Interp][NFC] Fix a doc comment

Author: Timm Bäder Date: 2023-07-05T09:05:53+02:00 New Revision: 3edc419b7e531ee4f290862b9fe3ac574162fe06 URL: https://github.com/llvm/llvm-project/commit/3edc419b7e531ee4f290862b9fe3ac574162fe06 DIFF: https://github.com/llvm/llvm-project/commit/3edc419b7e531ee4f290862b9fe3ac574162fe06.diff LO

[clang] 05bc1d0 - [clang][Interp][NFC] Move a declaration into an if statement

Author: Timm Bäder Date: 2023-07-05T09:05:54+02:00 New Revision: 05bc1d0e7c9abbbcd52ea1f2b6da29da8d311bd2 URL: https://github.com/llvm/llvm-project/commit/05bc1d0e7c9abbbcd52ea1f2b6da29da8d311bd2 DIFF: https://github.com/llvm/llvm-project/commit/05bc1d0e7c9abbbcd52ea1f2b6da29da8d311bd2.diff LO

[clang] b1a0197 - [clang][Interp][NFC] Remove unnecessary else blocks

Author: Timm Bäder Date: 2023-07-05T09:05:54+02:00 New Revision: b1a019747e6862346bc3c9b679e4d46baaff5ab9 URL: https://github.com/llvm/llvm-project/commit/b1a019747e6862346bc3c9b679e4d46baaff5ab9 DIFF: https://github.com/llvm/llvm-project/commit/b1a019747e6862346bc3c9b679e4d46baaff5ab9.diff LO

[PATCH] D154477: [include-cleaner] Ignore the layering-violation errors for the standalone tool

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. If the source code is compilable-but-layzering-violation, we still want the tool to be functional on it (rather than ba

[PATCH] D154478: [analyzer][NFC] Use unique_ptrs for PathDiagnosticConsumers

steakhal created this revision. steakhal added reviewers: xazax.hun, NoQ. Herald added subscribers: PiotrZSL, carlosgalvezp, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a reviewer: Szelethus. Herald added a rev

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/AnalysisManager.cpp:54 + for (PathDiagnosticConsumer *Consumer : PathConsumers) { +delete Consumer; } steakhal wrote: > xazax.hun wrote: > > Hm, I wonder whether we actually want to

[clang] 80c6792 - [clang][Tooling] Add mapping for make_error_code

Author: Kadir Cetinkaya Date: 2023-07-05T09:35:28+02:00 New Revision: 80c6792200380699bf8cc9837ac2c02e64a1b78b URL: https://github.com/llvm/llvm-project/commit/80c6792200380699bf8cc9837ac2c02e64a1b78b DIFF: https://github.com/llvm/llvm-project/commit/80c6792200380699bf8cc9837ac2c02e64a1b78b.dif

[PATCH] D154473: [clang][Tooling] Add mapping for make_error_code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80c679220038: [clang][Tooling] Add mapping for make_error_code (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D154473?v

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154479: [clang][dataflow] Bug fix: `BuiltinFnToFnPtr` cast does not produce a pointer.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See comments in the code for details. Reposito

[PATCH] D154479: [clang][dataflow] Bug fix: `BuiltinFnToFnPtr` cast does not produce a pointer.

mboehme added a comment. See also https://github.com/google/crubit/commit/381e2b904073a1c6490f1e1c323eb1b8e5b8595f for a corresponding change in the Crubit nullability checker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154479/new/ https://rev

[PATCH] D154481: [analyzer] Remove deprecated analyzer-config options

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus, xazax.hun. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revision. Herald

[PATCH] D154481: [analyzer] Remove deprecated analyzer-config options

steakhal added a comment. I'll mention this change in the Release Notes separately as we are getting closer and closer to branching off for the clang-17 release on 25th of July. Read more here . Repository: rG LLVM G

[PATCH] D154481: [analyzer] Remove deprecated analyzer-config options

steakhal added a comment. The option was deprecated in D138659 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154481/new/ https://reviews.llvm.org/D154481 ___ cfe-commit

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. In D153366#4471460 , @sammccall wrote: > In D153366#4471320 , @TWeaver wrote: > >> My apologies but I've had to revert this change for now until the author can >> address the buildbot fai

[PATCH] D151696: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon accepted this revision. RKSimon added a comment. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-commits mailing list cfe-commits@

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:138 + /// Returns the path (without surrounding quotes/brackets) for the header.

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D15

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

donat.nagy added a comment. These code changes seem to be promising. Please upload results on the open source projects (like the ones that you uploaded previously), and I hope that after verifying those I we can finally merge this set of commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154477: [include-cleaner] Ignore the layering-violation errors for the standalone tool

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:99 + bool BeginInvocation(CompilerInstance &CI) override { +// Disable the clang-module-bas

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. Ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:484 + S.Signature = RemoveFirstTemplateArg(S.Signature); + S.SnippetSuffix = RemoveFirstTemplateArg(

[PATCH] D151696: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7717c0071d7c: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGE

[clang] 7717c00 - [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

Author: Freddy Ye Date: 2023-07-05T17:32:00+08:00 New Revision: 7717c0071d7ce9f4ca7b1417f677bb0380171621 URL: https://github.com/llvm/llvm-project/commit/7717c0071d7ce9f4ca7b1417f677bb0380171621 DIFF: https://github.com/llvm/llvm-project/commit/7717c0071d7ce9f4ca7b1417f677bb0380171621.diff LOG

[PATCH] D151696: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. Thank so much on all your comments/review to make this happen. Cheers~! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-commit

[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We did not return an error when failing to producing a valid expression when performing the initialization of an aggregate

[clang] 2e90370 - [Clang] Reset FP options before function instantiations

Author: Serge Pavlov Date: 2023-07-05T16:34:19+07:00 New Revision: 2e903709de003dc6ae980197f4a0850a158dd9b8 URL: https://github.com/llvm/llvm-project/commit/2e903709de003dc6ae980197f4a0850a158dd9b8 DIFF: https://github.com/llvm/llvm-project/commit/2e903709de003dc6ae980197f4a0850a158dd9b8.diff

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:56-64 + template struct NodeData { +// The block from which the interval was constructed. It is either the +// graph's entry block or has at least one predecessor outs

[PATCH] D154478: [analyzer][NFC] Use unique_ptrs for PathDiagnosticConsumers

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154478/new/ https://reviews.llvm.org/D154478 __

[clang-tools-extra] 1af0e34 - [clangd][c++20] Drop first template argument in code completion in some contexts.

Author: Jens Massberg Date: 2023-07-05T12:04:24+02:00 New Revision: 1af0e34477a3b4a28a1c251e527c9f75f5cf69e1 URL: https://github.com/llvm/llvm-project/commit/1af0e34477a3b4a28a1c251e527c9f75f5cf69e1 DIFF: https://github.com/llvm/llvm-project/commit/1af0e34477a3b4a28a1c251e527c9f75f5cf69e1.diff

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1af0e34477a3: [clangd][c++20] Drop first template argument in code completion in some… (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 537286. hnrklssn added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Add unnamed global test case Added cases in generated-funcs.c with --check-globals all, testing that named and unnamed globals are matched diff

[PATCH] D154467: [clang-format] Add Verilog suffixes to the scripts

MyDeveloperDay added a comment. What would happen for say unicode escapes? x = "XXXThis is a string \u0041 With stuff after"; would it break after the \u? x = "XXXThis is a string \u 0041 With stuff after"; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added a comment. (The patch description could use an update...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. A thousand times yes! Comment at: clang/docs/ClangFormatStyleOptions.rst:4354 + + * ``RPS_None`` (in configuration: ``None``) +Do not remove parentheses.

[PATCH] D154478: [analyzer][NFC] Use unique_ptrs for PathDiagnosticConsumers

steakhal planned changes to this revision. steakhal added a comment. Hm, it seems like it broke some CSA unittests. I'll look into that once I have some time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154478/new/ https://reviews.llvm.org/D1544

[PATCH] D153001: [clang][ThreadSafety] Add __builtin_instance_member (WIP)

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153001/new/ https://reviews.llvm.org/D153001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154492: [Clang] Fix handling of using declarations in for loop init statements.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The type was never saved, and therefore never transformed in dependent contexts. Repository: rG LLVM Github Monorepo

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

hokein added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; yronglin wrote: > yronglin wrote: > > aaron.ballman wrote: > > > yronglin wrote: > > > > hokein wrote: > > > > > The constant evaluator

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

MyDeveloperDay added a comment. What would happen for say unicode escapes? x = "XXXThis is a string \u0041 With stuff after"; would it break after the \u? x = "XXXThis is a string \u 0041 With stuff after"; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:199 +if (EscapeSequence && Advance == 2) { + switch (Text[1]) { Can we add a unit test for escape sequences > \X which I assume this handles Repository: rG LLVM G

[PATCH] D153001: [clang][ThreadSafety] Add __builtin_instance_member (WIP)

aaronpuchert added a comment. We probably parse the attributes delayed in C++ but not in C. This probably also means you can't refer to later members in the attribute, so the mutex always needs to come first, right? Not sure if such a limitation is expected for C developers. Repository: rG

[clang-tools-extra] 67e94c9 - [include-cleaner] Ignore the layering-violation errors for the standalone tool

Author: Haojian Wu Date: 2023-07-05T13:30:26+02:00 New Revision: 67e94c9dc8ff7ac49f2557e02fdf375edd850d76 URL: https://github.com/llvm/llvm-project/commit/67e94c9dc8ff7ac49f2557e02fdf375edd850d76 DIFF: https://github.com/llvm/llvm-project/commit/67e94c9dc8ff7ac49f2557e02fdf375edd850d76.diff LO

[PATCH] D154477: [include-cleaner] Ignore the layering-violation errors for the standalone tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG67e94c9dc8ff: [include-cleaner] Ignore the layering-violation errors for the standalone tool (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D154477?vs=537240&id=537292#toc Repo

[clang] 1c3ac8d - Reland "[dataflow] Add dedicated representation of boolean formulas"

Author: Sam McCall Date: 2023-07-05T13:35:16+02:00 New Revision: 1c3ac8dfa16c42a631968aadd0396cfe7f7778e0 URL: https://github.com/llvm/llvm-project/commit/1c3ac8dfa16c42a631968aadd0396cfe7f7778e0 DIFF: https://github.com/llvm/llvm-project/commit/1c3ac8dfa16c42a631968aadd0396cfe7f7778e0.diff LO

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

FreddyYe created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; hokein wrote: > hokein wrote: > > hokein wrote: > > > yronglin wrote: > > > > yronglin wrote: > > > > > aaron.ballman wrote: > >

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm created this revision. arsenm added reviewers: yaxunl, Anastasia, jcranmer-intel, tra, jlebar, jhuber6. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. Herald added a reviewer: jdoerfert. OpenCL and HIP have -cl-fp32-c

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:61 + /// Passing in the same formula will result in the same BoolValue. + /// FIXME: This canonicalization isn't sound e.g. if we create t

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 537299. hnrklssn added a comment. Update test cases after rebasing on ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 Files: clang/test/utils/update_cc_test_ch

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG5e4ad816bf10: [dataflow] Replace most BoolValue subclasses with references to Formula (and… (authored by

[clang] 5e4ad81 - [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

Author: Sam McCall Date: 2023-07-05T13:54:32+02:00 New Revision: 5e4ad816bf100b0325ed45ab1cfea18deb3ab3d1 URL: https://github.com/llvm/llvm-project/commit/5e4ad816bf100b0325ed45ab1cfea18deb3ab3d1 DIFF: https://github.com/llvm/llvm-project/commit/5e4ad816bf100b0325ed45ab1cfea18deb3ab3d1.diff LO

[clang] 8a3fdf7 - [UTC] Add fallback support for specific metadata, and check their defs

Author: Henrik G. Olsson Date: 2023-07-05T14:04:50+02:00 New Revision: 8a3fdf7b908978625e9a7e57fbb443e4e6f98976 URL: https://github.com/llvm/llvm-project/commit/8a3fdf7b908978625e9a7e57fbb443e4e6f98976 DIFF: https://github.com/llvm/llvm-project/commit/8a3fdf7b908978625e9a7e57fbb443e4e6f98976.di

[clang] 7157956 - [dataflow] use true/false literals in formulas, rather than variables

Author: Sam McCall Date: 2023-07-05T14:06:48+02:00 New Revision: 71579569f4399d3cf6bc618dcd449b5388d749cc URL: https://github.com/llvm/llvm-project/commit/71579569f4399d3cf6bc618dcd449b5388d749cc DIFF: https://github.com/llvm/llvm-project/commit/71579569f4399d3cf6bc618dcd449b5388d749cc.diff LO

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71579569f439: [dataflow] use true/false literals in formulas, rather than variables (authored by sammccall). Changed prior to commit: https://revi

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:333 { {"pentium"}, CK_Pentium, ~0U, FeatureX87 | FeatureCMPXCHG8B, 'B', false }, { {"pentium-mmx"}, CK_PentiumMMX, ~0U, FeaturesPentiumMMX, '\0', false }, { {"pentium_mmx"}, CK_PentiumMM

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

john.brawn created this revision. john.brawn added reviewers: dexonsmith, rsmith, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. UnresolvedSet::erase works by popping the last element then

[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

aaron.ballman added a comment. Precommit CI found issues with the newly added test that should be addressed. Comment at: clang/docs/ReleaseNotes.rst:633-634 (`#63012 `_) +- Fix a crash when trying to parentheses-initialize a

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn created this revision. john.brawn added reviewers: dexonsmith, rsmith, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a function is declared in the same scope as a class wit

[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

cor3ntin updated this revision to Diff 537319. cor3ntin added a comment. Address Aaron's Feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154486/new/ https://reviews.llvm.org/D154486 Files: clang/lib/Sema/SemaInit.cpp clang/test/SemaCXX/

[PATCH] D86993: Document Clang's expectations of the C standard library.

aaron.ballman added a comment. In D86993#4471912 , @RalfJung wrote: > What is the status of this patch? It has not been committed as far as I can > tell. Correct, it's not been committed yet. we're still discussing (though that's obviously stalled out a

[clang] 4a49226 - [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

Author: Akash Banerjee Date: 2023-07-05T14:03:54+01:00 New Revision: 4a49226537abafc9b372ba8ef61d14a817a5226a URL: https://github.com/llvm/llvm-project/commit/4a49226537abafc9b372ba8ef61d14a817a5226a DIFF: https://github.com/llvm/llvm-project/commit/4a49226537abafc9b372ba8ef61d14a817a5226a.diff

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 537331. to268 added a comment. I have fixed the misleading diagnostic with auto array declarations. The diagnostics now says that `'auto' is not allowed in array declarations`. I am not sure with the way i have currently implemented it in ` SemaDecl.cpp`, mayb

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

aaron.ballman added reviewers: clang-language-wg, cor3ntin. aaron.ballman added a comment. Thank you for working on this! Comment at: clang/lib/Sema/SemaCast.cpp:1269-1272 +ResultType = Self.Context.getConstantArrayType( +IAT->getElementType(), +llvm::APInt(

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske added a comment. Results from the last run (the same applies as before, the run postfix `_3` must be selected at top right corner): | memcached_1.6.8_stdclf_notetag_interesting_test_3 | Reports

[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154486/new/ https://reviews.llvm.org/D154486 _

[PATCH] D154349: [include-cleaner] Add a signal to down-rank exporting headers

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154349/new/ https://reviews.llvm.org/D154349

[clang-tools-extra] 5933d26 - [include-cleaner] Add a signal to down-rank exporting headers

Author: Kadir Cetinkaya Date: 2023-07-05T15:37:17+02:00 New Revision: 5933d265b72a8e9aade5edd68998a00dc4fbb359 URL: https://github.com/llvm/llvm-project/commit/5933d265b72a8e9aade5edd68998a00dc4fbb359 DIFF: https://github.com/llvm/llvm-project/commit/5933d265b72a8e9aade5edd68998a00dc4fbb359.dif

[PATCH] D154349: [include-cleaner] Add a signal to down-rank exporting headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG5933d265b72a: [include-cleaner] Add a signal to down-rank exporting headers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154349/new/

[clang] 1bc7f3f - [Clang] Fix a crash when trying to initialize an invalid aggregate.

Author: Corentin Jabot Date: 2023-07-05T15:45:46+02:00 New Revision: 1bc7f3fb936724dd7a2d0b5ac91f773d3168a5f0 URL: https://github.com/llvm/llvm-project/commit/1bc7f3fb936724dd7a2d0b5ac91f773d3168a5f0 DIFF: https://github.com/llvm/llvm-project/commit/1bc7f3fb936724dd7a2d0b5ac91f773d3168a5f0.diff

[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bc7f3fb9367: [Clang] Fix a crash when trying to initialize an invalid aggregate. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHA

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154502/new/ https://reviews.llvm.org/D154502 __

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske updated this revision to Diff 537346. balazske added a comment. Added AT_FDCWD `openat` test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154423/new/ https://reviews.llvm.org/D154423 Files: clang/lib/StaticAnalyzer/Checkers/StdLibrary

[PATCH] D153881: Create diagnostic group for definition deprecation warning

aaron.ballman added a comment. In D153881#4468597 , @nuriamari wrote: > In D153881#4467127 , @aaron.ballman > wrote: > >> I think it's a bit odd that we'd leave `const` under `-Wdeprecated` but >> separate `cons

[PATCH] D154509: [clang][analyzer] StdLibraryFunctionsChecker: Allow NULL buffer in `fread` and `fwrite` if size is zero.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[clang] 07630da - Minor change to clang test

Author: Akash Banerjee Date: 2023-07-05T14:56:45+01:00 New Revision: 07630da36a31596594a1ba3b9f000dc57d5382f3 URL: https://github.com/llvm/llvm-project/commit/07630da36a31596594a1ba3b9f000dc57d5382f3 DIFF: https://github.com/llvm/llvm-project/commit/07630da36a31596594a1ba3b9f000dc57d5382f3.diff

[PATCH] D154492: [Clang] Fix handling of using declarations in for loop init statements.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/SemaCXX/cxx23-init-statement.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify=expected -std=c++23 -Wall %s + This s

[PATCH] D153695: [clang][Interp] Fix passing parameters of composite type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with debugging code removed and comments cleaned up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153695/new/ https://review

[PATCH] D154492: [Clang] Fix handling of using declarations in for loop init statements.

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx23-init-statement.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify=expected -std=c++23 -Wall %s + aaron.ballman wrote: > This should suffice, yes? Yep! Repository: rG LLVM Github Monorepo CHANG

[clang] 1077a34 - [Clang] Fix handling of using declarations in for loop init statements.

Author: Corentin Jabot Date: 2023-07-05T16:20:53+02:00 New Revision: 1077a343911127452615c6f5441c121de06be6d5 URL: https://github.com/llvm/llvm-project/commit/1077a343911127452615c6f5441c121de06be6d5 DIFF: https://github.com/llvm/llvm-project/commit/1077a343911127452615c6f5441c121de06be6d5.diff

[PATCH] D154492: [Clang] Fix handling of using declarations in for loop init statements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1077a3439111: [Clang] Fix handling of using declarations in for loop init statements. (authored by cor3ntin). Changed prior to commit: https://rev

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added a subscriber: clang-vendors. aaron.ballman added a comment. In D105759#4457041 , @cor3ntin wrote: > In D105759#4456864 , @aaron.ballman > wrote: > >> I don't think it's correct to assume that

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw added a comment. It won't break the string inside an escape sequence. But escape sequences like `\040`, `\x20`, and `\u0020` don't get recognized as whitespace. Comment at: clang/lib/Format/BreakableToken.cpp:199 +if (EscapeSequence && Advance == 2) { + swit

[clang] 4ade8b7 - [AST] Fix bug in UnresolvedSet::erase of last element

Author: John Brawn Date: 2023-07-05T16:02:40+01:00 New Revision: 4ade8b7ed9976303b23cff3525223826e65b46e7 URL: https://github.com/llvm/llvm-project/commit/4ade8b7ed9976303b23cff3525223826e65b46e7 DIFF: https://github.com/llvm/llvm-project/commit/4ade8b7ed9976303b23cff3525223826e65b46e7.diff LO

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ade8b7ed997: [AST] Fix bug in UnresolvedSet::erase of last element (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

gedare updated this revision to Diff 537359. gedare added a comment. Merge the two if statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153585/new/ https://reviews.llvm.org/D153585 Files: clang/lib/Format/WhitespaceManager.cpp clang/un

[PATCH] D153579: [clang-format] Fix RAS reference alignment when PAS is left or middle

gedare updated this revision to Diff 537363. gedare edited the summary of this revision. gedare added a comment. Use suggested shorter logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153579/new/ https://reviews.llvm.org/D153579 Files: clang/

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

unterumarmung added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/EnumSizeCheck.cpp:127-128 + + diag(MatchedDecl->getLocation(), "enum %0 derive from %1 of size %2 bytes, " + "derive from '%3' to reduce it size to %4") +

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added reviewers: dblaikie, echristo. aaron.ballman added a comment. CCing David and Eric -- do you see any concerns regarding debug information for these changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://revi

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/EnumSizeCheck.cpp:127-128 + + diag(MatchedDecl->getLocation(), "enum %0 derive from %1 of size %2 bytes, " + "derive

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537377. Jake-Egan added a comment. Rerun CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/llvm/CodeG

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin added a subscriber: hubert.reinterpretcast. cor3ntin added a comment. Some tests with lldb (lldb) b main Breakpoint 1: where = placeholder`main + 4 at debug_placeholder.cpp:2:9, address = 0x5134 (lldb) run Process 4044833 launched: '/home/cor3ntin/dev/compilers/LLVM

[PATCH] D154520: [UTC] Adapt version matcher to glob CLANG_VENDOR

hnrklssn created this revision. hnrklssn added reviewers: nikic, abrachet. Herald added subscribers: StephenFan, arichardson. Herald added a project: All. hnrklssn requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Both the p

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias updated this revision to Diff 537383. galenelias edited the summary of this revision. galenelias added a comment. I re-wrote the alignment to stop using AlignTokens so that I can now handle all the edge cases that came up. Specifically: - Allowing empty case labels (implicit fall thr

[clang] 2583221 - Fix compile error in UnresolvedSetTest.cpp with -Wall

Author: John Brawn Date: 2023-07-05T17:39:59+01:00 New Revision: 258322105892bd895a89ccbe89487885581f5a47 URL: https://github.com/llvm/llvm-project/commit/258322105892bd895a89ccbe89487885581f5a47 DIFF: https://github.com/llvm/llvm-project/commit/258322105892bd895a89ccbe89487885581f5a47.diff LO

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/paren-list-agg-init.cpp:276-285 +namespace gh62863 { +int (&&arr)[] = static_cast(42); +// beforecxx20-warning@-1 {{aggregate initialization of type 'int[1]' from a parenthesized list of values is a C++20 extension}

[PATCH] D154520: [UTC] Adapt version matcher to glob CLANG_VENDOR

abrachet accepted this revision. abrachet added a comment. This revision is now accepted and ready to land. That works. Thanks a lot, @hnrklssn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154520/new/ https://reviews.llvm.org/D154520

  1   2   3   >