kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:99
+ bool BeginInvocation(CompilerInstance &CI) override {
+ // Disable the clang-module-based layering-violation checks.
+ // These checks emit errors for a compilable source code. We want the tool
----------------
maybe mention the general stance against diagnostics here?
```
We only want to perform include-cleaner analysis. So we disable diagnostics
that won't affect our analysis to make the tool more robust against
in-development code.
```
and then follow up with specific around disabling decluse
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154477/new/
https://reviews.llvm.org/D154477
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
