steakhal added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/AnalysisManager.cpp:54
+ for (PathDiagnosticConsumer *Consumer : PathConsumers) {
+ delete Consumer;
}
----------------
steakhal wrote:
> xazax.hun wrote:
> > Hm, I wonder whether we actually want to use `unique_ptr`s to make the
> > ownership explicit. Feel free to leave as is in this PR.
> The ownership model of these consumers is so messed up.
> It's not that simple to fix. I was bitten by dangling consumers/graphs so
> many times now only counting **last** year.
> So, yea. Maybe one day.
Fixed by https://reviews.llvm.org/D154478
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154325/new/
https://reviews.llvm.org/D154325
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
