[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 533155. FreddyYe added a comment. Add missing FeatureCMOV in X8TargetParser.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1586 +/** +\brief Peeks next after next token I don't think this style of comment is common in llvm. Comment at: llvm/lib/Target/RISCV/AsmParse

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 533161. FreddyYe added a comment. debug typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/Basic/Targets/X86.

[PATCH] D153403: [RISCV] Use unsigned types for orc_b builtins.

craig.topper created this revision. craig.topper added reviewers: Jim, asb. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrt

[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.

VincentWu accepted this revision. VincentWu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153161/new/ https://reviews.llvm.org/D153161 _

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:407 +// reference the declaration. +if (ContextKind == CodeCompletionContext::CCC_ObjCClassForwardDecl) + ShouldInsert = false; rather than doing this here, can you

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

barannikov88 added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1610 +} + } while (NonComments < 2 and ReadCount > 0); + return NextNextToken; This is much more common. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder updated this revision to Diff 533175. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/ThreadSafety.cpp clang/test/Sema/warn-thread-safety-ana

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added a comment. Added a new element for cleanup functions. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2436 +CF.getVarDecl()->getLocation()); + break; +} This handles the function call, but witho

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 533182. HaohaiWen marked 10 inline comments as done. HaohaiWen added a comment. Address maskray's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files:

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added inline comments. Comment at: clang/include/clang/Driver/Options.td:1167 // GCC style -dumpdir. We intentionally don't implement the less useful -dumpbase{,-ext}. -def dumpdir : Separate<["-"], "dumpdir">, Flags<[CC1Option]>, +def dumpdir : Separate<["-"], "dumpd

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

ilya-biryukov added a comment. In D153294#4435767 , @rsmith wrote: > A constant expression (including the immediate invocations generated for > `consteval` functions) is a full-expression, so destructors should be run at > the end of evaluating it, not

[clang] 72ac907 - [C++20] [Modules] Use the canonical decl when getting associated constraints

Author: Chuanqi Xu Date: 2023-06-21T17:00:56+08:00 New Revision: 72ac90715876e2963af899cbb883bad1e07b67bd URL: https://github.com/llvm/llvm-project/commit/72ac90715876e2963af899cbb883bad1e07b67bd DIFF: https://github.com/llvm/llvm-project/commit/72ac90715876e2963af899cbb883bad1e07b67bd.diff LO

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij updated this revision to Diff 533190. stuij added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp llvm/include/

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 533191. abel-bernabeu added a comment. Addressed some review comments: - Doxygen-style comments are not common, so using triple-slash instead. - Using a regular C array on a place where the usage of SmallVector is not justified. - Proper capitalization

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 533193. abel-bernabeu added a comment. Reduced the commit message verbosity by one half, without losing anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 533194. abel-bernabeu added a comment. Even less verbosity... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 Files: llvm/lib/Target/RISCV/AsmParser/RISCVAsmP

[clang] dfb85c3 - [Clang][Interp] Diagnose uninitialized ctor of global record arrays

Author: Takuya Shimizu Date: 2023-06-21T19:03:01+09:00 New Revision: dfb85c3ce09a7bd1a059a3e821390b5111454f9e URL: https://github.com/llvm/llvm-project/commit/dfb85c3ce09a7bd1a059a3e821390b5111454f9e DIFF: https://github.com/llvm/llvm-project/commit/dfb85c3ce09a7bd1a059a3e821390b5111454f9e.diff

[PATCH] D152548: [Clang][Interp] Diagnose uninitialized ctor of global record arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfb85c3ce09a: [Clang][Interp] Diagnose uninitialized ctor of global record arrays (authored by hazohelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1525

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 533204. massberg marked 2 inline comments as done. massberg added a comment. Switched the "Hover, All" test to run with C++20 instead of C++17 and moved the RewrittenBinaryOperatorSpaceship test to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:4051 +TEST(Hover, RewrittenBinaryOperatorSpaceshipMassberg) { + Annotations T(R"cpp( sammccall wrote: > massberg wrote: > >

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 533211. massberg marked an inline comment as done. massberg added a comment. clang-format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files: clang-tools-e

[PATCH] D153409: BEGIN_PUBLIC [clang][dataflow] Treat fields of anonymous records as being part of their parent.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See https://en.cppreference.com/w/c/language/str

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon added a comment. > Thanks! We don't have any tests that break with this change, so I assume this > is not tested. I suppose it could also be that in most cases we have enough places in Sema adding `ExprWithCleanups`. While trying to figure out why we need `ExprWithCleanups` wrapping

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 533214. to268 marked 8 inline comments as done. to268 added a comment. I have updated and fixed all minors comments about the test cases. I have added the diagnostic to warn users about using a Clang extension when declaring an explicit `auto*` in pedantic mode

[PATCH] D153409: BEGIN_PUBLIC [clang][dataflow] Treat fields of anonymous records as being part of their parent.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:5433 +// that `i` is modeled. +S->getChild(*IDecl); + });

[PATCH] D153409: BEGIN_PUBLIC [clang][dataflow] Treat fields of anonymous records as being part of their parent.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:5433 +// that `i` is modeled. +S->getChild(*IDecl); + }); sammccall wrote: > assert that the result i

[PATCH] D153379: Remove -flang-experimental-exec flag

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. This is in line with the conclusions of https://discourse.llvm.org/t/proposal-rename-flang-new-to-flang/: > We should remove the need for the -flang-experimental-exec flag. There’s no

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added a comment. Please can you cleanup the summary, as it isn't very easy to understand at the moment. Possibly split into a series of bullet points describing the changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https:/

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:9567 unsigned EltSize = Context.getTypeSize(Info.ElementType); unsigned MinElts = Info.EC.getKnownMinValue(); I think I'd suggest just changing the types of these two variables in

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:886-887 TopLevelCase = Case; - else + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseSt

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

Szelethus added a comment. In D152436#4432736 , @balazske wrote: > From these two solutions, which one is better? (Show many unnecessary notes, > or show only necessary ones but lose some of the useful notes too.) How likely are the problems with the 2n

[PATCH] D153409: [clang][dataflow] Treat fields of anonymous records as being part of their parent.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:305 +if (Field->isAnonymousStructOrUnion()) + getFieldsFromClassHierarchy(Field->getType(), Fields); +else C

[clang] 6e04287 - [SystemZ] Fix regression in test macro-prefix-map-lambda.cpp

Author: Kai Nacke Date: 2023-06-21T12:53:15Z New Revision: 6e042871837b0c87e045d1a16929a7da4412e073 URL: https://github.com/llvm/llvm-project/commit/6e042871837b0c87e045d1a16929a7da4412e073 DIFF: https://github.com/llvm/llvm-project/commit/6e042871837b0c87e045d1a16929a7da4412e073.diff LOG: [Sy

[PATCH] D153352: [SystemZ] Fix regression in test macro-prefix-map-lambda.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e042871837b: [SystemZ] Fix regression in test macro-prefix-map-lambda.cpp (authored by Kai). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1854 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; Should this be doing the cast? The overloaded operat

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sunfish added a comment. This patch appears to be just the release notes and the test; is the actual driver change missing? Comment at: clang/docs/ReleaseNotes.rst:706 + limited to the Emscripten target OS and now works with other targets such as + wasm32-wasi. ---

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1854 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; aaron.ballman wrote: > Should this be doing the cast? The

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with the Dynamic bit pulled. Comment at: clang/lib/AST/Interp/Interp.h:1854 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind)

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

abhina.sreeskantharajan created this revision. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is adding a wrapper class called CharSetConverter for ConverterEBCDIC which was

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan created this revision. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds iconv support to the CharSetConverter class. Repository: rG LLVM Github

[PATCH] D153419: Enable fexec-charset option

abhina.sreeskantharajan created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This patch enables the fexe

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4437583 , @sunfish wrote: > This patch appears to be just the release notes and the test; is the actual > driver change missing? Sorry -- this is the first time I've used `arc`, and I apparently messed up. I meant to

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

tbaeder updated this revision to Diff 533238. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153276/new/ https://reviews.llvm.org/D153276 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Disasm.cpp clang/lib/AST/Interp/Int

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4436629 , @sbc100 wrote: > I'm happy to merge it, but perhaps we should get @sunfish to lg too. > > Also, should we remove the `-experimental-pic` linker flag, or are you OK > with that warning from the linker? If yes,

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan abandoned this revision. abhina.sreeskantharajan added a comment. I have opened a new patch https://reviews.llvm.org/D153419 and am closing this revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://revi

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

donat.nagy added a comment. In D152436#4432736 , @balazske wrote: > [...] > From these two solutions, which one is better? (Show many unnecessary notes, > or show only necessary ones but lose some of the useful notes too.) I think we must avoid pollutin

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 533243. dicej added a comment. update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChains/W

[PATCH] D153423: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, isuckatcs, JonasToth, baloghadamsoftware. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subs

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4435677 , @hoy wrote: > Hello, I'm seeing a build failure that seems related to this patch. I'm > seeing the patch has been relanded and reverted a couple times and not sure > where it is right now. Can you please

[PATCH] D153424: [clang][ASTImporter] Add import of CXXRewrittenBinaryOperator.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

steakhal resigned from this revision. steakhal added a comment. I resign as a reviewer as I'm not deeply connected to this checker, thus I won't block it or accept it. However, my opinion is that a checker should be "released" if they have clear diagnostics (which includes that it doesn't flood

[PATCH] D153423: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/exception-escape.rst:29 +and destructors, it is a clear indication of the developer's intention and +should be respected.. + Double period. Repository: rG LLV

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added a comment. In D153293#4437644 , @dicej wrote: > In D153293#4436629 , @sbc100 wrote: > >> I'm happy to merge it, but perhaps we should get @sunfish to lg too. >> >> Also, should we remove the `-experim

[PATCH] D153338: [clang-format] vim integration: Mention python3 variant of bindings

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153338/new/ https://reviews.llvm.org/D153338 ___

[PATCH] D153418: Adding iconv support to CharSetConverter class

michaelplatings added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:62 +if(Iconv_FOUND AND NOT Iconv_IS_BUILT_IN) + set(system_libs ${system_libs} ${Iconv_LIBRARIES}) +endif() This doesn't look like an idomatic way to link a library. Could you use

[PATCH] D153430: Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings created this revision. michaelplatings added reviewers: peter.smith, DavidSpickett. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald ad

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added a comment. My only concern is that this changes behaviour without someone making the conscious decision to make that change, now as much as I can't understand why someone would want to put the `}` onto the same line, it will only take on person to say "hey I liked it like t

[PATCH] D152975: [clang-format] Allow break after return keyword

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1484 LLVMStyle.PenaltyBreakFirstLessLess = 120; + LLVMStyle.PenaltyBreakReturn = 100; LLVMStyle.PenaltyBreakString = 1000; is 100 the current penalty? Comment

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

tejohnson added a comment. In D152741#4422462 , @modimo wrote: > In D152741#4421067 , @tejohnson > wrote: > >> In D152741#4419366 , @modimo wrote: >> >>> In D152741#44193

[clang] 9741ac5 - [clang-format] vim integration: Mention python3 variant of bindings

Author: Jannik Silvanus Date: 2023-06-21T17:18:36+02:00 New Revision: 9741ac5b3b3e7942e3332e37af829e58e5e2bb82 URL: https://github.com/llvm/llvm-project/commit/9741ac5b3b3e7942e3332e37af829e58e5e2bb82 DIFF: https://github.com/llvm/llvm-project/commit/9741ac5b3b3e7942e3332e37af829e58e5e2bb82.dif

[PATCH] D153338: [clang-format] vim integration: Mention python3 variant of bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rG9741ac5b3b3e: [clang-format] vim integration: Mention python3 variant of bindings (authored by jsilvanus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1533

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

tigermoth added a comment. Now that AES, SHA2, SHA3 and SM4 features have been removed from armv8.6-a, these Apple CPUs can be changed again from 8.5-a to more correctly specified as armv8.6-a https://reviews.llvm.org/D141606?id=488968 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

donat.nagy added a comment. In D152436#4437822 , @steakhal wrote: > In D152436#4437692 , @donat.nagy > wrote: > >> Personally I think it's completely acceptable if the analyzer sometimes >> emits bug reports tha

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hoy added a comment. In D144006#4437804 , @dzhidzhoev wrote: > In D144006#4435677 , @hoy wrote: > >> Hello, I'm seeing a build failure that seems related to this patch. I'm >> seeing the patch has been relanded

[PATCH] D153379: Remove -flang-experimental-exec flag

PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. All builds and tests correctly and looks good. @everythingfunctional, can you please post on Discourse about this change when you merge? Since we've discussed this with the community, I think we should let them know that this

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo added a comment. In D152741#4438007 , @tejohnson wrote: > Ok what I missed is that you don't want to apply this to entire TUs, but > rather just some paths that are header files, which may be included in many > source files. So in your above exam

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo updated this revision to Diff 533326. modimo added a comment. Address feedback. Allow empty string to unset the flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152741/new/ https://reviews.llvm.org/D152741 Files: clang/include/clang/Bas

[PATCH] D153379: Remove -flang-experimental-exec flag

everythingfunctional added a comment. In D153379#4438419 , @PeteSteinfeld wrote: > All builds and tests correctly and looks good. > > @everythingfunctional, can you please post on Discourse about this change > when you merge? Since we've discussed this

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 54. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/IdentifierTable.h clang/include/clang/Basic/TokenKinds.def clang/include/clang/Basic/TokenKinds.h clang/lib/B

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); } rjmcca

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:1167 // GCC style -dumpdir. We intentionally don't implement the less useful -dumpbase{,-ext}. -def dumpdi

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added a comment. CodeView is the default debug info format for COFF. Perhaps `-gsplit-dwarf` should be rejected when the default `-gcodeview` is used, with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.l

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

cjdb added a comment. I like this patch, thanks for working on it 😄 In D153359#4436873 , @hazohelet wrote: > Consider the following code. (I added another parameter to the original code > so that the covered range becomes clearer) > > void func(int aa

[PATCH] D143241: [Clang] Reset FP options before function instantiations

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143241/new/ https://reviews.llvm.org/D143241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D143241: [Clang] Reset FP options before function instantiations

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143241/new/ https://reviews.llvm.org/D143241 ___

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

cjdb added a comment. I think this will be a good addition because it underscores the salient part of why the function isn't viable. Would it be possible for patches like this to have both examples of before and after this patch in their commit message please? That'll help expose why patches l

[PATCH] D153419: Enable fexec-charset option

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6864 + CmdArgs.push_back("-fexec-charset"); + CmdArgs.push_back(Args.MakeArgString(Triple.getSystemCharset())); if (Arg *execCharset = Args.getLastArg(options::OPT_fexec_charset_EQ)) {

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan updated this revision to Diff 533352. abhina.sreeskantharajan added a reviewer: michaelplatings. abhina.sreeskantharajan added a comment. Use target_link_libraries instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153418/

[PATCH] D143241: [Clang] Reset FP options before function instantiations

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:1736 + // point of the template definition. + Actions.resetFPOptions(LPT.FPO); + Ah, is this bug specific to the MSVC-compatible template logic? Repository: rG LLVM Github Monorep

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:62 +if(Iconv_FOUND AND NOT Iconv_IS_BUILT_IN) + set(system_libs ${system_libs} ${Iconv_LIBRARIES}) +endif() michae

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

rjmccall added a comment. Yes, this is very close, thank you. Comment at: clang/include/clang/Basic/TokenKinds.def:805 +INTERESTING_IDENTIFIER(float_t) +INTERESTING_IDENTIFIER(double_t) +INTERESTING_IDENTIFIER(FILE) I think it would be cleaner if you added thes

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam updated this revision to Diff 533360. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/IdentifierTable.h clang/include/clang/Basic/TokenKinds.def clang/inc

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. In D153293#4437877 , @sbc100 wrote: > In D153293#4437644 , @dicej wrote: > >> In D153293#4436629 , @sbc100 wrote: >> >>> I'm happy to merge it, but

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

efriedma added a comment. As I mentioned at https://discourse.llvm.org/t/rfc-enabling-fexec-charset-support-to-llvm-and-clang-reposting/71512 , I think SimplifyLibCalls needs to be aware of encodings. To make that work, this probably needs to be somewhere in llvm/ , not clang/ . Repository:

[PATCH] D153418: Adding iconv support to CharSetConverter class

efriedma added a comment. This doesn't really address the concerns from https://discourse.llvm.org/t/rfc-adding-a-charset-converter-to-the-llvm-support-library/69795/17 about consistency. It's bad if different hosts support a different set of charsets/charset names, and it's really bad if a gi

[PATCH] D153205: [clang-format] Add new block type ListInit

HazardyKnusperkeks added a comment. In D153205#4437966 , @MyDeveloperDay wrote: > My only concern is that this changes behaviour without someone making the > conscious decision to make that change, now as much as I can't understand why > someone would

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:347 +return triple + m = re.match(r"(\w+)-(\w+)-(\w+)", triple) dicej wrote: > sbc100 wrote: > > Are the the changes to this file meant to be part of this CL? > The `

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

dblaikie added a comment. I haven't looked closely at this, but from a vague/quick reading, it sounds like this is creating annotations on certain type DINodes, but then moving them around to different types? It'd be nice if we could avoid that/create them in the right place in the first place.

[PATCH] D153458: [clang-tidy] Model noexcept more properly in bugprone-exception-escape

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, isuckatcs, JonasToth, baloghadamsoftware. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subs

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2077 + for (const auto &[VD, Fixables] : FixablesForUnsafeVars.byVar) { FixItsForVariable[VD] = NoQ wrote: > There's a bug in variable naming: `FixablesForUnsafeVars`

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

iains added a comment. In D152946#4431974 , @h-vetinari wrote: > Mark P2615 as implemented in > https://github.com/llvm/llvm-project/blame/main/clang/www/cxx_status.html? In D152946#4431974

[PATCH] D153462: [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D153462 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

NoQ added a comment. Uh-oh, looks like I'm not paying nearly enough attention to this discussion (sorry about that!!) I'm somewhat skeptical of the decision made in D151225 because the entire reason I originally implemented `StdCLibraryFunctions` was to deal

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 533375. dicej added a comment. remove config.py changes per review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

h-vetinari added a comment. Does https://clang.llvm.org/docs/OpenMPSupport.html need an update? It still says "Clang fully supports OpenMP 4.5" (with many 5.0/5.1 features marked as "worked on" / "unclaimed"), which would make it unusual to put the default on a version that's (according to that

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

NoQ added a comment. > In this case function `fileno` returns -1 because of failure, but this is not > indicated in a `NoteTag`. This is a correct result, only the note is missing. > This problem can be solved if a note is displayed on every branch ("case") of > the standard C functions. But th

  1   2   >