Fznamznon added a comment. > Thanks! We don't have any tests that break with this change, so I assume this > is not tested.
I suppose it could also be that in most cases we have enough places in Sema adding `ExprWithCleanups`. While trying to figure out why we need `ExprWithCleanups` wrapping immediate invocations I came to https://reviews.llvm.org/D63960 . There is https://reviews.llvm.org/D63960#inline-613559 asking to add wrapping that with an example, I added this example to the test and I suppose it didn't break after change since there is still an `ExprWithCleanups` around, I suppose it was added in another place. In fact, I can't come up with the test that this patch would break. Either `ExprWithCleanups` is redundant or added by different parts of Sema. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153294/new/ https://reviews.llvm.org/D153294 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
