[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

nridge added a comment. I believe this was superseded by D151190 , should we close this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125863/new/ https://reviews.llvm.org/D125863

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

eopXD updated this revision to Diff 528717. eopXD marked 3 inline comments as done. eopXD added a comment. Address comments from Craig. Also simplify code to get VectorTypeModifer for tuples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152070/new/

[PATCH] D151867: [Clang][RISCV] Make generic clz/ctz builtins defined for zero on RISCV targets.

Yunzezhu updated this revision to Diff 528698. Yunzezhu added a comment. I made the flag isCLZForZeroUndef set to false only when target support extension zbb or xtheadbb, and this will prevent making codegen worse when target does not support abb or xtheadbb. Repository: rG LLVM Github Mono

[PATCH] D152197: [NFC][CLANG] Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

sdesmalen added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9 if ((OperationKind == ACK_Arithmetic) && ((LHSBuiltinTy && LHSBuiltinTy->isSVEBool()) || (RHSBuiltinTy && RHSBuiltinTy->isSVEBool( { This doesn't seem like a non-

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse marked an inline comment as done. akshaykhadse added inline comments. Comment at: llvm/test/CodeGen/X86/movdir64b-inline-asm-x86_64.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2 +; RUN: llc < %s -mtriple=x8

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended consstructors parameters

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #63119 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152242 Files: clang/docs/ReleaseNotes.r

[PATCH] D152076: [8/11][Clang][RISCV] Expand all variants for indexed strided segment load

eopXD updated this revision to Diff 528729. eopXD added a comment. Add curly bracket. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152076/new/ https://reviews.llvm.org/D152076 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeG

[PATCH] D151867: [Clang][RISCV] Make generic clz/ctz builtins defined for zero on RISCV targets.

asb added a comment. Could you please post a separate patch that has a test that will show the codegen change (and demonstrate how it is unchanged when zbb or xtheadbb)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151867/new/ https://reviews.llv

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. @jacquesguan I'm not sure on the standardisation process or status for these intrinsics. Perhaps @kito-cheng has an idea? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d511e1864f1: [ARM][Driver] Warn if -mhard-float is incompatible (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 1d511e1 - [ARM][Driver] Warn if -mhard-float is incompatible

Author: Michael Platings Date: 2023-06-06T09:08:37+01:00 New Revision: 1d511e1864f142d08a491a89940d70c516a6c6a2 URL: https://github.com/llvm/llvm-project/commit/1d511e1864f142d08a491a89940d70c516a6c6a2 DIFF: https://github.com/llvm/llvm-project/commit/1d511e1864f142d08a491a89940d70c516a6c6a2.di

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

sdesmalen added a comment. Other than the two nits, the patch looks good. Thanks. Comment at: clang/include/clang/Basic/arm_sme.td:82 +def NAME # _H : SInst<"svread_hor_" # n_suffix # "[_{d}]", "ddPimi", t, MergeOp1, + "aarch64_sme_read" # !cond(!e

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

tbaeder created this revision. tbaeder added reviewers: delesley, aaronpuchert, Eugene.Zelenko, aaron.ballman. Herald added a reviewer: NoQ. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When we're cal

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9921-9922 return EmitSMEReadWrite(TypeFlags, Ops, Builtin->LLVMIntrinsic); + else if (TypeFlags.isZero()) +return EmitSMEZero(TypeFlags, Ops, Builtin->LLVMIntrinsic); Given t

[clang] 648931b - [clang][ThreadSafety][NFC] Make isReference() const

Author: Timm Bäder Date: 2023-06-06T11:19:53+02:00 New Revision: 648931ba6137ab6bfdecbc7512599943ed709d04 URL: https://github.com/llvm/llvm-project/commit/648931ba6137ab6bfdecbc7512599943ed709d04 DIFF: https://github.com/llvm/llvm-project/commit/648931ba6137ab6bfdecbc7512599943ed709d04.diff LO

[PATCH] D152250: [Clang][RISCV] Add test cases for intrinsics clz/ctz codegen when has extension zbb/xtheadbb

Yunzezhu created this revision. Yunzezhu added reviewers: asb, craig.topper, kito-cheng. Yunzezhu added a project: clang. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D151867: [Clang][RISCV] Make generic clz/ctz builtins defined for zero on RISCV targets.

Yunzezhu added a comment. In D151867#4398483 , @asb wrote: > Could you please post a separate patch that has a test that will show the > codegen change (and demonstrate how it is unchanged when zbb or xtheadbb)? Sure. I post a patch to demonstrate curre

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

tbaeder added a comment. Added some more reviewers based on lines owned in `CFG.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152093/new/ https://reviews.llvm.org/D152093 ___ cfe-commits mailing li

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

TWeaver added a comment. Good morning from the UK! I believe this change has caused the following buildbot to start failing: https://lab.llvm.org/buildbot/#/builders/139/builds/42214 Is anyone able to take a look? Much obliged, Tom W Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 2c60f9c - [clang][analyzer] Add report of NULL stream to StreamChecker.

Author: Balázs Kéri Date: 2023-06-06T11:51:33+02:00 New Revision: 2c60f9c8a4fdfce7f33493f874893e1c8c8143c1 URL: https://github.com/llvm/llvm-project/commit/2c60f9c8a4fdfce7f33493f874893e1c8c8143c1 DIFF: https://github.com/llvm/llvm-project/commit/2c60f9c8a4fdfce7f33493f874893e1c8c8143c1.diff L

[PATCH] D152169: [clang][analyzer] Add report of NULL stream to StreamChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c60f9c8a4fd: [clang][analyzer] Add report of NULL stream to StreamChecker. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152169/new/

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

Pierre-vh created this revision. Pierre-vh added reviewers: arsenm, tra, foad. Herald added subscribers: StephenFan, wenlei, tpr. Herald added a project: All. Pierre-vh requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Device libs make u

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Thanks Tom, I'll work on it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap

egorzhdan closed this revision. egorzhdan added a comment. Looks like https://reviews.llvm.org/D150773 got there first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149850/new/ https://reviews.llvm.org/D149850

[clang] fcd2fad - Revert "[ARM][Driver] Warn if -mhard-float is incompatible"

Author: Michael Platings Date: 2023-06-06T11:05:46+01:00 New Revision: fcd2fadd0b8c2c2140615efaa9df0148f004f8dd URL: https://github.com/llvm/llvm-project/commit/fcd2fadd0b8c2c2140615efaa9df0148f004f8dd DIFF: https://github.com/llvm/llvm-project/commit/fcd2fadd0b8c2c2140615efaa9df0148f004f8dd.di

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon updated this revision to Diff 528769. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151553/new/ https://reviews.llvm.org/D151553 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTransform.h cl

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

TWeaver added a comment. Thanks for the speedy reply and action! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/Inputs/ocml-sample-target-attrs.cl:2 +__attribute__((target("gfx11-insts"))) +unsigned do_intrin_stuff(void) +{ Sound really be ulong Comment at: clang/test/CodeGenCUDA/link-bui

[clang] 28ba4b2 - [ARM][Driver] Warn if -mhard-float is incompatible

Author: Michael Platings Date: 2023-06-06T11:39:19+01:00 New Revision: 28ba4b23177e90fa94c88f0bd9a99eb46dbc82c3 URL: https://github.com/llvm/llvm-project/commit/28ba4b23177e90fa94c88f0bd9a99eb46dbc82c3 DIFF: https://github.com/llvm/llvm-project/commit/28ba4b23177e90fa94c88f0bd9a99eb46dbc82c3.di

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Relanded with the warning in the "OptionIgnored" group which fixes the test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 _

[PATCH] D151337: ARM: default to arm_aapcscc (or VFP) for embedded MachO targets.

t.p.northover added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151337/new/ https://reviews.llvm.org/D151337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

cfe-commits@lists.llvm.org

massberg added a comment. In D148924#4391190 , @ilya-biryukov wrote: > @massberg did we figure out if there is anything else left from P2002R1? Are > there blockers to landing this? The only thing I came across was https://reviews.llvm.org/D151200 (err

[PATCH] D152255: [analyzer][NFC] Pass the diagnostic message to the TrackConstraintBRVisitor

donat.nagy created this revision. donat.nagy added reviewers: gamesh411, steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. donat.nagy re

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

Pierre-vh updated this revision to Diff 528793. Pierre-vh marked 3 inline comments as done. Pierre-vh added a comment. target-cpu wasn't set so I tried something a bit different, but now I still need to remove the target-cpu check in the old test. For some reason filecheck doesn't match it but it

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

Pierre-vh updated this revision to Diff 528794. Pierre-vh added a comment. Fix check lines, I think it's just FileCheck weirdness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152251/new/ https://reviews.llvm.org/D152251 Files: clang/lib/CodeGen

[PATCH] D152259: [Clang] Make increment bool SFINAE-friendly

yronglin created this revision. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: yronglin Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152259 Files: clang/lib/Sem

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7013a751f170: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 7013a75 - [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

Author: Sander de Smalen Date: 2023-06-06T12:07:43Z New Revision: 7013a751f170d829b35e7bb153d3334d144d5d54 URL: https://github.com/llvm/llvm-project/commit/7013a751f170d829b35e7bb153d3334d144d5d54 DIFF: https://github.com/llvm/llvm-project/commit/7013a751f170d829b35e7bb153d3334d144d5d54.diff L

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended consstructors parameters

aaron.ballman added a comment. In the patch summary: consstructors -> constructors Can you also add a test case to cover "unless that parameter-declaration appears in a default argument" from http://eel.is/c++draft/temp.res#general-4.3.3 ? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended consstructors parameters

cor3ntin updated this revision to Diff 528811. cor3ntin added a comment. Add test for default parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152242/new/ https://reviews.llvm.org/D152242 Files: clang/docs/ReleaseNotes.rst clang/lib/Pa

[PATCH] D152255: [analyzer][NFC] Pass the diagnostic message to the TrackConstraintBRVisitor

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152255/new/ https://reviews.llvm.org/D152255 ___

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended constructors parameters

aaron.ballman added inline comments. Comment at: clang/test/CXX/temp/temp.res/p4.cpp:182-183 + friend X::X(T::type); + friend X::X(T::type = (int)(void(*)(typename T::type))(nullptr)); // expected-error {{friend declaration specifying a default argument must be a definition}}

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended constructors parameters

cor3ntin added inline comments. Comment at: clang/test/CXX/temp/temp.res/p4.cpp:182-183 + friend X::X(T::type); + friend X::X(T::type = (int)(void(*)(typename T::type))(nullptr)); // expected-error {{friend declaration specifying a default argument must be a definition}} + f

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended constructors parameters

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/CXX/temp/temp.res/p4.cpp:182-183 + friend X::X(T::type); + friend X::X(T::type = (int)(void(*)(typename T::type))(nullptr)); //

[PATCH] D146023: [AMDGPU] Remove Code Object V2

Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:520 - assert(Func.getCallingConv() == CallingConv::AMDGPU_KERNEL || - Func.getCallingConv() == CallingConv::SPIR_KERNEL); + if (Func.getCallingConv() != CallingConv::AMDG

cfe-commits@lists.llvm.org

ilya-biryukov accepted this revision as: ilya-biryukov. ilya-biryukov added a comment. This revision is now accepted and ready to land. Since there are not remaining blockers, LGTM from my side. I suggest waiting for ~day to give chance to other reviewers. @shafik, @aaron.ballman, @rsmith please

[clang] 920aa39 - Switch from full to unreleased for a Clang 17 fix; NFC

Author: Aaron Ballman Date: 2023-06-06T08:58:31-04:00 New Revision: 920aa39568f61b7d413fd543fbf4975b188798a5 URL: https://github.com/llvm/llvm-project/commit/920aa39568f61b7d413fd543fbf4975b188798a5 DIFF: https://github.com/llvm/llvm-project/commit/920aa39568f61b7d413fd543fbf4975b188798a5.diff

cfe-commits@lists.llvm.org

aaron.ballman added a comment. LGTM aside from a minor issue with the status page (we use `unreleased` until the current version is released). Comment at: clang/www/cxx_status.html:1008 https://wg21.link/p2002r1";>P2002R1 -Partial +Clang 17 ---

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

aaron.ballman added a comment. In D151607#4383132 , @kazu wrote: > In D151607#4380757 , @erichkeane > wrote: > >> Since this is part of the public API, do we need to publish/alert folks of >> this? This could p

[PATCH] D152259: [Clang] Make increment bool SFINAE-friendly

erichkeane added a comment. This should have a release note. I think the bug is asking to make this a SFINAE failure (it isn't clear what you mean by "SFINAE Friendly"). Our mechanism for that is to mark the diagnostic SFINAEError. Comment at: clang/lib/Sema/SemaExpr.cpp:14

[clang] d9be8a8 - [Clang] Allow omitting `typename` in befriended constructors parameters

Author: Corentin Jabot Date: 2023-06-06T15:04:47+02:00 New Revision: d9be8a8a990d0194db5889c9b59c9ad49dd52cd7 URL: https://github.com/llvm/llvm-project/commit/d9be8a8a990d0194db5889c9b59c9ad49dd52cd7 DIFF: https://github.com/llvm/llvm-project/commit/d9be8a8a990d0194db5889c9b59c9ad49dd52cd7.diff

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended constructors parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9be8a8a990d: [Clang] Allow omitting `typename` in befriended constructors parameters (authored by cor3ntin). Repository: rG LLVM Github Monorepo

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon added a comment. libcxx CI seems to be failing for other patches as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151553/new/ https://reviews.llvm.org/D151553 ___ cfe-commits mailing list

[PATCH] D152197: [NFC][CLANG] Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. The SA tool is incorrect here. Comment at: clang/lib/Sema/SemaExpr.cpp:9 if ((OperationKind == ACK_Arithmetic) && ((LHSBuiltinTy && LHSBuiltin

[PATCH] D152195: [Clang] Fix access of friend function in local class

erichkeane added a comment. I think the patch looks fine, but this needs a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152195/new/ https://reviews.llvm.org/D152195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D152194: [NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool

erichkeane added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:756 if (ReceiverType->isObjCIdType() || ReceiverType->isObjCClassType() || ASTCtxt.canAssignObjCInterfaces(ReceiverObjectPtrType, TrackedType)) { const

[PATCH] D152194: [NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool

erichkeane added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:756 if (ReceiverType->isObjCIdType() || ReceiverType->isObjCClassType() || ASTCtxt.canAssignObjCInterfaces(ReceiverObjectPtrType, TrackedType)) { const

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

JonChesterfield added a comment. I'm trying to pick up the context for this and D95976 . Superficially it looks like lowering variadic functions in the compiler could be used to simplify quite a lot of this, @jdoerfert there's a comment from some time ago which

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:12002 + + UnresolvedSet<16> Functions; + if (ImplicitCastExpr *ICE = dyn_cast(Callee)) Can `Functions` ever held more than one element here? Repository: rG LLVM Github Monorepo CHAN

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings updated this revision to Diff 528826. michaelplatings added a comment. Herald added a subscriber: ormris. Update unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151438/new/ https://reviews.llvm.org/D151438 Files: clang/i

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Adds support for the classic dataflow algorithm that partitions a flow graph into dist

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 added a comment. Gentle ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. In D152017#4397113 , @dblaikie wrote: > What's the particular goal/value in including called-but-not-defined > functions? Are your users generally building only parts of their program with > debug info & you want it to be comp

[PATCH] D152069: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 16 bits

erichkeane added inline comments. Comment at: clang/include/clang/AST/Type.h:1652 /// The kind (BuiltinType::Kind) of builtin type this is. -unsigned Kind : 8; +unsigned Kind : 16; }; It looks like the largest of the Bitfields in the union uses 32

[PATCH] D152265: [clang][test] Use a physical copy of FS

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make use of a physical copy, rather than real FS in unittests that change working-di

[PATCH] D152265: [clang][test] Use a physical copy of FS

kadircet updated this revision to Diff 528834. kadircet added a comment. - Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152265/new/ https://reviews.llvm.org/D152265 Files: clang/unittests/Serialization/ModuleCacheTest.cpp clang/unitt

[PATCH] D152265: [clang][test] Use a physical copy of FS

goncharov accepted this revision. goncharov added a comment. This revision is now accepted and ready to land. nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152265/new/ https://reviews.llvm.org/D152265 _

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:12002 + + UnresolvedSet<16> Functions; + if (ImplicitCastExpr *ICE = dyn_cast(Callee)) cor3ntin wrote: > Can `Functions` ever held more than one element here? Good catch! I don't think

[clang] 476e7c4 - [clang][test] Use a physical copy of FS

Author: Kadir Cetinkaya Date: 2023-06-06T15:45:55+02:00 New Revision: 476e7c49ecb762df1d68273696b06c36feb0fd96 URL: https://github.com/llvm/llvm-project/commit/476e7c49ecb762df1d68273696b06c36feb0fd96 DIFF: https://github.com/llvm/llvm-project/commit/476e7c49ecb762df1d68273696b06c36feb0fd96.dif

[PATCH] D152265: [clang][test] Use a physical copy of FS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG476e7c49ecb7: [clang][test] Use a physical copy of FS (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D152194: [NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. I agree with @erichkeane. However, I can also see that the code could be improved. I don't understand why we have that variable hoisted from the guarded block in the first place.

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel updated this revision to Diff 528845. ymandel added a comment. fix formatting in header file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 Files: clang/include/clang/Analysis/Analyses/Interval

[PATCH] D152259: [Clang] Make increment bool SFINAE-friendly

yronglin updated this revision to Diff 528847. yronglin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152259/new/ https://reviews.llvm.org/D152259 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/

[PATCH] D152259: [Clang] Make increment bool SFINAE-friendly

yronglin marked an inline comment as done. yronglin added a comment. In D152259#4399217 , @erichkeane wrote: > This should have a release note. > > I think the bug is asking to make this a SFINAE failure (it isn't clear what > you mean by "SFINAE Friend

[PATCH] D152195: [Clang] Fix access of friend function in local class

eandrews added a comment. In D152195#4399251 , @erichkeane wrote: > I think the patch looks fine, but this needs a release note. Just so I know - Does every bug fix need a release note now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152195/

[PATCH] D152269: [StaticAnalyzer] Fix false negtive on NilArgChecker when creating literal object

tripleCC created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. tripleCC requested review of this revision. Herald added a project: cl

[PATCH] D152195: [Clang] Fix access of friend function in local class

erichkeane added a comment. In D152195#4399445 , @eandrews wrote: > In D152195#4399251 , @erichkeane > wrote: > >> I think the patch looks fine, but this needs a release note. > > Just so I know - Does every bug

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

jsjodin accepted this revision. jsjodin added a comment. This revision is now accepted and ready to land. Looks good. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5230 + if (!IsExternallyVisible) +OS << llvm::format("_%x", EntryInfo.FileID); + OS << "

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. Thank you for the review @jsjodin I'll wait a couple of days to see if @jdoerfert (or anyone else) has any further input before I land the patch! I will apply the nit before landing the patch, so the final reference commit in Phabricator will reflect it. Repository:

[PATCH] D152259: [Clang] Make increment bool SFINAE failure

yronglin updated this revision to Diff 528856. yronglin marked an inline comment as done. yronglin added a comment. Add release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152259/new/ https://reviews.llvm.org/D152259 Files: clang/docs/R

[clang] b16a593 - [analyzer][NFC] Pass the diagnostic message to the TrackConstraintBRVisitor

Author: Endre Fulop Date: 2023-06-06T16:28:31+02:00 New Revision: b16a59328fc5120006aeac501637229cc7e30357 URL: https://github.com/llvm/llvm-project/commit/b16a59328fc5120006aeac501637229cc7e30357 DIFF: https://github.com/llvm/llvm-project/commit/b16a59328fc5120006aeac501637229cc7e30357.diff L

[PATCH] D152255: [analyzer][NFC] Pass the diagnostic message to the TrackConstraintBRVisitor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb16a59328fc5: [analyzer][NFC] Pass the diagnostic message to the TrackConstraintBRVisitor (authored by Endre Fulop ,

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:151-164 + auto ArgSVal = C.getSVal(E).getAs(); + if (!ArgSVal) +return; + + ProgramStateRef StNonNull, StNull; + std::tie(StNonNull, StNull) = State->assume(*ArgSV

[PATCH] D152274: [clang] Don't create import decls without -fmodules

kadircet created this revision. kadircet added reviewers: sammccall, dblaikie. Herald added a subscriber: ChuanqiXu. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When modules are disabled, there's no

[PATCH] D152274: [clang] Don't create import decls without -fmodules

kadircet added a comment. @dblaikie this also updates `getSourceDescriptor-crash.cpp`, which was making use of generation of implicit import decl. I assumed that test is trying to make sure `ImportDecl` is represented properly, and incidentally relied on implicit generation of it. LMK if that i

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:749 if (HasRoptr) { if (!Args.hasFlag(options::OPT_fdata_sections, +options::OPT_fno_data_sections, UseSeparateSections) && Consider the `has

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

MaskRay added a comment. > The LTO mxcoff-roptr check against data `-mxcoff-roptr`. Consider not dropping the leading `-`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021

[PATCH] D152274: [clang] Don't create import decls without -fmodules

kadircet updated this revision to Diff 528863. kadircet added a comment. - Test layering check violation diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152274/new/ https://reviews.llvm.org/D152274 Files: clang/lib/Sema/SemaModule.cpp

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

jsjodin added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:355-356 // Region 00 +// CK2-DAG: [[DEV:%[^,]+]] = sext i32 [[DEVi32:%[^,]+]] to i64 +// CK2-DAG: [[DEVi32]] = load i32, ptr %{{[^,]+}}, // CK2: br i1 %{{[^,]+}}, label %[[IFTHEN:[^,]+]], label

[PATCH] D152275: Use memory region declaration intrinsic when generating code for array subscripts

simeon created this revision. simeon added reviewers: efriedma, lebedev.ri, arichardson. Herald added a subscriber: StephenFan. Herald added a project: All. simeon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As an alternative to https:/

[PATCH] D152207: [HIP] Instruct lld to go through all archives

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:168 + // the linker to go through every library to look for kernel functions + LldArgs.push_back("--whole-archive"); auto TargetID = Args.getLastArgValue(options::OPT_mcpu_EQ);

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

ahatanak added a comment. In D151587#4397499 , @nickdesaulniers wrote: > In D151587#4397446 , @efriedma > wrote: > >> The following also crashes, with no MaterializeTemporaryExpr involved. >> >> struct X { >>

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

MaskRay added inline comments. Herald added subscribers: jobnoorman, luke, pcwang-thead, eopXD, VincentWu, vkmr, frasercrmck, arichardson. Herald added a project: All. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1970 + // Get small data limitation. + if (Args.getLastArg(

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:151-164 + auto ArgSVal = C.getSVal(E).getAs(); + if (!ArgSVal) +return; + + ProgramStateRef StNonNull, StNull; + std::tie(StNonNull, StNull) = State->assume(*ArgSV

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Parser/cxx0x-for-range.cpp:67 +int a[] = {1, 2, 3, 4, 5}; +for (auto x = n ? 1 : 2 : a); // expected-error {{expected ';' in 'for' statem

[PATCH] D152195: [Clang] Fix access of friend function in local class

eandrews updated this revision to Diff 528883. eandrews added a comment. Thanks for the review! I added a release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152195/new/ https://reviews.llvm.org/D152195 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDecl.cpp clang/t

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

MaskRay created this revision. MaskRay added reviewers: apazos, asb, craig.topper, hiraditya, jrtc27, shiva0217. Herald added subscribers: luke, frasercrmck, luismarques, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, niosHD, sabu

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2087 // Not support linker relaxation for PIC. -SmallDataLimit = "0"; if (Args.hasArg(options::OPT_G)) { D.Diag(diag::warn_drv_unsupported_sdata); The code is wr

[clang] 4faa6c6 - [clang][test] Use a physical copy of FS

Author: Mikhail Goncharov Date: 2023-06-06T17:36:35+02:00 New Revision: 4faa6c6699149de504216173ea34f33765193905 URL: https://github.com/llvm/llvm-project/commit/4faa6c6699149de504216173ea34f33765193905 DIFF: https://github.com/llvm/llvm-project/commit/4faa6c6699149de504216173ea34f33765193905.d

  1   2   3   >