arsenm added inline comments.
================ Comment at: clang/test/CodeGenCUDA/Inputs/ocml-sample-target-attrs.cl:2 +__attribute__((target("gfx11-insts"))) +unsigned do_intrin_stuff(void) +{ ---------------- Sound really be ulong ================ Comment at: clang/test/CodeGenCUDA/link-builtin-bitcode-gpu-attrs-preserved.cu:34 +// CHECK: define {{.*}} i32 @do_intrin_stuff() #[[ATTR:[0-9]+]] +// CHECK: attributes #[[ATTR]] = {{.*}} "target-features"="+gfx11-insts" + ---------------- Also should make sure target-cpu was set ================ Comment at: clang/test/CodeGenCUDA/link-builtin-bitcode-gpu-attrs-preserved.cu:42 +extern "C" { +__device__ unsigned do_intrin_stuff(void); + ---------------- ulong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152251/new/ https://reviews.llvm.org/D152251 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits