[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 524582. HerrCai0907 added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sem

[clang] eb5902f - [Sema] `setInvalidDecl` for error deduction declaration

Author: Congcong Cai Date: 2023-05-23T09:07:05+02:00 New Revision: eb5902ffc97163338bab95d2fd84a953ee76e96f URL: https://github.com/llvm/llvm-project/commit/eb5902ffc97163338bab95d2fd84a953ee76e96f DIFF: https://github.com/llvm/llvm-project/commit/eb5902ffc97163338bab95d2fd84a953ee76e96f.diff

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5902ffc971: [Sema] `setInvalidDecl` for error deduction declaration (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. Thanks, It's great to have the complete feature in on PR Comment at: clang/include/clang/Sema/Sema.h:9661 +struct BuildingDeductionGuides {}; +/// Note that we are instantiating an exception specification +/// of a function template. --

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall added a comment. > Though I'm proposing a name like "DeclBlockEnd" to make it clearer I prefer the current name. DeclBlockEnd is both too long and contains a cryptic abbreviation (should be DeclarationBlockEnd). And I don't think distinguishing between declaration blocks and flow-cont

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is the most common use case, so it makes se

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 524590. vikramRH added a comment. Handled review comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files: clang/include/clang/Basic/TargetOptions

[PATCH] D151185: [clangd] Store paths as requested in PreambleStatCache

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Underlying FS c

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek created this revision. phosek added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Prior to this patch we would ignore -pie and -no

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

ebevhan added a comment. In D151087#4362059 , @aaron.ballman wrote: > Based on all this, I think we should go with `__addrspace_cast` as a named > cast and not allow the conversion through `reinterpret_cast` unless going > to/from a `[u]intptr_t`. I t

[clang] f5af7d2 - Revert "[clang][ExprConstant] fix __builtin_object_size for flexible array members"

Author: Krasimir Georgiev Date: 2023-05-23T07:59:38Z New Revision: f5af7d2d987b0b16d7a641b7aa9086a75d533944 URL: https://github.com/llvm/llvm-project/commit/f5af7d2d987b0b16d7a641b7aa9086a75d533944 DIFF: https://github.com/llvm/llvm-project/commit/f5af7d2d987b0b16d7a641b7aa9086a75d533944.diff

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek updated this revision to Diff 524599. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://reviews.llvm.org/D151186 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h clang/lib/Driver

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek updated this revision to Diff 524601. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://reviews.llvm.org/D151186 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h clang/lib/Driver

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek updated this revision to Diff 524602. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://reviews.llvm.org/D151186 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h clang/lib/Driver

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

dyung added a comment. Hi @HerrCai0907, this change is failing on the PS4 linux and PS5 Windows bot. Can you take a look? I'm guessing these failures are likely due to the PS4/PS5 target defaulting to a different C/C++ standard than the rest of clang. https://lab.llvm.org/buildbot/#/builders/13

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:616 +Position HintStart = sourceLocToPosition(SM, BraceRange.getEnd()); +Position HintEnd = {HintStart.line, +HintStart.character + sammccall w

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This carries

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:219 + +static inline size_t alignUp(size_t Value, uint Alignment) { + return (Value + Alignment - 1) & ~(Alignment - 1); MathExtras already has alignTo Co

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

phosek added a comment. I apologize about the delayed response. I had time to think about this a bit more and it's not really clear to me if we need to preserve the "plus/minus" flag syntax. Looking through the history, it seems that it was introduced in D2538 w

[PATCH] D142932: Multilib YAML parsing

phosek added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:150-152 + bool parseYaml(llvm::MemoryBufferRef, + llvm::SourceMgr::DiagHandlerTy = nullptr, + void *DiagHandlerCtxt = nullptr); Rather than `parseYaml

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:180 + SmallString<128> SysRootDir(D.Dir); + llvm::sys::path::append(SysRootDir, "../lib/clang-runtimes"); + Defer to `llvm::sys::path::append` for joining the path components to

[PATCH] D143075: BareMetal ToolChain multilib layering

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228 + +llvm::SmallVector BareMetal::getOrderedMultilibs() const { + // Get multilibs in reverse order because they're ordered most-specific last. Can you use [llvm::reverse](htt

[clang] baeb85b - [Clang] Support more stdio builtins

Author: Qiu Chaofan Date: 2023-05-23T16:35:25+08:00 New Revision: baeb85b5a99778956117d647b78b55be4f51a129 URL: https://github.com/llvm/llvm-project/commit/baeb85b5a99778956117d647b78b55be4f51a129 DIFF: https://github.com/llvm/llvm-project/commit/baeb85b5a99778956117d647b78b55be4f51a129.diff L

[PATCH] D150087: [Clang] Support more stdio builtins

This revision was automatically updated to reflect the committed changes. qiucf marked an inline comment as done. Closed by commit rGbaeb85b5a997: [Clang] Support more stdio builtins (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

muggenhor created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. muggenhor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

gribozavr2 added a comment. Could you change the tests to cover the new case? They are here: `llvm-project/clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151192/new/ https

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. @hubert.reinterpretcast I'll try to look at that but unless I'm mistaken, the wording excludes function parameters > The fourth context is when a temporary object **other than a function > parameter** object is created in the for-range-initializer of a range-based >

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

arsenm added a comment. In D151087#4363503 , @ebevhan wrote: > In D151087#4362059 , @aaron.ballman > wrote: > >> Based on all this, I think we should go with `__addrspace_cast` as a named >> cast and not allow t

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings added a comment. Funnily enough I had the same thought coming to work this morning that we don't need 2 syntaxes. I had an idea that we could only print flags beginning "-" but will consider the other options you suggested as well. Thanks. Repository: rG LLVM Github Monorepo

[PATCH] D151194: [clang][dataflow] Add support for return values of reference type.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the way `Environment::ReturnL

[clang] 71bc3dd - [clang] Add test for CWG2213

Author: Vlad Serebrennikov Date: 2023-05-23T12:44:24+03:00 New Revision: 71bc3dd42e2939a25e4394dbebf6239e3e6403a9 URL: https://github.com/llvm/llvm-project/commit/71bc3dd42e2939a25e4394dbebf6239e3e6403a9 DIFF: https://github.com/llvm/llvm-project/commit/71bc3dd42e2939a25e4394dbebf6239e3e6403a9.

[PATCH] D151032: [clang] Add test for CWG2213

This revision was automatically updated to reflect the committed changes. Closed by commit rG71bc3dd42e29: [clang] Add test for CWG2213 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151032/new/ https://reviews.llvm.org/D151032

[clang] 85452b5 - [clang] Add tests for CWG issues 977, 1482, 2516

Author: Vlad Serebrennikov Date: 2023-05-23T12:50:42+03:00 New Revision: 85452b5f9b5aba5bdf0259b7f0d7400362f95535 URL: https://github.com/llvm/llvm-project/commit/85452b5f9b5aba5bdf0259b7f0d7400362f95535 DIFF: https://github.com/llvm/llvm-project/commit/85452b5f9b5aba5bdf0259b7f0d7400362f95535.

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85452b5f9b5a: [clang] Add tests for CWG issues 977, 1482, 2516 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D150800: [AArch64][FMV] Fix name mangling.

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150800/new/ https://reviews.llvm.org/D150800 ___

[PATCH] D150867: [AArch64][FMV] Prevent target attribute using for multiversioning.

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150867/new/ https://reviews.llvm.org/D150867 ___

[PATCH] D150937: [clang-repl] Disable all tests on unsupported platforms

junaire abandoned this revision. junaire added a comment. This isn't an ideal solution after an off-list discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150937/new/ https://reviews.llvm.org/D150937 ___

[PATCH] D151166: [clangd] Interactive AST matchers with #pragma clang query

Endill added a comment. This is an interesting feature! There's a related `#pragma clang __debug dump`, that dumps name lookup result or a bit of AST for expression you pass to it (https://clang.llvm.org/docs/LanguageExtensions.html#debugging-the-compiler). I think clangd might be interested to

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: clang/test/CodeGenHIP/printf_nonhostcall.cpp:170-171 +// CHECK-NEXT:[[PRINTBUFFNEXTPTR5:%.*]] = getelementptr i8, ptr addrspace(1) [[PRINTBUFFNEXTPTR4]], i32 8 +// CHECK-NEXT:[[TMP13:%.*]] = bitcast double [[TMP4]] to i64 +// CHE

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm added a comment. Hi @erichkeane and @aaron.ballman. Does the updated patch look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148700/new/ https://reviews.llvm.org/D148700 ___ cfe-commi

[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

CarolineConcatto created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As described in: https://github.com/ARM-software/acle/p

[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

muggenhor added a comment. Sure. Looking at the test I'm unsure though, are the `optional` implementations in there stripped copies of the real implementations? Or just a minimal implementation that fits the basic optional interface in the given namespace? Repository: rG LLVM Github Monorepo

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall added a comment. Thanks, I'll try to repro those results. 100ms is significant in absolute terms, but >1s seems unacceptably slow. I believe VSCode always sends ranges along with latency-sensitive hint requests, I think we currently just post-filter. If we propagate the limits deeper w

[clang] ea79b3b - Revert "[Sema] `setInvalidDecl` for error deduction declaration"

Author: Tom Weaver Date: 2023-05-23T11:44:51+01:00 New Revision: ea79b3bc39700791567796faeeb63d12f49b8c50 URL: https://github.com/llvm/llvm-project/commit/ea79b3bc39700791567796faeeb63d12f49b8c50 DIFF: https://github.com/llvm/llvm-project/commit/ea79b3bc39700791567796faeeb63d12f49b8c50.diff LO

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme updated this revision to Diff 524641. Esme added a comment. Separate the backend changes from this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150758/new/ https://reviews.llvm.org/D150758 Files: clang/lib/Driver/ToolChains/AIX.h

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

TWeaver added a comment. The build bot failures have been going for a while now so I've had to revert this until the author can address them, my apologies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:434 // range otherwise. - return !NoMovt && hasV8MBaselineOps() && + return !NoMovt && hasV6MOps() && (isTargetWindows() || !OptMinSize || genExecuteOnly()); simonwallis2

[PATCH] D151199: [Clang][SVE2.1] Add pfalse builtin

CarolineConcatto created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As described in: https://github.com/ARM-software/acle/p

[PATCH] D151185: [clangd] Store paths as requested in PreambleStatCache

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151185/new/ https://reviews.llvm.org/D151185

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

Fznamznon added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2495 } else { + EnterExpressionEvaluationContext Ctx( + Actions, Sema::ExpressionEvaluationContext::PotentiallyEvaluated); What is the point for an additional expression

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparion operator are not all the same.

massberg created this revision. massberg added a reviewer: usaxena95. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes #62880 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D151201: [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a test that crashes without the

[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

gribozavr2 added a comment. The mock optional types in the unit test are just declarations of the API - they don't need any implementations (function or method bodies should be omitted). But the declarations of classes, methods, and functions should mirror the production header closely. There a

[clang] 5111286 - Reland "Reland [clang-repl] Introduce Value to capture expression results"

Author: Jun Zhang Date: 2023-05-23T19:32:31+08:00 New Revision: 5111286f06e1e10f24745007a45a830760f1790c URL: https://github.com/llvm/llvm-project/commit/5111286f06e1e10f24745007a45a830760f1790c DIFF: https://github.com/llvm/llvm-project/commit/5111286f06e1e10f24745007a45a830760f1790c.diff LOG

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin updated this revision to Diff 524656. cor3ntin marked 7 inline comments as done. cor3ntin added a comment. Address some of Mariya's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https://reviews.llvm.org/D151094 Files:

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet updated this revision to Diff 524655. hazohelet added a comment. The cause of the regression has been fixed in the other patch. This is a resubmission with rebase to the upstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 Files

[clang] 75cce50 - [Driver] Fix test for use of ld from devtoolset (NFC)

Author: Nikita Popov Date: 2023-05-23T13:53:17+02:00 New Revision: 75cce50fd2d3869b97d66c280dc2b2c34f9b2818 URL: https://github.com/llvm/llvm-project/commit/75cce50fd2d3869b97d66c280dc2b2c34f9b2818 DIFF: https://github.com/llvm/llvm-project/commit/75cce50fd2d3869b97d66c280dc2b2c34f9b2818.diff

[PATCH] D151195: [Driver] Fix test for use of ld from devtoolset

This revision was automatically updated to reflect the committed changes. Closed by commit rG75cce50fd2d3: [Driver] Fix test for use of ld from devtoolset (NFC) (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANG

[clang] 68baaca - [clang][dataflow] Use `Strict` accessors in comma operator and no-op cast.

Author: Martin Braenne Date: 2023-05-23T11:58:00Z New Revision: 68baaca61dfad1179a61d99cbf0fe23a6894849d URL: https://github.com/llvm/llvm-project/commit/68baaca61dfad1179a61d99cbf0fe23a6894849d DIFF: https://github.com/llvm/llvm-project/commit/68baaca61dfad1179a61d99cbf0fe23a6894849d.diff LOG

[PATCH] D150776: [clang][dataflow] Use `Strict` accessors in comma operator and no-op cast.

This revision was automatically updated to reflect the committed changes. Closed by commit rG68baaca61dfa: [clang][dataflow] Use `Strict` accessors in comma operator and no-op cast. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin updated this revision to Diff 524660. cor3ntin added a comment. Remove unecessary evaluation context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https://reviews.llvm.org/D151094 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

thakis added a comment. This breaks check-clang on windows: http://45.33.8.238/win/78827/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151042/new/ https://reviews.llvm.or

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/AST/Decl.h:2391 + + bool isImmediateFunction() const; + tbaeder wrote: > Some documentation on the new API would be useful; seems like most calls to > `is

[PATCH] D151133: [clang-tidy] Ignore implicit code in bugprone-branch-clone

donat.nagy added a comment. For me it's an unfortunate surprise that Clang Tidy is traversing the concrete //template instantiation// (I would've guessed that it's working on the original template body), but if that's the observed behavior, then this commit is a clean and straightforward fix.

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

Endill added a comment. In D151042#4364108 , @thakis wrote: > This breaks check-clang on windows: http://45.33.8.238/win/78827/step_7.txt > > Please take a look and revert for now if it takes a while to fix. It's not hard to fix, but is it just windows?

[clang] 211055c - AArch64: emit synchronous unwind for Darwin arm64_32 platforms too.

Author: Tim Northover Date: 2023-05-23T13:15:32+01:00 New Revision: 211055c7443e5594863ec95754e22f66e66aecc5 URL: https://github.com/llvm/llvm-project/commit/211055c7443e5594863ec95754e22f66e66aecc5 DIFF: https://github.com/llvm/llvm-project/commit/211055c7443e5594863ec95754e22f66e66aecc5.diff

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

thakis added a comment. On my bots (which cover linux, mac/arm, and windows), it's only failing on the windows bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151042/new/ https://reviews.llvm.org/D151042 ___

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

Endill added a comment. All tests pass for me on Linux. As far as I understand, diagnostics on Windows are not supposed to be different given the same `-cc1` flags. Reverting for further investigation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

Fznamznon added a comment. Out of curiosity - does something like these examples - https://godbolt.org/z/Eqb58Wqoo work as expected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https://reviews.llvm.org/D151094 __

[clang] 70688e8 - Revert "[clang] Add tests for CWG issues 977, 1482, 2516"

Author: Vlad Serebrennikov Date: 2023-05-23T15:29:14+03:00 New Revision: 70688e82e2fd6b486931669b981c18f3830385b5 URL: https://github.com/llvm/llvm-project/commit/70688e82e2fd6b486931669b981c18f3830385b5 DIFF: https://github.com/llvm/llvm-project/commit/70688e82e2fd6b486931669b981c18f3830385b5.

[clang-tools-extra] 35ce741 - [clangd] Store paths as requested in PreambleStatCache

Author: Kadir Cetinkaya Date: 2023-05-23T14:30:58+02:00 New Revision: 35ce741ef3e3dd9db1da3ea0a06c565cb90f665a URL: https://github.com/llvm/llvm-project/commit/35ce741ef3e3dd9db1da3ea0a06c565cb90f665a DIFF: https://github.com/llvm/llvm-project/commit/35ce741ef3e3dd9db1da3ea0a06c565cb90f665a.dif

[PATCH] D151185: [clangd] Store paths as requested in PreambleStatCache

This revision was automatically updated to reflect the committed changes. Closed by commit rG35ce741ef3e3: [clangd] Store paths as requested in PreambleStatCache (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151185/new/ https

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. In D147844#4361956 , @aaron.ballman wrote: > In D147844#4335598 , @dblaikie > wrote: > >> In D147844#4329497 , >> @aaron.ballman wrote: >> >

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

thakis added a comment. In D151042#4364131 , @Endill wrote: > All tests pass for me on Linux. > As far as I understand, diagnostics on Windows are not supposed to be > different given the same `-cc1` flags. Reverting for further investigation. Thanks fo

[PATCH] D151194: [clang][dataflow] Add support for return values of reference type.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151194/new/ https://reviews.llvm.org/D151194

[PATCH] D147889: [clang-tidy] Improve bugprone-branch-clone with support for fallthrough attribute

donat.nagy added a comment. Mostly LGTM, I suggested two cosmetic changes. Comment at: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp:55 +bool TraverseLambdaExpr(LambdaExpr *, DataRecursionQueue * = nullptr) { + // Ignore lambdas + return true; ---

[clang] 30b0fdf - [AArch64][FMV] Fix name mangling.

Author: Pavel Iliin Date: 2023-05-23T13:42:55+01:00 New Revision: 30b0fdfff1931c625babe45cbf9405003c48f8a0 URL: https://github.com/llvm/llvm-project/commit/30b0fdfff1931c625babe45cbf9405003c48f8a0 DIFF: https://github.com/llvm/llvm-project/commit/30b0fdfff1931c625babe45cbf9405003c48f8a0.diff L

[PATCH] D150800: [AArch64][FMV] Fix name mangling.

This revision was automatically updated to reflect the committed changes. Closed by commit rG30b0fdfff193: [AArch64][FMV] Fix name mangling. (authored by ilinpv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150800/new/ https://reviews.llvm.org/D15

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane updated this revision to Diff 524667. erichkeane added a comment. Fix tests + Aaron's formatting request. Guess I forgot to upload this last night! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150875/new/ https://reviews.llvm.org/D150875 Files: clang/docs/ReleaseNotes.r

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150953/new/ https://reviews.llvm.org/D150953

[PATCH] D151121: [Clang][UBSan] Fix the crash caused by __builtin_assume_aligned with -no-opaque-pointers enabled

yronglin updated this revision to Diff 524673. yronglin added a comment. Try fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151121/new/ https://reviews.llvm.org/D151121 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/lib/CodeGen/Co

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin updated this revision to Diff 524674. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Improve diagnostic message for immediate calls and add Mariya's examples Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ h

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin added a comment. In D151094#4364133 , @Fznamznon wrote: > Out of curiosity - does something like these examples - > https://godbolt.org/z/Eqb58Wqoo work as expected? Yes! I added those as tests, thanks! Repository: rG LLVM Github Monorepo

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2b-consteval-propagate.cpp:8 + +namespace examples { + Fznamznon wrote: > These examples exactly match the ones provided by P2564R3, should they be in >

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

aaron.ballman added a comment. This basically LGTM, but we should add documentation to the internals manual too: https://clang.llvm.org/docs/InternalsManual.html#spellings Comment at: clang/lib/AST/TypePrinter.cpp:1724-1727 + if (T->getAttrKind() == attr::ArmStreaming) { +

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150913/new/ https://reviews.llvm.org/D150913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:42 // q -> Scalable vector, followed by the number of elements and the base type. +// Q -> AArch64 svcount_t builtin type. // E -> ext_vector, followed by the number of elements and the base

[PATCH] D149948: [include-cleaner] Treat references to nested types implicit

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, this solution makes sense! Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:361 + struct Derived : public Base {};)cpp", + "void

[PATCH] D123649: Allow flexible array initialization in C++.

aaron.ballman added a comment. In D123649#4362756 , @efriedma wrote: > In D123649#4362418 , @aaron.ballman > wrote: > >> In D123649#4362402 , @efriedma >> wrote: >> >>>

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane added a comment. I did the llvm-test-suite build, and have a handful of linker issues (because I've not built libclang, and don't have some newer GCC library for some float16 commands), but everythign builds at least. If necessary, I can try to make sure it all builds, but I hope/su

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Fantastic! Presuming precommit CI comes back green this time, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150875/new/ https://reviews.llvm.org/D150875 _

[PATCH] D151081: [Clang][SVE2.1] Add svpext builtins

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:64 +// 2,3,4: array of vectors +// .: indicator for multi-vector modifier that will follow(eg.:2.x) // v: void `s/follow(eg.:2.x)/follow (e.g. 2.x)/` Comment at:

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 524686. john.brawn added a comment. Add VE test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targets/

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__ARM_FEATURE_C

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:616 +Position HintStart = sourceLocToPosition(SM, BraceRange.getEnd()); +Position HintEnd = {HintStart.line, +HintStart.character + daiyousei-qz w

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

hans added a comment. This broke the tests on Mac, see e.g. https://green.lab.llvm.org/green/job/clang-stage1-RA/34396/consoleFull (or http://crbug.com/1447928) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D1

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

aaron.ballman accepted this revision. aaron.ballman added a comment. In D146358#4364058 , @hazohelet wrote: > The cause of the regression has been fixed in the other patch. > This is a resubmission with rebase to the upstream. LGTM, feel free to land aga

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

Endill added a comment. In D151042#4364149 , @thakis wrote: > In fact, you can probably repro the test failure on your linux box if you > change that test and add locally add -triple=i386-pc-win32 to the RUN line You're right, MSVC-specific triple make

[clang] 28776d5 - [Driver] Try to fix linux-ld.c test with DEFAULT_LINKER set (NFC)

Author: Nikita Popov Date: 2023-05-23T16:05:27+02:00 New Revision: 28776d501cad38d56b8e05ba1ec5044c88901d7a URL: https://github.com/llvm/llvm-project/commit/28776d501cad38d56b8e05ba1ec5044c88901d7a DIFF: https://github.com/llvm/llvm-project/commit/28776d501cad38d56b8e05ba1ec5044c88901d7a.diff

[clang] 7586aea - [NFC][CLANG] Fix static code analyzer concerns with dereference null return value

Author: Manna, Soumi Date: 2023-05-23T07:10:44-07:00 New Revision: 7586aeab7ad3fb035752eea89fd2bb895de21143 URL: https://github.com/llvm/llvm-project/commit/7586aeab7ad3fb035752eea89fd2bb895de21143 DIFF: https://github.com/llvm/llvm-project/commit/7586aeab7ad3fb035752eea89fd2bb895de21143.diff

  1   2   3   >