stuij added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:434
// range otherwise.
- return !NoMovt && hasV8MBaselineOps() &&
+ return !NoMovt && hasV6MOps() &&
(isTargetWindows() || !OptMinSize || genExecuteOnly());
----------------
simonwallis2 wrote:
> simonwallis2 wrote:
> > V6M does not have Movt.
> > At face value, this line looks wrong and leads to about 30 unit test fails.
> >
> I clarify: there are no test fails with this patch on its own.
> The unit test fails I saw where when building this patch in conjunction with
> related patch https://reviews.llvm.org/D149443
Correct, this shouldn't be here. Initially it looked like we were going to
repurpose movt for v6m, but that should have been part of another patch. And
now it looks like we'll handle v6m immediates separately. In any case I'll
remove this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149444/new/
https://reviews.llvm.org/D149444
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
