[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. I rebased the patch and regenerated the clang tests. I haven't regenerated the llvm tests. @jhuber6 @jdoerfert Please help regenerate the llvm tests. Several of the failing clang tests were regenerated earlier, they can perhaps be regenerated after the llvm tests are

[clang] 745a957 - [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

Author: Martin Braenne Date: 2023-04-04T07:13:44Z New Revision: 745a957f9dc562477cbe587fb3fa8305713b51b3 URL: https://github.com/llvm/llvm-project/commit/745a957f9dc562477cbe587fb3fa8305713b51b3 DIFF: https://github.com/llvm/llvm-project/commit/745a957f9dc562477cbe587fb3fa8305713b51b3.diff LOG

[PATCH] D147302: [clang][dataflow] Add `create()` methods to `Environment` and `DataflowAnalysisContext`.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG745a957f9dc5: [clang][dataflow] Add `create()` methods to `Environment` and… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang-tools-extra] 3afe3db - [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

Author: AMS21 Date: 2023-04-04T07:20:25Z New Revision: 3afe3dbfa0157608aa1d058f6be28e0060aaf9c6 URL: https://github.com/llvm/llvm-project/commit/3afe3dbfa0157608aa1d058f6be28e0060aaf9c6 DIFF: https://github.com/llvm/llvm-project/commit/3afe3dbfa0157608aa1d058f6be28e0060aaf9c6.diff LOG: [clang-

[clang-tools-extra] 25956d5 - [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

Author: AMS21 Date: 2023-04-04T07:20:25Z New Revision: 25956d55d02489964428ab5f55e609ff16c6632d URL: https://github.com/llvm/llvm-project/commit/25956d55d02489964428ab5f55e609ff16c6632d DIFF: https://github.com/llvm/llvm-project/commit/25956d55d02489964428ab5f55e609ff16c6632d.diff LOG: [clang-

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

This revision was automatically updated to reflect the committed changes. Closed by commit rG3afe3dbfa015: [clang-tidy] Fix readability-static-accessed-through-instance check for… (authored by AMS21, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D147411?vs=510537&id

[clang-tools-extra] e588ef8 - [clang-tidy] Small refactor for ExceptionAnalyzer

Author: AMS21 Date: 2023-04-04T07:20:26Z New Revision: e588ef8a7a531380836e17242c2c2276559df0b9 URL: https://github.com/llvm/llvm-project/commit/e588ef8a7a531380836e17242c2c2276559df0b9 DIFF: https://github.com/llvm/llvm-project/commit/e588ef8a7a531380836e17242c2c2276559df0b9.diff LOG: [clang-

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25956d55d024: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std… (authored by AMS21, committed by PiotrZSL). Changed pr

[PATCH] D147376: [clang-tidy] Small refactor for ExceptionAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rGe588ef8a7a53: [clang-tidy] Small refactor for ExceptionAnalyzer (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D146030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143334/new/ https://reviews.llvm.org/D143334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on it! Comment at: clang/lib/Headers/immintrin.h:294 +/// \param __p +///Pointer to a 16-bit location to place the random value. +/// \returns

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

hans added a comment. In D147073#4240793 , @zequanwu wrote: > In D147073#4240017 , @hans wrote: > >> I'm not familiar with this code. I suppose the question is whether it's >> reasonable for this code to expect t

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

hokein added inline comments. Comment at: clang-tools-extra/clangd/Config.h:151 +// Limit the length of type names in inlay hints. +size_t TypeNameLimit = 32; } InlayHints; zhangyi1357 wrote: > hokein wrote: > > I would extend it a bit more -- 0 means

[clang] c107231 - [clang][dataflow] Fix -Wdeprecated-declarations after D147302 (NFC)

Author: Jie Fu Date: 2023-04-04T16:17:25+08:00 New Revision: c107231cde99c0b8cdda5c5befe6354750ca03f2 URL: https://github.com/llvm/llvm-project/commit/c107231cde99c0b8cdda5c5befe6354750ca03f2 DIFF: https://github.com/llvm/llvm-project/commit/c107231cde99c0b8cdda5c5befe6354750ca03f2.diff LOG: [

[PATCH] D147497: [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of __builtin_neon_vfmsh_f16.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147497/new/ https://reviews.llvm.org/D147497 ___

[PATCH] D147497: [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of __builtin_neon_vfmsh_f16.

dmgreen accepted this revision. dmgreen added a comment. Sounds OK to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147497/new/ https://reviews.llvm.org/D147497 ___ cfe-commits mailing list cfe-commit

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added a comment. Did another quick look. And I feel the title and the summary of the page is not consistent with the patch itself. I think it is better to split this to make the change to focus on the entities with internal linkage. I don't know what's wrong with the module linkage th

[clang] ee71cbd - [clang][Interp] Ignore more non-VarDecl declarations

Author: Timm Bäder Date: 2023-04-04T10:41:46+02:00 New Revision: ee71cbddb77f8da9285657cac248b431928143b9 URL: https://github.com/llvm/llvm-project/commit/ee71cbddb77f8da9285657cac248b431928143b9 DIFF: https://github.com/llvm/llvm-project/commit/ee71cbddb77f8da9285657cac248b431928143b9.diff LO

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee71cbddb77f: [clang][Interp] Ignore more non-VarDecl declarations (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D14586

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:3912-3936 + if (Visible) { +if (!FM) + break; +assert (D->hasLinkage() && "an imported func with no linkage?"); +// Unless the module is a defining

[clang] 626b7e5 - [clang][Interp][NFC] Remove Integral.h include from PrimType.h

Author: Timm Bäder Date: 2023-04-04T10:44:56+02:00 New Revision: 626b7e5dd249f569203e024141c1a2a0f618df9c URL: https://github.com/llvm/llvm-project/commit/626b7e5dd249f569203e024141c1a2a0f618df9c DIFF: https://github.com/llvm/llvm-project/commit/626b7e5dd249f569203e024141c1a2a0f618df9c.diff LO

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146242/new/ https://reviews.llvm.org/D146242 ___

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

RKSimon added inline comments. Comment at: clang/test/Driver/m68k-macros.cpp:2 // Check macro definitions // RUN: %clang -target m68k-unknown-linux -m68000 -dM -E %s | FileCheck --check-prefix=CHECK-MX %s +// RUN: %clang -target m68k-unknown-linux -m68000 -mhard-float -dM -E %

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi created this revision. MaggieYi added reviewers: Whitney, jamieschmeiser, MaskRay, rnk, aras-p, anton-afanasyev. Herald added a subscriber: hiraditya. Herald added a project: All. MaggieYi requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llv

[PATCH] D147449: [include-cleaner] Only ignore builtins without a header

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks. I was surprised to see that some standard library symbols are treated as builtin symbols. I think the current approach is better (e.g. clangd's hover on `__builtin_popcount()` will no

[clang-tools-extra] 3402b77 - [include-cleaner] Only ignore builtins without a header

Author: Kadir Cetinkaya Date: 2023-04-04T13:28:56+02:00 New Revision: 3402b77db3ee83f0c576988631afa12cfba61285 URL: https://github.com/llvm/llvm-project/commit/3402b77db3ee83f0c576988631afa12cfba61285 DIFF: https://github.com/llvm/llvm-project/commit/3402b77db3ee83f0c576988631afa12cfba61285.dif

[PATCH] D147449: [include-cleaner] Only ignore builtins without a header

This revision was automatically updated to reflect the committed changes. Closed by commit rG3402b77db3ee: [include-cleaner] Only ignore builtins without a header (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D147449?vs=510516&id=510746#toc Repository: rG LLVM Git

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi added a comment. A simple test to reproduce the issue: % cat main.cpp #include "1.h" #include "2.h" int foo(); % cat 1.h template auto Zero() -> T { return T{}; } %cat 2.h struct Bla {}; Compile the code with `-ftime-trace-granularity=0 -ftime-trace` to show the

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi added a comment. Analysis the issue using the above simple example: When clang parses the first line (`#include "1.h"`) in the `main.cpp`, a time section entry is created and put on the top of the time-trace stack. Assuming this time section entry is named `Source-1.h`, which has its n

[PATCH] D147495: [Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note about the fix. I don't *think* this qualifies as a potentially breaking change, though it does theoretically have the ability to cause code

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

serge-sans-paille updated this revision to Diff 510752. serge-sans-paille retitled this revision from "[clang] Consider artificial always inline builtin as inline builtins" to "[clang] Do not require GNUInlineAttr for inline builtins". serge-sans-paille added a comment. DO not require gnu inline

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. In D147073#4242566 , @hans wrote: > In D147073#4240793 , @zequanwu > wrote: > >> In D147073#4240017 , @hans wrote: >> >>> I'm not familiar

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 510756. Leporacanthicus added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[clang] d3aed4f - MachO use generic code to detect atomic support.

Author: Tim Northover Date: 2023-04-04T13:44:45+01:00 New Revision: d3aed4f401fa35ea986d3967c529f4d2b24e2bb6 URL: https://github.com/llvm/llvm-project/commit/d3aed4f401fa35ea986d3967c529f4d2b24e2bb6 DIFF: https://github.com/llvm/llvm-project/commit/d3aed4f401fa35ea986d3967c529f4d2b24e2bb6.diff

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147525: [X86] Add AMX_COMPLEX to Graniterapids

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch also rename __AMXCOMPLEX__ to __AMX_COMPLEX__

[clang] c7161e7 - [python] Expose clang_Location_isInSystemHeader

Author: Artur Ryt Date: 2023-04-04T09:21:04-04:00 New Revision: c7161e73ca0afdf9cc016ce4e9f1e23a6a140b51 URL: https://github.com/llvm/llvm-project/commit/c7161e73ca0afdf9cc016ce4e9f1e23a6a140b51 DIFF: https://github.com/llvm/llvm-project/commit/c7161e73ca0afdf9cc016ce4e9f1e23a6a140b51.diff LOG

[PATCH] D147414: [python] Expose clang_Location_isInSystemHeader

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7161e73ca0a: [python] Expose clang_Location_isInSystemHeader (authored by R2RT, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D147414?vs=510542&id=510771#toc Repositor

[PATCH] D147525: [X86] Add AMX_COMPLEX to Graniterapids

FreddyYe updated this revision to Diff 510772. FreddyYe added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147525/new/ https://reviews.llvm.org/D147525 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/Headers/immintrin

[clang] a82170f - [Headers] Add some intrinsic function descriptions to immintrin.h.

Author: Paul Robinson Date: 2023-04-04T06:26:05-07:00 New Revision: a82170fa41ca9756b0f67d0ed015adef325e8921 URL: https://github.com/llvm/llvm-project/commit/a82170fa41ca9756b0f67d0ed015adef325e8921 DIFF: https://github.com/llvm/llvm-project/commit/a82170fa41ca9756b0f67d0ed015adef325e8921.diff

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa82170fa41ca: [Headers] Add some intrinsic function descriptions to immintrin.h. (authored by probinson). Herald added a project: clang. Changed pri

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

erichkeane added subscribers: FreddyYe, craig.topper. erichkeane added a comment. Hi- We've actually seen some regressions internally thanks to this patch, which boil down to: https://godbolt.org/z/WEer4M6ha // compiled with -march=skylake __attribute__((always_inline)) inline void foo(){}

[PATCH] D147530: [clang] Add test for CWG191

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG191 and CWG1200 are resolved by defining unqu

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

erichkeane added a comment. In D146329#4242215 , @shafik wrote: > In D146329#4207522 , @royjacobson > wrote: > >> In D146329#4203174 , @shafik wrote: >> >>> I would have

[PATCH] D147525: [X86] Add AMX_COMPLEX to Graniterapids

FreddyYe updated this revision to Diff 510783. FreddyYe added a comment. Remove redundant file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147525/new/ https://reviews.llvm.org/D147525 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/Headers

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

erichkeane added a comment. In D143479#4243090 , @erichkeane wrote: > Hi- > We've actually seen some regressions internally thanks to this patch, which > boil down to: > > https://godbolt.org/z/WEer4M6ha > > // compiled with -march=skylake > __attri

[PATCH] D147525: [X86] Add AMX_COMPLEX to Graniterapids

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147525/new/ https://reviews.llvm.org/D147525 ___ cfe

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due not resetting that, clang still thinks that it is in immediate function context even if it is already entered non-co

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2357-2361 +if (SubobjectDecl) { + Info.FFDiag(DiagLoc, diag::note_constexpr_uninitialized) << SubobjectDecl; + Info.Note(SubobjectDecl->getLocation(), +diag::note_conste

[PATCH] D147530: [clang] Add test for CWG191

Endill updated this revision to Diff 510793. Endill edited the summary of this revision. Endill added a comment. Mark CWG1200 as "na" and enable newer standard versions in RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147530/new/ https://

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510795. zhangyi1357 added a comment. - [Clangd] Add unittest for TypeNameLimit config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/ https://reviews.llvm.org/D147395 Files: clang-tools-extra/c

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

cor3ntin added a comment. Thanks, for working on this Congrats on finding the underlying issue, it must not have been easy! Comment at: clang/lib/Sema/SemaDecl.cpp:15177 : ExprEvalContexts.back().Context); +ExprEvalContexts.back().InImmediateFunct

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 updated this revision to Diff 510797. jhuber6 added a comment. Herald added subscribers: kbarton, nemanjai. Fixed the Clang tests. Haven't touched the LLVM ones because this breaks SPMDzation and state machine rewrites completely in those tests. Someone who knows what this patch changes

[PATCH] D147534: [clang][Interp] Make sure we have a variable scope for initializers

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise, we run into an assertion when trying t

[PATCH] D147535: [clang][Interp] Don't create global variables more than once

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. just because we're being told to evaluate it twic

[clang] 74cc438 - [clang-format] Add option for having one port per line in Verilog

Author: sstwcw Date: 2023-04-04T14:51:22Z New Revision: 74cc4389f37d753bf07f1b4a4a4c5e09433d9231 URL: https://github.com/llvm/llvm-project/commit/74cc4389f37d753bf07f1b4a4a4c5e09433d9231 DIFF: https://github.com/llvm/llvm-project/commit/74cc4389f37d753bf07f1b4a4a4c5e09433d9231.diff LOG: [clang

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74cc4389f37d: [clang-format] Add option for having one port per line in Verilog (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon updated this revision to Diff 510807. Fznamznon added a comment. Add a comment, rebase, fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147531/new/ https://reviews.llvm.org/D147531 Files: clang/docs/ReleaseNotes.rst clang/li

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15177 : ExprEvalContexts.back().Context); +ExprEvalContexts.back().InImmediateFunctionContext = FD->isConsteval(); cor3ntin wrote: > I think it might be wort

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite created this revision. Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. argentite updated this revision to Diff 507049. argentite added a comment. argentite updated this revision to Diff 510808. argentite edited the summary of this revision. argentite a

[clang] 8ec36e6 - [clang][modules] Handle explicit modules when checking for .Private -> _Private

Author: Ben Langmuir Date: 2023-04-04T08:12:10-07:00 New Revision: 8ec36e6956cb03d80f3fee8e593808c43a8a1ec3 URL: https://github.com/llvm/llvm-project/commit/8ec36e6956cb03d80f3fee8e593808c43a8a1ec3 DIFF: https://github.com/llvm/llvm-project/commit/8ec36e6956cb03d80f3fee8e593808c43a8a1ec3.diff

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ec36e6956cb: [clang][modules] Handle explicit modules when checking for .Private -> _Private (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I reworked the comment a bit otherwise LGTM. Comment at: clang/lib/Sema/SemaDecl.cpp:15178-15185 + // Each ExpressionEvaluationContextRecord also keeps track on whether

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

kzhuravl added a comment. Overall looks good. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:299 + + Attrs.mRuntimeHandle = getEnqueuedBlockSymbolName(TM, Func); } Do we really need/want to update code object v2? CHANGES SINCE LAST ACTION

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:299 + + Attrs.mRuntimeHandle = getEnqueuedBlockSymbolName(TM, Func); } kzhuravl wrote: > Do we really need/want to update code object v2? as long as the code is here

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

balazske updated this revision to Diff 510816. balazske marked 3 inline comments as done. balazske added a comment. I decided to add back `DescriptionKind` and make possible to use a message like "should not be NULL". Now all generated strings in functions `describe` and `describeArgumentValue` st

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

ChuanqiXu added a reviewer: ChuanqiXu. ChuanqiXu added a comment. Add me as a reviewer to add this to my stack. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41416/new/ https://reviews.llvm.org/D41416 ___ cfe-commits mailing list cfe-commits@

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:288 + } + for (auto &SpecInfo : LazySpecializations) { +Record.push_back(SpecInfo.DeclID); We should not store the lazy specialization information as an ar

[clang] 0109f8d - [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of __builtin_neon_vfmsh_f16.

Author: Craig Topper Date: 2023-04-04T09:01:24-07:00 New Revision: 0109f8d1e3bf64e4b23db6e2f284185207e46541 URL: https://github.com/llvm/llvm-project/commit/0109f8d1e3bf64e4b23db6e2f284185207e46541 DIFF: https://github.com/llvm/llvm-project/commit/0109f8d1e3bf64e4b23db6e2f284185207e46541.diff

[PATCH] D147497: [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of __builtin_neon_vfmsh_f16.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0109f8d1e3bf: [AArch64] Use fneg instead of fsub -0.0, X Cin IR expansion of… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHA

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. Thanks for working on this! Comment at: clang/lib/Interpreter/Offload.cpp:1 +//===-- Offload.cpp - CUDA Offloading ---*- C++ -*-===// +// How about `DeviceOffload.cpp`? Comment at: clang/

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:273-274 - Fix incorrect merging of lambdas across modules. (`#60985 `_) +- Fix assertion hit when template consteval function appears in nested + c

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

shafik added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15186 + // different handling. + ExprEvalContexts.back().InImmediateFunctionContext = FD->isConsteval(); + I am a bit concerned that we are updating `InImmediateFunctionContext` outside of `

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15186 + // different handling. + ExprEvalContexts.back().InImmediateFunctionContext = FD->isConsteval(); + shafik wrote: > I am a bit concerned that we are updating `InImmediateFunctionCont

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon updated this revision to Diff 510843. Fznamznon added a comment. Fix grammar, add checks to the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147531/new/ https://reviews.llvm.org/D147531 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D147531: [clang] Reset track of immediate function context when entering new function

Fznamznon marked 2 inline comments as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15186 + // different handling. + ExprEvalContexts.back().InImmediateFunctionContext = FD->isConsteval(); + cor3ntin wrote: > shafik wrote: > > I

[clang] 32b53cf - [ExtractAPI] Remove extra attributes in property declaration fragments

Author: Usman Akinyemi Date: 2023-04-04T10:00:34-07:00 New Revision: 32b53cf9d0c8c0e01ce5b0e7d5c717202a98cdf5 URL: https://github.com/llvm/llvm-project/commit/32b53cf9d0c8c0e01ce5b0e7d5c717202a98cdf5 DIFF: https://github.com/llvm/llvm-project/commit/32b53cf9d0c8c0e01ce5b0e7d5c717202a98cdf5.diff

[PATCH] D146759: [ExtractAPI] Remove extra attributes in property declaration fragments

This revision was automatically updated to reflect the committed changes. Closed by commit rG32b53cf9d0c8: [ExtractAPI] Remove extra attributes in property declaration fragments (authored by Unique_Usman, committed by zixuw). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 510848. krzysz00 added a comment. Rebase data layout changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

hubert.reinterpretcast added a comment. @francii, what happens when `-K` is used on a pure-compile (`-c`) invocation? Do we get an "unused" message? Should we be testing that? I think we should be testing the diagnostic for the "wrong target" usage as well? Repository: rG LLVM Github Monorep

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#4243260 , @jhuber6 wrote: > Fixed the Clang tests. Haven't touched the LLVM ones because this breaks > SPMDzation and state machine rewrites completely in those tests. Someone who > knows what this patch changes sh

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

tra added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:27 +static llvm::cl::opt CudaEnabled("cuda", llvm::cl::Hidden); +static llvm::cl::opt OffloadArch("offload-arch", llvm::cl::Hidden); + Where will clang-repl find CUDA headers? Generally

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a subscriber: SimeonEhrig. v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:137 + +ExitOnErr(Interp->LoadDynamicLibrary("libcudart.so")); + } else tra wrote: > Is there any doc describing the big picture

[PATCH] D147549: [clang] Add test for CWG255

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG255 (partially resolved by N3778 is resolved

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15656 case BO_XorAssign: -DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, false); CheckIdentityFieldAssignment(LHS, RHS, OpLoc, S); break; This is the same thing, but for `this->x +

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

tra added a comment. > Initial interactive CUDA support for clang-repl What should a user expect to be supported, functionality wise? I assume it should cover parsing and compilation. I'm not so sure about the execution. Should it be expected to actually launch kernels, or will that come in a f

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:137 + +ExitOnErr(Interp->LoadDynamicLibrary("libcudart.so")); + } else tra wrote: > v.g.vassilev wrote: > > tra wrote: > > > Is there any doc describing the big picture appr

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. In D147175#4240572 , @aaron.ballman wrote: > Hmmm, is this effectively `std::has_unique_object_representations` (ensuring > that all bits of the object representation contribute to the value)? These two traits are indeed very s

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 510865. philnik marked 5 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files: clang/docs/Langua

[PATCH] D147551: [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Adds support for explic

[PATCH] D147554: [clang] Mark CWG562 as N/A

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG562 is resolved by defining lookup as occurri

[PATCH] D147530: [clang] Add test for CWG191

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147530/new/ https://reviews.llvm.org/D147530 ___

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15656 case BO_XorAssign: -DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, false); CheckIdentityFieldAssignment(LHS, RHS, OpLoc, S); break; rsmith wrote: > This is the same thin

[PATCH] D147556: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. jp4a50 requested review of this revision. The option allows users to specify how many columns to use t

[PATCH] D147556: [clang-format] Add BracedInitializerIndentWidth option.

HazardyKnusperkeks added a comment. Um, was this a mistake? What is with D146101 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147556/new/ https://reviews.llvm.org/D147556 ___

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

SimeonEhrig added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:135 +std::move(CI), std::move(DeviceCI), OffloadArch, +"/tmp/clang-repl.fatbin")); + v.g.vassilev wrote: > To cover the case where platforms have no `/tmp` we coul

  1   2   >