arsenm added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:299
+
+  Attrs.mRuntimeHandle = getEnqueuedBlockSymbolName(TM, Func);
 }
----------------
kzhuravl wrote:
> Do we really need/want to update code object v2?
as long as the code is here yes. Not updating it would mean maintaining two 
paths in the implementation. This is just changing the internal representation 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141700/new/

https://reviews.llvm.org/D141700

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D141700: AMD... Konstantin Zhuravlyov via Phabricator via cfe-commits
    • [PATCH] D141700... Matt Arsenault via Phabricator via cfe-commits

Reply via email to