[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

iains added a comment. In D144844#4195316 , @ChuanqiXu wrote: > Got your points. Let's postpone this one. > > But I want to emphasize that this patch (and the thin PCM) will decrease the > performance. While LTO can save the regression, LTO is not widely

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

ChuanqiXu added a comment. > However, "performance" also includes compilation speed in the 'no > optimisation, debug' case - that is also considered very important. So, > perhaps, the short-term approach should be (as @dblaikie suggested) to > include the bodies for -O >= 3? I don't think so.

[PATCH] D145974: [libclang] Add index option to store preambles in memory

vedgy added a comment. @aaron.ballman, can you land this revision for me please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145974/new/ https://reviews.llvm.org/D145974 ___ cfe-commits mailing list cf

[PATCH] D146026: [clangd] Patch PragmaMarks in preamble section of the file

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c888120e3c8: [clangd] Patch PragmaMarks in preamble section of the file (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146026/new/ h

[clang-tools-extra] 9c88812 - [clangd] Patch PragmaMarks in preamble section of the file

Author: Kadir Cetinkaya Date: 2023-03-15T09:00:14+01:00 New Revision: 9c888120e3c8cc93f9950590a9192002e7c3d08b URL: https://github.com/llvm/llvm-project/commit/9c888120e3c8cc93f9950590a9192002e7c3d08b DIFF: https://github.com/llvm/llvm-project/commit/9c888120e3c8cc93f9950590a9192002e7c3d08b.dif

[clang-tools-extra] 82c8bf8 - [clangd] Patch main file macros in preamble

Author: Kadir Cetinkaya Date: 2023-03-15T09:00:15+01:00 New Revision: 82c8bf8fcc91eda75e47856b34a1d68cedd2b46e URL: https://github.com/llvm/llvm-project/commit/82c8bf8fcc91eda75e47856b34a1d68cedd2b46e DIFF: https://github.com/llvm/llvm-project/commit/82c8bf8fcc91eda75e47856b34a1d68cedd2b46e.dif

[PATCH] D146028: [clangd] Patch main file macros in preamble

This revision was automatically updated to reflect the committed changes. Closed by commit rG82c8bf8fcc91: [clangd] Patch main file macros in preamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146028/new/ https://reviews.

[PATCH] D146116: [clangd] Respect WantDiags when emitting diags from possibly stale preambles

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Rep

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

nridge added a comment. Thanks for the update! I have a couple of more minor suggestions, hope you don't mind; I'm trying to make sure the next person to look at this will easily understand what the code is trying to do. Comment at: clang-tools-extra/clangd/CodeCompletionStri

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145659/new/ https://reviews.llvm.org/D145659 ___ cfe-commits mailing list cf

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda updated this revision to Diff 505394. jchlanda added a comment. Use `CHECK-LABEL`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib

[clang] 7258317 - [NVPTX] Expose LDU builtins

Author: Jakub Chlanda Date: 2023-03-15T08:41:45Z New Revision: 7258317bade0fd82e257e47b31eee3ad0c6c5305 URL: https://github.com/llvm/llvm-project/commit/7258317bade0fd82e257e47b31eee3ad0c6c5305 DIFF: https://github.com/llvm/llvm-project/commit/7258317bade0fd82e257e47b31eee3ad0c6c5305.diff LOG:

[PATCH] D145238: [NVPTX] Expose LDU builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7258317bade0: [NVPTX] Expose LDU builtins (authored by jchlanda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 96cc2d0 - [clang] Add AVR specific inline assembly escaped characters

Author: Ben Shi Date: 2023-03-15T16:44:49+08:00 New Revision: 96cc2d07e15a5ce9ad134ed8db0a88d7c6c0d657 URL: https://github.com/llvm/llvm-project/commit/96cc2d07e15a5ce9ad134ed8db0a88d7c6c0d657 DIFF: https://github.com/llvm/llvm-project/commit/96cc2d07e15a5ce9ad134ed8db0a88d7c6c0d657.diff LOG:

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96cc2d07e15a: [clang] Add AVR specific inline assembly escaped characters (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D146104: Use *{Map,Set}::contains (NFC)

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146104/new/ https://reviews.llvm.org/D146104 ___ c

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:390 - if (isa(ElemType.getTypePtr())) { + if (ElemType->isRecordType()) { const Record *R = BasePtr.getElemRecord(); shafik wrote: > aaron.ballman wrote: > > The difference betwee

[libunwind] 9b488ac - [libunwind][RISC-V] Rewrite testcase with C as possible.

Author: Kito Cheng Date: 2023-03-15T17:30:16+08:00 New Revision: 9b488ace17e6be64e61bf20f8ddc3eb563848bde URL: https://github.com/llvm/llvm-project/commit/9b488ace17e6be64e61bf20f8ddc3eb563848bde DIFF: https://github.com/llvm/llvm-project/commit/9b488ace17e6be64e61bf20f8ddc3eb563848bde.diff LO

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 505410. karapsinie added a comment. Fulfilled the wishes of aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang

[PATCH] D146023: [AMDGPU] Remove Code Object V2

Pierre-vh added inline comments. Comment at: llvm/test/MC/AMDGPU/hsa-gfx10.s:3 -// RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=gfx1010 --amdhsa-code-object-version=2 -mattr=-wavefrontsize32,+wavefrontsize64 -show-encoding %s | llvm-readobj -S --sd --syms - | FileChe

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 505420. zyounan marked 3 inline comments as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 Files: clang-tools-extra

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added a comment. Updated now. Thank you again for your patient review. :) Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:213 ++SnippetArg; - if (SnippetArg == CursorSnippetArg) { + if (ShouldPatchPlaceholder0 && SnippetArg == CursorSnipp

[PATCH] D144976: [clangd] Add provider info on symbol hover.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1094 +void maybeAddSymbolProviders(ParsedAST &AST, HoverInfo &HI, + std::optional UsedDecl, we can simplify the signature like `(ParsedAST&, include_cleaner

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1372 LLVMStyle.DerivePointerAlignment = false; + LLVMStyle.DesignatedInitializerIndentWidth = 4; LLVMStyle.DisableFormat = false; so lets say someone is using an IndentWidth of 2

[PATCH] D146116: [clangd] Respect WantDiags when emitting diags from possibly stale preambles

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e8bac748064: [clangd] Respect WantDiags when emitting diags from possibly stale preambles (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang-tools-extra] 9e8bac7 - [clangd] Respect WantDiags when emitting diags from possibly stale preambles

Author: Kadir Cetinkaya Date: 2023-03-15T11:29:16+01:00 New Revision: 9e8bac7480640677e04f4b9f98c41cb94f8180e2 URL: https://github.com/llvm/llvm-project/commit/9e8bac7480640677e04f4b9f98c41cb94f8180e2 DIFF: https://github.com/llvm/llvm-project/commit/9e8bac7480640677e04f4b9f98c41cb94f8180e2.dif

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

lenary marked an inline comment as done. lenary added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:1106 + +def : TokenAlias<"DSYNC", "dsync">; + john.brawn wrote: > It would make more sense to put this immediately after GCSB_DSYNC. Thi

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

DavidSpickett added a comment. > Since this is my first commit to such a large repository(and project), can > you please guide me with this @DavidSpickett ! Sure, you'll want to make a commit that only has changes to warnings and errors. You can split up this one to do that, see part "A)" of th

[clang] cb7fb73 - [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

Author: Archibald Elliott Date: 2023-03-15T11:03:53Z New Revision: cb7fb737858cdfdc90406f9675c8470ea98417ed URL: https://github.com/llvm/llvm-project/commit/cb7fb737858cdfdc90406f9675c8470ea98417ed DIFF: https://github.com/llvm/llvm-project/commit/cb7fb737858cdfdc90406f9675c8470ea98417ed.diff

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked an inline comment as done. Closed by commit rGcb7fb737858c: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK (authored by lenary). Changed prior to commi

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added a comment. In D146042#4195295 , @owenpan wrote: >> The previous implementation of the option involved a hack which corrupted >> the parenthesis state stack. > > Can you link the review (e.g. `Dnn`) of the previous implementation in > th

[clang] 36278b7 - [Flang][RISCV] Emit target features for RISC-V

Author: Shao-Ce SUN Date: 2023-03-15T19:39:13+08:00 New Revision: 36278b735fa193c954bf38c82ca81a5608bc5187 URL: https://github.com/llvm/llvm-project/commit/36278b735fa193c954bf38c82ca81a5608bc5187 DIFF: https://github.com/llvm/llvm-project/commit/36278b735fa193c954bf38c82ca81a5608bc5187.diff L

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

This revision was automatically updated to reflect the committed changes. sunshaoce marked an inline comment as done. Closed by commit rG36278b735fa1: [Flang][RISCV] Emit target features for RISC-V (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7501e53b8d6d: [Clang] Give warning for an underaligned 128-bit __sync library call. (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 7501e53 - [Clang] Give warning for an underaligned 128-bit __sync library call.

Author: Jonas Paulsson Date: 2023-03-15T12:46:06+01:00 New Revision: 7501e53b8d6d7563b047a34d0141630d5afc86c5 URL: https://github.com/llvm/llvm-project/commit/7501e53b8d6d7563b047a34d0141630d5afc86c5 DIFF: https://github.com/llvm/llvm-project/commit/7501e53b8d6d7563b047a34d0141630d5afc86c5.diff

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3540 + someMethod(someOtherMethod( + [](SomeReallyLongLambdaSignatureArgument foo) { MyDeveloperDay wrote: > This code may come from Format.h Sorry, I'm not sure I

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3540 + someMethod(someOtherMethod( + [](SomeReallyLongLambdaSignatureArgument foo) { jp4a50 wrote: > MyDeveloperDay wrote: > > This code may come from Format.h > So

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 updated this revision to Diff 505449. jp4a50 added a comment. Update OuterScope docs in Format.h and regenerate public docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042 Files: clang/docs/Clan

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 505451. michaelplatings marked an inline comment as done. michaelplatings added a comment. Add quotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 505456. TIFitis marked an inline comment as done. TIFitis added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/lib/CodeGen/CGOpenM

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:36 +return x; +} + Can you add a test that shows that we warn on instantiation? This shouldn't be a dependent declrefexpr when instantiated. Additionally, this would ma

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 505460. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.org/D144976 Files: clang

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo added a comment. thanks for the review! Comment at: clang-tools-extra/clangd/Hover.cpp:1094 +void maybeAddSymbolProviders(ParsedAST &AST, HoverInfo &HI, + std::optional UsedDecl, hokein wrote: > we can simplify the signatur

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 505462. karapsinie added a comment. Execute "git-clang-format HEAD~1" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 505468. karapsinie marked 4 inline comments as done. karapsinie added a comment. Added "__" for "builtin..." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/docs/LanguageExtensions.rst

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

hans marked an inline comment as done. hans added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4344 + (Record->hasTrivialDestructor() || + Record->hasConstexprDestructor()); } efriedma wrote: > For the purposes of C

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

hans updated this revision to Diff 505466. hans marked an inline comment as done. hans added a comment. Passing a `ExcludeDtor` param. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145369/new/ https://reviews.llvm.org/D145369 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CG

[clang] 55f7e00 - [libclang] Add index option to store preambles in memory

Author: Igor Kushnir Date: 2023-03-15T09:21:41-04:00 New Revision: 55f7e00afc56c68421220d60d29c079b58fe9c79 URL: https://github.com/llvm/llvm-project/commit/55f7e00afc56c68421220d60d29c079b58fe9c79 DIFF: https://github.com/llvm/llvm-project/commit/55f7e00afc56c68421220d60d29c079b58fe9c79.diff

[PATCH] D145974: [libclang] Add index option to store preambles in memory

This revision was automatically updated to reflect the committed changes. Closed by commit rG55f7e00afc56: [libclang] Add index option to store preambles in memory (authored by vedgy, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D145974?vs=504781&id=505469#toc

[PATCH] D145974: [libclang] Add index option to store preambles in memory

aaron.ballman added a comment. In D145974#4195643 , @vedgy wrote: > @aaron.ballman, can you land this revision for me please? Oops, thank you for the reminder! I've landed it on your behalf in 55f7e00afc56c68421220d60d29c079b58fe9c79

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1778-1780 + void setLambdaNumbering(Decl *ContextDecl, unsigned IndexInContext, + unsigned ManglingNumber, + unsigned DeviceManglingNumber, --

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

ldionne added inline comments. Herald added a project: All. Comment at: cfe/trunk/include/clang/Driver/ToolChain.h:312 + virtual std::string getCompilerRTPath() const; + By introducing a second way of getting the path to compiler-rt, this created inconsistenc

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def warn_hip_omp_target_directives : Warning< + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; yaxunl wrote: > jdoerfer

[PATCH] D145868: [clang][ASTImporter] Fix import of anonymous structures

balazske updated this revision to Diff 505481. balazske added a comment. Added a simple test and another test. Instead of calling getTypeDeclType only the reuse of existing type is done (this was the part that fixes the problem). In this way the underlying type is still imported. The result is not

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added inline comments. Comment at: clang/lib/Format/Format.cpp:1372 LLVMStyle.DerivePointerAlignment = false; + LLVMStyle.DesignatedInitializerIndentWidth = 4; LLVMStyle.DisableFormat = false; MyDeveloperDay wrote: > so lets say someone is using an

[PATCH] D146104: Use *{Map,Set}::contains (NFC)

kuhar accepted this revision. kuhar added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146104/new/ https://reviews.llvm.org/D146104 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2341 +``N==LMUL*__RISCV_RVV_VLEN_BITS``, the implementation defined feature macro that +is enabled under the ``-mrvv-vector-bits`` flag. +}]; You should add some details about

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel created this revision. rymiel added a project: clang. rymiel added reviewers: aaron.ballman, erichkeane. Herald added a project: All. rymiel requested review of this revision. Herald added a subscriber: cfe-commits. Since P0857, part of C++20, a *lambda-expression* can contain a *requires-c

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) && !IsLambdaRequiresClause &&

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) && !IsLambdaRequiresClause && (IsT

[PATCH] D146141: [ARM] Use FPUKind enum instead of unsigned

michaelplatings created this revision. michaelplatings added reviewers: simon_tatham, dcandler. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald ad

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) && !IsLambdaRequiresClause &&

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

aaron.ballman added a comment. In D139010#4159307 , @tlively wrote: > In D139010#4158540 , @aaron.ballman > wrote: > >> Roping in @jfb because I know he's been heavily involve in WebAssembly in >> the past and h

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 505499. rymiel added a comment. Slightly rewrite CheckForNonPrimary for slightly better clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/include/

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) && !I

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1283 ParseScope LambdaScope(this, Scope::LambdaScope | Scope::DeclScope | Scope::FunctionDeclarationScope | Ok, last bit, I promise :) I see t

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez updated this revision to Diff 505507. jmmartinez added a comment. - Fixed the loop and added test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144870/new/ https://reviews.llvm.org/D144870 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1558 + EmitSeparator = FieldIt->isBitField(); + } + probinson wrote: > I might not be following this correctly, but it feels like EmitSeparator will > end up true if the last f

[PATCH] D146146: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings.

paulwalker-arm created this revision. Herald added a project: All. paulwalker-arm requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146146 Files: clang/lib/Driver/Too

[clang] 8bdf387 - Use *{Map,Set}::contains (NFC)

Author: Kazu Hirata Date: 2023-03-15T08:46:32-07:00 New Revision: 8bdf38785888ddc7f2428918193b3f371ebea5cf URL: https://github.com/llvm/llvm-project/commit/8bdf38785888ddc7f2428918193b3f371ebea5cf DIFF: https://github.com/llvm/llvm-project/commit/8bdf38785888ddc7f2428918193b3f371ebea5cf.diff L

[PATCH] D146104: Use *{Map,Set}::contains (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bdf38785888: Use *{Map,Set}::contains (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a subscriber: jemarch. eddyz87 added a comment. Hi @jemarch, Could you please take a look to verify that this implementation is on the same page with what is planned for GCC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143967/new/

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. In D144709#4193603 , @MyDeveloperDay wrote: > In D144709#4188921 , > @AlexanderHederstaf wrote: > >> What is the next step in the process? Anything I should do? > > If you hav

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. When float_t and double_t types are used inside a scope with potential ABI breakage. See https://godbol

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 505525. rymiel added a comment. utilize getCurFunction() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/lib/Sema/SemaConcept.cpp clang/test/SemaTempl

[PATCH] D146146: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings.

paulwalker-arm added reviewers: sdesmalen, david-arm, craig.topper, reames. paulwalker-arm added a comment. This option was our pragmatic way to ensure scalable vector based toolchains remained useful whilst the kinks were worked out. We've a few releases under our belts now and I feel that eno

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1283 ParseScope LambdaScope(this, Scope::LambdaScope | Scope::DeclScope | Scope::FunctionDeclarationScope | ---

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Thank you! This looks good to me. I presume you don't have commit access, so if you give me your "SomeName ", I can commit this for you. Repository: rG LLVM Github Monorepo CHANG

[clang] 6d7da41 - [Debugify] Invalidate function analyses

Author: Arthur Eubanks Date: 2023-03-15T09:19:05-07:00 New Revision: 6d7da41b80e08a845e062dc62926cd58b4f1f5a8 URL: https://github.com/llvm/llvm-project/commit/6d7da41b80e08a845e062dc62926cd58b4f1f5a8 DIFF: https://github.com/llvm/llvm-project/commit/6d7da41b80e08a845e062dc62926cd58b4f1f5a8.diff

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added a comment. Ah, also, before commit, ensure that pre-commit CI passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 ___ cfe-commits mailing l

[PATCH] D146146: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings.

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. This makes perfect sense to me. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146146/new/ https://reviews.llvm.org/D146146 __

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

aeubanks updated this revision to Diff 505532. aeubanks edited the summary of this revision. aeubanks added a comment. rebase after cleanups fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146003/new/ https://reviews.llvm.org/D146003 Files

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

aeubanks added inline comments. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1127 +if (!PassPA.allAnalysesInSetPreserved>()) return; nikic wrote: > Hm, aren't we going to skip the CFG check below if only CFGAnalyses are > preserved (but

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 505534. rymiel added a comment. Use dyn_cast_if_present, otherwise we segfault in some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/lib/Sema/Se

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-preserved-analyses

nikic added a comment. To me `verify-preserved-analyses` sounds like "if DominatorTree is preserved, calls `DominatorTree::verify()`, etc". That is, call verify on the preserved analyses. Maybe `verify-change-reporting` or so? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel added a comment. In D146140#4196886 , @erichkeane wrote: > Ah, also, before commit, ensure that pre-commit CI passes. Yep, found an issue already ;; In D146140#4196866 , @erichkeane wrote: > I presume

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146003/new/ https://reviews.llvm.org/D146003 ___ cfe

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

tbaeder abandoned this revision. tbaeder added a comment. Abandoning this since the approach is not feasible anymore with https://reviews.llvm.org/D145545 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138275/new/ https://reviews.llvm.org/D138275 ___

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added a comment. In D146140#4196919 , @rymiel wrote: > In D146140#4196886 , @erichkeane > wrote: > >> Ah, also, before commit, ensure that pre-commit CI passes. > > Yep, found an issue already ;; > > I

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145545/new/ https://reviews.llvm.org/D145545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146146: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings.

sdesmalen accepted this revision. sdesmalen added a comment. It gives me great joy to see this code removed :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146146/new/ https://reviews.llvm.org/D146146 _

[PATCH] D146141: [ARM] Use FPUKind enum instead of unsigned

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146141/new/ https://reviews.llvm.org/D146141 __

Re: [PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

> eddyz87 added a subscriber: jemarch. > eddyz87 added a comment. > > Hi @jemarch, > > Could you please take a look to verify that this implementation is on > the same page with what is planned for GCC? Sure. Can you please add David Faust as a subscriber as well? I don't know if he has an acco

Re: [PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

On Wed, 2023-03-15 at 17:10 +0100, Jose E. Marchesi wrote: > > Could you please take a look to verify that this implementation is on > > the same page with what is planned for GCC? > > Sure. Can you please add David Faust as a subscriber as well? I don't > know if he has an account in reviews.ll

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation

aeubanks updated this revision to Diff 505539. aeubanks retitled this revision from "[StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-preserved-analyses" to "[StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation". aeubanks added a comment. re

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

Leporacanthicus accepted this revision. Leporacanthicus added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146075/new/ https://reviews.llvm.org/D146075

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

awarzynski added a comment. Please add tests ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146075/new/ https://reviews.llvm.org/D146075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 505540. jp4a50 added a comment. Change DesignatedInitializerIndentWidth to a signed integer which defaults to ContinuationIndentWidth when set to -1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ ht

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

tschuett added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:77 +/// specified. +bool saveMLIRTempFile(const CompilerInvocation &ci, mlir::ModuleOp mlirModule, + llvm::StringRef inputFile, llvm::StringRef outputTag) { st

  1   2   3   >